)]}'
{"id":"openstack%2Fdesignate~895035","triplet_id":"openstack%2Fdesignate~stable%2Fvictoria~I4e6ea0b6b717d2a1b5cc420874d1bb8fb290e04b","project":"openstack/designate","branch":"stable/victoria","attention_set":{},"removed_from_attention_set":{"22623":{"account":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"last_update":"2023-10-14 13:20:03.000000000","reason":"\u003cGERRIT_ACCOUNT_22623\u003e replied on the change","reason_account":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}}},"hashtags":[],"change_id":"I4e6ea0b6b717d2a1b5cc420874d1bb8fb290e04b","subject":"Fix designate-manage pool update bugs","status":"MERGED","created":"2023-09-14 22:38:34.000000000","updated":"2023-10-14 14:10:34.000000000","submitted":"2023-10-14 14:09:27.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"895035","cherry_pick_of_change":822891,"cherry_pick_of_patch_set":9,"meta_rev_id":"968e4e0098eb070d1ef549b5c53293413f3bc06b","_number":895035,"virtual_id_number":895035,"owner":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2023-10-14 14:09:27.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"all":[{"value":2,"date":"2023-09-21 16:20:46.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"all":[{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2023-10-14 13:20:03.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-09-14 23:24:46.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-09-21 16:20:46.000000000","updated_by":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"reviewer":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"state":"REVIEWER"}],"messages":[{"id":"5c0ecd2ce603b9664bca141abbef6dbe3feec202","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2023-09-14 22:38:34.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"b5317f1f0c918c647f4ee672d917bdd230931324","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-09-14 23:24:46.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/91ca174d93fa42d69583ea82ff693bc6\n\n- designate-bind9 https://zuul.opendev.org/t/openstack/build/8c2d394e1f6d404fb638391882562349 : SUCCESS in 27m 54s\n- designate-pdns4 https://zuul.opendev.org/t/openstack/build/b55dbffedb704c4b8eaa759b64f927e4 : SUCCESS in 34m 32s\n- designate-grenade-pdns4 https://zuul.opendev.org/t/openstack/build/cb1b912fcb464f3c963c928e308c013a : SUCCESS in 45m 04s (non-voting)\n- designate-ipv6-only-pdns4 https://zuul.opendev.org/t/openstack/build/38db03bcc90f4155b0224d1a40c4b88a : SUCCESS in 27m 52s\n- designate-ipv6-only-bind9 https://zuul.opendev.org/t/openstack/build/f9dec7fd140c4a1e8aa56bc4e296e56d : SUCCESS in 29m 16s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/199ca81573cb4c17a9e0deb7c06a07f9 : SUCCESS in 5m 54s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/addf4fd0d7a14b6e842830d3bb2d6cd5 : SUCCESS in 3m 41s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/0641f81ab900483db3c01fb8b3f5c106 : SUCCESS in 4m 36s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/10bd8637d812461083694314b5fa5993 : SUCCESS in 4m 43s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/23d927babba344e7a16fb0b41cddfd88 : SUCCESS in 7m 27s\n- neutron-tempest-plugin-designate-scenario-victoria https://zuul.opendev.org/t/openstack/build/14cfdc0321f647b7bfbb3e561ebc4dc1 : SUCCESS in 25m 09s","accounts_in_message":[],"_revision_number":1},{"id":"393c4affcb7a203c87242a6c477a5a02cdc98964","author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"date":"2023-09-21 16:20:46.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"9e3bb8c01661b845e32718f1122b52402ecd1f5b","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2023-10-14 13:20:03.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"9e557d71de7159e72d24c25406a1e829d87bed51","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-10-14 13:20:35.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"4daeb3e7574a3b684d1f03b00bf2bd8de6f7c110","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-10-14 14:09:27.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/5351d20ce99a4ae583487c64cc96980a\n\n- designate-bind9 https://zuul.opendev.org/t/openstack/build/45ee8192ced64d75bf9a4b8874d5c5ec : SUCCESS in 44m 02s\n- designate-pdns4 https://zuul.opendev.org/t/openstack/build/a4a97c4ce67c4b89bdb588f90b931a6d : SUCCESS in 43m 29s\n- designate-ipv6-only-pdns4 https://zuul.opendev.org/t/openstack/build/dda50d926e7f4c138e3145937e4a45a1 : SUCCESS in 40m 03s\n- designate-ipv6-only-bind9 https://zuul.opendev.org/t/openstack/build/5b92b944ef94489c954e8c96d84ef211 : SUCCESS in 41m 25s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a04c4447a6a54d70963d0a8cd25e417a : SUCCESS in 3m 07s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/fcfa268750914f8283460338af3a675b : SUCCESS in 4m 02s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/c929020060a445af9ba3af80b3ea66d7 : SUCCESS in 5m 04s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6411efd63c7b47a68ab3d913bf6444ee : SUCCESS in 6m 05s","accounts_in_message":[],"_revision_number":1},{"id":"e4976037fd137c7f3db29258b5259c0e13d36f19","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-10-14 14:09:27.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"968e4e0098eb070d1ef549b5c53293413f3bc06b","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-10-14 14:10:34.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/e40d105520414b1c82702d74f71fafb6\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/71c03430d6124161ab5f354dc23a66f5 : SUCCESS in 47s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"7181d35f4557974bce700c4b6382e9fbb49acc36","revisions":{"7181d35f4557974bce700c4b6382e9fbb49acc36":{"kind":"REWORK","_number":1,"created":"2023-09-14 22:38:34.000000000","uploader":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"ref":"refs/changes/35/895035/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/designate","ref":"refs/changes/35/895035/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/designate refs/changes/35/895035/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/designate refs/changes/35/895035/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/designate refs/changes/35/895035/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/designate refs/changes/35/895035/1"}}},"commit":{"parents":[{"commit":"4673e091fe9fcc1d6154f6430c74f8e4f56203e5","subject":"[stable-only] Cap virtualenv/setuptools","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/4673e091fe9fcc1d6154f6430c74f8e4f56203e5"}]}],"author":{"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","date":"2021-12-24 07:14:46.000000000","tz":-480},"committer":{"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","date":"2023-09-14 22:38:34.000000000","tz":0},"subject":"Fix designate-manage pool update bugs","message":"Fix designate-manage pool update bugs\n\nThis patch addresses a few problems with the manage\ncommand for pools and NS records.\n\n- Fixed an issue where having multiple NS records\n  would break the pool command.\n\n- Fixed a scenario where manually (non-managed) NS\n  records could break the pool command.\n\n- Fixed a potential edge case that could break the\n  pool command.\n\nThe biggest change is that we now only manage the NS\nrecord for the zone itself. This was always the case,\nbut because we didn\u0027t check for this specifically,\nother NS records would conflict with the command.\n\nChange-Id: I4e6ea0b6b717d2a1b5cc420874d1bb8fb290e04b\n(cherry picked from commit bff3d5f6e31fe595a77143ec4ac779c187bf72a8)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/7181d35f4557974bce700c4b6382e9fbb49acc36"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/7181d35f4557974bce700c4b6382e9fbb49acc36"}]},"branch":"refs/heads/stable/victoria"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review priority","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"-label:Review-Priority\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":[],"failing_atoms":["label:Review-Priority\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{}}}]}