)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"0fb7c0131b1d23ea0b053c0c396efd0cdd060bd7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"d4fcc3b2_d6d79ab6","updated":"2023-10-29 17:34:09.000000000","message":"recheck RecordsetsTest","commit_id":"ee58dd437929fe23e6776bbd97ee9397d62808f5"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"daf37bc011ea871fe78e0aec7962f1840e2e4982","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"023fb4a3_f0a87eb1","updated":"2023-11-01 17:45:56.000000000","message":"LGTM","commit_id":"af6469c105ba4a366a16a01cf7eaf13fa24e7fc2"}],"designate/tests/unit/objects/test_adapters_v2_api.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"e6b9b166d38d262a6ee4ba31f558aab7b91a1121","unresolved":true,"context_lines":[{"line_number":37,"context_line":"    def test_get_base_url(self):"},{"line_number":38,"context_line":"        CONF.set_override(\u0027enable_host_header\u0027, False, \u0027service:api\u0027)"},{"line_number":39,"context_line":"        CONF.set_override("},{"line_number":40,"context_line":"            \u0027api_base_uri\u0027, \u0027http://127.0.0.1:9001/\u0027, \u0027service:api\u0027"},{"line_number":41,"context_line":"        )"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        mock_request \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":9,"id":"bcde63bc_d0b7f4fa","line":40,"updated":"2023-11-01 15:31:23.000000000","message":"Even though these are all just adapter tests, it\u0027s a bad practice to use live addresses in tests. It also tends to be copies into other places.\nCan we use testing IP address space instead of 127.0.0.1 and localhost in these tests?\n\n192.0.2.0/24, 198.51.100.0/24, or 203.0.113.0/24","commit_id":"f4f8f2bddcde7b7f6d9efab9ae5ce0de00e86649"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"ca834aae49172529dddd5ed540b705f095d51d86","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    def test_get_base_url(self):"},{"line_number":38,"context_line":"        CONF.set_override(\u0027enable_host_header\u0027, False, \u0027service:api\u0027)"},{"line_number":39,"context_line":"        CONF.set_override("},{"line_number":40,"context_line":"            \u0027api_base_uri\u0027, \u0027http://127.0.0.1:9001/\u0027, \u0027service:api\u0027"},{"line_number":41,"context_line":"        )"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        mock_request \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":9,"id":"fc2f5d1b_c98a5363","line":40,"in_reply_to":"bcde63bc_d0b7f4fa","updated":"2023-11-01 16:23:57.000000000","message":"Done. I wasn\u0027t able to change some of them due to how the code we are testing works. Instead I removed the override on those situations and will fix in a future patch.","commit_id":"f4f8f2bddcde7b7f6d9efab9ae5ce0de00e86649"}]}
