)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9da2c7cbe1b4fac877289d282aed84bd27bac99b","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When these tests were implemented they were setup"},{"line_number":10,"context_line":"to test shards. The problem is that the range used"},{"line_number":11,"context_line":"in the tests ends at 4094, but there are 4095 shards"},{"line_number":12,"context_line":"in total. This means that if a zone is created on shard"},{"line_number":13,"context_line":"4095 it is always ignored in the tests."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1485dd53_8dfddada","line":11,"updated":"2023-11-09 06:36:19.000000000","message":"Actually there are 4096 shards, just numbered 0..4095.","commit_id":"dc6f47b7023b4599b1b03c346dfae7d3a5b796c7"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"6234547df3c222fb75d630e584a4d9b7cbeab64a","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When these tests were implemented they were setup"},{"line_number":10,"context_line":"to test shards. The problem is that the range used"},{"line_number":11,"context_line":"in the tests ends at 4094, but there are 4095 shards"},{"line_number":12,"context_line":"in total. This means that if a zone is created on shard"},{"line_number":13,"context_line":"4095 it is always ignored in the tests."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5611bf0a_176e5342","line":11,"in_reply_to":"1485dd53_8dfddada","updated":"2023-11-09 11:22:21.000000000","message":"Haha yea this bug is 8 years old and sometimes showed up very frequently. I have at two separate occasions commited code in an attempt to fix the issue.","commit_id":"dc6f47b7023b4599b1b03c346dfae7d3a5b796c7"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"20731961d9333260fe43992dbe03895ce471b335","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When these tests were implemented they were setup"},{"line_number":10,"context_line":"to test shards. The problem is that the range used"},{"line_number":11,"context_line":"in the tests ends at 4094, but there are 4095 shards"},{"line_number":12,"context_line":"in total. This means that if a zone is created on shard"},{"line_number":13,"context_line":"4095 it is always ignored in the tests."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"600a50c7_7167474c","line":11,"in_reply_to":"3dfce8d7_954451a6","updated":"2023-11-09 15:15:17.000000000","message":"No rush. Updated.","commit_id":"dc6f47b7023b4599b1b03c346dfae7d3a5b796c7"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"111f356e8225e0dc89a0a14507d5ff0043639da4","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When these tests were implemented they were setup"},{"line_number":10,"context_line":"to test shards. The problem is that the range used"},{"line_number":11,"context_line":"in the tests ends at 4094, but there are 4095 shards"},{"line_number":12,"context_line":"in total. This means that if a zone is created on shard"},{"line_number":13,"context_line":"4095 it is always ignored in the tests."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3dfce8d7_954451a6","line":11,"in_reply_to":"5611bf0a_176e5342","updated":"2023-11-09 14:54:46.000000000","message":"I\u0027d still like to see the 4095 fixed in this, but won\u0027t block the fix for that.","commit_id":"dc6f47b7023b4599b1b03c346dfae7d3a5b796c7"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9da2c7cbe1b4fac877289d282aed84bd27bac99b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"83d8192b_9ce86549","updated":"2023-11-09 06:36:19.000000000","message":"Wow, a 1 in 4096 chance of failing, that\u0027s a nice one.","commit_id":"dc6f47b7023b4599b1b03c346dfae7d3a5b796c7"}],"designate/tests/fixtures.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9da2c7cbe1b4fac877289d282aed84bd27bac99b","unresolved":true,"context_lines":[{"line_number":184,"context_line":"    def setUp(self):"},{"line_number":185,"context_line":"        super().setUp()"},{"line_number":186,"context_line":"        self.task \u003d self._task_cls()"},{"line_number":187,"context_line":"        self.task.on_partition_change(range(0, 4095 + 1), None, None)"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"# Logging handlers imported from Nova."}],"source_content_type":"text/x-python","patch_set":2,"id":"a536a958_5d542da7","line":187,"range":{"start_line":187,"start_character":47,"end_line":187,"end_character":55},"updated":"2023-11-09 06:36:19.000000000","message":"I\u0027d rather use 4096 here directly, otherwise a comment with an explanation would be needed, but knowing that the definition of the range function excludes the stop value makes this pretty obvious.\n\nSince start\u003d0 is the default, one could optimize further and just use \"range(4096)\", but staying a bit more explicit maybe isn\u0027t bad either.","commit_id":"dc6f47b7023b4599b1b03c346dfae7d3a5b796c7"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"6234547df3c222fb75d630e584a4d9b7cbeab64a","unresolved":false,"context_lines":[{"line_number":184,"context_line":"    def setUp(self):"},{"line_number":185,"context_line":"        super().setUp()"},{"line_number":186,"context_line":"        self.task \u003d self._task_cls()"},{"line_number":187,"context_line":"        self.task.on_partition_change(range(0, 4095 + 1), None, None)"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"# Logging handlers imported from Nova."}],"source_content_type":"text/x-python","patch_set":2,"id":"95c50d29_856ba12f","line":187,"range":{"start_line":187,"start_character":47,"end_line":187,"end_character":55},"in_reply_to":"a536a958_5d542da7","updated":"2023-11-09 11:22:21.000000000","message":"Yea - I was going back on forth on that one. I changed it to 0, 4096.","commit_id":"dc6f47b7023b4599b1b03c346dfae7d3a5b796c7"}]}