)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"e982fa35f8d008a697c198fcab04224500453e95","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cb02abf2_2848ab43","updated":"2023-11-16 13:11:06.000000000","message":"if this is valid - probably needs a bug report as well","commit_id":"a595ea10d757f21d56ade712a160d5953357c6bd"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"d444074a677587ac7e15bb725feb1800af07a4e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"54a1a4b5_da30f075","updated":"2023-11-17 00:19:55.000000000","message":"I am starting to see the problem here. One of the big issues is:\nhttps://github.com/openstack/designate/blob/master/designate/storage/sqlalchemy/alembic/versions/15b34ff3ecb8_fix_service_charset.py#L48\n\nWhere if the designate DB isn\u0027t created correctly from start with utf8 character set (like devstack and many deployment tools do), that migration does not update the tables created in the \"liberty\" migration. They may stay with the old database character set (likely latin).\n\nIt\u0027s sad that we have to force a character set (specific to only one DB engine no less) on every table forever now, but otherwise we may end up with failed migrations when a broken deployment tool is used.\n\nLet\u0027s take the hit and change this now and help anyone with mixed collations migrate to utf8. We should also backport this to the branch that introduced alembic.","commit_id":"5d01c3f4bb0266379072a8a8232f2cf3d9d3c6dc"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"4999126b3a39bdf99a13d01e44de13c00599e11c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ecc1d458_5a8d38d6","updated":"2023-11-16 17:53:53.000000000","message":"This will break migrations that used another collation. I.e. they ran with latin as the DB default, up to a point in the migration, then with this change the later migration will now fail.\nI don\u0027t think we should have these in the migrations, it should be done at DB create time like it is here in devstack:\nhttps://github.com/openstack/devstack/blob/master/lib/databases/mysql#L62\nThis would also block future use of an alternative collation.","commit_id":"5d01c3f4bb0266379072a8a8232f2cf3d9d3c6dc"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"f682c07850a2f1e6de49e6291c57121211238324","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a2e55e61_da0f6198","updated":"2023-11-17 12:45:52.000000000","message":"retesting in a basic environment seems to indicate that this has no effect :( investigating.","commit_id":"5d01c3f4bb0266379072a8a8232f2cf3d9d3c6dc"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"d99fde3ab90e7b1e44f9db669e6741f3f4b1f232","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f61354ae_2715af86","in_reply_to":"162665dd_be3b3ad9","updated":"2023-11-16 19:42:30.000000000","message":"None of the alembic migrations specify a mysql character set. They are agnostic and align with the database default setting. Changing that now would mean deployments with other defaults would start failing.","commit_id":"5d01c3f4bb0266379072a8a8232f2cf3d9d3c6dc"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"11dffc287257ebd6392c4946140497f952e8d96f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"db7b9f29_5fa35cd1","in_reply_to":"54a1a4b5_da30f075","updated":"2023-11-17 14:46:16.000000000","message":"Sounds like we may want some sort of release notes for this?","commit_id":"5d01c3f4bb0266379072a8a8232f2cf3d9d3c6dc"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"37e5af975c0ff4a32c0d40fa81bde6fed20250a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"162665dd_be3b3ad9","in_reply_to":"ecc1d458_5a8d38d6","updated":"2023-11-16 19:28:37.000000000","message":"I guess I misunderstood. It seemed like the migrations in wallaby all include similar mysql specific declarations. If so, wouldn\u0027t migrations that include table additions that do not have those settings the future cause issues with foreign key constraints due to mismatched charsets. Or all the collations meant reconciled on db sync?","commit_id":"5d01c3f4bb0266379072a8a8232f2cf3d9d3c6dc"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"f682c07850a2f1e6de49e6291c57121211238324","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8d366862_bb970922","in_reply_to":"f61354ae_2715af86","updated":"2023-11-17 12:45:52.000000000","message":"yeah, I see your point. What\u0027s weird is that there somehow a problem if no charset is set. let me look a bit more. I\u0027ll abandon this patch because I think there\u0027s got to be a better way than this.","commit_id":"5d01c3f4bb0266379072a8a8232f2cf3d9d3c6dc"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"031b0babdf8111818b1bd4bab77b05773ccc5072","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"11c058d3_d26433ac","updated":"2023-11-17 13:13:13.000000000","message":"old pycache files source of earlier test failures-- but missed one of the create_tables in the liberty migration file. Resolved.","commit_id":"314271a616d19302c22535fd6e38922d7dd12f3f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"498855558e62c7cad82e465287bb74257376a00c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"10536098_57a21548","updated":"2023-11-17 16:21:55.000000000","message":"Still LGTM","commit_id":"1f045ee64a27c6208b3dc2a6bf5b9c5027342235"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"606bcc90b4dce33bbf86aabe3e01adccd5dac443","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"11b9a39f_7333eba4","updated":"2023-11-19 00:30:41.000000000","message":"recheck CI not working","commit_id":"1f045ee64a27c6208b3dc2a6bf5b9c5027342235"}]}