)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"90fa793423c699cb095accde52abd077b4c414ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9a5a4f23_f8d77fb4","updated":"2023-11-16 23:49:37.000000000","message":"LGTM","commit_id":"12362a234f74ebaf8c8f7fce954a853716f9663c"}],"designate/tests/test_storage/test_storage.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d79245fa776fec50b6f6de09192d47aad8bb1769","unresolved":true,"context_lines":[{"line_number":672,"context_line":"        self.assertEqual(self.admin_context.project_id, result[\u0027tenant_id\u0027])"},{"line_number":673,"context_line":"        self.assertEqual(values[\u0027name\u0027], result[\u0027name\u0027])"},{"line_number":674,"context_line":"        self.assertEqual(values[\u0027email\u0027], result[\u0027email\u0027])"},{"line_number":675,"context_line":"        self.assertEqual(3600, result[\u0027ttl\u0027])"},{"line_number":676,"context_line":"        self.assertEqual(pool_id, result[\u0027pool_id\u0027])"},{"line_number":677,"context_line":"        self.assertIn(\u0027status\u0027, result)"},{"line_number":678,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"05f565ba_93bc9bee","line":675,"updated":"2023-11-16 18:04:53.000000000","message":"It might be helpful to have a comment here stating that this is the default value from the configuration.\n\nAlso when we start testing this, maybe we\u0027d rather set a different value in values[] and verify that scenario here and then have another test verifying the default being used?","commit_id":"ac43c30d5cb22271935a4c997589ae2855643f05"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"09884a9f13d7249922940b4f2527649599c44834","unresolved":false,"context_lines":[{"line_number":672,"context_line":"        self.assertEqual(self.admin_context.project_id, result[\u0027tenant_id\u0027])"},{"line_number":673,"context_line":"        self.assertEqual(values[\u0027name\u0027], result[\u0027name\u0027])"},{"line_number":674,"context_line":"        self.assertEqual(values[\u0027email\u0027], result[\u0027email\u0027])"},{"line_number":675,"context_line":"        self.assertEqual(3600, result[\u0027ttl\u0027])"},{"line_number":676,"context_line":"        self.assertEqual(pool_id, result[\u0027pool_id\u0027])"},{"line_number":677,"context_line":"        self.assertIn(\u0027status\u0027, result)"},{"line_number":678,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"69d622f1_71fd7e03","line":675,"in_reply_to":"05f565ba_93bc9bee","updated":"2023-11-16 19:20:29.000000000","message":"Ack","commit_id":"ac43c30d5cb22271935a4c997589ae2855643f05"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d79245fa776fec50b6f6de09192d47aad8bb1769","unresolved":true,"context_lines":[{"line_number":686,"context_line":"        self.assertEqual(exceptions.DuplicateZone, exc.exc_info[0])"},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"    def test_create_zone_override_default_ttl(self):"},{"line_number":689,"context_line":"        CONF.set_override(\u0027default_ttl\u0027, 60)"},{"line_number":690,"context_line":""},{"line_number":691,"context_line":"        zone \u003d self.get_zone_fixture()"},{"line_number":692,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3b2e4910_bcbf8cff","line":689,"updated":"2023-11-16 18:04:53.000000000","message":"Looking at other examples, we want to use the self.config() function here for consistency?","commit_id":"ac43c30d5cb22271935a4c997589ae2855643f05"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"09884a9f13d7249922940b4f2527649599c44834","unresolved":false,"context_lines":[{"line_number":686,"context_line":"        self.assertEqual(exceptions.DuplicateZone, exc.exc_info[0])"},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"    def test_create_zone_override_default_ttl(self):"},{"line_number":689,"context_line":"        CONF.set_override(\u0027default_ttl\u0027, 60)"},{"line_number":690,"context_line":""},{"line_number":691,"context_line":"        zone \u003d self.get_zone_fixture()"},{"line_number":692,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"4025cf4c_6c71970d","line":689,"in_reply_to":"3b2e4910_bcbf8cff","updated":"2023-11-16 19:20:29.000000000","message":"Ack","commit_id":"ac43c30d5cb22271935a4c997589ae2855643f05"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d79245fa776fec50b6f6de09192d47aad8bb1769","unresolved":true,"context_lines":[{"line_number":688,"context_line":"    def test_create_zone_override_default_ttl(self):"},{"line_number":689,"context_line":"        CONF.set_override(\u0027default_ttl\u0027, 60)"},{"line_number":690,"context_line":""},{"line_number":691,"context_line":"        zone \u003d self.get_zone_fixture()"},{"line_number":692,"context_line":""},{"line_number":693,"context_line":"        with sql.get_write_session() as session:"},{"line_number":694,"context_line":"            result \u003d session.execute(tables.zones.insert(), [zone])"},{"line_number":695,"context_line":""},{"line_number":696,"context_line":"        new_zone \u003d self.storage.get_zone(self.admin_context,"},{"line_number":697,"context_line":"                                         result.inserted_primary_key[0])"},{"line_number":698,"context_line":"        self.assertEqual(60, new_zone.ttl)"},{"line_number":699,"context_line":""},{"line_number":700,"context_line":"    def test_find_zones(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba19f849_bbaabdb5","line":697,"range":{"start_line":691,"start_character":8,"end_line":697,"end_character":72},"updated":"2023-11-16 18:04:53.000000000","message":"I don\u0027t think I understand this part. Why not do the same things as in test_create_zone()?","commit_id":"ac43c30d5cb22271935a4c997589ae2855643f05"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"09884a9f13d7249922940b4f2527649599c44834","unresolved":false,"context_lines":[{"line_number":688,"context_line":"    def test_create_zone_override_default_ttl(self):"},{"line_number":689,"context_line":"        CONF.set_override(\u0027default_ttl\u0027, 60)"},{"line_number":690,"context_line":""},{"line_number":691,"context_line":"        zone \u003d self.get_zone_fixture()"},{"line_number":692,"context_line":""},{"line_number":693,"context_line":"        with sql.get_write_session() as session:"},{"line_number":694,"context_line":"            result \u003d session.execute(tables.zones.insert(), [zone])"},{"line_number":695,"context_line":""},{"line_number":696,"context_line":"        new_zone \u003d self.storage.get_zone(self.admin_context,"},{"line_number":697,"context_line":"                                         result.inserted_primary_key[0])"},{"line_number":698,"context_line":"        self.assertEqual(60, new_zone.ttl)"},{"line_number":699,"context_line":""},{"line_number":700,"context_line":"    def test_find_zones(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"816302d1_273524d3","line":697,"range":{"start_line":691,"start_character":8,"end_line":697,"end_character":72},"in_reply_to":"ba19f849_bbaabdb5","updated":"2023-11-16 19:20:29.000000000","message":"Ack","commit_id":"ac43c30d5cb22271935a4c997589ae2855643f05"}]}