)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"d1bf4d3b9494c357aeb72d1ad09b414f4da6dd62","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5eb3d817_734bb28a","updated":"2023-12-07 03:30:28.000000000","message":"I think it would be good if we go a little deeper on the test assertions.","commit_id":"0add40e5e0ce43a52e5e23317a650668836abb60"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c49c8c91d25dc51c29ab7d54ecbe738195e26c5c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0b947d59_109e932f","updated":"2023-12-09 01:53:27.000000000","message":"Two items here","commit_id":"a448530abe8ebccc94e9182a33137fdab22f95d7"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"cac1bcd05b202bc1289441e5496fae34c9ff7f84","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"1bd1e1d2_12e76b04","updated":"2023-12-12 03:59:47.000000000","message":"LGTM","commit_id":"c184426ee2f245179ef0b72a8113d11dcebd924b"}],"designate/service.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c49c8c91d25dc51c29ab7d54ecbe738195e26c5c","unresolved":true,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def start(self):"},{"line_number":126,"context_line":"        for server in self.servers:"},{"line_number":127,"context_line":"            print(server, server.start)"},{"line_number":128,"context_line":"            server.start()"},{"line_number":129,"context_line":"        super().start()"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"8b3b3f12_4e3c9d62","line":127,"updated":"2023-12-09 01:53:27.000000000","message":"Opps, debugging?","commit_id":"a448530abe8ebccc94e9182a33137fdab22f95d7"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"3a264cf6c1422f37388fbb2bb10c0d849b182886","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def start(self):"},{"line_number":126,"context_line":"        for server in self.servers:"},{"line_number":127,"context_line":"            print(server, server.start)"},{"line_number":128,"context_line":"            server.start()"},{"line_number":129,"context_line":"        super().start()"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"2bf78857_ae4821c2","line":127,"in_reply_to":"8b3b3f12_4e3c9d62","updated":"2023-12-09 14:54:33.000000000","message":"good catch lol","commit_id":"a448530abe8ebccc94e9182a33137fdab22f95d7"}],"designate/tests/unit/test_service.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"d1bf4d3b9494c357aeb72d1ad09b414f4da6dd62","unresolved":true,"context_lines":[{"line_number":185,"context_line":"        self.assertIsNone(self.service.start())"},{"line_number":186,"context_line":"        mock_wsgi_server.assert_called_once()"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        self.assertIsNone(self.service.stop())"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    @mock.patch(\u0027oslo_service.wsgi.Server\u0027, mock.Mock())"},{"line_number":191,"context_line":"    def test_service_wait(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"73cab457_cd0b230e","line":188,"updated":"2023-12-07 03:30:28.000000000","message":"We could check that the server stop() was called right?","commit_id":"0add40e5e0ce43a52e5e23317a650668836abb60"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"1e38ebdca69b156d5bd1868fac1f633566970141","unresolved":true,"context_lines":[{"line_number":185,"context_line":"        self.assertIsNone(self.service.start())"},{"line_number":186,"context_line":"        mock_wsgi_server.assert_called_once()"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        self.assertIsNone(self.service.stop())"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    @mock.patch(\u0027oslo_service.wsgi.Server\u0027, mock.Mock())"},{"line_number":191,"context_line":"    def test_service_wait(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"998acad8_c287b7e3","line":188,"in_reply_to":"73cab457_cd0b230e","updated":"2023-12-07 14:07:01.000000000","message":"Good idea. Will add that.","commit_id":"0add40e5e0ce43a52e5e23317a650668836abb60"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"f3eafe2f47c72501575e3bbcabbf8deb9fc20ba3","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        self.assertIsNone(self.service.start())"},{"line_number":186,"context_line":"        mock_wsgi_server.assert_called_once()"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"        self.assertIsNone(self.service.stop())"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    @mock.patch(\u0027oslo_service.wsgi.Server\u0027, mock.Mock())"},{"line_number":191,"context_line":"    def test_service_wait(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"4fd16af0_533b9391","line":188,"in_reply_to":"998acad8_c287b7e3","updated":"2023-12-07 16:03:28.000000000","message":"Done","commit_id":"0add40e5e0ce43a52e5e23317a650668836abb60"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"d1bf4d3b9494c357aeb72d1ad09b414f4da6dd62","unresolved":true,"context_lines":[{"line_number":196,"context_line":"            self.mock_app, \u0027test-wsgi-service\u0027, listen"},{"line_number":197,"context_line":"        )"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        self.assertIsNone(self.service.wait())"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    @mock.patch(\u0027oslo_service.wsgi.Server\u0027, mock.Mock())"},{"line_number":202,"context_line":"    def test_service_wait_multiple_servers(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"8011f803_460c0db6","line":199,"updated":"2023-12-07 03:30:28.000000000","message":"Same here, can we check that wait() was called?","commit_id":"0add40e5e0ce43a52e5e23317a650668836abb60"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"1e38ebdca69b156d5bd1868fac1f633566970141","unresolved":true,"context_lines":[{"line_number":196,"context_line":"            self.mock_app, \u0027test-wsgi-service\u0027, listen"},{"line_number":197,"context_line":"        )"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        self.assertIsNone(self.service.wait())"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    @mock.patch(\u0027oslo_service.wsgi.Server\u0027, mock.Mock())"},{"line_number":202,"context_line":"    def test_service_wait_multiple_servers(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"b589f3ae_be0edbb2","line":199,"in_reply_to":"8011f803_460c0db6","updated":"2023-12-07 14:07:01.000000000","message":"Good idea. Will add that.","commit_id":"0add40e5e0ce43a52e5e23317a650668836abb60"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"f3eafe2f47c72501575e3bbcabbf8deb9fc20ba3","unresolved":false,"context_lines":[{"line_number":196,"context_line":"            self.mock_app, \u0027test-wsgi-service\u0027, listen"},{"line_number":197,"context_line":"        )"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        self.assertIsNone(self.service.wait())"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    @mock.patch(\u0027oslo_service.wsgi.Server\u0027, mock.Mock())"},{"line_number":202,"context_line":"    def test_service_wait_multiple_servers(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"e56b43a1_a8276369","line":199,"in_reply_to":"b589f3ae_be0edbb2","updated":"2023-12-07 16:03:28.000000000","message":"Done","commit_id":"0add40e5e0ce43a52e5e23317a650668836abb60"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"c49c8c91d25dc51c29ab7d54ecbe738195e26c5c","unresolved":true,"context_lines":[{"line_number":435,"context_line":""},{"line_number":436,"context_line":"    def test_dns_handle_tcp_conn_client_none(self):"},{"line_number":437,"context_line":"        addr \u003d (\u0027192.0.2.1\u0027, 53)"},{"line_number":438,"context_line":"        self.service._dns_handle_tcp_conn(addr, None)"}],"source_content_type":"text/x-python","patch_set":6,"id":"4ee46607_4a7f5d3e","line":438,"updated":"2023-12-09 01:53:27.000000000","message":"Tests without at least an assert is a red flag.\nMaybe we check that something was not called? Maybe the client.close()?\nMaybe the struct unpack as well?","commit_id":"a448530abe8ebccc94e9182a33137fdab22f95d7"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"3a264cf6c1422f37388fbb2bb10c0d849b182886","unresolved":false,"context_lines":[{"line_number":435,"context_line":""},{"line_number":436,"context_line":"    def test_dns_handle_tcp_conn_client_none(self):"},{"line_number":437,"context_line":"        addr \u003d (\u0027192.0.2.1\u0027, 53)"},{"line_number":438,"context_line":"        self.service._dns_handle_tcp_conn(addr, None)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7748d027_872a8229","line":438,"in_reply_to":"4ee46607_4a7f5d3e","updated":"2023-12-09 14:54:33.000000000","message":"Yea - I removed this test and removed this if statement. It is impossible to his this in a real world scenario.","commit_id":"a448530abe8ebccc94e9182a33137fdab22f95d7"}]}