)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7b2e13802f15a187c7b1af1a669be8c3e6e692b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"d2dc4c7c_f57e25fd","updated":"2023-12-07 03:49:16.000000000","message":"Just a question about the deepcopy code change.","commit_id":"930d2a2a03b70a352eb73dc5bd14f688cb88ab36"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"5539b9b28b4e36d65f1f48b91d53f820f39d5df4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"f866ec31_25ee4861","updated":"2023-12-09 01:40:56.000000000","message":"LGTM","commit_id":"e720d8d59a835e58d63539ea257b8a4b231ce628"}],"designate/context.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7b2e13802f15a187c7b1af1a669be8c3e6e692b6","unresolved":true,"context_lines":[{"line_number":245,"context_line":"                          discover_versions\u003dTrue,"},{"line_number":246,"context_line":"                          **kwargs):"},{"line_number":247,"context_line":"        urlkw \u003d {}"},{"line_number":248,"context_line":"        for k in (\u0027service_type\u0027, \u0027service_name\u0027, \u0027service_id\u0027, \u0027endpoint_id\u0027,"},{"line_number":249,"context_line":"                  \u0027region_name\u0027, \u0027interface\u0027):"},{"line_number":250,"context_line":"            if k in kwargs:"},{"line_number":251,"context_line":"                urlkw[k] \u003d kwargs[k]"}],"source_content_type":"text/x-python","patch_set":9,"id":"0ab33b59_deb9fe3d","side":"PARENT","line":248,"updated":"2023-12-07 03:49:16.000000000","message":"I saw this once in another context and thought it was odd. Thanks for cleaning this up!","commit_id":"98f1ad2856a0acb9081c5449ab13718714b42920"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7b2e13802f15a187c7b1af1a669be8c3e6e692b6","unresolved":true,"context_lines":[{"line_number":63,"context_line":"        self.delete_shares \u003d delete_shares"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def deepcopy(self):"},{"line_number":66,"context_line":"        return self.from_dict(self.to_dict())"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def to_dict(self):"},{"line_number":69,"context_line":"        d \u003d super().to_dict()"}],"source_content_type":"text/x-python","patch_set":9,"id":"eaf0c448_cf0420ed","line":66,"updated":"2023-12-07 03:49:16.000000000","message":"Such an odd deepcopy(), it hurts my brain. Did you check that the object ID chain is different when we do it like this?\nI am just wondering if the assignment creates the new base object.\nI think this is ok, but I don\u0027t have a debugger at the moment to confirm.","commit_id":"930d2a2a03b70a352eb73dc5bd14f688cb88ab36"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"0a2b551d7113c2cef6190f47d15fe121aad571db","unresolved":true,"context_lines":[{"line_number":63,"context_line":"        self.delete_shares \u003d delete_shares"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def deepcopy(self):"},{"line_number":66,"context_line":"        return self.from_dict(self.to_dict())"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def to_dict(self):"},{"line_number":69,"context_line":"        d \u003d super().to_dict()"}],"source_content_type":"text/x-python","patch_set":9,"id":"bf529c7a_461c8338","line":66,"in_reply_to":"eaf0c448_cf0420ed","updated":"2023-12-07 16:08:25.000000000","message":"So I originally just changed this to be a more typical deepcopy, but ended up not changing it as I had the same question, but felt like it was out of the scope for this patch.\n\nI can probably throw up a follow up change after this to tackle the deep command.","commit_id":"930d2a2a03b70a352eb73dc5bd14f688cb88ab36"}]}