)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2c88cff08f4301fd16ecc4e655cca8acf3bcd9f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2c4fe3c9_5e2c3abf","updated":"2023-11-29 23:47:37.000000000","message":"This is not valid, underscores are very common in records. In fact, they are required for Microsoft Active Directory environments.\nSee this RFC for an example: https://www.rfc-editor.org/rfc/rfc2782\n\n _ldap._tcp.example.com","commit_id":"73eb02ac1d96f521cda0bb1ba6ec2f43270ec2d0"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"0cd8c73189b4d0bf6926655918f3d86532a6f317","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a0b6ad92_0bc87016","updated":"2023-11-30 13:31:06.000000000","message":"We have been informed by customer that recordset should not contain underscore and that was allowed by Designate. Looks like it is not correct. \n\n @Erik, @Michael,\nCan domain name as well contain underscore or its restricted ?","commit_id":"73eb02ac1d96f521cda0bb1ba6ec2f43270ec2d0"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"40c2ca5bff4a31e98e09428cadbcf808ce313601","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"81da327a_8680e145","in_reply_to":"65b6808f_6190420e","updated":"2023-11-30 14:01:54.000000000","message":"yes its confusing e.g. https://en.wikipedia.org/wiki/NAPTR_record has mention of \"_sip._udp.example.com.\" as domain name","commit_id":"73eb02ac1d96f521cda0bb1ba6ec2f43270ec2d0"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"fafa4f183f4c6ce8c5d587d0ea1ca90454979752","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4b2bb084_9b19a481","in_reply_to":"81da327a_8680e145","updated":"2023-11-30 14:07:10.000000000","message":"Yep and reading e.g. the Microsoft guide they say this\n\u003e The underscore has a special role. It\u0027s permitted for the first character in SRV records by RFC definition. But newer DNS servers might also allow it anywhere in a name. When you create a domain, you receive a warning message that states that an underscore character might cause problems for some DNS servers. However, you can still create the domain.\n\nI tried this with bind and got this warning, but the domain was working fine.\n\u003e  zone teee_est.net/IN: hey.teee_est.net/A: bad owner name (check-names)","commit_id":"73eb02ac1d96f521cda0bb1ba6ec2f43270ec2d0"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"ff6bd229afee01dc2534deb2b1738cf23c845f0b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"65b6808f_6190420e","in_reply_to":"a0b6ad92_0bc87016","updated":"2023-11-30 13:35:25.000000000","message":"Yea - I don\u0027t believe domain names allow for an underscore, but it\u0027s tricky as while you cannot register a domain with a underscore (afaik), most tools allow you to create a domain with an underscore.","commit_id":"73eb02ac1d96f521cda0bb1ba6ec2f43270ec2d0"}],"designate/central/service.py":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"4c3bcd41b5c7efdcd8600caf6e996da27c6ffde2","unresolved":true,"context_lines":[{"line_number":1346,"context_line":"        if zone.action \u003d\u003d \u0027DELETE\u0027:"},{"line_number":1347,"context_line":"            raise exceptions.BadRequest(\u0027Can not update a deleting zone\u0027)"},{"line_number":1348,"context_line":""},{"line_number":1349,"context_line":"        if \u0027_\u0027 in recordset.name:"},{"line_number":1350,"context_line":"            raise exceptions.BadRequest("},{"line_number":1351,"context_line":"                \u0027record name should not contain underscore\u0027)"},{"line_number":1352,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"44d363bc_5104af3b","line":1349,"updated":"2023-11-29 14:55:41.000000000","message":"Recordsets are allowed to have a _, it\u0027s just the zone name as far as I am aware?\n\nThe issue is more likely to be with this regex here\nhttps://github.com/openstack/designate/blob/master/designate/common/constants.py#L64","commit_id":"73eb02ac1d96f521cda0bb1ba6ec2f43270ec2d0"}]}