)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"72b654e0b7f74c09fa2ee47cb86e0f4b30a77561","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"61d64f7f_b4dc94d6","updated":"2023-12-12 23:25:50.000000000","message":"Just a couple of questions and a thought about using a sqlite engine instead of full mysql/mariadb.","commit_id":"fe1d03ca0cefcc064ed0f26af3ac253ace14dd99"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"d45e590e2c0bf5025ea4301850cbc59b6640b1af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"f3c9526e_1334c195","updated":"2023-12-14 17:23:14.000000000","message":"I think this is a good start","commit_id":"f5a034272ddeddf80dc858396cf31ab581f4ae5e"}],"bindep.txt":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"72b654e0b7f74c09fa2ee47cb86e0f4b30a77561","unresolved":true,"context_lines":[{"line_number":2,"context_line":"graphviz [doc]"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Mysql testing dependencies"},{"line_number":5,"context_line":"mysql [platform:rpm !platform:redhat]"},{"line_number":6,"context_line":"mysql-client [platform:dpkg !platform:debian]"},{"line_number":7,"context_line":"mysql-devel [platform:rpm !platform:redhat test]"},{"line_number":8,"context_line":"mysql-server [!platform:redhat !platform:debian]"}],"source_content_type":"text/plain","patch_set":9,"id":"3f36d266_c6ff5029","line":5,"updated":"2023-12-12 23:25:50.000000000","message":"So, technically these are requirements of the project (though usually supplied by the database component of the deployment tool), this is a bit heavy weight for unit/functional tests. Obviously we load them for tempest runs, but unit/functional this might be some overhead.\n\nOne thing Octavia did was use a in-memory sqlite instance for the functional tests. It\u0027s faster than dealing with mysql, but has the downside of not being 100% compatible when it comes to transactions (you need to turn on disk storage for that).\n\nI am guessing that the goal here is to *run* the migrations, sqlite may be good enough.","commit_id":"fe1d03ca0cefcc064ed0f26af3ac253ace14dd99"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"96bd60cfb08e8b8ef42f0f2e9ed769b90d50e675","unresolved":true,"context_lines":[{"line_number":2,"context_line":"graphviz [doc]"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"# Mysql testing dependencies"},{"line_number":5,"context_line":"mysql [platform:rpm !platform:redhat]"},{"line_number":6,"context_line":"mysql-client [platform:dpkg !platform:debian]"},{"line_number":7,"context_line":"mysql-devel [platform:rpm !platform:redhat test]"},{"line_number":8,"context_line":"mysql-server [!platform:redhat !platform:debian]"}],"source_content_type":"text/plain","patch_set":9,"id":"7457bfd3_587390b1","line":5,"in_reply_to":"3f36d266_c6ff5029","updated":"2023-12-12 23:50:24.000000000","message":"So the reason for this is because SQLite hasn’t been enough to catch the majority of upgrade bugs and issues we have historically seen and would be easier to catch preemptively here, plus this allows fast local iteration on code changes to the upgrade process than tempest or devstack since this is a lot more light weight and reproducible.\n\nOverall a few other projects have made good use of this test framework (eg Nova, Zaqar) and that is why I wanted to adopt it as well.\n\nAlso, keep in mind that all of this is optional and running the unit tests does not require MySQL to be installed. We run both these and a ton of other SQLite based tests even if MySQL isn’t installed.","commit_id":"fe1d03ca0cefcc064ed0f26af3ac253ace14dd99"}],"designate/storage/sqlalchemy/alembic/env.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"72b654e0b7f74c09fa2ee47cb86e0f4b30a77561","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"634f54b2_e428396c","updated":"2023-12-12 23:25:50.000000000","message":"This is boilerplate code generated by alembic init, do we need to change this?","commit_id":"a0fc0ad4993194b5fe010bc4a906ae254b1b9a1f"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"96bd60cfb08e8b8ef42f0f2e9ed769b90d50e675","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"f710c7f9_d21f411e","in_reply_to":"634f54b2_e428396c","updated":"2023-12-12 23:50:24.000000000","message":"I wasn’t able to make this work without it at least. might be able to work around it in code.","commit_id":"a0fc0ad4993194b5fe010bc4a906ae254b1b9a1f"}],"tools/test-setup.sh":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"72b654e0b7f74c09fa2ee47cb86e0f4b30a77561","unresolved":true,"context_lines":[{"line_number":56,"context_line":"    GRANT ALL PRIVILEGES ON *.* TO \u0027$DB_USER\u0027@\u0027%\u0027 WITH GRANT OPTION;\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"# Now create our database."},{"line_number":59,"context_line":"mysql -u $DB_USER -p$DB_PW -h 127.0.0.1 -e \""},{"line_number":60,"context_line":"    SET default_storage_engine\u003dMYISAM;"},{"line_number":61,"context_line":"    DROP DATABASE IF EXISTS openstack_citest;"},{"line_number":62,"context_line":"    CREATE DATABASE openstack_citest CHARACTER SET utf8;\""}],"source_content_type":"text/x-sh","patch_set":9,"id":"d3ee9b19_c12b2d77","line":59,"updated":"2023-12-12 23:25:50.000000000","message":"Again here, I wonder if spinning up a sqlite DB in memory would be better than using mysql/mariadb.","commit_id":"fe1d03ca0cefcc064ed0f26af3ac253ace14dd99"}]}