)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"fa7705caf1a2046bf5aa68e94b1ba4d140c034c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"e5e2a59b_971b1737","updated":"2024-02-17 14:12:28.000000000","message":"recheck unrelated failure","commit_id":"f930eb44ebef6054c704f9d7b8ea42c155f8f825"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"98588a26e551b05eccfabe36affa6865f43add5c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"dc3787c4_9cc78b8f","updated":"2024-05-16 17:37:21.000000000","message":"I have a concern about the requirements change.","commit_id":"f70e4cff3f7b5b133af089d1e0f860691a86894c"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"005e753002740f32527954c47bf8c7b89bba9b5a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"1d71e9ad_5216108e","in_reply_to":"dc3787c4_9cc78b8f","updated":"2024-05-17 07:35:35.000000000","message":"Good catch. That must have been merge damage.","commit_id":"f70e4cff3f7b5b133af089d1e0f860691a86894c"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"4ebb8dbf980bbc097a2ee893a3fe18d91d8c3e2c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"ae5f2284_cedc8909","updated":"2024-05-17 16:52:10.000000000","message":"LGTM","commit_id":"1dbdcac58fdb602c9a3617d4b22ba16690e869cf"}],"designate/backend/impl_infoblox.py":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"cae56a63bf85747aa54d76b8ac9d09999442dde7","unresolved":true,"context_lines":[{"line_number":140,"context_line":"    def get_or_create_network_view(self, project_id, create_if_missing\u003dTrue):"},{"line_number":141,"context_line":"        net_view_name \u003d f\u0027{self.network_view}.{project_id}\u0027"},{"line_number":142,"context_line":"        network_view \u003d infoblox_objects.NetworkView.search("},{"line_number":143,"context_line":"            self.connection, name\u003dnet_view_name"},{"line_number":144,"context_line":"        )"},{"line_number":145,"context_line":"        if not network_view and create_if_missing:"},{"line_number":146,"context_line":"            network_view \u003d self.infoblox.create_network_view("}],"source_content_type":"text/x-python","patch_set":5,"id":"184164c6_8319032e","line":143,"updated":"2024-01-16 18:43:10.000000000","message":"I am unable to search using exattrs with the infoblox client\n\u003e {\u0027TenantID\u0027: {\u0027value\u0027: project_id}}","commit_id":"578af2333c3907cbbea99f4c3858560c0d076a5d"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"ac55e6ca4725c8da6d9a6d0576dc3d41fbc53963","unresolved":true,"context_lines":[{"line_number":140,"context_line":"    def get_or_create_network_view(self, project_id, create_if_missing\u003dTrue):"},{"line_number":141,"context_line":"        net_view_name \u003d f\u0027{self.network_view}.{project_id}\u0027"},{"line_number":142,"context_line":"        network_view \u003d infoblox_objects.NetworkView.search("},{"line_number":143,"context_line":"            self.connection, name\u003dnet_view_name"},{"line_number":144,"context_line":"        )"},{"line_number":145,"context_line":"        if not network_view and create_if_missing:"},{"line_number":146,"context_line":"            network_view \u003d self.infoblox.create_network_view("}],"source_content_type":"text/x-python","patch_set":5,"id":"3c5a9098_2e2a1918","line":143,"in_reply_to":"184164c6_8319032e","updated":"2024-01-17 00:45:46.000000000","message":"I am pretty sure it\u0027s fine to just use the namespace, instead of searching for TenantID, but maybe a feature request to the infoblox client to add support for searching for extattrs?","commit_id":"578af2333c3907cbbea99f4c3858560c0d076a5d"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"405242a64a84b9adf21e04e668cea4846f2979ae","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    def get_or_create_network_view(self, project_id, create_if_missing\u003dTrue):"},{"line_number":141,"context_line":"        net_view_name \u003d f\u0027{self.network_view}.{project_id}\u0027"},{"line_number":142,"context_line":"        network_view \u003d infoblox_objects.NetworkView.search("},{"line_number":143,"context_line":"            self.connection, name\u003dnet_view_name"},{"line_number":144,"context_line":"        )"},{"line_number":145,"context_line":"        if not network_view and create_if_missing:"},{"line_number":146,"context_line":"            network_view \u003d self.infoblox.create_network_view("}],"source_content_type":"text/x-python","patch_set":5,"id":"7adcb5fe_c0083725","line":143,"in_reply_to":"3c5a9098_2e2a1918","updated":"2024-01-17 13:21:59.000000000","message":"Done","commit_id":"578af2333c3907cbbea99f4c3858560c0d076a5d"}],"designate/tests/unit/backend/test_infoblox.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"99a6a542e613616a0df4a1a615f46afeec7cfd53","unresolved":true,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from infoblox_client import connector as infoblox_connector"},{"line_number":20,"context_line":"from infoblox_client import exceptions as infoblox_exceptions"},{"line_number":21,"context_line":"from infoblox_client import objects as infoblox_objects"},{"line_number":22,"context_line":"import oslotest.base"},{"line_number":23,"context_line":"import requests_mock"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"00590336_0c103c3d","line":21,"updated":"2024-01-22 10:59:28.000000000","message":"make these imports conditional within the test class and skip the tests if they fail?","commit_id":"15759751d24ad0d5c3b378f136804b7488894698"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"fe3d3cbc3f7c1c9d00b24674a5c1da001c762bce","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from infoblox_client import connector as infoblox_connector"},{"line_number":20,"context_line":"from infoblox_client import exceptions as infoblox_exceptions"},{"line_number":21,"context_line":"from infoblox_client import objects as infoblox_objects"},{"line_number":22,"context_line":"import oslotest.base"},{"line_number":23,"context_line":"import requests_mock"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"0d36505d_ca6ae99e","line":21,"in_reply_to":"00590336_0c103c3d","updated":"2024-03-02 15:48:38.000000000","message":"No. I don\u0027t want untested drivers in the code base.","commit_id":"15759751d24ad0d5c3b378f136804b7488894698"}],"requirements.txt":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"98588a26e551b05eccfabe36affa6865f43add5c","unresolved":true,"context_lines":[{"line_number":40,"context_line":"oslo.policy\u003e\u003d3.7.0 # Apache-2.0"},{"line_number":41,"context_line":"tooz\u003e\u003d1.58.0 # Apache-2.0"},{"line_number":42,"context_line":"futurist\u003e\u003d1.2.0 # Apache-2.0"},{"line_number":43,"context_line":"edgegrid-python\u003e\u003d1.1.1 # Apache-2.0"},{"line_number":44,"context_line":"infoblox-client\u003e\u003d0.6.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":23,"id":"077bf2ff_0e454a11","line":43,"updated":"2024-05-16 17:37:21.000000000","message":"This is an \"extra\" so should not be in requirements.txt:\nhttps://github.com/openstack/designate/blob/master/setup.cfg#L37","commit_id":"f70e4cff3f7b5b133af089d1e0f860691a86894c"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"46396ec91f451d71ea78295310159dfcebe9ea14","unresolved":false,"context_lines":[{"line_number":40,"context_line":"oslo.policy\u003e\u003d3.7.0 # Apache-2.0"},{"line_number":41,"context_line":"tooz\u003e\u003d1.58.0 # Apache-2.0"},{"line_number":42,"context_line":"futurist\u003e\u003d1.2.0 # Apache-2.0"},{"line_number":43,"context_line":"edgegrid-python\u003e\u003d1.1.1 # Apache-2.0"},{"line_number":44,"context_line":"infoblox-client\u003e\u003d0.6.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":23,"id":"4458f377_dfb6f4e4","line":43,"in_reply_to":"077bf2ff_0e454a11","updated":"2024-05-17 14:41:39.000000000","message":"Done","commit_id":"f70e4cff3f7b5b133af089d1e0f860691a86894c"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"98588a26e551b05eccfabe36affa6865f43add5c","unresolved":true,"context_lines":[{"line_number":41,"context_line":"tooz\u003e\u003d1.58.0 # Apache-2.0"},{"line_number":42,"context_line":"futurist\u003e\u003d1.2.0 # Apache-2.0"},{"line_number":43,"context_line":"edgegrid-python\u003e\u003d1.1.1 # Apache-2.0"},{"line_number":44,"context_line":"infoblox-client\u003e\u003d0.6.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":23,"id":"389716cd_e53395d2","line":44,"updated":"2024-05-16 17:37:21.000000000","message":"I think this should also be an \"extra\" as it\u0027s only needed when the infoblox backend is used.","commit_id":"f70e4cff3f7b5b133af089d1e0f860691a86894c"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"46396ec91f451d71ea78295310159dfcebe9ea14","unresolved":false,"context_lines":[{"line_number":41,"context_line":"tooz\u003e\u003d1.58.0 # Apache-2.0"},{"line_number":42,"context_line":"futurist\u003e\u003d1.2.0 # Apache-2.0"},{"line_number":43,"context_line":"edgegrid-python\u003e\u003d1.1.1 # Apache-2.0"},{"line_number":44,"context_line":"infoblox-client\u003e\u003d0.6.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":23,"id":"0afa7e89_3132e458","line":44,"in_reply_to":"389716cd_e53395d2","updated":"2024-05-17 14:41:39.000000000","message":"Done","commit_id":"f70e4cff3f7b5b133af089d1e0f860691a86894c"}],"test-requirements.txt":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"99a6a542e613616a0df4a1a615f46afeec7cfd53","unresolved":true,"context_lines":[{"line_number":20,"context_line":"Pygments\u003e\u003d2.2.0 # BSD license"},{"line_number":21,"context_line":"pymemcache!\u003d1.3.0,\u003e\u003d1.2.9 # Apache 2.0 License"},{"line_number":22,"context_line":"PyMySQL\u003e\u003d0.8.0 # MIT License"},{"line_number":23,"context_line":"infoblox-client\u003e\u003d0.6.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":13,"id":"c639f3b4_8276c4e0","line":23,"updated":"2024-01-22 10:59:28.000000000","message":"If it is not added to th requirements repo, you cannot use it here, but you must install it in tox or the devstack plugin if needed.","commit_id":"15759751d24ad0d5c3b378f136804b7488894698"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"e43248027eba78887fc605b1149fa96857fca25f","unresolved":false,"context_lines":[{"line_number":20,"context_line":"Pygments\u003e\u003d2.2.0 # BSD license"},{"line_number":21,"context_line":"pymemcache!\u003d1.3.0,\u003e\u003d1.2.9 # Apache 2.0 License"},{"line_number":22,"context_line":"PyMySQL\u003e\u003d0.8.0 # MIT License"},{"line_number":23,"context_line":"infoblox-client\u003e\u003d0.6.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":13,"id":"72971fe3_7e915ab5","line":23,"in_reply_to":"c487ade7_b570e002","updated":"2024-01-26 03:40:29.000000000","message":"The idea here is that we want to replace the existing implementation with something that is properly tested (and based on something supported by infoblox). If we were to remove this from requirements it would be a step backwards and at that point instead of writing a fancy new driver, I would rather deprecate and remove this driver.","commit_id":"15759751d24ad0d5c3b378f136804b7488894698"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"71d83e0741e82a624c2dbc93d088e0b16e2b36ed","unresolved":true,"context_lines":[{"line_number":20,"context_line":"Pygments\u003e\u003d2.2.0 # BSD license"},{"line_number":21,"context_line":"pymemcache!\u003d1.3.0,\u003e\u003d1.2.9 # Apache 2.0 License"},{"line_number":22,"context_line":"PyMySQL\u003e\u003d0.8.0 # MIT License"},{"line_number":23,"context_line":"infoblox-client\u003e\u003d0.6.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":13,"id":"c487ade7_b570e002","line":23,"in_reply_to":"c639f3b4_8276c4e0","updated":"2024-01-22 11:09:11.000000000","message":"Yea, not having it in requirements isn\u0027t an acceptable solution.","commit_id":"15759751d24ad0d5c3b378f136804b7488894698"}]}