)]}'
{"id":"openstack%2Fdesignate~905352","triplet_id":"openstack%2Fdesignate~master~Ib7b75331228d4e52e7003add8186d6a939efa224","project":"openstack/designate","branch":"master","attention_set":{},"removed_from_attention_set":{"36652":{"account":{"_account_id":36652,"name":"Daniel T. Lee","display_name":"Daniel T. Lee","email":"danieltimlee@gmail.com","username":"danieltimlee"},"last_update":"2024-01-15 07:35:44.000000000","reason":"\u003cGERRIT_ACCOUNT_36652\u003e replied on the change","reason_account":{"_account_id":36652,"name":"Daniel T. Lee","display_name":"Daniel T. Lee","email":"danieltimlee@gmail.com","username":"danieltimlee"}},"22623":{"account":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"last_update":"2024-01-15 07:36:37.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"Ib7b75331228d4e52e7003add8186d6a939efa224","subject":"Make SOA MNAME follow pool\u0027s ns_records priority","status":"ABANDONED","created":"2024-01-11 19:14:05.000000000","updated":"2024-01-15 07:36:37.000000000","total_comment_count":6,"unresolved_comment_count":1,"has_review_started":true,"meta_rev_id":"2b99a432cb0b81f1281471efc49a5654f89a1b74","_number":905352,"virtual_id_number":905352,"owner":{"_account_id":36652,"name":"Daniel T. Lee","display_name":"Daniel T. Lee","email":"danieltimlee@gmail.com","username":"danieltimlee"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2024-01-12 00:31:15.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2024-01-11 20:40:04.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2024-01-12 13:49:54.000000000","updated_by":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"reviewer":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"state":"CC"}],"messages":[{"id":"58410c574c93004f4d52035f2542418246459211","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":36652,"name":"Daniel T. Lee","display_name":"Daniel T. Lee","email":"danieltimlee@gmail.com","username":"danieltimlee"},"date":"2024-01-11 19:14:05.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f3f62f6a8f373df30f181c6dae7cc44dc290ff08","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-01-11 20:40:04.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/7f1dc0594ed5443193c8b0230040c673\n\n- designate-bind9 https://zuul.opendev.org/t/openstack/build/e566ad1df63947fba10b6ad0fadd8d63 : SUCCESS in 51m 10s\n- designate-bind9-centos9stream-fips https://zuul.opendev.org/t/openstack/build/68ab80b80f3840fcb661a603e6a6aa50 : SUCCESS in 57m 28s (non-voting)\n- designate-bind9-centos-9-stream https://zuul.opendev.org/t/openstack/build/ccf4aeaf584446cc849dd6c7a52193c0 : SUCCESS in 45m 07s (non-voting)\n- designate-bind9-keystone-default-roles https://zuul.opendev.org/t/openstack/build/f4ee43dd69b6463db53baaa197fe14eb : SUCCESS in 46m 37s\n- designate-pdns4 https://zuul.opendev.org/t/openstack/build/31768c65c93f4d619a7ed783cb9cfc31 : SUCCESS in 50m 49s\n- designate-grenade-bind9 https://zuul.opendev.org/t/openstack/build/8ae0a16e933244c39f3caf1a36d8c971 : SUCCESS in 53m 22s (non-voting)\n- designate-grenade-pdns4 https://zuul.opendev.org/t/openstack/build/2217e16d197940d686f350fa9a76c0d8 : SUCCESS in 1h 10m 16s\n- designate-ipv6-only-pdns4 https://zuul.opendev.org/t/openstack/build/4db10a3c0efb4aaba19141d0f499904d : SUCCESS in 47m 24s\n- designate-ipv6-only-bind9 https://zuul.opendev.org/t/openstack/build/ad3b65d7f8ed4042b1fd3b6076901d0d : SUCCESS in 50m 55s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/d10ed3e6867943e49b69e540681d8579 : SUCCESS in 5m 57s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/00adefd2a8cb415bb435c282c92ab24f : FAILURE in 3m 42s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/c54a581c60f445d08a8797ce5304e048 : SUCCESS in 7m 56s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/b988ca0109344b719592655debf87207 : SUCCESS in 5m 18s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9aeadb8af4784aee979642d7498e331f : SUCCESS in 11m 09s\n- neutron-tempest-plugin-designate-scenario https://zuul.opendev.org/t/openstack/build/6e7bf1d859864e239cb3fa5e3fe36da9 : SUCCESS in 45m 08s\n- designate-tox-py310-with-sqlalchemy-2x https://zuul.opendev.org/t/openstack/build/31758f05811a4d749feeeb100c34354f : SUCCESS in 9m 30s\n- designate-bind9-sqlalchemy-2x https://zuul.opendev.org/t/openstack/build/e53c2d1d1cc247aaa869b95183125ccb : SUCCESS in 39m 17s\n- designate-tox-dnspython-latest https://zuul.opendev.org/t/openstack/build/cad96c3de7794902b642ec11f8598ace : SUCCESS in 4m 39s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"d9664abd98b446ef4790adf887ea55656c1561cb","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":36652,"name":"Daniel T. Lee","display_name":"Daniel T. Lee","email":"danieltimlee@gmail.com","username":"danieltimlee"},"date":"2024-01-11 23:12:40.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified-1\n","accounts_in_message":[],"_revision_number":2},{"id":"04b1224d567f675e73c6f8076da1677c3a69fe99","author":{"_account_id":36652,"name":"Daniel T. Lee","display_name":"Daniel T. Lee","email":"danieltimlee@gmail.com","username":"danieltimlee"},"date":"2024-01-11 23:32:18.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"f74f04966988de89eee656cfdb0f9271b20d8668","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2024-01-12 00:31:15.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/300f152549d54873a6f289984b021281\n\n- designate-bind9 https://zuul.opendev.org/t/openstack/build/99c16adb454e4870adf419ddd5581cf3 : SUCCESS in 51m 20s\n- designate-bind9-centos9stream-fips https://zuul.opendev.org/t/openstack/build/e18ec00b3040413fbdc5e47de47d9641 : SUCCESS in 1h 02m 16s (non-voting)\n- designate-bind9-centos-9-stream https://zuul.opendev.org/t/openstack/build/5c571b3c8ed445b58bb9a62d3b3ab791 : SUCCESS in 52m 25s (non-voting)\n- designate-bind9-keystone-default-roles https://zuul.opendev.org/t/openstack/build/ec7b1e223a57403c8d25a33935df5b2b : SUCCESS in 49m 56s\n- designate-pdns4 https://zuul.opendev.org/t/openstack/build/aaabb8538d264067b7dc87c4106ce23e : SUCCESS in 51m 17s\n- designate-grenade-bind9 https://zuul.opendev.org/t/openstack/build/e92e03eacdf94fdcb62f3d3c57d2321f : SUCCESS in 1h 10m 22s (non-voting)\n- designate-grenade-pdns4 https://zuul.opendev.org/t/openstack/build/6799a42461d448119bf56b4e799137e8 : SUCCESS in 1h 07m 57s\n- designate-ipv6-only-pdns4 https://zuul.opendev.org/t/openstack/build/09c2216025174d9a931721189e486d1b : SUCCESS in 51m 18s\n- designate-ipv6-only-bind9 https://zuul.opendev.org/t/openstack/build/32b575fe06a2405e887499817da46df6 : SUCCESS in 46m 08s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/ccf87952834748d5a3452394be5fbc31 : SUCCESS in 6m 01s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/640cea6d607a4c05b8e633c0cb2d7252 : SUCCESS in 4m 01s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/49236c06073940a09efca21c032bd5d2 : SUCCESS in 5m 26s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/3171094f474a44d5a50135ac5c925773 : SUCCESS in 5m 16s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ceac4aae4fe547ad80aa51b5f13a832c : SUCCESS in 7m 47s\n- neutron-tempest-plugin-designate-scenario https://zuul.opendev.org/t/openstack/build/31050955303848e0807d01cf07e3712e : SUCCESS in 33m 28s\n- designate-tox-py310-with-sqlalchemy-2x https://zuul.opendev.org/t/openstack/build/2aad3ac63d07485dbb39d24b7d96cf72 : SUCCESS in 6m 50s\n- designate-bind9-sqlalchemy-2x https://zuul.opendev.org/t/openstack/build/22f0e42d72894c7ca84a66434e3024c8 : SUCCESS in 39m 25s\n- designate-tox-dnspython-latest https://zuul.opendev.org/t/openstack/build/ae4312b2554943bca4928c554e8cb243 : SUCCESS in 5m 01s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"cfddba4079a903378b2e42aa506d771de3921010","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2024-01-12 13:49:54.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"6661d52369d727ca5c6e32be7e102cab9d74d29c","author":{"_account_id":36652,"name":"Daniel T. Lee","display_name":"Daniel T. Lee","email":"danieltimlee@gmail.com","username":"danieltimlee"},"date":"2024-01-12 13:53:48.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"bbe5c9cb02e7827edc9c1ee0ae20c0fafa86ea98","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2024-01-12 13:58:13.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"237f621890f80acb6cb6e2c48d66553e5a16d50b","author":{"_account_id":36652,"name":"Daniel T. Lee","display_name":"Daniel T. Lee","email":"danieltimlee@gmail.com","username":"danieltimlee"},"date":"2024-01-15 07:35:44.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"2b99a432cb0b81f1281471efc49a5654f89a1b74","tag":"autogenerated:gerrit:abandon","author":{"_account_id":36652,"name":"Daniel T. Lee","display_name":"Daniel T. Lee","email":"danieltimlee@gmail.com","username":"danieltimlee"},"date":"2024-01-15 07:36:37.000000000","message":"Abandoned\n\nfix with an upcoming patch","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"581ef880cb1e0e14127041b6f9dd1e2fb9bb89cf","revisions":{"ac0b6fd63080aea2aa3ac74abf940a4f018cbc05":{"kind":"REWORK","_number":1,"created":"2024-01-11 19:14:05.000000000","uploader":{"_account_id":36652,"name":"Daniel T. Lee","display_name":"Daniel T. Lee","email":"danieltimlee@gmail.com","username":"danieltimlee"},"ref":"refs/changes/52/905352/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/designate","ref":"refs/changes/52/905352/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/designate refs/changes/52/905352/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/designate refs/changes/52/905352/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/designate refs/changes/52/905352/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/designate refs/changes/52/905352/1"}}},"commit":{"parents":[{"commit":"002005a440e87198e05719d17c3d39a980a552e3","subject":"Cleanup Heartbeat Emitter abstraction code","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/002005a440e87198e05719d17c3d39a980a552e3"}]}],"author":{"name":"Daniel T. Lee","email":"danieltimlee@gmail.com","date":"2024-01-11 18:46:25.000000000","tz":0},"committer":{"name":"Daniel T. Lee","email":"danieltimlee@gmail.com","date":"2024-01-11 18:46:25.000000000","tz":0},"subject":"Make SOA MNAME follow pool\u0027s ns_records priority","message":"Make SOA MNAME follow pool\u0027s ns_records priority\n\nCurrently, the build_soa_record function creates the SOA record\u0027s\nprimary master name server (MNAME) by simply using the first entry in\nthe pool configuration. However, this approach disregards the priority\nattribute in the ns_records section, and can be misleading to users.\n\n    $ cat /etc/designate/pools.yaml | grep -A 6 ns_records\n      ns_records:\n\t- hostname: ns3.devstack.org.\n\t  priority: 1\n\t- hostname: ns2.devstack.org.\n\t  priority: 2\n\t- hostname: ns1.devstack.org.\n\t  priority: 3\n    $ designate-manage pool show_config | grep -A 6 ns_records\n    ns_records:\n    - hostname: ns2.devstack.org.\n      priority: 2\n    - hostname: ns3.devstack.org.\n      priority: 1\n    - hostname: ns1.devstack.org.\n      priority: 3\n\nAs the provided example shows, in here the order is mingled and MNAME\nwill be the \u0027ns2.devstack.org\u0027 instead of \u0027ns3.devstack.org\u0027 which is\nthe first entry configured at \u0027pools.yaml\u0027.\n\nTo address this, this commit modifies the selection of MNAME by sorting\nthe ns_records based on the priority key in ascending order. This change\nensures that the item with the highest priority is set as MNAME.\n\nChange-Id: Ib7b75331228d4e52e7003add8186d6a939efa224\nSigned-off-by: Daniel T. Lee \u003cdanieltimlee@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/ac0b6fd63080aea2aa3ac74abf940a4f018cbc05"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/ac0b6fd63080aea2aa3ac74abf940a4f018cbc05"}]},"branch":"refs/heads/master"},"581ef880cb1e0e14127041b6f9dd1e2fb9bb89cf":{"kind":"REWORK","_number":2,"created":"2024-01-11 23:12:40.000000000","uploader":{"_account_id":36652,"name":"Daniel T. Lee","display_name":"Daniel T. Lee","email":"danieltimlee@gmail.com","username":"danieltimlee"},"ref":"refs/changes/52/905352/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/designate","ref":"refs/changes/52/905352/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/designate refs/changes/52/905352/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/designate refs/changes/52/905352/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/designate refs/changes/52/905352/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/designate refs/changes/52/905352/2"}}},"commit":{"parents":[{"commit":"002005a440e87198e05719d17c3d39a980a552e3","subject":"Cleanup Heartbeat Emitter abstraction code","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/002005a440e87198e05719d17c3d39a980a552e3"}]}],"author":{"name":"Daniel T. Lee","email":"danieltimlee@gmail.com","date":"2024-01-11 18:46:25.000000000","tz":0},"committer":{"name":"Daniel T. Lee","email":"danieltimlee@gmail.com","date":"2024-01-11 23:10:04.000000000","tz":0},"subject":"Make SOA MNAME follow pool\u0027s ns_records priority","message":"Make SOA MNAME follow pool\u0027s ns_records priority\n\nCurrently, the build_soa_record function creates the SOA record\u0027s\nprimary master name server (MNAME) by simply using the first entry in\nthe pool configuration. However, this approach disregards the priority\nattribute in the ns_records section, and can be misleading to users.\n\n    $ cat /etc/designate/pools.yaml | grep -A 6 ns_records\n      ns_records:\n\t- hostname: ns3.devstack.org.\n\t  priority: 1\n\t- hostname: ns2.devstack.org.\n\t  priority: 2\n\t- hostname: ns1.devstack.org.\n\t  priority: 3\n    $ designate-manage pool show_config | grep -A 6 ns_records\n    ns_records:\n    - hostname: ns2.devstack.org.\n      priority: 2\n    - hostname: ns3.devstack.org.\n      priority: 1\n    - hostname: ns1.devstack.org.\n      priority: 3\n\nAs the provided example shows, in here the order is mingled and MNAME\nwill be the \u0027ns2.devstack.org\u0027 instead of \u0027ns3.devstack.org\u0027 which is\nthe first entry configured at \u0027pools.yaml\u0027.\n\nTo address this, this commit modifies the selection of MNAME by sorting\nthe ns_records based on the priority key in ascending order. This change\nensures that the item with the highest priority is set as MNAME.\n\nChange-Id: Ib7b75331228d4e52e7003add8186d6a939efa224\nSigned-off-by: Daniel T. Lee \u003cdanieltimlee@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/581ef880cb1e0e14127041b6f9dd1e2fb9bb89cf"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/581ef880cb1e0e14127041b6f9dd1e2fb9bb89cf"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review priority","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"-label:Review-Priority\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":[],"failing_atoms":["label:Review-Priority\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}