)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"451319abd99895024d4153984cd3602ebb1bb9e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5b0aa663_feddb474","updated":"2024-05-27 14:03:53.000000000","message":"Except for the comment I wrote, looks good to me","commit_id":"6845f6b6d212a3f977ca05a83e8070c0fc0ac55f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7b87dfbd6ba47d696d8f65f3c3b79cad1cf6e487","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"99045b85_454c976e","updated":"2024-02-01 16:42:28.000000000","message":"LGTM","commit_id":"6845f6b6d212a3f977ca05a83e8070c0fc0ac55f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"453e297bfae9e8274a21cce265ebecb92ab23067","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2fd9fbbc_d6146714","updated":"2024-05-28 18:42:15.000000000","message":"I think we should enable this as part of the pep8 run and it appears to be ignoring the backend plugins scripts.","commit_id":"099b87b5eb00c62235ff3154e2703b28ac1249c5"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"075a213279fb77906955ace3fcba7da01c74e01d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3ad8efe6_eadcbc07","updated":"2024-06-28 22:04:48.000000000","message":"+w as this has the reviews","commit_id":"781fb6dc4be6915db7c673b1926e2dd51e555ada"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"e427cfd711b8fdb4dd3cf862c027053cc1ff7ed7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"70204782_ca6e7958","updated":"2024-06-07 11:01:02.000000000","message":"I tried both tox -e pep8, flake8, and bashate and they pass in my env with the current patch. The other comment I left is also resolved now. Looks good to me, thanks!","commit_id":"781fb6dc4be6915db7c673b1926e2dd51e555ada"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"5b71fec4cb57da6c226c59f2a35c4590387b2c85","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b24d955e_4b7b762e","updated":"2024-06-07 15:36:06.000000000","message":"LGTM","commit_id":"781fb6dc4be6915db7c673b1926e2dd51e555ada"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"36f6167d6e583ec4f11ebafe7e55dc85bd0d9d0f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"81f7d031_851e70e6","updated":"2024-06-30 14:20:33.000000000","message":"recheck `BlockingIOError: [Errno 11] Resource temporarily unavailable`","commit_id":"781fb6dc4be6915db7c673b1926e2dd51e555ada"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"85e81cef93b1263188a323d662399ddd0d12efde","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9e17a4f4_bdf9125e","updated":"2024-06-01 14:36:38.000000000","message":"recheck the failure looks like a race problem ?","commit_id":"781fb6dc4be6915db7c673b1926e2dd51e555ada"}],"devstack/exercise.sh":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"451319abd99895024d4153984cd3602ebb1bb9e7","unresolved":true,"context_lines":[{"line_number":181,"context_line":"NUMBER_OF_RECORDS\u003d$(designate server-list -f csv | wc -l)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"# Add 1 extra to account for the additional SOA at the end of the AXFR"},{"line_number":184,"context_line":"$((NUMBER_OF_RECORDS+\u003d1))"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"# Testing Domains"},{"line_number":187,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-sh","patch_set":1,"id":"41f565cb_59878eab","line":184,"range":{"start_line":184,"start_character":0,"end_line":184,"end_character":25},"updated":"2024-05-27 14:03:53.000000000","message":"Testing it in my local env, that would fail:\n[oschwart@fedora ~]$ MY_VAR\u003d1\n[oschwart@fedora ~]$ ((MY_VAR+\u003d1))\n[oschwart@fedora ~]$ echo $MY_VAR\n2\n[oschwart@fedora ~]$ $((MY_VAR+\u003d1))\nbash: 3: command not found...","commit_id":"6845f6b6d212a3f977ca05a83e8070c0fc0ac55f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e71a51800f571fe4b9d17a6b17ad0f2f00c7194b","unresolved":false,"context_lines":[{"line_number":181,"context_line":"NUMBER_OF_RECORDS\u003d$(designate server-list -f csv | wc -l)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"# Add 1 extra to account for the additional SOA at the end of the AXFR"},{"line_number":184,"context_line":"$((NUMBER_OF_RECORDS+\u003d1))"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"# Testing Domains"},{"line_number":187,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-sh","patch_set":1,"id":"b3098b0c_6be1b16d","line":184,"range":{"start_line":184,"start_character":0,"end_line":184,"end_character":25},"in_reply_to":"41f565cb_59878eab","updated":"2024-05-27 14:28:48.000000000","message":"I followed the update in a few other repos but indeed the approach causes the failure and makes the whole script stop when set -e is used...\n\nI\u0027ve replaced it by bare assignment... Alternatively we can probably disable the chack (because the value can never be 0 https://opendev.org/openstack/bashate/commit/0feb84a83fca92789d2a154b33b959ef6ffbff11 ) but I could not find a good way to disable the check for that specific line.","commit_id":"6845f6b6d212a3f977ca05a83e8070c0fc0ac55f"}],"tox.ini":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"453e297bfae9e8274a21cce265ebecb92ab23067","unresolved":true,"context_lines":[{"line_number":90,"context_line":"commands \u003d sh tools/pretty_flake8.sh"},{"line_number":91,"context_line":"  {[testenv:bandit]commands}"},{"line_number":92,"context_line":"  doc8 {posargs}"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"[testenv:genconfig]"},{"line_number":95,"context_line":"commands \u003d oslo-config-generator --config-file\u003detc/designate/designate-config-generator.conf"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-properties","patch_set":2,"id":"dcd9bb60_068ff27e","line":93,"updated":"2024-05-28 18:42:15.000000000","message":"I think we should add bashate to the pep8 run, it\u0027s reasonably fast. This way it will run in the check gate\n\n {[testenv:bashate]commands}","commit_id":"099b87b5eb00c62235ff3154e2703b28ac1249c5"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3aa88e939a968ffd5aeda2f518e51d3642fc77ef","unresolved":false,"context_lines":[{"line_number":90,"context_line":"commands \u003d sh tools/pretty_flake8.sh"},{"line_number":91,"context_line":"  {[testenv:bandit]commands}"},{"line_number":92,"context_line":"  doc8 {posargs}"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"[testenv:genconfig]"},{"line_number":95,"context_line":"commands \u003d oslo-config-generator --config-file\u003detc/designate/designate-config-generator.conf"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-properties","patch_set":2,"id":"efbcf5c5_de23fc46","line":93,"in_reply_to":"dcd9bb60_068ff27e","updated":"2024-05-30 23:02:30.000000000","message":"Done","commit_id":"099b87b5eb00c62235ff3154e2703b28ac1249c5"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"453e297bfae9e8274a21cce265ebecb92ab23067","unresolved":true,"context_lines":[{"line_number":110,"context_line":"          -name \\*.sh -or                             \\"},{"line_number":111,"context_line":"          -name \\*rc -or                              \\"},{"line_number":112,"context_line":"          -name functions\\* -or                       \\"},{"line_number":113,"context_line":"          -wholename \\*/lib/\\*                        \\"},{"line_number":114,"context_line":"         \\)                                           \\"},{"line_number":115,"context_line":"         -print0 | xargs -0 bashate -v -iE006 -eE005,E042\""},{"line_number":116,"context_line":""}],"source_content_type":"text/x-properties","patch_set":2,"id":"605a83ca_768332e8","line":113,"updated":"2024-05-28 18:42:15.000000000","message":"This is not checking the backend plugins either.\n\n-wholename \\*/designate_plugins/\\*","commit_id":"099b87b5eb00c62235ff3154e2703b28ac1249c5"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3aa88e939a968ffd5aeda2f518e51d3642fc77ef","unresolved":false,"context_lines":[{"line_number":110,"context_line":"          -name \\*.sh -or                             \\"},{"line_number":111,"context_line":"          -name \\*rc -or                              \\"},{"line_number":112,"context_line":"          -name functions\\* -or                       \\"},{"line_number":113,"context_line":"          -wholename \\*/lib/\\*                        \\"},{"line_number":114,"context_line":"         \\)                                           \\"},{"line_number":115,"context_line":"         -print0 | xargs -0 bashate -v -iE006 -eE005,E042\""},{"line_number":116,"context_line":""}],"source_content_type":"text/x-properties","patch_set":2,"id":"d80cba47_b5b64ba3","line":113,"in_reply_to":"605a83ca_768332e8","updated":"2024-05-30 23:02:30.000000000","message":"Done","commit_id":"099b87b5eb00c62235ff3154e2703b28ac1249c5"}]}