)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"4f88ce1335b39fbd7899924c292ecda9304136a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"11444b93_64e9e235","updated":"2024-02-27 08:46:28.000000000","message":"-1 workflow as still testing","commit_id":"b807373aacf08470527340024b414afe5819d212"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"058ba7a876d669036435367e2ba6c8daf036b5b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"596159e1_f5c1d662","updated":"2024-08-09 05:50:56.000000000","message":"iiuc changing existing alembic versions is not allowed, since this would only affect new deployments, but not ones that are already running with that version applied, leading to inconsistencies. so instead you would need to add a new migration to target the desired charset.\n\n(note that I\u0027m not a DB expert, so this might be wrong, but hopefully other reviewers can confirm)","commit_id":"b807373aacf08470527340024b414afe5819d212"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ec18b57d6decfe84f266222edd35d9fa9ceb4e29","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ebbdb812_7e0b7a4f","updated":"2024-11-20 03:20:13.000000000","message":"the bug linked to this patch is unrelated","commit_id":"43bcf7e3f337267bc9677f3ddce2584429ee21e9"},{"author":{"_account_id":12404,"name":"Rico Lin","email":"ricolin@ricolky.com","username":"rico.lin"},"change_message_id":"e0521691d88c929c332c6ed4826ca7db68b61ab4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3ec717a9_92057516","in_reply_to":"ebbdb812_7e0b7a4f","updated":"2025-01-02 06:51:32.000000000","message":"okay, was meant to use relate-to. Let\u0027s remove it here","commit_id":"43bcf7e3f337267bc9677f3ddce2584429ee21e9"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"6221e74d7c7435a3bd816b63ee53008cf22fb970","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"649cde45_ded96814","updated":"2025-01-06 03:38:37.000000000","message":"I have some concerns here.","commit_id":"21f750a501ca6908b6133d41ae60848d002f6e4d"}],"designate/storage/sqlalchemy/alembic/versions/c4f8af529b56_fix_table_service_statuses.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"6221e74d7c7435a3bd816b63ee53008cf22fb970","unresolved":true,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def upgrade() -\u003e None:"},{"line_number":33,"context_line":"    # Check if the equivalent legacy migration has already run"},{"line_number":34,"context_line":"    if not legacy_utils.is_migration_needed(98):"},{"line_number":35,"context_line":"        return"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    current_bind \u003d op.get_bind()"}],"source_content_type":"text/x-python","patch_set":5,"id":"348a07ac_a93bbbde","line":34,"updated":"2025-01-06 03:38:37.000000000","message":"I don\u0027t think you want this here as you are making a change to the overall DB collation. This means that if that legacy migration has already run in a deployment, this one will not.","commit_id":"21f750a501ca6908b6133d41ae60848d002f6e4d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"6221e74d7c7435a3bd816b63ee53008cf22fb970","unresolved":true,"context_lines":[{"line_number":43,"context_line":"        \u0027ALTER TABLE service_statuses CONVERT TO CHARACTER SET utf8mb4;\u0027"},{"line_number":44,"context_line":"    )"},{"line_number":45,"context_line":"    op.execute(\u0027SET foreign_key_checks \u003d 1;\u0027)"},{"line_number":46,"context_line":"    op.execute(\u0027ALTER DATABASE DEFAULT CHARACTER SET utf8mb4;\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"16e290e4_bc112002","line":46,"updated":"2025-01-06 03:38:37.000000000","message":"I have compatibility concerns about this. Really, this setting should be configured by the deployment tooling as most of them do.\nFor example, devstack sets a conflicting setting here:\nhttps://github.com/openstack/devstack/blob/master/lib/databases/mysql#L62\n\nSo, we should standardize this across all of the deployment tooling and not be forcing a collation in the projects themselves. IMO","commit_id":"21f750a501ca6908b6133d41ae60848d002f6e4d"}]}