)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"ed1dbb0766a2325cae1b3c3b7dae5c1d205f3462","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"78e23f84_0cf54b9c","updated":"2024-05-03 10:50:23.000000000","message":"Can you add test coverage for this fix?","commit_id":"4229f25a19456cc9107bc3740946373503717837"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"652edfee26f7983056a49e1a925d0b051a256c5f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8781020e_17ee096d","updated":"2024-05-06 15:13:46.000000000","message":"Hey Eric, thank you for your comment. After I tried to add test coverage, I suspect now that I didn\u0027t really fix the issue, maybe it just worked in that specific scenario I tried. I get the following error:\ndesignate.exceptions.RelationNotLoaded: catalog_zone is not loaded on Pool\n\nI am not sure how to continue here, should every pool have a catalog_zone? Or maybe I should wrap this line https://opendev.org/openstack/designate/src/branch/master/designate/objects/adapters/yaml/base.py#L50 with try/except RelationNotLoaded ? and then just continue with the loop?","commit_id":"9ae6441627eac177d92971f29c7b741fb0824ad2"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"0fa00b750edcb41dad5552619d06dbdb2da0b30c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"22c3732c_a8ab4324","updated":"2024-05-07 15:34:55.000000000","message":"This is probably how I would fix this. This way it shows up as none (null) in the show_config output. This also tests both paths.\nhttps://paste.openstack.org/show/bSm21SIrZvbNiAaOIY7E/","commit_id":"9ae6441627eac177d92971f29c7b741fb0824ad2"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"88e64175b9977ed8fd78b55235b087316a90f294","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c0829d39_a1376210","updated":"2024-05-08 09:16:40.000000000","message":"looks good to me, I will test it a little on my devstack env","commit_id":"9ae6441627eac177d92971f29c7b741fb0824ad2"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"22379aec4cb93113355199f9365257e045149337","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"23250856_ccb01d55","in_reply_to":"0354a4fc_a53dbefa","updated":"2024-05-07 14:53:38.000000000","message":"Ah yea that is a pretty bad bug.","commit_id":"9ae6441627eac177d92971f29c7b741fb0824ad2"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"370705f5a26633fde25b3259e58027381cf60930","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"96d9050d_e38078c5","in_reply_to":"8781020e_17ee096d","updated":"2024-05-07 10:05:25.000000000","message":"Not sure if I understand the bug you are trying to fix here. catalog_zone isn\u0027t required in pools.yaml. Can you share more about the configuration that is failing for you and what commands are failing.","commit_id":"9ae6441627eac177d92971f29c7b741fb0824ad2"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"bf2a3ab47ed9b2ee594d1bbff86f4458d0ddb93c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0354a4fc_a53dbefa","in_reply_to":"96d9050d_e38078c5","updated":"2024-05-07 14:41:33.000000000","message":"Sure, on my devstack environment I run\n`designate-manage pool update --file /etc/designate/pools.yaml`, which has the following content: https://paste.openstack.org/show/bnlPb7u9PKlj9fvE2ssH/\nI am using designate on master branch.\n\nAfterwards, I run \n`designate-manage pool show_config`\nand I get\n\n$ designate-manage pool show_config                                                                      \nINFO oslo_messaging._drivers.amqpdriver [None designate-manage None None] Creating reply queue: reply_956557d699a24b34bb528d3817e3f2c3\nINFO oslo_messaging._drivers.amqpdriver [None designate-manage None None] Expecting reply to msg e60cf492c25a436d82841b0b37d9cf0c in queue reply_956557d699a24b34bb528d3817e3f2c3\nINFO oslo_messaging._drivers.amqpdriver [None designate-manage None None] Received RPC response for msg e60cf492c25a436d82841b0b37d9cf0c\n\nPool Configuration:\n- - - - - - - - - -\nAn error has occurred:\nTraceback (most recent call last):\n  File \"/opt/stack/designate/designate/objects/adapters/base.py\", line 69, in get_object_adapter\n    return cls._adapter_classes[key]\nKeyError: \u0027YAML:None\u0027\n\nDuring handling of the above exception, another exception occurred:\n\nTraceback (most recent call last):\n  File \"/opt/stack/designate/designate/cmd/manage.py\", line 122, in main\n    fn(*fn_args)\n  File \"/opt/stack/designate/designate/manage/pool.py\", line 85, in show_config\n    DesignateAdapter.render(\u0027YAML\u0027, pool),\n  File \"/opt/stack/designate/designate/objects/adapters/base.py\", line 90, in render\n    return adapter.render_object(obj, *args, **kwargs)\n  File \"/opt/stack/designate/designate/objects/adapters/yaml/base.py\", line 59, in render_object\n    r_obj[key] \u003d adapter.render(cls.ADAPTER_FORMAT, new_obj, *args,\n  File \"/opt/stack/designate/designate/objects/adapters/base.py\", line 86, in render\n    adapter \u003d cls.get_object_adapter(obj, obj_format)\n  File \"/opt/stack/designate/designate/objects/adapters/base.py\", line 72, in get_object_adapter\n    raise exceptions.AdapterNotFound(\ndesignate.exceptions.AdapterNotFound: Adapter for None to format YAML not found","commit_id":"9ae6441627eac177d92971f29c7b741fb0824ad2"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"00c7be42205fa90747dc89055a177a236a2fc8b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"005b58d2_d06821d4","updated":"2024-05-09 10:25:35.000000000","message":"Adding W-1 until we figure it out, just in case","commit_id":"e7d890ed20f7396b1a934ec1f99441f2fe8b5d7e"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"8ccde2274d34816597e87e508760aabc0a6854b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5ada6754_e814d281","updated":"2024-05-08 14:09:47.000000000","message":"LGTM. We probably want to back port this as well.","commit_id":"e7d890ed20f7396b1a934ec1f99441f2fe8b5d7e"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"5ad3881897ef7bf257631db140f06736780a0284","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"caee283d_5c986fb5","updated":"2024-05-08 09:54:02.000000000","message":"ok it looks like it is working fine on my devstack, and the multipool patch on top of it also works with it, thanks Erik!","commit_id":"e7d890ed20f7396b1a934ec1f99441f2fe8b5d7e"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"c8488c093fac1b484295e8c7e34729319c088cf3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fbbe2c10_b99982e2","updated":"2024-05-09 10:24:45.000000000","message":"ok so after some additional testing for this fix, I see that running `designate-manage pool generate_file` (say, to /etc/designate/pools.yaml by default), and then pool updating that same file that has \"catalog_zone: null\", fails with the following:\nhttps://paste.openstack.org/show/bn8Vh88iSwbcp2XoYJP4/","commit_id":"e7d890ed20f7396b1a934ec1f99441f2fe8b5d7e"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"48f64eda25d1f70fafecb7002a6bd45be463e2ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3cfc37d7_c4b91e7b","in_reply_to":"005b58d2_d06821d4","updated":"2024-05-09 11:34:48.000000000","message":"Good catch. We could go back to your original fix and just continue if new_obj s None, but keep the testing. I would move it slightly further down to be consistent.\n\nhttps://paste.openstack.org/show/bMqnCinS6ohAb6xYWF5S/","commit_id":"e7d890ed20f7396b1a934ec1f99441f2fe8b5d7e"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"dc20bcce2acb5e4532ab90368249025c0dbf22b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"45905154_6005eadc","updated":"2024-05-23 00:29:48.000000000","message":"Otherwise I am good with this patch.","commit_id":"6dd9aaf13b693c831aabbfac5406757b8ea96fc6"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"3709625e44490a07067e21cba2b972a278cd2f39","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1358b624_13bf2bdd","updated":"2024-05-23 00:29:01.000000000","message":"This is a bad bug and we need to back port it, please add a release note for the fix.\n\n$ reno new \"Fix designate-manage pool update with missing attributes\"\n\nThen fill in the \"Fixes\" section, removing the others.","commit_id":"6dd9aaf13b693c831aabbfac5406757b8ea96fc6"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"5f78d98164c3c17900c6a59ba037efaabb9b2100","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c54df618_7b2cf948","in_reply_to":"1358b624_13bf2bdd","updated":"2024-05-23 14:07:19.000000000","message":"Release note was added.","commit_id":"6dd9aaf13b693c831aabbfac5406757b8ea96fc6"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"6da0f77b152539f59f310fcfecff4df0bef42e96","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"56fcdc19_6b811a0b","updated":"2024-05-28 19:04:33.000000000","message":"LGTM","commit_id":"6cc0a7d8876291f874edaac2ff86b7d7a84a738a"}]}