)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2d624c93b0f3490e483ccf2aabf8a99000b641e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"061b8c99_1b45d17d","updated":"2024-05-28 19:46:51.000000000","message":"A couple of suggestions","commit_id":"7eb472b5fb23624dd763f6e7e79da88fad055a49"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"95bd26e4bedffd4ca38207a9e6e125cc10a5900a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"482acd89_94d21b6c","updated":"2024-05-29 13:30:13.000000000","message":"Thanks for the review Michael, I am uploading another version, after resolving your comments.","commit_id":"7eb472b5fb23624dd763f6e7e79da88fad055a49"},{"author":{"_account_id":31933,"name":"Greg Rakauskas","display_name":"Greg Rakauskas","email":"gregraka@redhat.com","username":"gregraka"},"change_message_id":"df22e1cd70a47df696e77b1d6efec4eff155fee6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fb65db1b_e951ca7c","updated":"2024-05-29 14:05:32.000000000","message":"Hi Omer,\nI saw that you added a doc patch, so I could not resist the temptation to review! Hope that\u0027s OK! :^)\nSolid work. I like how you structured the doc, and especially the use cases! Customers LOVE examples!\nI made a few comments which I hope will help. Feel free to reject them! :^0\nBest,\n--Greg R.","commit_id":"59d2ebcca21fb2d9eb086a1df24a6459a9b86df9"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"d92fb11c2d05735db7363038f26eaa0659478013","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"77ca5e2f_c66a78c0","in_reply_to":"fb65db1b_e951ca7c","updated":"2024-06-03 09:00:17.000000000","message":"Thanks a lot for the review, Greg!! Writing / assisting with the docs is definitely an area I would like to improve! I will take a look at the comments, probably today or tomorrow.","commit_id":"59d2ebcca21fb2d9eb086a1df24a6459a9b86df9"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"484f899580d500fa3eac6d4943cfb5aea74d7dfb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"85789bf0_f7dfaf88","updated":"2024-06-04 14:35:32.000000000","message":"Thanks Greg! I applied most of your comments, it definitely helps! In case that I am either wrong with the English, or anything else, please feel free to leave additional comments","commit_id":"5b1554a0c2e94ef770b9aa5eaad05a206b18cc3d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"5b1c44f9db1d6e1248f8157d82c35766ee5a00e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"645d3246_2c26e92c","updated":"2024-12-16 13:40:33.000000000","message":"recheck","commit_id":"b3b016f84a70486b8c507f6aaf2a3be6e756f25c"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"6addc65efdc7510cb424b0546b840cf3c8a041a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"4a57905e_fe7a91c4","updated":"2025-01-14 02:26:52.000000000","message":"Just a few comments","commit_id":"7b538859e35a07b204d2ca370491b62ff22af6f6"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"5680bc40582bf859cd1c2d87c1f2d5c5bfbc33ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"632ff2aa_856f066d","updated":"2025-01-17 03:57:30.000000000","message":"LGTM","commit_id":"304b6e1bf009f1680c1ef37f67aee6bb10762fe4"}],"doc/source/admin/pools.rst":[{"author":{"_account_id":31933,"name":"Greg Rakauskas","display_name":"Greg Rakauskas","email":"gregraka@redhat.com","username":"gregraka"},"change_message_id":"df22e1cd70a47df696e77b1d6efec4eff155fee6","unresolved":true,"context_lines":[{"line_number":82,"context_line":"NS records"},{"line_number":83,"context_line":"^^^^^^^^^^"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"The ns_records section is the list of name servers Designate will advertise in"},{"line_number":86,"context_line":"the zones as available for query."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"Nameservers"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9e13206a_8e07cbd9","line":85,"updated":"2024-05-29 14:05:32.000000000","message":"From the use cases below, I discern that ns_records are \"public\" in that they are reachable from external networks. Perhaps this is implied by the term `advertise`? However, it might be worth mentioning?\n\nMaybe something like?\n\n````\nThe ns_records section is the list of name servers Designate will \nadvertise in the zones as available for query. Nameservers listed \nin the ns_records section are reachable from external networks.\n````","commit_id":"7eb472b5fb23624dd763f6e7e79da88fad055a49"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"484f899580d500fa3eac6d4943cfb5aea74d7dfb","unresolved":false,"context_lines":[{"line_number":82,"context_line":"NS records"},{"line_number":83,"context_line":"^^^^^^^^^^"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"The ns_records section is the list of name servers Designate will advertise in"},{"line_number":86,"context_line":"the zones as available for query."},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"Nameservers"}],"source_content_type":"text/x-rst","patch_set":1,"id":"2d48d8ba_29419fcc","line":85,"in_reply_to":"9e13206a_8e07cbd9","updated":"2024-06-04 14:35:32.000000000","message":"Well, the nameserver entries that appear on ns_records are advertised, but all the mechanism of making them reachable from external networks is not being taking care of only by specifying them under ns_records.\nMaybe I could rephrase that extra sentence:\n\nNameservers listed in the ns_records section are expected to be reachable from external networks.","commit_id":"7eb472b5fb23624dd763f6e7e79da88fad055a49"},{"author":{"_account_id":31933,"name":"Greg Rakauskas","display_name":"Greg Rakauskas","email":"gregraka@redhat.com","username":"gregraka"},"change_message_id":"df22e1cd70a47df696e77b1d6efec4eff155fee6","unresolved":true,"context_lines":[{"line_number":88,"context_line":"Nameservers"},{"line_number":89,"context_line":"^^^^^^^^^^^"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"The nameservers section is the list of name servers Designate will query to"},{"line_number":92,"context_line":"confirm an update has completed on all of the Designate managed nameservers."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"NS Records vs. Nameservers: Understanding the Differences"}],"source_content_type":"text/x-rst","patch_set":1,"id":"98d115c8_a87689a1","line":91,"updated":"2024-05-29 14:05:32.000000000","message":"Maybe some mention that nameservers listed in this section are not reachable from external networks, unless also listed in ns_records?\n\n````\nThe nameservers section is the list of name servers Designate will query to\nconfirm an update has completed on all of the Designate managed nameservers. \nNameservers listed in the nameservers section are not reachable from external \nnetworks unless they are also listed in the ns_records section.\n````","commit_id":"7eb472b5fb23624dd763f6e7e79da88fad055a49"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"484f899580d500fa3eac6d4943cfb5aea74d7dfb","unresolved":false,"context_lines":[{"line_number":88,"context_line":"Nameservers"},{"line_number":89,"context_line":"^^^^^^^^^^^"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"The nameservers section is the list of name servers Designate will query to"},{"line_number":92,"context_line":"confirm an update has completed on all of the Designate managed nameservers."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"NS Records vs. Nameservers: Understanding the Differences"}],"source_content_type":"text/x-rst","patch_set":1,"id":"e02104f8_58a67337","line":91,"in_reply_to":"98d115c8_a87689a1","updated":"2024-06-04 14:35:32.000000000","message":"Well, some of the nameservers in the nameservers section might be reachable from external networks (like there is not something that will block their connectivity afaik), but not advertised (it is hard to think of such a use case, maybe if the operator wants to have resources that are reachable from the outside, but the operator will only tell some of its clients, because of different payment levels, etc). Maybe I can rephrase:\n\nThe nameservers section is the list of name servers Designate will query to\nconfirm an update has completed on all of the Designate managed nameservers. \nNameservers listed in the nameservers section are not expected to be reachable from external networks unless they are also listed in the ns_records section.","commit_id":"7eb472b5fb23624dd763f6e7e79da88fad055a49"},{"author":{"_account_id":31933,"name":"Greg Rakauskas","display_name":"Greg Rakauskas","email":"gregraka@redhat.com","username":"gregraka"},"change_message_id":"df22e1cd70a47df696e77b1d6efec4eff155fee6","unresolved":true,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"There isn\u0027t always a direct relationship between the ns_records and the"},{"line_number":98,"context_line":"nameservers sections, as they serve different use cases. Here are a few"},{"line_number":99,"context_line":"examples to different use cases of those:"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"* ns_records list is equal to the nameservers list:"},{"line_number":102,"context_line":"    The end user may want to query all of the advertised nameservers when they"}],"source_content_type":"text/x-rst","patch_set":1,"id":"5574d890_2cdb54ba","line":99,"updated":"2024-05-29 14:05:32.000000000","message":"You might say more with less:\n\n````\nHere are a few use cases:\n````","commit_id":"7eb472b5fb23624dd763f6e7e79da88fad055a49"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"484f899580d500fa3eac6d4943cfb5aea74d7dfb","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"There isn\u0027t always a direct relationship between the ns_records and the"},{"line_number":98,"context_line":"nameservers sections, as they serve different use cases. Here are a few"},{"line_number":99,"context_line":"examples to different use cases of those:"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"* ns_records list is equal to the nameservers list:"},{"line_number":102,"context_line":"    The end user may want to query all of the advertised nameservers when they"}],"source_content_type":"text/x-rst","patch_set":1,"id":"0dec123a_d32f1f5a","line":99,"in_reply_to":"5574d890_2cdb54ba","updated":"2024-06-04 14:35:32.000000000","message":"Done","commit_id":"7eb472b5fb23624dd763f6e7e79da88fad055a49"},{"author":{"_account_id":31933,"name":"Greg Rakauskas","display_name":"Greg Rakauskas","email":"gregraka@redhat.com","username":"gregraka"},"change_message_id":"df22e1cd70a47df696e77b1d6efec4eff155fee6","unresolved":true,"context_lines":[{"line_number":99,"context_line":"examples to different use cases of those:"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"* ns_records list is equal to the nameservers list:"},{"line_number":102,"context_line":"    The end user may want to query all of the advertised nameservers when they"},{"line_number":103,"context_line":"    make sure updates have propagated successfully."},{"line_number":104,"context_line":"* ns_records list is different (smaller) than the nameservers list:"},{"line_number":105,"context_line":"    The end user may not want to advertise all of the nameservers as ns_records"},{"line_number":106,"context_line":"    (publicly), as they might want to have a few \"stealth\" nameservers."}],"source_content_type":"text/x-rst","patch_set":1,"id":"e0ceb29e_bbc9e38d","line":103,"range":{"start_line":102,"start_character":3,"end_line":103,"end_character":51},"updated":"2024-05-29 14:05:32.000000000","message":"Perhaps this instead?\n\n````\nThe end user may want to query all of the advertised nameservers to confirm that\ntheir updates have successfully propagated.\n````","commit_id":"7eb472b5fb23624dd763f6e7e79da88fad055a49"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"484f899580d500fa3eac6d4943cfb5aea74d7dfb","unresolved":false,"context_lines":[{"line_number":99,"context_line":"examples to different use cases of those:"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"* ns_records list is equal to the nameservers list:"},{"line_number":102,"context_line":"    The end user may want to query all of the advertised nameservers when they"},{"line_number":103,"context_line":"    make sure updates have propagated successfully."},{"line_number":104,"context_line":"* ns_records list is different (smaller) than the nameservers list:"},{"line_number":105,"context_line":"    The end user may not want to advertise all of the nameservers as ns_records"},{"line_number":106,"context_line":"    (publicly), as they might want to have a few \"stealth\" nameservers."}],"source_content_type":"text/x-rst","patch_set":1,"id":"512625bc_10c8f579","line":103,"range":{"start_line":102,"start_character":3,"end_line":103,"end_character":51},"in_reply_to":"e0ceb29e_bbc9e38d","updated":"2024-06-04 14:35:32.000000000","message":"Done","commit_id":"7eb472b5fb23624dd763f6e7e79da88fad055a49"},{"author":{"_account_id":31933,"name":"Greg Rakauskas","display_name":"Greg Rakauskas","email":"gregraka@redhat.com","username":"gregraka"},"change_message_id":"df22e1cd70a47df696e77b1d6efec4eff155fee6","unresolved":true,"context_lines":[{"line_number":101,"context_line":"* ns_records list is equal to the nameservers list:"},{"line_number":102,"context_line":"    The end user may want to query all of the advertised nameservers when they"},{"line_number":103,"context_line":"    make sure updates have propagated successfully."},{"line_number":104,"context_line":"* ns_records list is different (smaller) than the nameservers list:"},{"line_number":105,"context_line":"    The end user may not want to advertise all of the nameservers as ns_records"},{"line_number":106,"context_line":"    (publicly), as they might want to have a few \"stealth\" nameservers."},{"line_number":107,"context_line":"    \"stealth\" nameservers are private and should not be reached from external"}],"source_content_type":"text/x-rst","patch_set":1,"id":"350b986a_50ab0c17","line":104,"range":{"start_line":104,"start_character":2,"end_line":104,"end_character":67},"updated":"2024-05-29 14:05:32.000000000","message":"How about this?\n\n````\n* ns_records list is smaller than the nameservers list:\n````","commit_id":"7eb472b5fb23624dd763f6e7e79da88fad055a49"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"484f899580d500fa3eac6d4943cfb5aea74d7dfb","unresolved":false,"context_lines":[{"line_number":101,"context_line":"* ns_records list is equal to the nameservers list:"},{"line_number":102,"context_line":"    The end user may want to query all of the advertised nameservers when they"},{"line_number":103,"context_line":"    make sure updates have propagated successfully."},{"line_number":104,"context_line":"* ns_records list is different (smaller) than the nameservers list:"},{"line_number":105,"context_line":"    The end user may not want to advertise all of the nameservers as ns_records"},{"line_number":106,"context_line":"    (publicly), as they might want to have a few \"stealth\" nameservers."},{"line_number":107,"context_line":"    \"stealth\" nameservers are private and should not be reached from external"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9da996d5_6b5e72cb","line":104,"range":{"start_line":104,"start_character":2,"end_line":104,"end_character":67},"in_reply_to":"350b986a_50ab0c17","updated":"2024-06-04 14:35:32.000000000","message":"Done","commit_id":"7eb472b5fb23624dd763f6e7e79da88fad055a49"},{"author":{"_account_id":31933,"name":"Greg Rakauskas","display_name":"Greg Rakauskas","email":"gregraka@redhat.com","username":"gregraka"},"change_message_id":"df22e1cd70a47df696e77b1d6efec4eff155fee6","unresolved":true,"context_lines":[{"line_number":103,"context_line":"    make sure updates have propagated successfully."},{"line_number":104,"context_line":"* ns_records list is different (smaller) than the nameservers list:"},{"line_number":105,"context_line":"    The end user may not want to advertise all of the nameservers as ns_records"},{"line_number":106,"context_line":"    (publicly), as they might want to have a few \"stealth\" nameservers."},{"line_number":107,"context_line":"    \"stealth\" nameservers are private and should not be reached from external"},{"line_number":108,"context_line":"    networks."},{"line_number":109,"context_line":"* ns_records list is different (bigger) than the nameservers list:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"62ad6ef0_bc4eea26","line":106,"range":{"start_line":106,"start_character":4,"end_line":106,"end_character":29},"updated":"2024-05-29 14:05:32.000000000","message":"Here\u0027s another way to write this, that you might like? It also incorporates Michael\u0027s term, `reachable`.\n\n````\nThe end user may have some private, or stealth, nameservers that they do not want \nto advertise publicly as ns_records. Because they are private, these stealth \nnameservers must not be reachable from external networks.\n````","commit_id":"7eb472b5fb23624dd763f6e7e79da88fad055a49"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"484f899580d500fa3eac6d4943cfb5aea74d7dfb","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    make sure updates have propagated successfully."},{"line_number":104,"context_line":"* ns_records list is different (smaller) than the nameservers list:"},{"line_number":105,"context_line":"    The end user may not want to advertise all of the nameservers as ns_records"},{"line_number":106,"context_line":"    (publicly), as they might want to have a few \"stealth\" nameservers."},{"line_number":107,"context_line":"    \"stealth\" nameservers are private and should not be reached from external"},{"line_number":108,"context_line":"    networks."},{"line_number":109,"context_line":"* ns_records list is different (bigger) than the nameservers list:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"cc443229_4f775d31","line":106,"range":{"start_line":106,"start_character":4,"end_line":106,"end_character":29},"in_reply_to":"62ad6ef0_bc4eea26","updated":"2024-06-04 14:35:32.000000000","message":"So again, at least afaik, there probably won\u0027t be anything explicitly blocking it from being reachable, but it is not expected to be reachable either.\nI will use that version that you suggested, but I am changing from\nnameservers must not be reachable from external networks\nto\nnameservers are not expected be reachable from external networks\n\nthanks for the suggestion!","commit_id":"7eb472b5fb23624dd763f6e7e79da88fad055a49"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2d624c93b0f3490e483ccf2aabf8a99000b641e8","unresolved":true,"context_lines":[{"line_number":104,"context_line":"* ns_records list is different (smaller) than the nameservers list:"},{"line_number":105,"context_line":"    The end user may not want to advertise all of the nameservers as ns_records"},{"line_number":106,"context_line":"    (publicly), as they might want to have a few \"stealth\" nameservers."},{"line_number":107,"context_line":"    \"stealth\" nameservers are private and should not be reached from external"},{"line_number":108,"context_line":"    networks."},{"line_number":109,"context_line":"* ns_records list is different (bigger) than the nameservers list:"},{"line_number":110,"context_line":"    The end user may not want to query all of the nameservers they manage"}],"source_content_type":"text/x-rst","patch_set":1,"id":"663d7144_bb474666","line":107,"range":{"start_line":107,"start_character":42,"end_line":107,"end_character":63},"updated":"2024-05-28 19:46:51.000000000","message":"How about \"may not be reachable\"?","commit_id":"7eb472b5fb23624dd763f6e7e79da88fad055a49"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"95bd26e4bedffd4ca38207a9e6e125cc10a5900a","unresolved":false,"context_lines":[{"line_number":104,"context_line":"* ns_records list is different (smaller) than the nameservers list:"},{"line_number":105,"context_line":"    The end user may not want to advertise all of the nameservers as ns_records"},{"line_number":106,"context_line":"    (publicly), as they might want to have a few \"stealth\" nameservers."},{"line_number":107,"context_line":"    \"stealth\" nameservers are private and should not be reached from external"},{"line_number":108,"context_line":"    networks."},{"line_number":109,"context_line":"* ns_records list is different (bigger) than the nameservers list:"},{"line_number":110,"context_line":"    The end user may not want to query all of the nameservers they manage"}],"source_content_type":"text/x-rst","patch_set":1,"id":"a133d7da_5f7370d9","line":107,"range":{"start_line":107,"start_character":42,"end_line":107,"end_character":63},"in_reply_to":"663d7144_bb474666","updated":"2024-05-29 13:30:13.000000000","message":"Done","commit_id":"7eb472b5fb23624dd763f6e7e79da88fad055a49"},{"author":{"_account_id":31933,"name":"Greg Rakauskas","display_name":"Greg Rakauskas","email":"gregraka@redhat.com","username":"gregraka"},"change_message_id":"df22e1cd70a47df696e77b1d6efec4eff155fee6","unresolved":true,"context_lines":[{"line_number":106,"context_line":"    (publicly), as they might want to have a few \"stealth\" nameservers."},{"line_number":107,"context_line":"    \"stealth\" nameservers are private and should not be reached from external"},{"line_number":108,"context_line":"    networks."},{"line_number":109,"context_line":"* ns_records list is different (bigger) than the nameservers list:"},{"line_number":110,"context_line":"    The end user may not want to query all of the nameservers they manage"},{"line_number":111,"context_line":"    after a zone update as some of those nameservers might be secondary, or"},{"line_number":112,"context_line":"    maybe the list of nameservers is just too big to query all of them."}],"source_content_type":"text/x-rst","patch_set":1,"id":"9633a764_80a03e7e","line":109,"range":{"start_line":109,"start_character":2,"end_line":109,"end_character":12},"updated":"2024-05-29 14:05:32.000000000","message":"Maybe use the same technique that was proposed for the `smaller` use case?\n\n````\n* ns_records list is larger than the nameservers list:\n````","commit_id":"7eb472b5fb23624dd763f6e7e79da88fad055a49"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"484f899580d500fa3eac6d4943cfb5aea74d7dfb","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    (publicly), as they might want to have a few \"stealth\" nameservers."},{"line_number":107,"context_line":"    \"stealth\" nameservers are private and should not be reached from external"},{"line_number":108,"context_line":"    networks."},{"line_number":109,"context_line":"* ns_records list is different (bigger) than the nameservers list:"},{"line_number":110,"context_line":"    The end user may not want to query all of the nameservers they manage"},{"line_number":111,"context_line":"    after a zone update as some of those nameservers might be secondary, or"},{"line_number":112,"context_line":"    maybe the list of nameservers is just too big to query all of them."}],"source_content_type":"text/x-rst","patch_set":1,"id":"2898c1e9_d882f5ec","line":109,"range":{"start_line":109,"start_character":2,"end_line":109,"end_character":12},"in_reply_to":"9633a764_80a03e7e","updated":"2024-06-04 14:35:32.000000000","message":"Done","commit_id":"7eb472b5fb23624dd763f6e7e79da88fad055a49"},{"author":{"_account_id":31933,"name":"Greg Rakauskas","display_name":"Greg Rakauskas","email":"gregraka@redhat.com","username":"gregraka"},"change_message_id":"df22e1cd70a47df696e77b1d6efec4eff155fee6","unresolved":true,"context_lines":[{"line_number":114,"context_line":"Targets"},{"line_number":115,"context_line":"^^^^^^^"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"The targets section is about how does Designate talk to the backend nameservers"},{"line_number":118,"context_line":"to configure it, and how should those backend nameservers talk to MiniDNS."},{"line_number":119,"context_line":"So for the BIND driver, the options section defines the address and port the"},{"line_number":120,"context_line":"“NOTIFY” messages should go ,to and the IP/port the driver should use to make"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7bd23218_785d9c64","line":117,"range":{"start_line":117,"start_character":20,"end_line":117,"end_character":37},"updated":"2024-05-29 14:05:32.000000000","message":"Instead of:\n\n`is about how does`\n\nHow about?\n\n`defines how`","commit_id":"7eb472b5fb23624dd763f6e7e79da88fad055a49"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"484f899580d500fa3eac6d4943cfb5aea74d7dfb","unresolved":false,"context_lines":[{"line_number":114,"context_line":"Targets"},{"line_number":115,"context_line":"^^^^^^^"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"The targets section is about how does Designate talk to the backend nameservers"},{"line_number":118,"context_line":"to configure it, and how should those backend nameservers talk to MiniDNS."},{"line_number":119,"context_line":"So for the BIND driver, the options section defines the address and port the"},{"line_number":120,"context_line":"“NOTIFY” messages should go ,to and the IP/port the driver should use to make"}],"source_content_type":"text/x-rst","patch_set":1,"id":"a1645fe6_e7798c9b","line":117,"range":{"start_line":117,"start_character":20,"end_line":117,"end_character":37},"in_reply_to":"7bd23218_785d9c64","updated":"2024-06-04 14:35:32.000000000","message":"Yes, I rephrased the whole sentence just a little before you have submitted the review, thanks!","commit_id":"7eb472b5fb23624dd763f6e7e79da88fad055a49"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"95bd26e4bedffd4ca38207a9e6e125cc10a5900a","unresolved":false,"context_lines":[{"line_number":114,"context_line":"Targets"},{"line_number":115,"context_line":"^^^^^^^"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"The targets section is about how does Designate talk to the backend nameservers"},{"line_number":118,"context_line":"to configure it, and how should those backend nameservers talk to MiniDNS."},{"line_number":119,"context_line":"So for the BIND driver, the options section defines the address and port the"},{"line_number":120,"context_line":"“NOTIFY” messages should go ,to and the IP/port the driver should use to make"},{"line_number":121,"context_line":"rndc calls to BIND, as can be seen in"}],"source_content_type":"text/x-rst","patch_set":1,"id":"76292bb0_12c5623a","line":118,"range":{"start_line":117,"start_character":0,"end_line":118,"end_character":74},"updated":"2024-05-29 13:30:13.000000000","message":"I rephrased this sentence as well.","commit_id":"7eb472b5fb23624dd763f6e7e79da88fad055a49"},{"author":{"_account_id":31933,"name":"Greg Rakauskas","display_name":"Greg Rakauskas","email":"gregraka@redhat.com","username":"gregraka"},"change_message_id":"df22e1cd70a47df696e77b1d6efec4eff155fee6","unresolved":true,"context_lines":[{"line_number":115,"context_line":"^^^^^^^"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"The targets section is about how does Designate talk to the backend nameservers"},{"line_number":118,"context_line":"to configure it, and how should those backend nameservers talk to MiniDNS."},{"line_number":119,"context_line":"So for the BIND driver, the options section defines the address and port the"},{"line_number":120,"context_line":"“NOTIFY” messages should go ,to and the IP/port the driver should use to make"},{"line_number":121,"context_line":"rndc calls to BIND, as can be seen in"}],"source_content_type":"text/x-rst","patch_set":1,"id":"a805cc2b_3f9fadad","line":118,"range":{"start_line":118,"start_character":13,"end_line":118,"end_character":15},"updated":"2024-05-29 14:05:32.000000000","message":"`backend nameservers` is plural, so `it` should be `them`.","commit_id":"7eb472b5fb23624dd763f6e7e79da88fad055a49"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"484f899580d500fa3eac6d4943cfb5aea74d7dfb","unresolved":false,"context_lines":[{"line_number":115,"context_line":"^^^^^^^"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"The targets section is about how does Designate talk to the backend nameservers"},{"line_number":118,"context_line":"to configure it, and how should those backend nameservers talk to MiniDNS."},{"line_number":119,"context_line":"So for the BIND driver, the options section defines the address and port the"},{"line_number":120,"context_line":"“NOTIFY” messages should go ,to and the IP/port the driver should use to make"},{"line_number":121,"context_line":"rndc calls to BIND, as can be seen in"}],"source_content_type":"text/x-rst","patch_set":1,"id":"330f8e22_7d8216b4","line":118,"range":{"start_line":118,"start_character":13,"end_line":118,"end_character":15},"in_reply_to":"a805cc2b_3f9fadad","updated":"2024-06-04 14:35:32.000000000","message":"Done","commit_id":"7eb472b5fb23624dd763f6e7e79da88fad055a49"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2d624c93b0f3490e483ccf2aabf8a99000b641e8","unresolved":true,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"The targets section is about how does Designate talk to the backend nameservers"},{"line_number":118,"context_line":"to configure it, and how should those backend nameservers talk to MiniDNS."},{"line_number":119,"context_line":"So for the BIND driver, the options section defines the address and port the"},{"line_number":120,"context_line":"“NOTIFY” messages should go ,to and the IP/port the driver should use to make"},{"line_number":121,"context_line":"rndc calls to BIND, as can be seen in"},{"line_number":122,"context_line":":ref:`this example. \u003cbind9_target_example\u003e`"}],"source_content_type":"text/x-rst","patch_set":1,"id":"e8911b11_d771f707","line":119,"updated":"2024-05-28 19:46:51.000000000","message":"nit: \"For the BIND driver,\"","commit_id":"7eb472b5fb23624dd763f6e7e79da88fad055a49"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"95bd26e4bedffd4ca38207a9e6e125cc10a5900a","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"The targets section is about how does Designate talk to the backend nameservers"},{"line_number":118,"context_line":"to configure it, and how should those backend nameservers talk to MiniDNS."},{"line_number":119,"context_line":"So for the BIND driver, the options section defines the address and port the"},{"line_number":120,"context_line":"“NOTIFY” messages should go ,to and the IP/port the driver should use to make"},{"line_number":121,"context_line":"rndc calls to BIND, as can be seen in"},{"line_number":122,"context_line":":ref:`this example. \u003cbind9_target_example\u003e`"}],"source_content_type":"text/x-rst","patch_set":1,"id":"a2b6da31_f95e9e40","line":119,"in_reply_to":"e8911b11_d771f707","updated":"2024-05-29 13:30:13.000000000","message":"Done","commit_id":"7eb472b5fb23624dd763f6e7e79da88fad055a49"},{"author":{"_account_id":31933,"name":"Greg Rakauskas","display_name":"Greg Rakauskas","email":"gregraka@redhat.com","username":"gregraka"},"change_message_id":"df22e1cd70a47df696e77b1d6efec4eff155fee6","unresolved":true,"context_lines":[{"line_number":117,"context_line":"The targets section is about how does Designate talk to the backend nameservers"},{"line_number":118,"context_line":"to configure it, and how should those backend nameservers talk to MiniDNS."},{"line_number":119,"context_line":"So for the BIND driver, the options section defines the address and port the"},{"line_number":120,"context_line":"“NOTIFY” messages should go ,to and the IP/port the driver should use to make"},{"line_number":121,"context_line":"rndc calls to BIND, as can be seen in"},{"line_number":122,"context_line":":ref:`this example. \u003cbind9_target_example\u003e`"},{"line_number":123,"context_line":"PowerDNS require using the connection keyword, as can be seen above."}],"source_content_type":"text/x-rst","patch_set":1,"id":"e0a8bc29_ea6c887d","line":120,"range":{"start_line":120,"start_character":40,"end_line":120,"end_character":47},"updated":"2024-05-29 14:05:32.000000000","message":"I\u0027m not sure that you need a slash here. But, I\u0027m not very familiar with the upstream style....","commit_id":"7eb472b5fb23624dd763f6e7e79da88fad055a49"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"2d624c93b0f3490e483ccf2aabf8a99000b641e8","unresolved":true,"context_lines":[{"line_number":117,"context_line":"The targets section is about how does Designate talk to the backend nameservers"},{"line_number":118,"context_line":"to configure it, and how should those backend nameservers talk to MiniDNS."},{"line_number":119,"context_line":"So for the BIND driver, the options section defines the address and port the"},{"line_number":120,"context_line":"“NOTIFY” messages should go ,to and the IP/port the driver should use to make"},{"line_number":121,"context_line":"rndc calls to BIND, as can be seen in"},{"line_number":122,"context_line":":ref:`this example. \u003cbind9_target_example\u003e`"},{"line_number":123,"context_line":"PowerDNS require using the connection keyword, as can be seen above."}],"source_content_type":"text/x-rst","patch_set":1,"id":"27ef64fa_9666e0ae","line":120,"updated":"2024-05-28 19:46:51.000000000","message":"There is an extra comma here.","commit_id":"7eb472b5fb23624dd763f6e7e79da88fad055a49"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"95bd26e4bedffd4ca38207a9e6e125cc10a5900a","unresolved":false,"context_lines":[{"line_number":117,"context_line":"The targets section is about how does Designate talk to the backend nameservers"},{"line_number":118,"context_line":"to configure it, and how should those backend nameservers talk to MiniDNS."},{"line_number":119,"context_line":"So for the BIND driver, the options section defines the address and port the"},{"line_number":120,"context_line":"“NOTIFY” messages should go ,to and the IP/port the driver should use to make"},{"line_number":121,"context_line":"rndc calls to BIND, as can be seen in"},{"line_number":122,"context_line":":ref:`this example. \u003cbind9_target_example\u003e`"},{"line_number":123,"context_line":"PowerDNS require using the connection keyword, as can be seen above."}],"source_content_type":"text/x-rst","patch_set":1,"id":"4a61fa57_ba7f481f","line":120,"in_reply_to":"27ef64fa_9666e0ae","updated":"2024-05-29 13:30:13.000000000","message":"Done","commit_id":"7eb472b5fb23624dd763f6e7e79da88fad055a49"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"484f899580d500fa3eac6d4943cfb5aea74d7dfb","unresolved":false,"context_lines":[{"line_number":117,"context_line":"The targets section is about how does Designate talk to the backend nameservers"},{"line_number":118,"context_line":"to configure it, and how should those backend nameservers talk to MiniDNS."},{"line_number":119,"context_line":"So for the BIND driver, the options section defines the address and port the"},{"line_number":120,"context_line":"“NOTIFY” messages should go ,to and the IP/port the driver should use to make"},{"line_number":121,"context_line":"rndc calls to BIND, as can be seen in"},{"line_number":122,"context_line":":ref:`this example. \u003cbind9_target_example\u003e`"},{"line_number":123,"context_line":"PowerDNS require using the connection keyword, as can be seen above."}],"source_content_type":"text/x-rst","patch_set":1,"id":"28a4354a_e0bcba79","line":120,"range":{"start_line":120,"start_character":40,"end_line":120,"end_character":47},"in_reply_to":"e0a8bc29_ea6c887d","updated":"2024-06-04 14:35:32.000000000","message":"Thanks, I agree. I am wondering to what I should change it, as the sentence is already a little long.\nFor now I will change it to IP:port, as \"IP and port\" might use many \"and\"s.","commit_id":"7eb472b5fb23624dd763f6e7e79da88fad055a49"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"6addc65efdc7510cb424b0546b840cf3c8a041a8","unresolved":true,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"The nameservers section is the list of name servers Designate will query to"},{"line_number":93,"context_line":"confirm an update has completed on all of the Designate managed nameservers."},{"line_number":94,"context_line":"Nameservers listed in the nameservers section are not expected to be reachable"},{"line_number":95,"context_line":"from external networks unless they are also listed in the ns_records section."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"NS Records vs. Nameservers: Understanding the Differences"}],"source_content_type":"text/x-rst","patch_set":9,"id":"b2f393d1_1a2f7f4c","line":94,"updated":"2025-01-14 02:26:52.000000000","message":"Maybe we should clarify this, they aren\u0027t expected to be \"advertised\". They may or may not be reachable. Maybe just a re-word?","commit_id":"7b538859e35a07b204d2ca370491b62ff22af6f6"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"0da968a1ef2f80a837c483d04fd873db5c4110b4","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"The nameservers section is the list of name servers Designate will query to"},{"line_number":93,"context_line":"confirm an update has completed on all of the Designate managed nameservers."},{"line_number":94,"context_line":"Nameservers listed in the nameservers section are not expected to be reachable"},{"line_number":95,"context_line":"from external networks unless they are also listed in the ns_records section."},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"NS Records vs. Nameservers: Understanding the Differences"}],"source_content_type":"text/x-rst","patch_set":9,"id":"f1ecc0b9_ddbff348","line":94,"in_reply_to":"b2f393d1_1a2f7f4c","updated":"2025-01-14 14:18:46.000000000","message":"Sounds good to me","commit_id":"7b538859e35a07b204d2ca370491b62ff22af6f6"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"6addc65efdc7510cb424b0546b840cf3c8a041a8","unresolved":true,"context_lines":[{"line_number":107,"context_line":"* ns_records list is smaller than the nameservers list:"},{"line_number":108,"context_line":"    The end user may have some private, or stealth, nameservers that they do"},{"line_number":109,"context_line":"    not want to advertise publicly as ns_records. Because they are private,"},{"line_number":110,"context_line":"    these stealth nameservers are not expected be reachable from external"},{"line_number":111,"context_line":"    networks."},{"line_number":112,"context_line":"* ns_records list is larger than the nameservers list:"},{"line_number":113,"context_line":"    The end user may not want to query all of the nameservers they manage"}],"source_content_type":"text/x-rst","patch_set":9,"id":"f2c48c65_b6839a61","line":110,"range":{"start_line":110,"start_character":38,"end_line":110,"end_character":46},"updated":"2025-01-14 02:26:52.000000000","message":"maybe \"necessarily\" reachable?\n\nThey may or may not be externally reachable.","commit_id":"7b538859e35a07b204d2ca370491b62ff22af6f6"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"0da968a1ef2f80a837c483d04fd873db5c4110b4","unresolved":false,"context_lines":[{"line_number":107,"context_line":"* ns_records list is smaller than the nameservers list:"},{"line_number":108,"context_line":"    The end user may have some private, or stealth, nameservers that they do"},{"line_number":109,"context_line":"    not want to advertise publicly as ns_records. Because they are private,"},{"line_number":110,"context_line":"    these stealth nameservers are not expected be reachable from external"},{"line_number":111,"context_line":"    networks."},{"line_number":112,"context_line":"* ns_records list is larger than the nameservers list:"},{"line_number":113,"context_line":"    The end user may not want to query all of the nameservers they manage"}],"source_content_type":"text/x-rst","patch_set":9,"id":"e039853e_e2dc1d35","line":110,"range":{"start_line":110,"start_character":38,"end_line":110,"end_character":46},"in_reply_to":"f2c48c65_b6839a61","updated":"2025-01-14 14:18:46.000000000","message":"Done","commit_id":"7b538859e35a07b204d2ca370491b62ff22af6f6"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"6addc65efdc7510cb424b0546b840cf3c8a041a8","unresolved":true,"context_lines":[{"line_number":111,"context_line":"    networks."},{"line_number":112,"context_line":"* ns_records list is larger than the nameservers list:"},{"line_number":113,"context_line":"    The end user may not want to query all of the nameservers they manage"},{"line_number":114,"context_line":"    after a zone update as some of those nameservers might be secondary, or"},{"line_number":115,"context_line":"    maybe the list of nameservers is just too big to query all of them."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Targets"}],"source_content_type":"text/x-rst","patch_set":9,"id":"5aed110e_e1832232","line":114,"range":{"start_line":114,"start_character":62,"end_line":114,"end_character":71},"updated":"2025-01-14 02:26:52.000000000","message":"Let\u0027s not use \"secondary\" here as that implies name servers in the \"secondary\" role. Maybe \"backup\" or \"warm standby\"?","commit_id":"7b538859e35a07b204d2ca370491b62ff22af6f6"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"0da968a1ef2f80a837c483d04fd873db5c4110b4","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    networks."},{"line_number":112,"context_line":"* ns_records list is larger than the nameservers list:"},{"line_number":113,"context_line":"    The end user may not want to query all of the nameservers they manage"},{"line_number":114,"context_line":"    after a zone update as some of those nameservers might be secondary, or"},{"line_number":115,"context_line":"    maybe the list of nameservers is just too big to query all of them."},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"Targets"}],"source_content_type":"text/x-rst","patch_set":9,"id":"ae1bde1e_6129eec3","line":114,"range":{"start_line":114,"start_character":62,"end_line":114,"end_character":71},"in_reply_to":"5aed110e_e1832232","updated":"2025-01-14 14:18:46.000000000","message":"Sounds good to me","commit_id":"7b538859e35a07b204d2ca370491b62ff22af6f6"}]}