)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"36f4811f5b2f2abac637b144dab88ab9d8c6a8c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5c08ece7_fecc0c2d","updated":"2024-08-16 20:21:36.000000000","message":"LGTM","commit_id":"f0ae34098b47c9a591099ee84f489b17088b1633"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"fd0bcdf9f23854a5b68e149742bdb4fc1040dfbc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"476d9b31_8e39429d","updated":"2024-09-11 09:13:24.000000000","message":"So I looked at the code, and afaik this is not sufficient?\n\ndesignate seems to look for a policy.yaml file, which it loads, and when you don\u0027t have set `enforce_new_defaults` in there, it defaults this setting to `False`, see:\n\nhttps://github.com/openstack/designate/blob/c64083d45d5d91c063edc2f828440e79e69d07b7/designate/policy.py#L108-L109\n\nit also returns `False` by default, if there is no `policy.yaml` file.\n\nSee also the rbac policy admin guide, which was added in I12c1a9dacc8fef1ca991e14d143fa76b588eef07\n\nwhich explicitly mentions that you need to set this in your policy.yaml (so the language is ambiguous there).\n\nI didn\u0027t find any special code to set a default for `enforce_scope` though.\n\nHTH\n\nPS: I\u0027m not that deep into the designate code base, so I hope the above is correct, please check yourself, it\u0027s possible I overlooked something.","commit_id":"f0ae34098b47c9a591099ee84f489b17088b1633"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"03249abc43b5ebff6e7219952136896386ace61d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"65eed594_0de21ca3","updated":"2024-09-03 19:03:20.000000000","message":"all depends-on are merged now, this is good to go","commit_id":"f0ae34098b47c9a591099ee84f489b17088b1633"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"91422ada8b9e3d7d1cdf3b2ec2c76900ad83a2b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d4d68894_fa9b5dd3","updated":"2024-08-30 18:26:19.000000000","message":"neutron-tempest-plugin-designate-scenario job is failing with designate new RBAC. this job is not triggered in this change (which should be) but we can see it is failing in https://review.opendev.org/c/openstack/designate/+/926446/","commit_id":"f0ae34098b47c9a591099ee84f489b17088b1633"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"652446a94c49b82f413b8cf1f555a11bfa095277","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f9bc15cd_bcba859b","in_reply_to":"476d9b31_8e39429d","updated":"2024-09-12 22:33:22.000000000","message":"Thanks Sven. \n\nenforce_new_defaults  and enforce_scope are configured and default in oslo.policy\n\n- https://github.com/openstack/oslo.policy/blob/9f91b67ac55a5c69bbdf72af2b2ea4a5203844db/oslo_policy/opts.py#L27-L45\n\nand if anyone want to override these config option for designate, they need to add these options in designate.conf under oslo_policy section. It has nothing to do with policy.yaml file.\n\nThough you have good point of enforce_new_defaults() method in policy.py file. I think we do not need that method now. I will do this cleanup in this change.","commit_id":"f0ae34098b47c9a591099ee84f489b17088b1633"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"8c0870a95e19419f025864a46867ddc96b5d7472","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d7e0303f_76ecb8c0","in_reply_to":"d4d68894_fa9b5dd3","updated":"2024-08-30 20:22:41.000000000","message":"To avoid breaking the designate gate (once requirement change is merged), I am making neutron-tempest-plugin-designate-scenario job non-voting - https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/927648","commit_id":"f0ae34098b47c9a591099ee84f489b17088b1633"},{"author":{"_account_id":32553,"name":"Sven Kieske","email":"sven_oss@posteo.de","username":"skieske"},"change_message_id":"177c70e71cca81c6a192580a175f737165116f87","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"400a95d6_3f31db62","in_reply_to":"f9bc15cd_bcba859b","updated":"2024-09-13 11:40:18.000000000","message":"Acknowledged","commit_id":"f0ae34098b47c9a591099ee84f489b17088b1633"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"440ae788dae61fd8e797b92c1425d6bf08ab1bc2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3083d482_79cd960a","updated":"2024-09-13 10:51:15.000000000","message":"Looks good to me","commit_id":"81b9b44bdae2e02329151142abeb7c6085b9fd2a"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"6f6a09085d63fcbea68700a864050540e3fe5266","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0d01d43e_cf655f56","updated":"2025-01-06 02:59:06.000000000","message":"LGTM","commit_id":"5aa3412826e153ad8ee00697fbb8c3bf901b89d3"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"707d677f15a370b6bef97b0379adc7c2f905218b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"99675b95_8b038f9b","updated":"2024-11-20 10:38:51.000000000","message":"Looks good to me","commit_id":"5aa3412826e153ad8ee00697fbb8c3bf901b89d3"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"f40d295677ccffc9d52cd472ac86a52233b26af9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5b097a00_9525b4a0","updated":"2025-02-11 01:49:00.000000000","message":"Workflowing as it has a +1 and +2 and previously had a second +2.","commit_id":"5aa3412826e153ad8ee00697fbb8c3bf901b89d3"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"bc3079d662d3cadb3a0f5c29fa9d0a0c40f2ee6d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"faf6a7bd_b2716393","updated":"2024-11-18 21:35:34.000000000","message":"recheck CI is working again","commit_id":"5aa3412826e153ad8ee00697fbb8c3bf901b89d3"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"82cfef5642e0de5d7e33273415fed886b54fd668","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1d94c1dc_8c77d713","updated":"2024-11-18 16:49:56.000000000","message":"recheck neutron CI should be fixed now","commit_id":"5aa3412826e153ad8ee00697fbb8c3bf901b89d3"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"8fafbcfc1ca11092571295464fcb4186a1835c34","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"be44e40b_849a865b","updated":"2024-11-19 19:15:54.000000000","message":"recheck test_zone_abandon_forbidden","commit_id":"5aa3412826e153ad8ee00697fbb8c3bf901b89d3"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"1d783df50267bb946f8e04ab15d221349ec87957","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"29c26afb_3f6d6793","updated":"2024-11-19 11:53:09.000000000","message":"recheck unrelated mirror failure","commit_id":"5aa3412826e153ad8ee00697fbb8c3bf901b89d3"}]}