)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"04d6466d06c4414c393595603ae2b864d26ceb14","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"53db196e_91f6f797","updated":"2024-09-12 10:01:28.000000000","message":"recheck a new version of the depended patch has been uploaded","commit_id":"37c8c1dd4a92e064c7173447c09cb950d556212e"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"e8dbe66f8e221a04ade0fb653af7de4bdee3c195","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ff063e7f_f7db3c40","updated":"2024-09-12 15:28:06.000000000","message":"recheck failure of designate-ipv6-only-bind9 doesn\u0027t seem related","commit_id":"37c8c1dd4a92e064c7173447c09cb950d556212e"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"8dea1b7dee22d486ead412ad2100dc53b3543713","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a79480a0_43dcd860","updated":"2025-01-06 02:51:01.000000000","message":"I removed the conflicting depends-on, plus I wanted current logs.","commit_id":"47abbe3ec562e42b00e62c31a0d2c1f8d3d0e626"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"ccf8019416b62f14c662b2e8ac3c83e5ebfc4e41","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"75bad2d5_05854258","updated":"2025-01-07 12:36:29.000000000","message":"In the current format of those patches, they depend on each other, I will split the changes and I hope they will pass","commit_id":"47abbe3ec562e42b00e62c31a0d2c1f8d3d0e626"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"fc606f511839651684d45fc1c1c4e2c5b58f989b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a7a836d5_59b1c85f","updated":"2025-01-08 13:58:31.000000000","message":"It looks like this patch is breaking test_unset_floatingip_ptr on stable releases https://review.opendev.org/c/openstack/designate-tempest-plugin/+/938554\nI will have to think about a solution","commit_id":"26389e760e046a62e52a93fd7ebe35e3eb93e8a7"}],"designate/central/service.py":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"4c9cf35418fab9e83c1618f5dca9b59100992b23","unresolved":true,"context_lines":[{"line_number":1888,"context_line":"        policy.check(\u0027count_records\u0027, context, target)"},{"line_number":1889,"context_line":"        return self.storage.count_records(context, criterion)"},{"line_number":1890,"context_line":""},{"line_number":1891,"context_line":"    def _determine_floatingips(self, context, fips, project_id\u003dNone):"},{"line_number":1892,"context_line":"        \"\"\""},{"line_number":1893,"context_line":"        Given the context or project, and fips it returns the valid"},{"line_number":1894,"context_line":"        floating ips either with an associated record or not. Deletes invalid"}],"source_content_type":"text/x-python","patch_set":1,"id":"d53ab926_7905469f","side":"PARENT","line":1891,"updated":"2024-08-28 10:47:53.000000000","message":"We might insert this writing-permission task in that same producer task, and remove it from here.","commit_id":"c79b2ae126c127c24221f521e25a92548cf4e625"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"4c9cf35418fab9e83c1618f5dca9b59100992b23","unresolved":true,"context_lines":[{"line_number":1951,"context_line":"                record[\u0027id\u0027]"},{"line_number":1952,"context_line":"            )"},{"line_number":1953,"context_line":""},{"line_number":1954,"context_line":"    def _list_floatingips(self, context, region\u003dNone):"},{"line_number":1955,"context_line":"        data \u003d self.network_api.list_floatingips(context, region\u003dregion)"},{"line_number":1956,"context_line":"        return self._list_to_dict(data, keys\u003d[\u0027region\u0027, \u0027id\u0027])"},{"line_number":1957,"context_line":""},{"line_number":1958,"context_line":"    def _list_to_dict(self, data, keys\u003dNone):"},{"line_number":1959,"context_line":"        if keys is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"b3b79a7c_c704aa89","side":"PARENT","line":1956,"range":{"start_line":1954,"start_character":4,"end_line":1956,"end_character":62},"updated":"2024-08-28 10:47:53.000000000","message":"I am planning to delete every call to the network_api, regarding floating ip validation.","commit_id":"c79b2ae126c127c24221f521e25a92548cf4e625"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"4c9cf35418fab9e83c1618f5dca9b59100992b23","unresolved":true,"context_lines":[{"line_number":2004,"context_line":"        \"\"\""},{"line_number":2005,"context_line":"        elevated_context \u003d context.elevated(all_tenants\u003dTrue)"},{"line_number":2006,"context_line":""},{"line_number":2007,"context_line":"        tenant_fips \u003d self._list_floatingips(context, region\u003dregion)"},{"line_number":2008,"context_line":""},{"line_number":2009,"context_line":"        fip \u003d self._get_floatingip(context, region, floatingip_id, tenant_fips)"},{"line_number":2010,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"59166f60_ccaf544e","side":"PARENT","line":2007,"range":{"start_line":2007,"start_character":27,"end_line":2007,"end_character":44},"updated":"2024-08-28 10:47:53.000000000","message":"I plan to remove this neutron call too.","commit_id":"c79b2ae126c127c24221f521e25a92548cf4e625"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"fcee9d40821e86e84617e909b09c735d8977a883","unresolved":false,"context_lines":[{"line_number":2004,"context_line":"        \"\"\""},{"line_number":2005,"context_line":"        elevated_context \u003d context.elevated(all_tenants\u003dTrue)"},{"line_number":2006,"context_line":""},{"line_number":2007,"context_line":"        tenant_fips \u003d self._list_floatingips(context, region\u003dregion)"},{"line_number":2008,"context_line":""},{"line_number":2009,"context_line":"        fip \u003d self._get_floatingip(context, region, floatingip_id, tenant_fips)"},{"line_number":2010,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"aecd2c60_52641162","side":"PARENT","line":2007,"range":{"start_line":2007,"start_character":27,"end_line":2007,"end_character":44},"in_reply_to":"59166f60_ccaf544e","updated":"2024-09-03 13:08:56.000000000","message":"Done","commit_id":"c79b2ae126c127c24221f521e25a92548cf4e625"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"4c9cf35418fab9e83c1618f5dca9b59100992b23","unresolved":true,"context_lines":[{"line_number":2026,"context_line":"        elevated_context \u003d context.elevated(all_tenants\u003dTrue,"},{"line_number":2027,"context_line":"                                            edit_managed_records\u003dTrue)"},{"line_number":2028,"context_line":""},{"line_number":2029,"context_line":"        project_fips \u003d self._list_floatingips(context, region\u003dregion)"},{"line_number":2030,"context_line":""},{"line_number":2031,"context_line":"        fip \u003d self._get_floatingip("},{"line_number":2032,"context_line":"            context, region, floatingip_id, project_fips"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a942232_1c8903c8","side":"PARENT","line":2029,"range":{"start_line":2029,"start_character":28,"end_line":2029,"end_character":45},"updated":"2024-08-28 10:47:53.000000000","message":"I plan to remove this neutron call too.","commit_id":"c79b2ae126c127c24221f521e25a92548cf4e625"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"fcee9d40821e86e84617e909b09c735d8977a883","unresolved":true,"context_lines":[{"line_number":2026,"context_line":"        elevated_context \u003d context.elevated(all_tenants\u003dTrue,"},{"line_number":2027,"context_line":"                                            edit_managed_records\u003dTrue)"},{"line_number":2028,"context_line":""},{"line_number":2029,"context_line":"        project_fips \u003d self._list_floatingips(context, region\u003dregion)"},{"line_number":2030,"context_line":""},{"line_number":2031,"context_line":"        fip \u003d self._get_floatingip("},{"line_number":2032,"context_line":"            context, region, floatingip_id, project_fips"}],"source_content_type":"text/x-python","patch_set":1,"id":"2f5137fe_c43f2fc2","side":"PARENT","line":2029,"range":{"start_line":2029,"start_character":28,"end_line":2029,"end_character":45},"in_reply_to":"9a942232_1c8903c8","updated":"2024-09-03 13:08:56.000000000","message":"We cannot remove the network_api calls from this API without breaking backward compatibility.\n\nThis API today (might) start from an empty ptr record list, then it gets the existing FIPs, constructs a reversed \"zone_name\" (X.X.X.in-addr.arpa.), creates a zone for the ptr record in case it doesn\u0027t exist, and then creates the ptr record.\n\nWithout getting the existing FIPs (while the existing ptr list is empty), we cannot do all of those operations. We could require the end user to create a ptr record before, but that would break the existing behavior of this API.","commit_id":"c79b2ae126c127c24221f521e25a92548cf4e625"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"85b0e71c4b8c9633d82a90bb6bfb37c07fb1142a","unresolved":true,"context_lines":[{"line_number":2006,"context_line":"                break"},{"line_number":2007,"context_line":"        else:"},{"line_number":2008,"context_line":"            raise exceptions.NotFound("},{"line_number":2009,"context_line":"                \u0027FloatingIP {} in {} is not associated for project \u0027"},{"line_number":2010,"context_line":"                \u0027\"{}\"\u0027.format("},{"line_number":2011,"context_line":"                    floatingip_id, region, context.project_id"},{"line_number":2012,"context_line":"                )"}],"source_content_type":"text/x-python","patch_set":4,"id":"a283860a_ae7bce14","line":2009,"updated":"2024-09-07 14:41:29.000000000","message":"Might as well use f\u0027FlaotingIP ....\u0027 here instead of format","commit_id":"e3015866e49eec2542f754d404cef735c85e04a7"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"0985a81e306492777b1bffca0d16a44571eadbd3","unresolved":true,"context_lines":[{"line_number":2006,"context_line":"                break"},{"line_number":2007,"context_line":"        else:"},{"line_number":2008,"context_line":"            raise exceptions.NotFound("},{"line_number":2009,"context_line":"                \u0027FloatingIP {} in {} is not associated for project \u0027"},{"line_number":2010,"context_line":"                \u0027\"{}\"\u0027.format("},{"line_number":2011,"context_line":"                    floatingip_id, region, context.project_id"},{"line_number":2012,"context_line":"                )"}],"source_content_type":"text/x-python","patch_set":4,"id":"f7dfaa03_b06f676e","line":2009,"in_reply_to":"a283860a_ae7bce14","updated":"2024-09-10 17:03:44.000000000","message":"I also prefer fstrings, I will change it, thanks.","commit_id":"e3015866e49eec2542f754d404cef735c85e04a7"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"46e413c6966c92bd7f32becdae014586f91ec3cf","unresolved":false,"context_lines":[{"line_number":2006,"context_line":"                break"},{"line_number":2007,"context_line":"        else:"},{"line_number":2008,"context_line":"            raise exceptions.NotFound("},{"line_number":2009,"context_line":"                \u0027FloatingIP {} in {} is not associated for project \u0027"},{"line_number":2010,"context_line":"                \u0027\"{}\"\u0027.format("},{"line_number":2011,"context_line":"                    floatingip_id, region, context.project_id"},{"line_number":2012,"context_line":"                )"}],"source_content_type":"text/x-python","patch_set":4,"id":"6dedb574_36fc09fe","line":2009,"in_reply_to":"f7dfaa03_b06f676e","updated":"2024-09-10 17:06:04.000000000","message":"Done","commit_id":"e3015866e49eec2542f754d404cef735c85e04a7"}]}