)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f7e8ec8da1b4e0b8c222ad6a84548edb2bcd8a98","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a1e761dd_af1c4079","updated":"2024-09-13 10:05:16.000000000","message":"Yeah, looks like you\u0027ve been a little overeager here. Please look at Takashi-san\u0027s comments","commit_id":"cf62722c6a6e2795f23cbfa33ccfb4cfddbff810"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a2c739c66d81c03424188706e2743c3b7a918f94","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a36e0a31_aba43812","updated":"2024-09-12 17:50:04.000000000","message":"Yeah, looks like you\u0027ve been a little overeager here. Please look at Takashi-san\u0027s comments","commit_id":"cf62722c6a6e2795f23cbfa33ccfb4cfddbff810"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"98f6f16c04d220940ea718dfd827aa1e80252578","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"87dd2dae_be871f19","in_reply_to":"a1e761dd_af1c4079","updated":"2024-09-13 10:05:48.000000000","message":"Whoops, didn\u0027t mean to leave this comment again. Don\u0027t know how that happened.","commit_id":"cf62722c6a6e2795f23cbfa33ccfb4cfddbff810"}],"api-ref/source/dns-api-v2-blacklist.inc":[{"author":{"_account_id":35119,"name":"jihyun huh","email":"huhji.elha@gmail.com","username":"jhhuh"},"change_message_id":"110907be2fe9861b6ee1c12cec2e558a9b3796ba","unresolved":true,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"List Blacklists"},{"line_number":80,"context_line":"---------------"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":".. rest_method::  GET /v2/blacklists"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"c02a3224_5e13525e","line":80,"updated":"2024-09-05 12:20:54.000000000","message":"This is the part that needs to be changed...","commit_id":"2d73ac52fc0c112258c000ea6468102542797c09"},{"author":{"_account_id":37216,"name":"이현규","display_name":"hyungyulee","email":"dlgusrb3456@naver.com","username":"hyungyulee"},"change_message_id":"bb9c1c0875edc6755b1255b734069f207b4af35e","unresolved":true,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"List Blacklists"},{"line_number":80,"context_line":"---------------"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":".. rest_method::  GET /v2/blacklists"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":2,"id":"b3f71750_d1c506c8","line":80,"in_reply_to":"c02a3224_5e13525e","updated":"2024-09-09 16:30:50.000000000","message":"I changed the \u0027-\u0027 symbol to \u0027\u003d\u0027. Is that what you intended?","commit_id":"2d73ac52fc0c112258c000ea6468102542797c09"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"bbb6ddabf95a08399f20836fc52e793d0e7aa82c","unresolved":true,"context_lines":[{"line_number":98,"context_line":"   - 405"},{"line_number":99,"context_line":"   - 503"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Request Parameters"},{"line_number":102,"context_line":"------------------"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":".. rest_parameters:: parameters.yaml"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"d990a005_436d5795","side":"PARENT","line":101,"range":{"start_line":101,"start_character":8,"end_line":101,"end_character":18},"updated":"2024-09-10 10:23:14.000000000","message":"why is this removed ? \u0027Request Parameters\u0027 is commonly used as a section name in the other APIs and I think it should be kept.","commit_id":"cfa330c0fddd356b3053dd5050c76cfb42fcda64"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f7e8ec8da1b4e0b8c222ad6a84548edb2bcd8a98","unresolved":true,"context_lines":[{"line_number":98,"context_line":"   - 405"},{"line_number":99,"context_line":"   - 503"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Request Parameters"},{"line_number":102,"context_line":"------------------"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":".. rest_parameters:: parameters.yaml"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"ddfe1817_ab3b5fed","side":"PARENT","line":101,"range":{"start_line":101,"start_character":8,"end_line":101,"end_character":18},"in_reply_to":"0f3882da_31f5ceb4","updated":"2024-09-13 10:05:16.000000000","message":"@dlgusrb3456@naver.com I think you left the reply on the wrong comment. I\u0027ve replied below.\n\nRegarding this comment, @kajinamit@oss.nttdata.com, it seems we\u0027re using both `Request` and `Request Parameters` in the api-ref:\n\n```\n❯ ag \u0027^Request$\u0027 api-ref --nogroup | wc -l\n62\n❯ ag \u0027^Request Parameters$\u0027 api-ref --nogroup | wc -l\n7\n```\n\nSo we should probably settle on one or the other.\n\n@dlgusrb3456@naver.com: rather than changing this here, how about you update the places where we have:\n\n```\nRequest\n-------\n```\n\nto:\n\n```\nRequest Parameters\n------------------\n```\n\ninstead?\n\nIf you are interested, this should be done in a separate patch. I would suggest working in a different branch. For example:\n\n```\ngit checkout master            # checkout master branch\ngit pull                       # pull in latest changes, if any, for master\ngit checkout -b api-ref-fixes  # checkout new branch\n# make changes\ngit commit -a                  # save changes\ngit review -fy                 # push changes to Gerrit and delete local branch\n```\n\nIf you need to respin later, you can do:\n\n```\ngit review -d \u003cchange-id\u003e\n# make changes\ngit commit --amend -a\ngit review -fy\n```","commit_id":"cfa330c0fddd356b3053dd5050c76cfb42fcda64"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"47ba1da124cc1ce16614b6f877a2b61b7b81444e","unresolved":true,"context_lines":[{"line_number":98,"context_line":"   - 405"},{"line_number":99,"context_line":"   - 503"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Request Parameters"},{"line_number":102,"context_line":"------------------"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":".. rest_parameters:: parameters.yaml"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"30e9efc6_760cf401","side":"PARENT","line":101,"range":{"start_line":101,"start_character":8,"end_line":101,"end_character":18},"in_reply_to":"0f3882da_31f5ceb4","updated":"2024-09-13 10:00:04.000000000","message":"both \"Request Parameters\" and \"pattern\" appear in other docs or api-ref:\n\n~/designate \u003e rg \u0027Request Parameters\u0027                                                                                         \napi-ref/source/dns-api-v2-blacklist.inc\n38:Request Parameters\n101:Request Parameters\n205:Request Parameters\n\napi-ref/source/dns-api-v2-tsigkey.inc\n101:Request Parameters\n225:Request Parameters\n\napi-ref/source/dns-api-v2-service-status.inc\n31:Request Parameters\n87:Request Parameters\n\n\n~/designate \u003e rg \u0027pattern:\u0027                                                                                                    \ndoc/source/user/secondary-zones.rst\n96:    pattern:\n\napi-ref/source/parameters.yaml\n456:blacklist_pattern:\n\napi-ref/source/dns-api-v2-blacklist.inc\n46:   - pattern: blacklist_pattern\n64:   - pattern: blacklist_pattern\n109:   - pattern: blacklist_pattern_filter\n119:   - pattern: blacklist_pattern\n177:   - pattern: blacklist_pattern\n213:   - pattern: blacklist_pattern\n232:   - pattern: blacklist_pattern","commit_id":"cfa330c0fddd356b3053dd5050c76cfb42fcda64"},{"author":{"_account_id":37216,"name":"이현규","display_name":"hyungyulee","email":"dlgusrb3456@naver.com","username":"hyungyulee"},"change_message_id":"d7ffb472d4ec93ac6e6b00959516014f1f868b86","unresolved":true,"context_lines":[{"line_number":98,"context_line":"   - 405"},{"line_number":99,"context_line":"   - 503"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Request Parameters"},{"line_number":102,"context_line":"------------------"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":".. rest_parameters:: parameters.yaml"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"40491389_52266745","side":"PARENT","line":101,"range":{"start_line":101,"start_character":8,"end_line":101,"end_character":18},"in_reply_to":"4436bcd6_b95ac3bd","updated":"2024-09-25 14:48:09.000000000","message":"@stephenfin@redhat.com\n\nThank you stepfin. I made a new patch set as you said. I will leave it as a link, so please check it.\n\nhttps://review.opendev.org/c/openstack/designate/+/930479","commit_id":"cfa330c0fddd356b3053dd5050c76cfb42fcda64"},{"author":{"_account_id":37216,"name":"이현규","display_name":"hyungyulee","email":"dlgusrb3456@naver.com","username":"hyungyulee"},"change_message_id":"785d117a2280967c67896d1dee0009c31d8b3853","unresolved":true,"context_lines":[{"line_number":98,"context_line":"   - 405"},{"line_number":99,"context_line":"   - 503"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Request Parameters"},{"line_number":102,"context_line":"------------------"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":".. rest_parameters:: parameters.yaml"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"0f3882da_31f5ceb4","side":"PARENT","line":101,"range":{"start_line":101,"start_character":8,"end_line":101,"end_character":18},"in_reply_to":"d990a005_436d5795","updated":"2024-09-13 04:42:55.000000000","message":"When I checked through openstack cli --help, it didn\u0027t receive \"pattern\" as a parameter, so I deleted the request parameter. Do you happen to have any other documents to refer to other than cli?","commit_id":"cfa330c0fddd356b3053dd5050c76cfb42fcda64"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"73dae03595f5a4a1222384d1fad802d9ac9ca2b4","unresolved":true,"context_lines":[{"line_number":98,"context_line":"   - 405"},{"line_number":99,"context_line":"   - 503"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"Request Parameters"},{"line_number":102,"context_line":"------------------"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":".. rest_parameters:: parameters.yaml"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"4436bcd6_b95ac3bd","side":"PARENT","line":101,"range":{"start_line":101,"start_character":8,"end_line":101,"end_character":18},"in_reply_to":"ddfe1817_ab3b5fed","updated":"2024-09-13 11:10:49.000000000","message":"Thanks @stephenfin for that information. I wasn\u0027t aware about the inconsistencies across the doc.\n\nSo I agree with Stephen and think that should be done in a different change. At least when we look at the blacklist API section \"Request parameter\" is consistently used so just updating this single section does not make much sense.","commit_id":"cfa330c0fddd356b3053dd5050c76cfb42fcda64"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"bbb6ddabf95a08399f20836fc52e793d0e7aa82c","unresolved":true,"context_lines":[{"line_number":106,"context_line":"   - x-auth-token: x-auth-token"},{"line_number":107,"context_line":"   - x-auth-all-projects: x-auth-all-projects"},{"line_number":108,"context_line":"   - x-auth-sudo-project-id: x-auth-sudo-project-id"},{"line_number":109,"context_line":"   - pattern: blacklist_pattern_filter"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Response Parameters"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"25535638_57b78737","side":"PARENT","line":109,"range":{"start_line":109,"start_character":14,"end_line":109,"end_character":38},"updated":"2024-09-10 10:23:14.000000000","message":"why is this removed ?","commit_id":"cfa330c0fddd356b3053dd5050c76cfb42fcda64"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"73dae03595f5a4a1222384d1fad802d9ac9ca2b4","unresolved":true,"context_lines":[{"line_number":106,"context_line":"   - x-auth-token: x-auth-token"},{"line_number":107,"context_line":"   - x-auth-all-projects: x-auth-all-projects"},{"line_number":108,"context_line":"   - x-auth-sudo-project-id: x-auth-sudo-project-id"},{"line_number":109,"context_line":"   - pattern: blacklist_pattern_filter"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Response Parameters"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"375256a1_e8f1554d","side":"PARENT","line":109,"range":{"start_line":109,"start_character":14,"end_line":109,"end_character":38},"in_reply_to":"0853fe42_d0a596ed","updated":"2024-09-13 11:10:49.000000000","message":"Thanks, Stephen, for the through explanation !\n\nOne thing I\u0027d add to him is that this is api documentation does not necessarily match with the interface implementated in openstack cli. You should always look at the implementation in REST API side rather than openstack cli.","commit_id":"cfa330c0fddd356b3053dd5050c76cfb42fcda64"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"f7e8ec8da1b4e0b8c222ad6a84548edb2bcd8a98","unresolved":true,"context_lines":[{"line_number":106,"context_line":"   - x-auth-token: x-auth-token"},{"line_number":107,"context_line":"   - x-auth-all-projects: x-auth-all-projects"},{"line_number":108,"context_line":"   - x-auth-sudo-project-id: x-auth-sudo-project-id"},{"line_number":109,"context_line":"   - pattern: blacklist_pattern_filter"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"Response Parameters"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"0853fe42_d0a596ed","side":"PARENT","line":109,"range":{"start_line":109,"start_character":14,"end_line":109,"end_character":38},"in_reply_to":"25535638_57b78737","updated":"2024-09-13 10:05:16.000000000","message":"\u003e When I checked through openstack cli --help, it didn\u0027t receive \"pattern\" as a parameter, so I deleted the request parameter. Do you happen to have any other documents to refer to other than cli?\n\nTo verify this, I suggest looking at the code. The code for this API lives in `designate/api/v2/controllers/blacklists.py`. If we look at that, we find that it supports a number of parameters.\n\nhttps://opendev.org/openstack/designate/src/branch/master/designate/api/v2/controllers/blacklists.py#L51-L58\n\n`pattern` is one of them so that should stay. There are also some parameters that are currently not documented which you may wish to add, namely `marker`, `limit`, `sort_key` and `sort_dir`. If you grep for these, you will find existing examples of these documented in api-ref that you can copy (hint: for example, in the `api-ref/source/dns-api-v2-recordset.inc`).","commit_id":"cfa330c0fddd356b3053dd5050c76cfb42fcda64"}]}