)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"5b48944ad0e1a72193dbcc77ddc34fb72d9dabda","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"134f88b9_2b66e3aa","updated":"2024-11-14 13:28:03.000000000","message":"recheck CI fixed","commit_id":"f9d310fbf0d1e405c0f08a5c80f796f209a7ca45"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"284b27ed6da7cdab1203b4d3300f86929267f6dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"18e48071_8e3da73b","updated":"2024-11-20 18:47:43.000000000","message":"Just a small request to clarify the option help","commit_id":"60c6c8b1ec005d895f932eea21a21fff9aaf8038"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"e7aa9e59e65d8e226ab3e21fd2c0d16001a8b851","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ab32aa1c_261e9729","updated":"2024-11-20 15:09:21.000000000","message":"Looks good to me","commit_id":"60c6c8b1ec005d895f932eea21a21fff9aaf8038"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"17226ecd8097cadb592e37c3b82a97287249f87f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fdf975d0_01350770","updated":"2025-01-06 03:28:00.000000000","message":"LGTM","commit_id":"4c7d5d950f729b2074aaa087dd1d7b900ba8a32f"}],"designate/conf/mdns.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"284b27ed6da7cdab1203b4d3300f86929267f6dd","unresolved":true,"context_lines":[{"line_number":31,"context_line":"                help\u003d\u0027mDNS host:port pairs to listen on\u0027),"},{"line_number":32,"context_line":"    cfg.IntOpt(\u0027tcp_backlog\u0027, default\u003d100,"},{"line_number":33,"context_line":"               help\u003d\u0027mDNS TCP Backlog\u0027),"},{"line_number":34,"context_line":"    cfg.IntOpt(\u0027tcp_keepidle\u0027, help\u003d\u0027mDNS TCP Keepidle\u0027),"},{"line_number":35,"context_line":"    cfg.FloatOpt(\u0027tcp_recv_timeout\u0027, default\u003d0.5,"},{"line_number":36,"context_line":"                 help\u003d\u0027mDNS TCP Receive Timeout\u0027),"},{"line_number":37,"context_line":"    cfg.BoolOpt(\u0027query_enforce_tsig\u0027, default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":2,"id":"42da3bd3_3c7c41b6","line":34,"updated":"2024-11-20 18:47:43.000000000","message":"Can we expand this description to include that this is a interval setting and what units it is in?\n\"keepidle\" is similar to \"keepalive\"(which is a boolean vs an interval) and I want to make sure our configuration settings are clear to users.\nHow about \"mini-DNS TCP Keepidle interval in seconds.\"","commit_id":"60c6c8b1ec005d895f932eea21a21fff9aaf8038"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"899f8f2ed06d0a19725fc5b748517fdc4ff024a0","unresolved":true,"context_lines":[{"line_number":31,"context_line":"                help\u003d\u0027mDNS host:port pairs to listen on\u0027),"},{"line_number":32,"context_line":"    cfg.IntOpt(\u0027tcp_backlog\u0027, default\u003d100,"},{"line_number":33,"context_line":"               help\u003d\u0027mDNS TCP Backlog\u0027),"},{"line_number":34,"context_line":"    cfg.IntOpt(\u0027tcp_keepidle\u0027, help\u003d\u0027mDNS TCP Keepidle\u0027),"},{"line_number":35,"context_line":"    cfg.FloatOpt(\u0027tcp_recv_timeout\u0027, default\u003d0.5,"},{"line_number":36,"context_line":"                 help\u003d\u0027mDNS TCP Receive Timeout\u0027),"},{"line_number":37,"context_line":"    cfg.BoolOpt(\u0027query_enforce_tsig\u0027, default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":2,"id":"a9abb521_8994a8b2","line":34,"in_reply_to":"42da3bd3_3c7c41b6","updated":"2024-11-22 05:43:45.000000000","message":"Done. Note that I decided to use \"mDNS\" because it is used commonly in the other descriptions but I can update these all if mini-DNS is a better wording.","commit_id":"60c6c8b1ec005d895f932eea21a21fff9aaf8038"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9ac86a0d9649e7c6d2dead7f761b7c2264ce66ad","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                help\u003d\u0027mDNS host:port pairs to listen on\u0027),"},{"line_number":32,"context_line":"    cfg.IntOpt(\u0027tcp_backlog\u0027, default\u003d100,"},{"line_number":33,"context_line":"               help\u003d\u0027mDNS TCP Backlog\u0027),"},{"line_number":34,"context_line":"    cfg.IntOpt(\u0027tcp_keepidle\u0027, help\u003d\u0027mDNS TCP Keepidle\u0027),"},{"line_number":35,"context_line":"    cfg.FloatOpt(\u0027tcp_recv_timeout\u0027, default\u003d0.5,"},{"line_number":36,"context_line":"                 help\u003d\u0027mDNS TCP Receive Timeout\u0027),"},{"line_number":37,"context_line":"    cfg.BoolOpt(\u0027query_enforce_tsig\u0027, default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fd9f775f_ec91f549","line":34,"in_reply_to":"a9abb521_8994a8b2","updated":"2024-11-22 05:44:00.000000000","message":"Done","commit_id":"60c6c8b1ec005d895f932eea21a21fff9aaf8038"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"17226ecd8097cadb592e37c3b82a97287249f87f","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                help\u003d\u0027mDNS host:port pairs to listen on\u0027),"},{"line_number":32,"context_line":"    cfg.IntOpt(\u0027tcp_backlog\u0027, default\u003d100,"},{"line_number":33,"context_line":"               help\u003d\u0027mDNS TCP Backlog\u0027),"},{"line_number":34,"context_line":"    cfg.IntOpt(\u0027tcp_keepidle\u0027, help\u003d\u0027mDNS TCP Keepidle\u0027),"},{"line_number":35,"context_line":"    cfg.FloatOpt(\u0027tcp_recv_timeout\u0027, default\u003d0.5,"},{"line_number":36,"context_line":"                 help\u003d\u0027mDNS TCP Receive Timeout\u0027),"},{"line_number":37,"context_line":"    cfg.BoolOpt(\u0027query_enforce_tsig\u0027, default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":2,"id":"6550d00b_d79a370d","line":34,"in_reply_to":"fd9f775f_ec91f549","updated":"2025-01-06 03:28:00.000000000","message":"I prefer to use mini-DNS as \"mDNS\" is actually multicast DNS. That said, \"mDNS\" is used all over in Designate and should be a future patch to clarify it everywhere.","commit_id":"60c6c8b1ec005d895f932eea21a21fff9aaf8038"}],"designate/tests/unit/test_service.py":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"fa585a80231decbd76b898155850cab7eb981519","unresolved":true,"context_lines":[{"line_number":275,"context_line":"        )"},{"line_number":276,"context_line":"        self.service._running \u003d mock.Mock()"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    def test_service_init(self):"},{"line_number":279,"context_line":"        self.assertEqual(CONF[\u0027service:mdns\u0027].listen, self.service.listen)"},{"line_number":280,"context_line":"        self.assertEqual("},{"line_number":281,"context_line":"            CONF[\u0027service:mdns\u0027].tcp_backlog, self.service.tcp_backlog"}],"source_content_type":"text/x-python","patch_set":1,"id":"a2bd2c7f_7f06df9a","line":278,"range":{"start_line":278,"start_character":8,"end_line":278,"end_character":25},"updated":"2024-11-20 10:53:50.000000000","message":"do we want to add it here too?","commit_id":"f9d310fbf0d1e405c0f08a5c80f796f209a7ca45"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"ec1e85a1b7ad6131a777a0b2a0e04789759915f7","unresolved":false,"context_lines":[{"line_number":275,"context_line":"        )"},{"line_number":276,"context_line":"        self.service._running \u003d mock.Mock()"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    def test_service_init(self):"},{"line_number":279,"context_line":"        self.assertEqual(CONF[\u0027service:mdns\u0027].listen, self.service.listen)"},{"line_number":280,"context_line":"        self.assertEqual("},{"line_number":281,"context_line":"            CONF[\u0027service:mdns\u0027].tcp_backlog, self.service.tcp_backlog"}],"source_content_type":"text/x-python","patch_set":1,"id":"88c16824_80bcacfc","line":278,"range":{"start_line":278,"start_character":8,"end_line":278,"end_character":25},"in_reply_to":"a2bd2c7f_7f06df9a","updated":"2024-11-20 13:44:10.000000000","message":"That makes sense. Done.","commit_id":"f9d310fbf0d1e405c0f08a5c80f796f209a7ca45"}]}