)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f6f8be67ff9af1f4e1e2e6ac1f1a24d23e7b7594","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"17f07a44_484d10eb","updated":"2024-12-30 13:53:07.000000000","message":"A few small comments. Would you mind adding release notes too? https://docs.openstack.org/reno/latest/user/usage.html#creating-new-release-notes","commit_id":"5b8262363afabf8539824b3efa48d13c03eab975"}],"designate/objects/recordset.py":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f6f8be67ff9af1f4e1e2e6ac1f1a24d23e7b7594","unresolved":true,"context_lines":[{"line_number":253,"context_line":"        try:"},{"line_number":254,"context_line":"            rdclassnumber \u003d rdataclass.RdataClass.make(rdclass)"},{"line_number":255,"context_line":"            rdtypenumber \u003d rdatatype.RdataType.make(rdtype)"},{"line_number":256,"context_line":"        except rdatatype.UnknownRdatatype:"},{"line_number":257,"context_line":"            err_msg \u003d (\"recordset of class \u0027%(class)s\u0027 and type \u0027%(type)s\u0027\""},{"line_number":258,"context_line":"                       \" is unknown. Try to use \u0027CLASSN\u0027 or \u0027TYPEN\u0027 to force\""},{"line_number":259,"context_line":"                       \" generic datatype. see RFC3597\""}],"source_content_type":"text/x-python","patch_set":4,"id":"25793cc3_87e6ecba","line":256,"updated":"2024-12-30 13:53:07.000000000","message":"would we like to catch dns.rdataclass.UnknownRdataclass as well?","commit_id":"5b8262363afabf8539824b3efa48d13c03eab975"}],"designate/storage/sqlalchemy/types.py":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"67f4f11cda449e51f103e6b136ebac29749a2730","unresolved":true,"context_lines":[{"line_number":83,"context_line":"                if isinstance(value, str) else False):"},{"line_number":84,"context_line":"            return value"},{"line_number":85,"context_line":"        else:"},{"line_number":86,"context_line":"            err_msg \u003d (\"Value \u0027%(value)s\u0027 in table is not valid.\""},{"line_number":87,"context_line":"                       \" Must be in [%(record_types)s] or match \""},{"line_number":88,"context_line":"                       \"\u0027^TYPE\\\\d$\u0027\""},{"line_number":89,"context_line":"             % {\u0027value\u0027: value,"}],"source_content_type":"text/x-python","patch_set":2,"id":"d1c23e49_18418f23","line":86,"updated":"2024-12-01 14:32:10.000000000","message":"Missing some test cases for this error handling.","commit_id":"a26bd59e34246bd102dbcffbdefca1bf9cfe0df5"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f6f8be67ff9af1f4e1e2e6ac1f1a24d23e7b7594","unresolved":true,"context_lines":[{"line_number":66,"context_line":"    \"\"\""},{"line_number":67,"context_line":"    A custom string type that validates whether the value is:"},{"line_number":68,"context_line":"    1. A string within a list of DNS record types allowed values, or"},{"line_number":69,"context_line":"    2. A string that matches with \"^TYPE[0-9]*\"."},{"line_number":70,"context_line":"    \"\"\""},{"line_number":71,"context_line":"    cache_ok \u003d True"},{"line_number":72,"context_line":"    impl \u003d String(10)"}],"source_content_type":"text/x-python","patch_set":4,"id":"53fdc615_96ac129f","line":69,"range":{"start_line":69,"start_character":35,"end_line":69,"end_character":46},"updated":"2024-12-30 13:53:07.000000000","message":"nit: we use \u0027^TYPE\\d+$\u0027 on line 82","commit_id":"5b8262363afabf8539824b3efa48d13c03eab975"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f6f8be67ff9af1f4e1e2e6ac1f1a24d23e7b7594","unresolved":true,"context_lines":[{"line_number":80,"context_line":"        elif value.upper() in tables.RECORD_TYPES or ("},{"line_number":81,"context_line":"                CONF.support_generic_record_types and"},{"line_number":82,"context_line":"                re.match(r\u0027^TYPE\\d+$\u0027, value)"},{"line_number":83,"context_line":"                if isinstance(value, str) else False):"},{"line_number":84,"context_line":"            return value"},{"line_number":85,"context_line":"        else:"},{"line_number":86,"context_line":"            err_msg \u003d (\"Value \u0027%(value)s\u0027 in table is not valid.\""}],"source_content_type":"text/x-python","patch_set":4,"id":"f46b6158_140b1ef6","line":83,"range":{"start_line":83,"start_character":16,"end_line":83,"end_character":53},"updated":"2024-12-30 13:53:07.000000000","message":"I would suggest to use another \"and\" instead of that if else statement (if I understood its purpose correctly)","commit_id":"5b8262363afabf8539824b3efa48d13c03eab975"}]}