)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"030e1f1dbd95d846ac6f789adb369a8c5bb964dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c2f84e06_5321cdd5","updated":"2025-03-06 15:56:23.000000000","message":"Would you mind adding release notes?\nhttps://docs.openstack.org/reno/2.1.1/usage.html#creating-new-release-notes\n\nand extending/creating the test that was supposed to catch what you are fixing:\nhttps://opendev.org/openstack/designate/src/branch/master/designate/tests/unit/producer/test_tasks.py#L196\n\nthanks","commit_id":"7a97e78f3801c025f4f30a4a93ccaf38247cfa0b"},{"author":{"_account_id":32927,"name":"mitya-eremeev-2","display_name":"Mitya Eremeev","email":"mitossvyaz@mail.ru","username":"mitya-eremeev-2"},"change_message_id":"47030b1f5c373c7a9a32e1c94c0c7fd54de2996e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d11e4b3a_88e67631","in_reply_to":"c2f84e06_5321cdd5","updated":"2025-03-07 19:24:52.000000000","message":"done","commit_id":"7a97e78f3801c025f4f30a4a93ccaf38247cfa0b"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"a26f345ff8d5a997022b9236bb882b12250e00b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bb5d4576_a15b7cac","updated":"2025-03-11 00:44:23.000000000","message":"LGTM","commit_id":"a265c5070bd0f83d9352218f9de9475416a132b1"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"3eef12eb4b42493959b9c86c552a9a518a362457","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"21fdbfdd_ea54eaca","updated":"2025-03-10 14:15:13.000000000","message":"Looks good to me. I added a comment against the release notes that should/might be confirmed by other reviewers.","commit_id":"a265c5070bd0f83d9352218f9de9475416a132b1"}],"releasenotes/notes/fix-refresh-secondary-zone-task-79f68d3f7377181c.yaml":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"3eef12eb4b42493959b9c86c552a9a518a362457","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Refresh secondary zone task was broken. It failed all the time."},{"line_number":5,"context_line":"    If MDNS didn\u0027t get NOTIFY from master server, the secondary zone didn\u0027t get"},{"line_number":6,"context_line":"    updates. Now it\u0027s fixed."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"026d7abf_74d5be13","line":6,"range":{"start_line":4,"start_character":4,"end_line":6,"end_character":28},"updated":"2025-03-10 14:15:13.000000000","message":"I think it is the worker that sends the NOTIFY to the secondary zone. But core/other reviewers will confirm.","commit_id":"a265c5070bd0f83d9352218f9de9475416a132b1"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"a26f345ff8d5a997022b9236bb882b12250e00b5","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Refresh secondary zone task was broken. It failed all the time."},{"line_number":5,"context_line":"    If MDNS didn\u0027t get NOTIFY from master server, the secondary zone didn\u0027t get"},{"line_number":6,"context_line":"    updates. Now it\u0027s fixed."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"35fc6ba4_567242eb","line":6,"range":{"start_line":4,"start_character":4,"end_line":6,"end_character":28},"in_reply_to":"026d7abf_74d5be13","updated":"2025-03-11 00:44:23.000000000","message":"No, they are right. In the case of a secondary zone, it is the primary server\u0027s job to send a NOTIFY on zone update. Worker only sends NOTIFY for primary zones hosted in Designate.","commit_id":"a265c5070bd0f83d9352218f9de9475416a132b1"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"7d913bdbfc9fe9fc979c36812bba1ce3a91d82ba","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Refresh secondary zone task was broken. It failed all the time."},{"line_number":5,"context_line":"    If MDNS didn\u0027t get NOTIFY from master server, the secondary zone didn\u0027t get"},{"line_number":6,"context_line":"    updates. Now it\u0027s fixed."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3e460bdd_b9109d27","line":6,"range":{"start_line":4,"start_character":4,"end_line":6,"end_character":28},"in_reply_to":"35fc6ba4_567242eb","updated":"2025-03-11 09:09:59.000000000","message":"Cool. I also made sure that the bug mentioned in the commit message is fixed, and it works.","commit_id":"a265c5070bd0f83d9352218f9de9475416a132b1"}]}