)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"56f25568537908bad7c5e3ae115512e0f08a3fe2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a8bb3702_04f77aa1","updated":"2025-04-15 16:46:46.000000000","message":"I am still missing tests and release notes","commit_id":"9232613c1c228479a7592a4afc99ebbf4a60c2a2"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"0acd8317826e618abb7f65e6de7459de9b96759e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c52bb491_296c64de","updated":"2025-04-16 13:43:30.000000000","message":"I am still missing tests and release notes","commit_id":"ced2771c948c689be8c9dd0ef60227c6c9392788"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"c7280d67b24a850de3312a5663b35a03a2b0a478","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"3add1ef6_2346c36a","updated":"2025-04-21 23:26:50.000000000","message":"recheck gerrit was down","commit_id":"d62e36a6b6f056ca9218bcaca7f907d29e4418d6"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"70c320e3f373c597e5de985be1f80e6ead8868ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"ab00c893_0ba5f01b","updated":"2025-09-22 12:23:52.000000000","message":"Hey Erik, I missed your comment back then, thanks.\nI tried this commit lately and I had an issue with Keystone authentication in the Neutron client. It looks like it is working now, but I still have some work to do in the patch.","commit_id":"e3cba95124f240ee3dd242c2e161b5e0f8554ed2"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"2f152f21f5bd71bf82c81cd57cf412f5af467109","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"0f88afd0_fef742e8","updated":"2025-04-23 15:07:59.000000000","message":"Thanks Erik, done","commit_id":"e3cba95124f240ee3dd242c2e161b5e0f8554ed2"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"95e1f200ac1d57da328bb323404a010822873e2e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"9d500b42_903947c0","updated":"2025-05-09 09:05:47.000000000","message":"This was actually meant for another PR, but noticed it here too","commit_id":"e3cba95124f240ee3dd242c2e161b5e0f8554ed2"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"d16c7f3b2d1a4988e7d79dc69ff4a2a053219a68","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"e5fd2d96_1e487048","updated":"2025-11-07 00:54:35.000000000","message":"Still a lot of coverage missing, but I suspect that is related to issues with the coverage plugin itself","commit_id":"c82aafbfef74dce759fd7ba91236ea918fc15c2f"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"4a071e7315984ff4169b242cb37e81f0c5f12f50","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"20ef97b8_25841117","updated":"2025-10-24 16:58:05.000000000","message":"recheck failure is not related to the patch","commit_id":"c82aafbfef74dce759fd7ba91236ea918fc15c2f"}],"designate/central/service.py":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"6d78489456d1fca15a8b454db69f72222748c237","unresolved":true,"context_lines":[{"line_number":1788,"context_line":""},{"line_number":1789,"context_line":"            all_ptr_records \u003d self.find_records(elevated_context, criterion)"},{"line_number":1790,"context_line":"            if not all_ptr_records:"},{"line_number":1791,"context_line":"                LOG.warning(\u0027No PTR records were found. This is weird, because\u0027"},{"line_number":1792,"context_line":"                            f\u0027 provided parameter {ptr_records} should have \u0027"},{"line_number":1793,"context_line":"                            \u0027led to at least one ptr record to be found. \u0027"},{"line_number":1794,"context_line":"                            \u0027Skipping as this is a delete method.\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"96384794_8f5fd3d6","line":1791,"updated":"2025-04-23 13:32:33.000000000","message":"All logs should be lazy loaded.","commit_id":"b13564f6dcd0a3c6a2954df84ee66aa5d163e65f"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"2f152f21f5bd71bf82c81cd57cf412f5af467109","unresolved":false,"context_lines":[{"line_number":1788,"context_line":""},{"line_number":1789,"context_line":"            all_ptr_records \u003d self.find_records(elevated_context, criterion)"},{"line_number":1790,"context_line":"            if not all_ptr_records:"},{"line_number":1791,"context_line":"                LOG.warning(\u0027No PTR records were found. This is weird, because\u0027"},{"line_number":1792,"context_line":"                            f\u0027 provided parameter {ptr_records} should have \u0027"},{"line_number":1793,"context_line":"                            \u0027led to at least one ptr record to be found. \u0027"},{"line_number":1794,"context_line":"                            \u0027Skipping as this is a delete method.\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"b17ced6b_ef967acd","line":1791,"in_reply_to":"96384794_8f5fd3d6","updated":"2025-04-23 15:07:59.000000000","message":"Done","commit_id":"b13564f6dcd0a3c6a2954df84ee66aa5d163e65f"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"6d78489456d1fca15a8b454db69f72222748c237","unresolved":true,"context_lines":[{"line_number":1810,"context_line":""},{"line_number":1811,"context_line":"        for record in ptr_records:"},{"line_number":1812,"context_line":"            try:"},{"line_number":1813,"context_line":"                LOG.debug(f\u0027Deleting PTR record {record.id} for FIP \u0027"},{"line_number":1814,"context_line":"                          f\u0027{record.managed_resource_id}\u0027)"},{"line_number":1815,"context_line":"                self._delete_or_update_managed_recordset("},{"line_number":1816,"context_line":"                    elevated_context,"}],"source_content_type":"text/x-python","patch_set":10,"id":"b2594906_e95b59e5","line":1813,"updated":"2025-04-23 13:32:33.000000000","message":"Same here.","commit_id":"b13564f6dcd0a3c6a2954df84ee66aa5d163e65f"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"2f152f21f5bd71bf82c81cd57cf412f5af467109","unresolved":false,"context_lines":[{"line_number":1810,"context_line":""},{"line_number":1811,"context_line":"        for record in ptr_records:"},{"line_number":1812,"context_line":"            try:"},{"line_number":1813,"context_line":"                LOG.debug(f\u0027Deleting PTR record {record.id} for FIP \u0027"},{"line_number":1814,"context_line":"                          f\u0027{record.managed_resource_id}\u0027)"},{"line_number":1815,"context_line":"                self._delete_or_update_managed_recordset("},{"line_number":1816,"context_line":"                    elevated_context,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ed8bf4d_57174852","line":1813,"in_reply_to":"b2594906_e95b59e5","updated":"2025-04-23 15:07:59.000000000","message":"Done","commit_id":"b13564f6dcd0a3c6a2954df84ee66aa5d163e65f"}],"designate/producer/tasks.py":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"95e1f200ac1d57da328bb323404a010822873e2e","unresolved":true,"context_lines":[{"line_number":377,"context_line":""},{"line_number":378,"context_line":"        if stale_ptr_ids:"},{"line_number":379,"context_line":"            context \u003d DesignateContext().elevated()"},{"line_number":380,"context_line":"            LOG.debug(f\u0027Removing the following ptr records: {stale_ptr_ids} as\u0027"},{"line_number":381,"context_line":"                      \u0027 they are not associated to any FIP (\"stale\")\u0027)"},{"line_number":382,"context_line":"            self.central_api.delete_ptr_records(context, stale_ptr_ids)"}],"source_content_type":"text/x-python","patch_set":11,"id":"3cb17145_de207697","line":380,"updated":"2025-05-09 09:05:47.000000000","message":"Keep using %-style for now, especially for DEBUG logs.","commit_id":"e3cba95124f240ee3dd242c2e161b5e0f8554ed2"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"009d7966bda181fbd5d58ae1671ec38af327f340","unresolved":true,"context_lines":[{"line_number":394,"context_line":"                           ptr_record.id, clean_fip_id)"},{"line_number":395,"context_line":"                    stale_ptr_records.append(ptr_record)"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"            if stale_ptr_records:"},{"line_number":398,"context_line":"                context_elevated \u003d DesignateContext().elevated("},{"line_number":399,"context_line":"                    all_tenants\u003dTrue, edit_managed_records\u003dTrue)"},{"line_number":400,"context_line":"                deleted_count \u003d 0"}],"source_content_type":"text/x-python","patch_set":18,"id":"aec202ab_a558e609","line":397,"updated":"2025-09-26 13:34:45.000000000","message":"This code feels a bit rough to read and must be a nightmare to unit test. Probably worth breaking it into separate functions. You could probably inverse an if statement or two as well to reduce the indentation depth.","commit_id":"1db3391f7505b37bdc2b7e4e6f48169140da441f"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"2d269cbf8af8f0fee427f26d624c002d0cd1bc4d","unresolved":true,"context_lines":[{"line_number":394,"context_line":"                           ptr_record.id, clean_fip_id)"},{"line_number":395,"context_line":"                    stale_ptr_records.append(ptr_record)"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"            if stale_ptr_records:"},{"line_number":398,"context_line":"                context_elevated \u003d DesignateContext().elevated("},{"line_number":399,"context_line":"                    all_tenants\u003dTrue, edit_managed_records\u003dTrue)"},{"line_number":400,"context_line":"                deleted_count \u003d 0"}],"source_content_type":"text/x-python","patch_set":18,"id":"f85d72f7_f92f64ea","line":397,"in_reply_to":"aec202ab_a558e609","updated":"2025-09-26 14:47:45.000000000","message":"I agree, I will upload another patch set then.","commit_id":"1db3391f7505b37bdc2b7e4e6f48169140da441f"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"404ec6c21b20c7d21c9a31d73c6b04ae9b1b8566","unresolved":false,"context_lines":[{"line_number":394,"context_line":"                           ptr_record.id, clean_fip_id)"},{"line_number":395,"context_line":"                    stale_ptr_records.append(ptr_record)"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"            if stale_ptr_records:"},{"line_number":398,"context_line":"                context_elevated \u003d DesignateContext().elevated("},{"line_number":399,"context_line":"                    all_tenants\u003dTrue, edit_managed_records\u003dTrue)"},{"line_number":400,"context_line":"                deleted_count \u003d 0"}],"source_content_type":"text/x-python","patch_set":18,"id":"8faa1566_10480137","line":397,"in_reply_to":"f85d72f7_f92f64ea","updated":"2025-09-29 14:37:32.000000000","message":"Done","commit_id":"1db3391f7505b37bdc2b7e4e6f48169140da441f"}]}