)]}'
{"designate/backend/impl_bind9.py":[{"author":{"_account_id":2064,"name":"Loic Dachary","email":"loic@dachary.org","username":"dachary"},"change_message_id":"209c769b5c67ed3d64da611fe8ca37fdc9028533","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            except utils.processutils.ProcessExecutionError as proc_exec_err:"},{"line_number":58,"context_line":"                if proc_exec_err.stderr.count(\"not found\") is not 0:"},{"line_number":59,"context_line":"                    LOG.debug(\"Create Missing Domain\")"},{"line_number":60,"context_line":"                    self._sync_domain(domain, new_domain_flag\u003dTrue)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def create_server(self, context, server):"},{"line_number":63,"context_line":"        LOG.debug(\u0027Create Server\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5adbc538_312cd84a","line":60,"updated":"2014-05-24 06:59:08.000000000","message":"would it make sense to raise if \"not found\" is not in the stderr ? otherwise it will silently ignore the error","commit_id":"70b171909e29f1bdb805a741f2b8d169db78a5bf"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"00ac3faed7ef4e385dbab545e59107bde9f7dbbc","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            except utils.processutils.ProcessExecutionError as proc_exec_err:"},{"line_number":58,"context_line":"                if proc_exec_err.stderr.count(\"not found\") is not 0:"},{"line_number":59,"context_line":"                    LOG.debug(\"Create Missing Domain\")"},{"line_number":60,"context_line":"                    self._sync_domain(domain, new_domain_flag\u003dTrue)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def create_server(self, context, server):"},{"line_number":63,"context_line":"        LOG.debug(\u0027Create Server\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5adbc538_6cb4c3f2","line":60,"in_reply_to":"5adbc538_312cd84a","updated":"2014-05-24 14:05:46.000000000","message":"It looks to me like it will correct the error, so raising is probably too much.\n\nA clearer log message at warning level would be better though.\n\ne.g. Domain X missing from backend, recreating.","commit_id":"70b171909e29f1bdb805a741f2b8d169db78a5bf"},{"author":{"_account_id":8130,"name":"Betsy Luzader","email":"betsy.luzader@rackspace.com","username":"bluzader"},"change_message_id":"d525da7f83ba40c52f530a65892eb1950997ccbc","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                    self._sync_domain(domain, new_domain_flag\u003dTrue)"},{"line_number":62,"context_line":"                else:"},{"line_number":63,"context_line":"                    raise proc_exec_err"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def create_server(self, context, server):"},{"line_number":66,"context_line":"        LOG.debug(\u0027Create Server\u0027)"},{"line_number":67,"context_line":"        self._sync_domains_on_server_change()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3ae8d1ca_023cdc2e","line":64,"updated":"2014-05-27 14:03:48.000000000","message":"I agree with Kiall\u0027s suggestion from Patch 1 that the LOG.debug message could be clearer. He suggested something like \"Domain X missing from backend, recreating\"","commit_id":"bb7d3327eba74f1d96fd11750107287d52ab2af7"}]}