)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f1683da583a1d0fc938ba2b563f6ed1bb9775102","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"d25a2f2e_9bc2a00e","updated":"2025-09-03 10:13:54.000000000","message":"recheck we have some suggested fixes for those ptr tests that fail every now and then. After we finish with eventlet we might want to focus on those.","commit_id":"b13d69241502f1c19b1289a9207d4cebed563197"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"d47739e901fbc08a31f6c42ded607fe6da614963","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"9d2de8f8_be348240","updated":"2025-10-09 10:51:34.000000000","message":"recheck PTR records test failure","commit_id":"bb7afa99aed5ecd777052fabcf73275f37028dff"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"354906a48ab4a1edf5b98d416aa1d58adc382da0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"7c3f47df_f54ae2ff","updated":"2025-10-15 08:15:44.000000000","message":"recheck failure is not related to patch","commit_id":"f92bfb2d43d70873185e83b3dc583e50cd5f0fd9"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"1b2812edbfdb5d08e055df2caad7532eefa0fc9f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"6a908f87_f80da679","updated":"2025-10-16 11:28:10.000000000","message":"recheck failure is not related to the patch","commit_id":"6cc5f798978cedbb04d904dca804481ca83995d7"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"2a9fa66d1e20bb200868e4ee85712f135362e161","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":35,"id":"aefc7d2b_e81e4308","updated":"2025-11-05 16:21:57.000000000","message":"recheck change it not related to the patch","commit_id":"a500473575242c2000a3e61b5772420faf30f564"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"b54d6bc1c0c0b1dfb39bc98ea2b49312110b9d92","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":38,"id":"9f3ef8c5_b0c04c07","updated":"2026-01-20 19:02:41.000000000","message":"Gerrit UI complains about conflicts again, I will rebase via cli","commit_id":"204a0f940e898861d5fb0c6e23c3e98bb64e133e"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"70d275c3c099a3e7933fd7c0dfdceda5d86b17a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":38,"id":"8bd3374b_f2c16f05","updated":"2026-01-15 21:31:16.000000000","message":"LGTM\nThe only potential change here is if we fix the rpc.init() duplication here (could be done in a followup patch though).","commit_id":"204a0f940e898861d5fb0c6e23c3e98bb64e133e"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"e6026c704577f65909b34ffe5e37fa870dc237e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":39,"id":"551de01c_f9a344d7","updated":"2026-01-21 09:10:30.000000000","message":"recheck failure is not related to the patch","commit_id":"000d8b02c1e3a9f100bbfe3b4c6480e16fabbcd6"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"300bba3edd4ebb26c8290e7434e038ddd0f7c97a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":39,"id":"6291dce6_f11418b1","updated":"2026-01-21 00:36:34.000000000","message":"recheck failure is not related to the patch","commit_id":"000d8b02c1e3a9f100bbfe3b4c6480e16fabbcd6"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"18c010e790eeaab9d20e63287599b24b1481ad39","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":39,"id":"943ee9c5_ae2f1f5f","updated":"2026-01-21 10:49:38.000000000","message":"recheck failure is not related to the patch","commit_id":"000d8b02c1e3a9f100bbfe3b4c6480e16fabbcd6"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"6c2f1f5c58516ecb31bdbc62da090243c35fcaba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":40,"id":"08163093_255ba189","updated":"2026-02-05 21:20:56.000000000","message":"LGTM","commit_id":"8f61861435de142a0f719b1df6454cf926b27f1b"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"814e91caf7520f7e64a4f413b5975dda6718750d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":40,"id":"cf6ed5bb_2bec119e","updated":"2026-02-06 17:43:43.000000000","message":"recheck\nnova failed to create a server","commit_id":"8f61861435de142a0f719b1df6454cf926b27f1b"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"5bf1cf65538934e823efad5c69a33d9058fcb59e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":40,"id":"c14f62ee_5e727d65","updated":"2026-02-06 16:04:52.000000000","message":"recheck\ntest_create_and_delete_records_on_existing_zone_13_CAA failure","commit_id":"8f61861435de142a0f719b1df6454cf926b27f1b"}],"designate/cmd/threading/sink.py":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"63e9260a51be7dd3bb5e7f4c02ad22885cf2757d","unresolved":true,"context_lines":[{"line_number":43,"context_line":"    try:"},{"line_number":44,"context_line":"        service.wait()"},{"line_number":45,"context_line":"    finally:"},{"line_number":46,"context_line":"        if heartbeat:"},{"line_number":47,"context_line":"            heartbeat.stop()"}],"source_content_type":"text/x-python","patch_set":15,"id":"4643c6d5_c5eede8a","line":46,"updated":"2025-08-15 10:56:25.000000000","message":"Is there a reason you put the if statement here? I feel like there shouldn\u0027t be a scenario where it could be null (without failing the start first)?","commit_id":"8375ae9b2febcf615c50cfa8f93d46aed8d74fdd"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"85e9cc93cb49bf82275d6872e4319d10d0b66594","unresolved":true,"context_lines":[{"line_number":43,"context_line":"    try:"},{"line_number":44,"context_line":"        service.wait()"},{"line_number":45,"context_line":"    finally:"},{"line_number":46,"context_line":"        if heartbeat:"},{"line_number":47,"context_line":"            heartbeat.stop()"}],"source_content_type":"text/x-python","patch_set":15,"id":"e594dc29_f094188d","line":46,"in_reply_to":"4643c6d5_c5eede8a","updated":"2025-08-18 08:58:36.000000000","message":"Ok, I just tried commenting line #46 and it looks safe on my devstack env. \nThe important part for me was the heartbeat.stop(). I will upload a new patch set, thanks.","commit_id":"8375ae9b2febcf615c50cfa8f93d46aed8d74fdd"}],"designate/sink/service.py":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"629e0a5c713a24681ea5399be49721b64606fd38","unresolved":true,"context_lines":[{"line_number":75,"context_line":"        super().start()"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        heartbeat \u003d heartbeat_emitter.get_heartbeat_emitter(self.service_name)"},{"line_number":78,"context_line":"        heartbeat.start()"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        # Setup notification subscriptions and start consuming"},{"line_number":81,"context_line":"        targets \u003d self._get_targets()"}],"source_content_type":"text/x-python","patch_set":14,"id":"8d0229d9_a734974a","line":78,"updated":"2025-08-13 07:17:39.000000000","message":"This is likely not an ok change. We intentionally moved this out of start, as it will create one heartbeat per thread. If you have a lot of CPUS that means an excessive amount of heartbeats sent.","commit_id":"3b59fd3fdc13b3676d1cc0b8eadb0b388a015d7b"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"feca3194c2f0fd3252bf97faabce9f2ce5e3c745","unresolved":true,"context_lines":[{"line_number":75,"context_line":"        super().start()"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        heartbeat \u003d heartbeat_emitter.get_heartbeat_emitter(self.service_name)"},{"line_number":78,"context_line":"        heartbeat.start()"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        # Setup notification subscriptions and start consuming"},{"line_number":81,"context_line":"        targets \u003d self._get_targets()"}],"source_content_type":"text/x-python","patch_set":14,"id":"95a43c61_3da6b396","line":78,"in_reply_to":"8d0229d9_a734974a","updated":"2025-08-13 10:38:23.000000000","message":"hmm, right, ok. I would like to explain what is the problem that I am facing: because eventlet creates green threads, it is easier to terminate the heartbeat threads as they just yield.\n\nbut with the migration to native threads I see that every time I restart sink (or many other designate services), it hangs until systemd kills it, depends on the value we set TimeoutStopSec to be, in the service unit file.\n\nAnother mechanism that worked for me is using:\n\n    try:\n        service.wait()\n    finally:\n        if heartbeat:\n            heartbeat.stop()\n\ninstead of just service.wait()\n\nI will upload it in the next patch set, please let me know what are your thoughts about it.","commit_id":"3b59fd3fdc13b3676d1cc0b8eadb0b388a015d7b"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"e2e521c1b00495c3cdec8c63c00c6f49559ed8c3","unresolved":true,"context_lines":[{"line_number":75,"context_line":"        super().start()"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        heartbeat \u003d heartbeat_emitter.get_heartbeat_emitter(self.service_name)"},{"line_number":78,"context_line":"        heartbeat.start()"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        # Setup notification subscriptions and start consuming"},{"line_number":81,"context_line":"        targets \u003d self._get_targets()"}],"source_content_type":"text/x-python","patch_set":14,"id":"a3c880b3_e85756e8","line":78,"in_reply_to":"95a43c61_3da6b396","updated":"2025-08-15 10:54:55.000000000","message":"Sounds good. That is something I spent a lot of time trying to fix even with Eventlet as well.","commit_id":"3b59fd3fdc13b3676d1cc0b8eadb0b388a015d7b"}]}