)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a11677588eb85be283aa91f642d5da0924db5603","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ffa55512_7b43f61c","updated":"2025-08-25 12:47:42.000000000","message":"Nice update","commit_id":"34a36c78b6ba9b6796b354fc4b9e7661b1859dd7"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"89f7c1abdb4543fc2444cbd9791f91d2d94a48f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"16b88805_55124c8a","updated":"2026-01-06 22:25:27.000000000","message":"I think this can be simplified by not moving some of the global init out of the root _init_.py and reduce duplicated code in multiple modules.\nOtherwise this looks ok to me.","commit_id":"de65267c997e751e5caa862f4d8bcb45eb42de51"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"6885bd0b1edc8806ce72ea183a2f021b0544e940","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"1a52bc90_a2b38122","in_reply_to":"135e6975_111e2424","updated":"2026-01-08 13:43:50.000000000","message":"Done","commit_id":"de65267c997e751e5caa862f4d8bcb45eb42de51"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"df720920b2176a32abb0374e7adc724cb677b643","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"135e6975_111e2424","in_reply_to":"16b88805_55124c8a","updated":"2026-01-07 16:50:37.000000000","message":"Yeah I agree, I will fix it in the next patch set, I guess it will pass CI, thanks.","commit_id":"de65267c997e751e5caa862f4d8bcb45eb42de51"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"483316a9161dc6a627b4fff5097dfa1cb22425d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"04c5665b_0ee1b0f0","updated":"2026-01-07 21:18:33.000000000","message":"I am reverting the changes I did so this patch will pass CI and I could test if the second patch passes CI with its changes","commit_id":"552bbd4f3634306c6858fa26ae4a89e1ce1d4f20"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"411731a7e3a265b9d8242574ccc39078a8bdfe21","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"c40cfc29_c30089da","updated":"2026-01-09 15:07:32.000000000","message":"I am not sure why CI doesn\u0027t run, I will try to rebase it on top of the master branch","commit_id":"9ed8f9b83d68f9b39215521963f38fa227deda8d"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"88875cb18588415d3f0b9c95a2c904701a4aa57a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"9ba323dd_7c575ef0","updated":"2026-01-09 00:12:41.000000000","message":"LGTM","commit_id":"9ed8f9b83d68f9b39215521963f38fa227deda8d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"5eaa38bb5fd05869828c1734283649dc9e2fc9b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"6c01774c_4ea462e5","updated":"2026-01-08 04:36:59.000000000","message":"recheck failure is not related to the patch","commit_id":"9ed8f9b83d68f9b39215521963f38fa227deda8d"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"ed13f74c48f2fbefd2167097878633b9755f3ab4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"29e5c0ee_19967323","updated":"2026-01-09 16:49:12.000000000","message":"recheck failure is not related to the patch","commit_id":"c1a482a673d0c39ca750cc980bda53992358872d"}],"designate/__init__.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"89f7c1abdb4543fc2444cbd9791f91d2d94a48f3","unresolved":true,"context_lines":[{"line_number":19,"context_line":"# the /etc/hosts file, causing problems for installs."},{"line_number":20,"context_line":"os.environ[\u0027EVENTLET_NO_GREENDNS\u0027] \u003d \u0027yes\u0027  # noqa"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslo_log import log  # noqa"},{"line_number":23,"context_line":"from oslo_concurrency import lockutils  # noqa"},{"line_number":24,"context_line":"import oslo_messaging as messaging  # noqa"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"c12ed643_6f1cfe9f","side":"PARENT","line":22,"updated":"2026-01-06 22:25:27.000000000","message":"Why not leave these lines 22 to 41 here instead of duplicating them in both the eventlet and threading backend?","commit_id":"e773de35e72ee46a3eced71e2678342271fc692f"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"6885bd0b1edc8806ce72ea183a2f021b0544e940","unresolved":false,"context_lines":[{"line_number":19,"context_line":"# the /etc/hosts file, causing problems for installs."},{"line_number":20,"context_line":"os.environ[\u0027EVENTLET_NO_GREENDNS\u0027] \u003d \u0027yes\u0027  # noqa"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from oslo_log import log  # noqa"},{"line_number":23,"context_line":"from oslo_concurrency import lockutils  # noqa"},{"line_number":24,"context_line":"import oslo_messaging as messaging  # noqa"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"7df81c43_f21143f7","side":"PARENT","line":22,"in_reply_to":"c12ed643_6f1cfe9f","updated":"2026-01-08 13:43:50.000000000","message":"Done","commit_id":"e773de35e72ee46a3eced71e2678342271fc692f"}],"designate/api/wsgi.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"89f7c1abdb4543fc2444cbd9791f91d2d94a48f3","unresolved":true,"context_lines":[{"line_number":20,"context_line":"except service.exceptions.BackendAlreadySelected:"},{"line_number":21,"context_line":"    pass"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from oslo_concurrency import lockutils"},{"line_number":24,"context_line":"from oslo_config import cfg"},{"line_number":25,"context_line":"from oslo_log import log as logging"},{"line_number":26,"context_line":"import oslo_messaging as messaging"}],"source_content_type":"text/x-python","patch_set":8,"id":"ada17459_77842ba3","line":23,"updated":"2026-01-06 22:25:27.000000000","message":"I don\u0027t think these changes (23-50) are needed if we leave them in the root _init_.py.","commit_id":"de65267c997e751e5caa862f4d8bcb45eb42de51"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"6885bd0b1edc8806ce72ea183a2f021b0544e940","unresolved":false,"context_lines":[{"line_number":20,"context_line":"except service.exceptions.BackendAlreadySelected:"},{"line_number":21,"context_line":"    pass"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from oslo_concurrency import lockutils"},{"line_number":24,"context_line":"from oslo_config import cfg"},{"line_number":25,"context_line":"from oslo_log import log as logging"},{"line_number":26,"context_line":"import oslo_messaging as messaging"}],"source_content_type":"text/x-python","patch_set":8,"id":"5d2c0113_1982b342","line":23,"in_reply_to":"ada17459_77842ba3","updated":"2026-01-08 13:43:50.000000000","message":"Done","commit_id":"de65267c997e751e5caa862f4d8bcb45eb42de51"}],"designate/cmd/eventlet/__init__.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"89f7c1abdb4543fc2444cbd9791f91d2d94a48f3","unresolved":true,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"eventlet.monkey_patch(os\u003dFalse)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from oslo_log import log  # noqa"},{"line_number":27,"context_line":"from oslo_concurrency import lockutils  # noqa"},{"line_number":28,"context_line":"import oslo_messaging as messaging  # noqa"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"821fbc22_0cd49dc2","line":26,"updated":"2026-01-06 22:25:27.000000000","message":"Same comments here as in the threading _init_.py, these are all the same as they were in the root _init_.py. Can\u0027t we just leave them there and not duplicate code?","commit_id":"de65267c997e751e5caa862f4d8bcb45eb42de51"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"6885bd0b1edc8806ce72ea183a2f021b0544e940","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"eventlet.monkey_patch(os\u003dFalse)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from oslo_log import log  # noqa"},{"line_number":27,"context_line":"from oslo_concurrency import lockutils  # noqa"},{"line_number":28,"context_line":"import oslo_messaging as messaging  # noqa"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"a4dbe030_1ea0a14e","line":26,"in_reply_to":"821fbc22_0cd49dc2","updated":"2026-01-08 13:43:50.000000000","message":"Done","commit_id":"de65267c997e751e5caa862f4d8bcb45eb42de51"}],"designate/cmd/threading/__init__.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"89f7c1abdb4543fc2444cbd9791f91d2d94a48f3","unresolved":true,"context_lines":[{"line_number":21,"context_line":"except service.exceptions.BackendAlreadySelected:"},{"line_number":22,"context_line":"    pass"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from oslo_log import log  # noqa"},{"line_number":25,"context_line":"from oslo_concurrency import lockutils  # noqa"},{"line_number":26,"context_line":"import oslo_messaging as messaging  # noqa"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1434ba96_e6b149c3","line":24,"updated":"2026-01-06 22:25:27.000000000","message":"All of this from line 24 down is the same as it was at the root _init_.py and is duplicated in both the threading and eventlet _init_.py\u0027s. Can\u0027t we just leave them at the root _init_.py and not duplicate code?","commit_id":"de65267c997e751e5caa862f4d8bcb45eb42de51"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"89f7c1abdb4543fc2444cbd9791f91d2d94a48f3","unresolved":true,"context_lines":[{"line_number":21,"context_line":"except service.exceptions.BackendAlreadySelected:"},{"line_number":22,"context_line":"    pass"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from oslo_log import log  # noqa"},{"line_number":25,"context_line":"from oslo_concurrency import lockutils  # noqa"},{"line_number":26,"context_line":"import oslo_messaging as messaging  # noqa"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"6720d47d_9124083c","line":24,"updated":"2026-01-06 22:25:27.000000000","message":"Do we really need noqa on these? They are used below.","commit_id":"de65267c997e751e5caa862f4d8bcb45eb42de51"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"6885bd0b1edc8806ce72ea183a2f021b0544e940","unresolved":false,"context_lines":[{"line_number":21,"context_line":"except service.exceptions.BackendAlreadySelected:"},{"line_number":22,"context_line":"    pass"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from oslo_log import log  # noqa"},{"line_number":25,"context_line":"from oslo_concurrency import lockutils  # noqa"},{"line_number":26,"context_line":"import oslo_messaging as messaging  # noqa"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ffdf1262_20b96f94","line":24,"in_reply_to":"1434ba96_e6b149c3","updated":"2026-01-08 13:43:50.000000000","message":"Done","commit_id":"de65267c997e751e5caa862f4d8bcb45eb42de51"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"6885bd0b1edc8806ce72ea183a2f021b0544e940","unresolved":false,"context_lines":[{"line_number":21,"context_line":"except service.exceptions.BackendAlreadySelected:"},{"line_number":22,"context_line":"    pass"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from oslo_log import log  # noqa"},{"line_number":25,"context_line":"from oslo_concurrency import lockutils  # noqa"},{"line_number":26,"context_line":"import oslo_messaging as messaging  # noqa"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"03342834_12d20652","line":24,"in_reply_to":"6720d47d_9124083c","updated":"2026-01-08 13:43:50.000000000","message":"Done","commit_id":"de65267c997e751e5caa862f4d8bcb45eb42de51"}]}