)]}'
{"id":"openstack%2Fdesignate~961250","triplet_id":"openstack%2Fdesignate~master~I89c5ef0645f9688afb16c6d3c48b55f9c52b6d76","project":"openstack/designate","branch":"master","topic":"bug_1802227","attention_set":{"31664":{"account":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"last_update":"2025-09-21 12:19:20.000000000","reason":"\u003cGERRIT_ACCOUNT_22623\u003e replied on the change","reason_account":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I89c5ef0645f9688afb16c6d3c48b55f9c52b6d76","subject":"Fix zone deletion failure with BIND recursion enabled","status":"NEW","created":"2025-09-15 14:51:33.000000000","updated":"2025-09-21 12:19:20.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":false,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"999f97ffa28da682826182da9b13ab85bcc37786","_number":961250,"virtual_id_number":961250,"owner":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2025-09-15 16:11:49.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2025-09-21 12:19:20.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-09-15 16:11:49.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-09-21 12:19:20.000000000","updated_by":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"reviewer":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"state":"REVIEWER"}],"messages":[{"id":"4fe82be68ba58ada3d46e918c20b580f1263c53e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"date":"2025-09-15 14:51:33.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4dd5af7fb73cdecb94fb8ad3a3acc94a9d339c5a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"date":"2025-09-15 14:57:56.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"2aa57881c21035623992846178ca116dd9f8980d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-09-15 16:11:49.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/ba661d19d346467cb1f1653da8fde202\n\n- designate-grenade-bind9 https://zuul.opendev.org/t/openstack/build/85ea890d470d40ecbb0045c6806d2410 : SUCCESS in 1h 02m 14s\n- designate-grenade-pdns4 https://zuul.opendev.org/t/openstack/build/0ee2c8c7113e45e9b1d98804f4a3d806 : SUCCESS in 1h 07m 36s\n- designate-grenade-bind9-skip-level https://zuul.opendev.org/t/openstack/build/572bf913fba4451286045a9b26cbdc58 : SUCCESS in 1h 02m 44s\n- designate-grenade-pdns4-skip-level https://zuul.opendev.org/t/openstack/build/0ae84c5de30342919a3f8b642b4c5553 : SUCCESS in 1h 05m 20s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/f3f1fc7d07564b3e9a63282c7ea8fa60 : SUCCESS in 8m 49s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/642e07cec5cb41c2ab19ab0d904b31e0 : SUCCESS in 3m 30s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/e61c60fe82e64e3d8f681583fb41535d : SUCCESS in 6m 37s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/4d1f557a1f5645bdb1a48e5fd8f7e3f0 : SUCCESS in 5m 05s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/54b6fb0f4d8c4e589aab985146eb1a81 : SUCCESS in 9m 15s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b066f99ade964486bfb901fc3f18e577 : SUCCESS in 7m 15s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/a7f05e6f59e14979a2ce50e674025c77 : SUCCESS in 6m 35s\n- neutron-tempest-plugin-designate-scenario https://zuul.opendev.org/t/openstack/build/17772d3ca06a4e8babf003a529a811e7 : SUCCESS in 35m 10s\n- designate-tox-dnspython-latest https://zuul.opendev.org/t/openstack/build/6b717551f4914320a57eeb0dbdf13da4 : SUCCESS in 7m 06s","accounts_in_message":[],"_revision_number":2},{"id":"999f97ffa28da682826182da9b13ab85bcc37786","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2025-09-21 12:19:20.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"c21c22c626a1954503f7c9c3385011d393676206","revisions":{"49ab69c761c32f0764d828d8a46943dafca31c5c":{"kind":"REWORK","_number":1,"created":"2025-09-15 14:51:33.000000000","uploader":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"ref":"refs/changes/50/961250/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/designate","ref":"refs/changes/50/961250/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/designate refs/changes/50/961250/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/designate refs/changes/50/961250/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/designate refs/changes/50/961250/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/designate refs/changes/50/961250/1"}}},"commit":{"parents":[{"commit":"abce3bd94b243deb2fb5805d76609d11a4818fc7","subject":"Update master for stable/2025.2","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/abce3bd94b243deb2fb5805d76609d11a4818fc7"}]}],"author":{"name":"Omer","email":"oschwart@redhat.com","date":"2025-09-15 12:52:22.000000000","tz":0},"committer":{"name":"Omer","email":"oschwart@redhat.com","date":"2025-09-15 14:50:51.000000000","tz":0},"subject":"Fix zone deletion failure with BIND recursion enabled","message":"Fix zone deletion failure with BIND recursion enabled\n\nWhen BIND9 is configured with both authoritative and recursive roles,\nzone deletion can fail because get_serial() incorrectly interprets\nnon-authoritative recursive responses as evidence that the zone still\nexists locally.\n\nAfter a zone is deleted from the authoritative server, BIND may still\nreturn SOA records for the zone by querying upstream nameservers via\nrecursion. The original code only checked for the presence of answer\nrecords and serial numbers, not whether the response was authoritative.\n\nThis fix checks the DNS response flags:\n- If AA (Authoritative Answer) flag is not set AND\n- RA (Recursion Available) flag is set\nget_serial will return 0 to indicate the zone doesn\u0027t exist locally.\n\nCloses-Bug: #1802227\nAssisted-By: Cursor (claude-4-sonnet)\nChange-Id: I89c5ef0645f9688afb16c6d3c48b55f9c52b6d76\nSigned-off-by: Omer \u003coschwart@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/49ab69c761c32f0764d828d8a46943dafca31c5c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/49ab69c761c32f0764d828d8a46943dafca31c5c"}]},"branch":"refs/heads/master"},"c21c22c626a1954503f7c9c3385011d393676206":{"kind":"REWORK","_number":2,"created":"2025-09-15 14:57:56.000000000","uploader":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"ref":"refs/changes/50/961250/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/designate","ref":"refs/changes/50/961250/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/designate refs/changes/50/961250/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/designate refs/changes/50/961250/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/designate refs/changes/50/961250/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/designate refs/changes/50/961250/2"}}},"commit":{"parents":[{"commit":"abce3bd94b243deb2fb5805d76609d11a4818fc7","subject":"Update master for stable/2025.2","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/abce3bd94b243deb2fb5805d76609d11a4818fc7"}]}],"author":{"name":"Omer","email":"oschwart@redhat.com","date":"2025-09-15 12:52:22.000000000","tz":0},"committer":{"name":"Omer","email":"oschwart@redhat.com","date":"2025-09-15 14:57:49.000000000","tz":0},"subject":"Fix zone deletion failure with BIND recursion enabled","message":"Fix zone deletion failure with BIND recursion enabled\n\nWhen BIND9 is configured with both authoritative and recursive roles,\nzone deletion can fail because get_serial() incorrectly interprets\nnon-authoritative recursive responses as evidence that the zone still\nexists locally.\n\nAfter a zone is deleted from the authoritative server, BIND may still\nreturn SOA records for the zone by querying upstream nameservers via\nrecursion. The original code only checked for the presence of answer\nrecords and serial numbers, not whether the response was authoritative.\n\nThis fix checks the DNS response flags:\n- If AA (Authoritative Answer) flag is not set AND\n- RA (Recursion Available) flag is set\nget_serial will return 0 to indicate the zone doesn\u0027t exist locally.\n\nCloses-Bug: #1802227\nAssisted-By: Cursor (claude-4-sonnet)\nChange-Id: I89c5ef0645f9688afb16c6d3c48b55f9c52b6d76\nSigned-off-by: Omer \u003coschwart@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/c21c22c626a1954503f7c9c3385011d393676206"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/c21c22c626a1954503f7c9c3385011d393676206"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}},{"label":"Workflow","status":"MAY"},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Review-Priority","description":"Review priority","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"-label:Review-Priority\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":[],"failing_atoms":["label:Review-Priority\u003dMIN"],"atom_explanations":{"label:Review-Priority\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}