)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"e8a9b93c425306f3cc9ff5db8bee5ac6cc9698a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dca03dce_08b7467d","updated":"2025-10-20 11:34:42.000000000","message":"recheck failure is not related to the patch","commit_id":"419412232044a75a0aa66469fed0c9eaa60ff680"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"27c8d099b954f04d1bb2b8c6a8c2013043ac27b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"dc691af9_04c420e3","updated":"2025-11-18 08:42:13.000000000","message":"@Omer: Congratulation for your excellent work!","commit_id":"76d3da30a7518021eb734b8fd0c0a37cdb3004ee"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"8fb2013d1bbfd321686837d54a05b32970c1eef0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"514d27c5_a5a27582","in_reply_to":"dc691af9_04c420e3","updated":"2025-11-18 09:48:01.000000000","message":"Thanks Herve!","commit_id":"76d3da30a7518021eb734b8fd0c0a37cdb3004ee"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"6b27dc2229d8bef61dc345f25ff6576bf790e5ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"155ef914_2f1fd6a8","updated":"2026-01-21 01:12:31.000000000","message":"ok, it is related to the central patch I think","commit_id":"ff6a1497e4d1c3c7441cb07eef00bdd7c6816268"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"6e11c5485910b6e719cecf53e406ca53569a14ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"9f8d1a1c_8e3e620b","updated":"2026-01-21 00:37:12.000000000","message":"recheck failure is not related to the patch","commit_id":"ff6a1497e4d1c3c7441cb07eef00bdd7c6816268"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"c82a81240dad9228905af965d865b746c209c1a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"76a00b69_a01f97f8","updated":"2026-01-23 14:22:27.000000000","message":"recheck failure is not related to the patch","commit_id":"18ebb0b5205b9ea7a254b7041c7c2e19be17c4a0"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ad3dead2f562dc5b25ef750a51a4ef6fa7604d94","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"86da6a29_b6aa7e3d","updated":"2026-02-06 18:39:29.000000000","message":"Just a couple minor comments, otherwise looks good.","commit_id":"f5f5d058100101325f5f9d5698db8a8d801ac44c"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"6b4e80a26fbdcd867045f8957b19347697544317","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"da1a4583_38671ea0","updated":"2026-02-16 09:36:45.000000000","message":"Adding W+1 as we are 1 week from feature freeze","commit_id":"46cb4098e0a0176466e2e92493076f5186c3b11b"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"700b72dc4713e7e107facb421552c0aaac16cbf8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"db31bb34_8d8726c1","updated":"2026-02-12 19:06:10.000000000","message":"LGTM","commit_id":"46cb4098e0a0176466e2e92493076f5186c3b11b"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"c8c104d7f7f541b3282da2a17e1e456b8fd6614d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"5da839e0_971bd8bb","updated":"2026-02-11 15:12:55.000000000","message":"recheck grenade jobs are not broken anymore","commit_id":"46cb4098e0a0176466e2e92493076f5186c3b11b"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"196485c47a07d9fa172649cab8ebc40b20269411","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"ca12fe6c_0d8bd651","updated":"2026-02-16 14:32:31.000000000","message":"recheck parent patch is merged now","commit_id":"46cb4098e0a0176466e2e92493076f5186c3b11b"}],"designate/__init__.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ad3dead2f562dc5b25ef750a51a4ef6fa7604d94","unresolved":true,"context_lines":[{"line_number":19,"context_line":"# compatibility issues. Without this, dnspython\u0027s zone parsing fails with"},{"line_number":20,"context_line":"# errors like \"TypeError: add(): expected an Rdata\" due to conflicts between"},{"line_number":21,"context_line":"# eventlet\u0027s patched DNS resolver and dnspython\u0027s native implementation."},{"line_number":22,"context_line":"os.environ[\u0027EVENTLET_NO_GREENDNS\u0027] \u003d \u0027yes\u0027"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from oslo_concurrency import lockutils  # noqa"},{"line_number":25,"context_line":"from oslo_log import log  # noqa"}],"source_content_type":"text/x-python","patch_set":21,"id":"603ee1ce_ee211919","line":22,"updated":"2026-02-06 18:39:29.000000000","message":"This should be able to go away with this patch right?","commit_id":"f5f5d058100101325f5f9d5698db8a8d801ac44c"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f3a6e30068831566d7ae08ca65f7a1815b8635ee","unresolved":true,"context_lines":[{"line_number":19,"context_line":"# compatibility issues. Without this, dnspython\u0027s zone parsing fails with"},{"line_number":20,"context_line":"# errors like \"TypeError: add(): expected an Rdata\" due to conflicts between"},{"line_number":21,"context_line":"# eventlet\u0027s patched DNS resolver and dnspython\u0027s native implementation."},{"line_number":22,"context_line":"os.environ[\u0027EVENTLET_NO_GREENDNS\u0027] \u003d \u0027yes\u0027"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from oslo_concurrency import lockutils  # noqa"},{"line_number":25,"context_line":"from oslo_log import log  # noqa"}],"source_content_type":"text/x-python","patch_set":21,"id":"e6d558a1_7359827c","line":22,"in_reply_to":"603ee1ce_ee211919","updated":"2026-02-09 10:33:53.000000000","message":"Eventlet\u0027s greendns still patches DNS resolution and breaks dnspython.\n\nIt is still required by oslo (I removed those lines and ran tox -re cover) and I got that \"TypeError: add(): expected an Rdata\" error.\n\n~/designate review/omer_..tlet-removal \u003e .tox/py3/bin/pip show eventlet | grep Required-by\nRequired-by: oslo.service\n\nI think we could remove those lines in the future, when oslo.service removes its eventlet dependency.","commit_id":"f5f5d058100101325f5f9d5698db8a8d801ac44c"}],"designate/central/service.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ad3dead2f562dc5b25ef750a51a4ef6fa7604d94","unresolved":true,"context_lines":[{"line_number":834,"context_line":"            for rrset in zone.recordsets:"},{"line_number":835,"context_line":"                # Allow other threads to run, as this looping operation"},{"line_number":836,"context_line":"                # can be very long-lived."},{"line_number":837,"context_line":"                time.sleep(0)"},{"line_number":838,"context_line":"                self._create_recordset_in_storage("},{"line_number":839,"context_line":"                    context, zone, rrset, increment_serial\u003dFalse"},{"line_number":840,"context_line":"                )"}],"source_content_type":"text/x-python","patch_set":21,"id":"8c103723_ad4f2899","line":837,"updated":"2026-02-06 18:39:29.000000000","message":"This is probably no longer necessary with the threading backend.","commit_id":"f5f5d058100101325f5f9d5698db8a8d801ac44c"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f3a6e30068831566d7ae08ca65f7a1815b8635ee","unresolved":false,"context_lines":[{"line_number":834,"context_line":"            for rrset in zone.recordsets:"},{"line_number":835,"context_line":"                # Allow other threads to run, as this looping operation"},{"line_number":836,"context_line":"                # can be very long-lived."},{"line_number":837,"context_line":"                time.sleep(0)"},{"line_number":838,"context_line":"                self._create_recordset_in_storage("},{"line_number":839,"context_line":"                    context, zone, rrset, increment_serial\u003dFalse"},{"line_number":840,"context_line":"                )"}],"source_content_type":"text/x-python","patch_set":21,"id":"7e7d5a4d_be16ac5d","line":837,"in_reply_to":"8c103723_ad4f2899","updated":"2026-02-09 10:33:53.000000000","message":"Done","commit_id":"f5f5d058100101325f5f9d5698db8a8d801ac44c"}],"designate/tests/__init__.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ad3dead2f562dc5b25ef750a51a4ef6fa7604d94","unresolved":true,"context_lines":[{"line_number":20,"context_line":"# compatibility issues. Without this, dnspython\u0027s zone parsing fails with"},{"line_number":21,"context_line":"# errors like \"TypeError: add(): expected an Rdata\" due to conflicts between"},{"line_number":22,"context_line":"# eventlet\u0027s patched DNS resolver and dnspython\u0027s native implementation."},{"line_number":23,"context_line":"os.environ[\u0027EVENTLET_NO_GREENDNS\u0027] \u003d \u0027yes\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from oslo_service import backend as oslo_service_backend # noqa"},{"line_number":26,"context_line":"try:"}],"source_content_type":"text/x-python","patch_set":21,"id":"14b52d9b_64a04633","line":23,"updated":"2026-02-06 18:39:29.000000000","message":"This can also probably be removed","commit_id":"f5f5d058100101325f5f9d5698db8a8d801ac44c"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f3a6e30068831566d7ae08ca65f7a1815b8635ee","unresolved":true,"context_lines":[{"line_number":20,"context_line":"# compatibility issues. Without this, dnspython\u0027s zone parsing fails with"},{"line_number":21,"context_line":"# errors like \"TypeError: add(): expected an Rdata\" due to conflicts between"},{"line_number":22,"context_line":"# eventlet\u0027s patched DNS resolver and dnspython\u0027s native implementation."},{"line_number":23,"context_line":"os.environ[\u0027EVENTLET_NO_GREENDNS\u0027] \u003d \u0027yes\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from oslo_service import backend as oslo_service_backend # noqa"},{"line_number":26,"context_line":"try:"}],"source_content_type":"text/x-python","patch_set":21,"id":"55884bd0_2f8b9565","line":23,"in_reply_to":"14b52d9b_64a04633","updated":"2026-02-09 10:33:53.000000000","message":"ditto oslo.service requires eventlet","commit_id":"f5f5d058100101325f5f9d5698db8a8d801ac44c"}]}