)]}'
{"designate/mdns/service.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"de8bf6fe694f918672e1b7d296b605d784d31f0a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        # Create an instance of the RequestHandler class"},{"line_number":32,"context_line":"        self.handler \u003d handler.RequestHandler()"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        # Bind to TCP 53"},{"line_number":35,"context_line":"        LOG.info(\u0027Opening TCP Listening Socket\u0027)"},{"line_number":36,"context_line":"        self._sock_tcp \u003d socket.socket(socket.AF_INET, socket.SOCK_STREAM)"},{"line_number":37,"context_line":"        self._sock_tcp.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_db707dde","line":34,"updated":"2014-06-04 21:01:54.000000000","message":"The default port in the sample however says 5354.  Should the designate.conf.sample be changed?","commit_id":"6340367638996e9ef1b516f0d5aafd0ea76c1dad"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"64310e822ce453512e5e85a68b7120befb0eefd0","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        # Create an instance of the RequestHandler class"},{"line_number":32,"context_line":"        self.handler \u003d handler.RequestHandler()"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        # Bind to TCP 53"},{"line_number":35,"context_line":"        LOG.info(\u0027Opening TCP Listening Socket\u0027)"},{"line_number":36,"context_line":"        self._sock_tcp \u003d socket.socket(socket.AF_INET, socket.SOCK_STREAM)"},{"line_number":37,"context_line":"        self._sock_tcp.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_86c77463","line":34,"in_reply_to":"1ae5cdf2_db707dde","updated":"2014-06-04 22:43:59.000000000","message":"Yea, you need root for 53, I should update this comment.\n\nAlso - We\u0027ll want to be able to start as root, then drop all privileges. But that\u0027s another review.","commit_id":"6340367638996e9ef1b516f0d5aafd0ea76c1dad"},{"author":{"_account_id":8101,"name":"Emmanuel Ankutse","email":"emmanuel.ankutse@rackspace.com","username":"emmanuel.ankutse"},"change_message_id":"ac049854f68e00948ff8df8d484b5d507813b88a","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            client, addr \u003d self._sock_tcp.accept()"},{"line_number":58,"context_line":"            LOG.warn(\"Handling TCP Request from: %s\", addr)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"            payload \u003d client.recv(8192)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"            self.tg.add_thread(self._dispatch, addr, payload)"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_fa472575","line":60,"updated":"2014-06-03 14:36:49.000000000","message":"we can do 65535 for tcp","commit_id":"6340367638996e9ef1b516f0d5aafd0ea76c1dad"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"64310e822ce453512e5e85a68b7120befb0eefd0","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            client, addr \u003d self._sock_tcp.accept()"},{"line_number":58,"context_line":"            LOG.warn(\"Handling TCP Request from: %s\", addr)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"            payload \u003d client.recv(8192)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"            self.tg.add_thread(self._dispatch, addr, payload)"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_26aea098","line":60,"in_reply_to":"1ae5cdf2_fa472575","updated":"2014-06-04 22:43:59.000000000","message":"Done","commit_id":"6340367638996e9ef1b516f0d5aafd0ea76c1dad"},{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"de8bf6fe694f918672e1b7d296b605d784d31f0a","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"            payload \u003d client.recv(8192)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"            self.tg.add_thread(self._dispatch, addr, payload)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def _handle_udp(self):"},{"line_number":65,"context_line":"        while True:"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_7684e05d","line":62,"updated":"2014-06-04 21:01:54.000000000","message":"Shouldn\u0027t client be passed too?","commit_id":"6340367638996e9ef1b516f0d5aafd0ea76c1dad"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"64310e822ce453512e5e85a68b7120befb0eefd0","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"            payload \u003d client.recv(8192)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"            self.tg.add_thread(self._dispatch, addr, payload)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def _handle_udp(self):"},{"line_number":65,"context_line":"        while True:"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_06ab6489","line":62,"in_reply_to":"1ae5cdf2_7684e05d","updated":"2014-06-04 22:43:59.000000000","message":"That explains SO much. Thanks :)","commit_id":"6340367638996e9ef1b516f0d5aafd0ea76c1dad"},{"author":{"_account_id":8101,"name":"Emmanuel Ankutse","email":"emmanuel.ankutse@rackspace.com","username":"emmanuel.ankutse"},"change_message_id":"ac049854f68e00948ff8df8d484b5d507813b88a","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def _handle_udp(self):"},{"line_number":65,"context_line":"        while True:"},{"line_number":66,"context_line":"            payload, addr \u003d self._sock_udp.recvfrom(8192)"},{"line_number":67,"context_line":"            LOG.warn(\"Handling UDP Request from: %s\", addr)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"            self.tg.add_thread(self._dispatch, addr, payload)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_ba1f5d6b","line":66,"updated":"2014-06-03 14:36:49.000000000","message":"maybe 512 for udp?","commit_id":"6340367638996e9ef1b516f0d5aafd0ea76c1dad"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"64310e822ce453512e5e85a68b7120befb0eefd0","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def _handle_udp(self):"},{"line_number":65,"context_line":"        while True:"},{"line_number":66,"context_line":"            payload, addr \u003d self._sock_udp.recvfrom(8192)"},{"line_number":67,"context_line":"            LOG.warn(\"Handling UDP Request from: %s\", addr)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"            self.tg.add_thread(self._dispatch, addr, payload)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_e68e782d","line":66,"in_reply_to":"1ae5cdf2_ba1f5d6b","updated":"2014-06-04 22:43:59.000000000","message":"No, EDNS supports packets larger than - I\u0027m not entirely sure what the best choice is here, but 8192 is what dnspy defaults to :)","commit_id":"6340367638996e9ef1b516f0d5aafd0ea76c1dad"}],"designate/tests/test_mdns/test_handler.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"de8bf6fe694f918672e1b7d296b605d784d31f0a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    def test_dispatch_opcode_query(self, mock):"},{"line_number":29,"context_line":"        # DNS packet with QUERY opcode"},{"line_number":30,"context_line":"        payload \u003d (\"abbe01200001000000000001076578616d706c6503636f6d0000010001\""},{"line_number":31,"context_line":"                   \"0000291000000000000000\")"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        self.handler.handle(binascii.a2b_hex(payload))"},{"line_number":34,"context_line":"        self.assertTrue(mock.called)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_6f54fefe","line":31,"updated":"2014-06-04 21:01:54.000000000","message":"Just curious - Did you craft the payloads by hand or use a tool to generate them?","commit_id":"6340367638996e9ef1b516f0d5aafd0ea76c1dad"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"64310e822ce453512e5e85a68b7120befb0eefd0","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    def test_dispatch_opcode_query(self, mock):"},{"line_number":29,"context_line":"        # DNS packet with QUERY opcode"},{"line_number":30,"context_line":"        payload \u003d (\"abbe01200001000000000001076578616d706c6503636f6d0000010001\""},{"line_number":31,"context_line":"                   \"0000291000000000000000\")"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        self.handler.handle(binascii.a2b_hex(payload))"},{"line_number":34,"context_line":"        self.assertTrue(mock.called)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1ae5cdf2_46a64caf","line":31,"in_reply_to":"1ae5cdf2_6f54fefe","updated":"2014-06-04 22:43:59.000000000","message":"This particular packet is from dig, aimed at the \"contrib/dns_dump_server.py\" script included in this review.\n\nThe remaining packets are generated with the \"contrib/dns_dump_dnspy.py\" (i.e. craft in dnspy, serialize to wire format, hex encode).\n\nIdeally - we avoid using the dnspy method, as a bug in dnspy slips into our tests, then the tests pass when they should not etc etc. But - Generating those other packets with standard tools is surprisingly hard ;)\n\nAt least by keeping them here in wire format, new bugs in future dnspy releases will be caught :)","commit_id":"6340367638996e9ef1b516f0d5aafd0ea76c1dad"}],"etc/designate/designate.conf.sample":[{"author":{"_account_id":8101,"name":"Emmanuel Ankutse","email":"emmanuel.ankutse@rackspace.com","username":"emmanuel.ankutse"},"change_message_id":"ac049854f68e00948ff8df8d484b5d507813b88a","unresolved":false,"context_lines":[{"line_number":123,"context_line":"#workers \u003d None"},{"line_number":124,"context_line":"#host \u003d 0.0.0.0"},{"line_number":125,"context_line":"#port \u003d 5354"},{"line_number":126,"context_line":"#tcp_backlog \u003d1 00"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"##############"},{"line_number":129,"context_line":"## Network API"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"1ae5cdf2_2b308555","line":126,"updated":"2014-06-03 14:36:49.000000000","message":"typo?","commit_id":"6340367638996e9ef1b516f0d5aafd0ea76c1dad"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"64310e822ce453512e5e85a68b7120befb0eefd0","unresolved":false,"context_lines":[{"line_number":123,"context_line":"#workers \u003d None"},{"line_number":124,"context_line":"#host \u003d 0.0.0.0"},{"line_number":125,"context_line":"#port \u003d 5354"},{"line_number":126,"context_line":"#tcp_backlog \u003d1 00"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"##############"},{"line_number":129,"context_line":"## Network API"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"1ae5cdf2_e61e786f","line":126,"in_reply_to":"1ae5cdf2_2b308555","updated":"2014-06-04 22:43:59.000000000","message":"Done","commit_id":"6340367638996e9ef1b516f0d5aafd0ea76c1dad"}]}