)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"9454756f7c4537fbd3d934b4e56c96b915c7f314","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"24a4acd3_babfc0c4","updated":"2025-12-15 19:20:11.000000000","message":"recheck failure is not related to the patch","commit_id":"57fad96533d26d3415fe38be9d4b3e8d6d22d01b"},{"author":{"_account_id":36710,"name":"Jeong Jiho","display_name":"jiho","email":"jiho.jeong@samsung.com","username":"jihoJeong"},"change_message_id":"1b0c7fc129cc6a62841676041cb1a4b8c2dc58fb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d263c77f_044481bb","updated":"2026-01-08 00:31:16.000000000","message":"I’m wondering whether it’s possible to reload the pool from every designate‑worker pod and from all processes running inside each pod.","commit_id":"917c684d8bf39becb1850b3099820f662e6915f8"}],"designate/worker/service.py":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"08ec8e503678c00835be4be9209613020b46d18b","unresolved":true,"context_lines":[{"line_number":248,"context_line":"        for pool_id in pool_ids:"},{"line_number":249,"context_line":"            if pool_id in self.pools_map:"},{"line_number":250,"context_line":"                LOG.info(\u0027Invalidating cache for pool %s\u0027, pool_id)"},{"line_number":251,"context_line":"                del self.pools_map[pool_id]"},{"line_number":252,"context_line":"                count +\u003d 1"},{"line_number":253,"context_line":"            else:"},{"line_number":254,"context_line":"                LOG.debug(\u0027Pool %s not cached, skipping\u0027, pool_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"d1906f12_04e8dc32","line":251,"updated":"2026-01-02 10:28:45.000000000","message":"Do we need some sort of locking here to make this safe?","commit_id":"57fad96533d26d3415fe38be9d4b3e8d6d22d01b"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"411db326a51854baef5ab9d8743732f8e3a01726","unresolved":true,"context_lines":[{"line_number":248,"context_line":"        for pool_id in pool_ids:"},{"line_number":249,"context_line":"            if pool_id in self.pools_map:"},{"line_number":250,"context_line":"                LOG.info(\u0027Invalidating cache for pool %s\u0027, pool_id)"},{"line_number":251,"context_line":"                del self.pools_map[pool_id]"},{"line_number":252,"context_line":"                count +\u003d 1"},{"line_number":253,"context_line":"            else:"},{"line_number":254,"context_line":"                LOG.debug(\u0027Pool %s not cached, skipping\u0027, pool_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfdf93a6_5c16ba26","line":251,"in_reply_to":"d1906f12_04e8dc32","updated":"2026-01-02 15:10:57.000000000","message":"Yes, we do, I will add it. Thanks!","commit_id":"57fad96533d26d3415fe38be9d4b3e8d6d22d01b"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"fb236f0069069122148a4b1fc302796ff60f7cf2","unresolved":false,"context_lines":[{"line_number":248,"context_line":"        for pool_id in pool_ids:"},{"line_number":249,"context_line":"            if pool_id in self.pools_map:"},{"line_number":250,"context_line":"                LOG.info(\u0027Invalidating cache for pool %s\u0027, pool_id)"},{"line_number":251,"context_line":"                del self.pools_map[pool_id]"},{"line_number":252,"context_line":"                count +\u003d 1"},{"line_number":253,"context_line":"            else:"},{"line_number":254,"context_line":"                LOG.debug(\u0027Pool %s not cached, skipping\u0027, pool_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"d0be1ae8_d7be99e3","line":251,"in_reply_to":"dfdf93a6_5c16ba26","updated":"2026-01-05 19:25:21.000000000","message":"Done","commit_id":"57fad96533d26d3415fe38be9d4b3e8d6d22d01b"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"19d2521b46fb8f7f1b387abdbfe1d828f3a3999c","unresolved":true,"context_lines":[{"line_number":130,"context_line":"        return self._pools_map"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def get_pool(self, pool_id):"},{"line_number":133,"context_line":"        if pool_id not in self.pools_map:"},{"line_number":134,"context_line":"            LOG.info(\u0027Lazily loading pool %s\u0027, pool_id)"},{"line_number":135,"context_line":"            self.pools_map[pool_id] \u003d self.load_pool(pool_id)"},{"line_number":136,"context_line":"        return self.pools_map[pool_id]"}],"source_content_type":"text/x-python","patch_set":2,"id":"561a5e48_bef82848","line":133,"updated":"2026-01-02 21:26:47.000000000","message":"Do we need the same locking here as well?","commit_id":"917c684d8bf39becb1850b3099820f662e6915f8"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"76ea7c05b3541ad33006251a95f8c01f3073ed37","unresolved":true,"context_lines":[{"line_number":130,"context_line":"        return self._pools_map"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def get_pool(self, pool_id):"},{"line_number":133,"context_line":"        if pool_id not in self.pools_map:"},{"line_number":134,"context_line":"            LOG.info(\u0027Lazily loading pool %s\u0027, pool_id)"},{"line_number":135,"context_line":"            self.pools_map[pool_id] \u003d self.load_pool(pool_id)"},{"line_number":136,"context_line":"        return self.pools_map[pool_id]"}],"source_content_type":"text/x-python","patch_set":2,"id":"29a68fb4_dbb9e697","line":133,"in_reply_to":"1f9dbe9a_69531da3","updated":"2026-01-06 16:00:58.000000000","message":"Yea - I guess what would happen here in case a reload removes something from the pool map is that it would re-fetch the pool. \n\nIf you wanted to triple check you could run a basic stress test just reloading the pool while performing basic actions (e.g. running tempest) to verify?","commit_id":"917c684d8bf39becb1850b3099820f662e6915f8"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"fb236f0069069122148a4b1fc302796ff60f7cf2","unresolved":true,"context_lines":[{"line_number":130,"context_line":"        return self._pools_map"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def get_pool(self, pool_id):"},{"line_number":133,"context_line":"        if pool_id not in self.pools_map:"},{"line_number":134,"context_line":"            LOG.info(\u0027Lazily loading pool %s\u0027, pool_id)"},{"line_number":135,"context_line":"            self.pools_map[pool_id] \u003d self.load_pool(pool_id)"},{"line_number":136,"context_line":"        return self.pools_map[pool_id]"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f9dbe9a_69531da3","line":133,"in_reply_to":"561a5e48_bef82848","updated":"2026-01-05 19:25:21.000000000","message":"TBH I thought about it, but I couldn\u0027t think of a valid use case. Can you think of a use case that would justify using that lock in get_pool too?","commit_id":"917c684d8bf39becb1850b3099820f662e6915f8"}]}