)]}'
{"id":"openstack%2Fdesignate~971575","triplet_id":"openstack%2Fdesignate~master~I20438b3b64c3b1ae61c431e9fdee13371348fed1","project":"openstack/designate","branch":"master","topic":"bug/1930054","attention_set":{},"removed_from_attention_set":{"31664":{"account":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"last_update":"2025-12-22 19:56:07.000000000","reason":"\u003cGERRIT_ACCOUNT_31664\u003e replied on the change","reason_account":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"}}},"hashtags":[],"change_id":"I20438b3b64c3b1ae61c431e9fdee13371348fed1","subject":"Normalize TSIG key names to fix multi-pool lookup failures","status":"NEW","created":"2025-12-19 19:45:16.000000000","updated":"2025-12-22 19:56:07.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":true,"submittable":false,"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"aa65bfeea9fad549205b80fb3ea5fb14270fa646","_number":971575,"virtual_id_number":971575,"owner":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":-1,"date":"2025-12-19 20:59:10.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-12-19 20:59:10.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"6d23e0536debbc2fc099b7d107267643224b40d5","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"date":"2025-12-19 19:45:16.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"068b1769c24e092864d5bd98348f701dafded118","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-12-19 20:59:10.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\nand https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures\n\nhttps://zuul.opendev.org/t/openstack/buildset/4f7d50caa44b489caaa406c909604a57\n\n- designate-bind9-core https://zuul.opendev.org/t/openstack/build/f4dc8f6a0e0b442684323458f3bd1e65 : FAILURE in 50m 51s\n- designate-bind9-with-keystone-default-roles https://zuul.opendev.org/t/openstack/build/05502e2bf653463596e7533db3b4dc58 : FAILURE in 42m 55s\n- designate-pdns4-core https://zuul.opendev.org/t/openstack/build/bc2c73d36c1d4c7faec779db75edccea : FAILURE in 48m 15s\n- designate-bind9-multipool https://zuul.opendev.org/t/openstack/build/152609920c5c4b7d82300b0ce8f3d697 : SUCCESS in 34m 09s\n- designate-grenade-bind9 https://zuul.opendev.org/t/openstack/build/62dfefb5ec444d02bb32386ed647787c : FAILURE in 1h 07m 06s\n- designate-grenade-pdns4 https://zuul.opendev.org/t/openstack/build/6575b9c1157c4c5fa3ef71aa6720cbd1 : FAILURE in 59m 01s\n- designate-grenade-bind9-skip-level https://zuul.opendev.org/t/openstack/build/a757f1c5ca61476881edd92735a18c37 : FAILURE in 1h 06m 29s\n- designate-grenade-pdns4-skip-level https://zuul.opendev.org/t/openstack/build/946c4cf57c4a4a418bbdbc4df1cacdc4 : FAILURE in 1h 11m 45s\n- designate-bind9-core-catalog-zones https://zuul.opendev.org/t/openstack/build/7457227925aa46ec91e1c79be0d97564 : FAILURE in 47m 39s (non-voting)\n- designate-only-ipv6-pdns4 https://zuul.opendev.org/t/openstack/build/83dbf5c0ec89407eaccc62e3515da8bc : FAILURE in 41m 13s\n- designate-only-ipv6-bind9 https://zuul.opendev.org/t/openstack/build/08731306bc7b490fa9fd110cb3272fc6 : FAILURE in 51m 56s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/4951b53d26f8471abf56c551ba197384 : FAILURE in 7m 14s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/7487cebf1e4049088066487afe2a5aa8 : SUCCESS in 2m 07s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/850601bc03be40b792a67bf746fc3fc6 : FAILURE in 3m 56s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/1847f475c6ae47aeb04217895588e9c2 : FAILURE in 7m 42s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2754bc4854244b9e9ec448415f7b7bc7 : SUCCESS in 8m 50s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/14f30c7ea9214cad94bdf9cb460ec494 : SUCCESS in 4m 27s\n- neutron-tempest-plugin-designate-scenario https://zuul.opendev.org/t/openstack/build/8546028140a540a78f8b278f6eef1541 : SUCCESS in 31m 04s\n- designate-tox-dnspython-latest https://zuul.opendev.org/t/openstack/build/c04c2052cfa14b3095680e4b63eb5cd3 : FAILURE in 5m 20s","accounts_in_message":[],"_revision_number":1},{"id":"aa65bfeea9fad549205b80fb3ea5fb14270fa646","author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"date":"2025-12-22 19:56:07.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"186074a6af71eccf78c0c64b25e19b8baeddf7eb","revisions":{"186074a6af71eccf78c0c64b25e19b8baeddf7eb":{"kind":"REWORK","_number":1,"created":"2025-12-19 19:45:16.000000000","uploader":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"ref":"refs/changes/75/971575/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/designate","ref":"refs/changes/75/971575/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/designate refs/changes/75/971575/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/designate refs/changes/75/971575/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/designate refs/changes/75/971575/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/designate refs/changes/75/971575/1"}}},"commit":{"parents":[{"commit":"7c785e72c3936d89531a8866384f19172b1e1111","subject":"reno: Update master for unmaintained/2024.1","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/7c785e72c3936d89531a8866384f19172b1e1111"}]}],"author":{"name":"Omer","email":"oschwart@redhat.com","date":"2025-12-19 19:42:55.000000000","tz":-180},"committer":{"name":"Omer","email":"oschwart@redhat.com","date":"2025-12-19 19:44:57.000000000","tz":-180},"subject":"Normalize TSIG key names to fix multi-pool lookup failures","message":"Normalize TSIG key names to fix multi-pool lookup failures\n\nThis change fixes an inconsistency between TSIG key storage and\nlookup that caused TSIG-authenticated zone transfers to fail in\nmulti-pool PowerDNS deployments.\n\nProblem:\nWhen TSIG keys were created with trailing dots (e.g., \"mykey.\"),\nthey were stored as-is in the database. However, during DNS\nprotocol operations, dnspython provides key names as absolute\nDNS names. The TsigKeyring.get() method strips the trailing dot\nusing key.to_text(True), causing a mismatch between the lookup\nname and stored name, resulting in authentication failures.\n\nSolution:\n- Normalize TSIG key names by stripping trailing dots on create/update\n- Normalize search criteria to handle queries with trailing dots\n- Add database migration to clean up existing keys with trailing dots\n- Add tests for creation, retrieval, and search with trailing dots\n\nThe DNS wire protocol continues to work correctly as dnspython\nautomatically converts all names to absolute format (with root label)\nwhen serializing to wire format, regardless of how they\u0027re stored.\n\nCloses-Bug: #1930054\nAssisted-By: Claude Code 4.5 Sonnet\nChange-Id: I20438b3b64c3b1ae61c431e9fdee13371348fed1\nSigned-off-by: Omer \u003coschwart@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/186074a6af71eccf78c0c64b25e19b8baeddf7eb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/186074a6af71eccf78c0c64b25e19b8baeddf7eb"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY"},{"label":"Workflow","status":"MAY"},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Review-Priority","description":"Review priority","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"-label:Review-Priority\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":[],"failing_atoms":["label:Review-Priority\u003dMIN"],"atom_explanations":{"label:Review-Priority\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}