)]}'
{"id":"openstack%2Fdesignate~971785","triplet_id":"openstack%2Fdesignate~master~I093902f27a1221a063c7f3e7a2dc38525e91dcb1","project":"openstack/designate","branch":"master","topic":"bug/2030326","attention_set":{"31664":{"account":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"last_update":"2025-12-24 22:27:46.000000000","reason":"A robot voted negatively on a label"}},"removed_from_attention_set":{},"hashtags":[],"change_id":"I093902f27a1221a063c7f3e7a2dc38525e91dcb1","subject":"Improve error messages for invalid UUIDs in notifications","status":"NEW","created":"2025-12-24 21:09:54.000000000","updated":"2025-12-29 09:26:52.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":true,"submittable":false,"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"a2d15609fa72d2773ff081671703d79b2114a232","_number":971785,"virtual_id_number":971785,"owner":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2025-12-25 00:02:26.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2025-12-24 22:27:46.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2025-12-29 09:26:52.000000000","updated_by":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"reviewer":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"state":"CC"}],"messages":[{"id":"d538bc4b61d607cd8afb751631566d298fad3a6f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"date":"2025-12-24 21:09:54.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"df9cf82dd6ea17dacede0f2fabfb758d3d08fcd3","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-12-24 22:27:46.000000000","message":"Patch Set 1: Verified-1\n\n(3 comments)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\nand https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures\n\nhttps://zuul.opendev.org/t/openstack/buildset/ecf0aea9106a4310847f3ee608840b50\n\n- designate-bind9-core https://zuul.opendev.org/t/openstack/build/5b1829718a6d4a9e8dca01c9afe38ce1 : SUCCESS in 47m 07s\n- designate-bind9-with-keystone-default-roles https://zuul.opendev.org/t/openstack/build/2949f417d74f4e4cb4b05b8aa0c6a3f3 : SUCCESS in 50m 27s\n- designate-pdns4-core https://zuul.opendev.org/t/openstack/build/3b071992bf994bc6bcf17bb258d2c7d4 : SUCCESS in 48m 02s\n- designate-bind9-multipool https://zuul.opendev.org/t/openstack/build/a65cb90c7c84445d9b804b13b902e337 : SUCCESS in 23m 01s\n- designate-grenade-bind9 https://zuul.opendev.org/t/openstack/build/f1ac8098daeb42f78c438aea7442d21d : SUCCESS in 49m 34s\n- designate-grenade-pdns4 https://zuul.opendev.org/t/openstack/build/fa32a17548ba47a289c36be322c2b413 : SUCCESS in 1h 11m 34s\n- designate-grenade-bind9-skip-level https://zuul.opendev.org/t/openstack/build/387d5f8f6bc846c68993c8bbacb5f99c : SUCCESS in 1h 09m 34s\n- designate-grenade-pdns4-skip-level https://zuul.opendev.org/t/openstack/build/d384ada78fe643d190592930259f881f : SUCCESS in 52m 11s\n- designate-bind9-core-catalog-zones https://zuul.opendev.org/t/openstack/build/537f6004547d4211a73997d44521d7c5 : SUCCESS in 47m 43s (non-voting)\n- designate-only-ipv6-pdns4 https://zuul.opendev.org/t/openstack/build/c0c7384572d449528c721143fd5efe52 : SUCCESS in 37m 50s\n- designate-only-ipv6-bind9 https://zuul.opendev.org/t/openstack/build/9a3aa59571264234ba58332f58199033 : FAILURE in 53m 22s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/7e1266e6ccf8414c9c35412037a7fccd : SUCCESS in 9m 38s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1375f93f72f84acea58f4fff9754ad44 : FAILURE in 3m 23s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/1b7ab1cec85842488f24ab86bb327caf : SUCCESS in 7m 46s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/6b43b2e2be394baf8fd3b2e1bd47f032 : SUCCESS in 8m 09s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f6ea0f17e49742cfbbfe98f177459b80 : SUCCESS in 10m 20s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/b0ff3d72bcd545ff8b0d5ee6ae0297a6 : SUCCESS in 4m 31s\n- neutron-tempest-plugin-designate-scenario https://zuul.opendev.org/t/openstack/build/d7e5fffdb2c34b27a80e675b4ca61bf2 : SUCCESS in 43m 49s\n- designate-tox-dnspython-latest https://zuul.opendev.org/t/openstack/build/f5514f49017e4750b00d22e7a4f73179 : SUCCESS in 5m 23s","accounts_in_message":[],"_revision_number":1},{"id":"e43bcd93ed5005554ff9bb5eb22cf33b4f94ad1b","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"date":"2025-12-24 22:39:31.000000000","message":"Uploaded patch set 2.\n\nOutdated Votes:\n* Verified-1\n","accounts_in_message":[],"_revision_number":2},{"id":"a7a83a65b948cb87b1ee4c56ebee3928f8578b0b","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2025-12-25 00:02:26.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/fe92b1df1e4c47b68a6006f4c53379e6\n\n- designate-bind9-core https://zuul.opendev.org/t/openstack/build/7d4c53afc0ce49258726970e78ed2667 : SUCCESS in 52m 52s\n- designate-bind9-with-keystone-default-roles https://zuul.opendev.org/t/openstack/build/8a841b924aa344e7a389680f7dcd26c8 : SUCCESS in 40m 02s\n- designate-pdns4-core https://zuul.opendev.org/t/openstack/build/b75e14583f0c43568a7fecb84bf79f78 : SUCCESS in 46m 58s\n- designate-bind9-multipool https://zuul.opendev.org/t/openstack/build/e6e916a8c44342278178ddf0aa47278b : SUCCESS in 19m 36s\n- designate-grenade-bind9 https://zuul.opendev.org/t/openstack/build/05cc759ab7204214829c38226696d444 : SUCCESS in 1h 14m 09s\n- designate-grenade-pdns4 https://zuul.opendev.org/t/openstack/build/e43b0849544d425dbb810c99f3d7212a : SUCCESS in 1h 12m 28s\n- designate-grenade-bind9-skip-level https://zuul.opendev.org/t/openstack/build/4c86583f71394d62baf7701c88b3a7d8 : SUCCESS in 1h 17m 03s\n- designate-grenade-pdns4-skip-level https://zuul.opendev.org/t/openstack/build/e67715e63c74471980f2ad509eab6242 : SUCCESS in 1h 08m 26s\n- designate-bind9-core-catalog-zones https://zuul.opendev.org/t/openstack/build/f7a10c2e12454abb9262f4ddb2a96e74 : SUCCESS in 48m 01s (non-voting)\n- designate-only-ipv6-pdns4 https://zuul.opendev.org/t/openstack/build/6121a245b7134485b1aed2dbb5d6d49c : SUCCESS in 42m 12s\n- designate-only-ipv6-bind9 https://zuul.opendev.org/t/openstack/build/94c012f7956340a9b54fb6382e2f49c8 : SUCCESS in 45m 54s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/1fdea4e6e60349d0b7e25fb823f656e7 : SUCCESS in 6m 14s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/88d6746d763f451ea34dc58b9af6c4a9 : SUCCESS in 3m 05s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/df859ae787a842ba82eedef0f9c36e07 : SUCCESS in 5m 00s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/875cd3ba918c40c0869f1722ea032fb5 : SUCCESS in 7m 25s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1b57c44df02b411da82e80f7d41d4c44 : SUCCESS in 8m 34s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/5b29850cf6a24e99b622ccccaea010a8 : SUCCESS in 4m 12s\n- neutron-tempest-plugin-designate-scenario https://zuul.opendev.org/t/openstack/build/60c8711437474139853eb616fea1adb4 : SUCCESS in 18m 54s\n- designate-tox-dnspython-latest https://zuul.opendev.org/t/openstack/build/a8d648f5ca4d482db1f0ecbb8f4a66a8 : SUCCESS in 6m 13s","accounts_in_message":[],"_revision_number":2},{"id":"a2d15609fa72d2773ff081671703d79b2114a232","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2025-12-29 09:26:52.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"2b826d85da7b8671e5bc6b4edcc53d9f1fd125ce","revisions":{"0a9f4b0d231af7d85ede687a297aedd83e9381ae":{"kind":"REWORK","_number":1,"created":"2025-12-24 21:09:54.000000000","uploader":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"ref":"refs/changes/85/971785/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/designate","ref":"refs/changes/85/971785/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/designate refs/changes/85/971785/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/designate refs/changes/85/971785/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/designate refs/changes/85/971785/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/designate refs/changes/85/971785/1"}}},"commit":{"parents":[{"commit":"7c785e72c3936d89531a8866384f19172b1e1111","subject":"reno: Update master for unmaintained/2024.1","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/7c785e72c3936d89531a8866384f19172b1e1111"}]}],"author":{"name":"Omer","email":"oschwart@redhat.com","date":"2025-12-24 21:09:02.000000000","tz":-180},"committer":{"name":"Omer","email":"oschwart@redhat.com","date":"2025-12-24 21:09:02.000000000","tz":-180},"subject":"Improve error messages for invalid UUIDs in notifications","message":"Improve error messages for invalid UUIDs in notifications\n\nWhen notifications contain malformed resource_id or zone_id values,\nDesignate would raise unclear SQLAlchemy errors deep in the database\nlayer, making it difficult to diagnose the root cause.\n\nThis change adds early UUID validation in the notification handler\nbase class that raises a clear ValueError identifying the problematic\nfield, invalid value, and source (Nova/Neutron notification payload).\n\nThis makes debugging significantly easier for operators.\n\nCloses-Bug: #2030326\nAssisted-By: Claude Code 4.5 Sonnet\nChange-Id: I093902f27a1221a063c7f3e7a2dc38525e91dcb1\nSigned-off-by: Omer \u003coschwart@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/0a9f4b0d231af7d85ede687a297aedd83e9381ae"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/0a9f4b0d231af7d85ede687a297aedd83e9381ae"}]},"branch":"refs/heads/master"},"2b826d85da7b8671e5bc6b4edcc53d9f1fd125ce":{"kind":"REWORK","_number":2,"created":"2025-12-24 22:39:31.000000000","uploader":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"ref":"refs/changes/85/971785/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/designate","ref":"refs/changes/85/971785/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/designate refs/changes/85/971785/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/designate refs/changes/85/971785/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/designate refs/changes/85/971785/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/designate refs/changes/85/971785/2"}}},"commit":{"parents":[{"commit":"7c785e72c3936d89531a8866384f19172b1e1111","subject":"reno: Update master for unmaintained/2024.1","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/7c785e72c3936d89531a8866384f19172b1e1111"}]}],"author":{"name":"Omer","email":"oschwart@redhat.com","date":"2025-12-24 21:09:02.000000000","tz":-180},"committer":{"name":"Omer","email":"oschwart@redhat.com","date":"2025-12-24 22:39:23.000000000","tz":-180},"subject":"Improve error messages for invalid UUIDs in notifications","message":"Improve error messages for invalid UUIDs in notifications\n\nWhen notifications contain malformed resource_id or zone_id values,\nDesignate would raise unclear SQLAlchemy errors deep in the database\nlayer, making it difficult to diagnose the root cause.\n\nThis change adds early UUID validation in the notification handler\nbase class that raises a clear ValueError identifying the problematic\nfield, invalid value, and source (Nova/Neutron notification payload).\n\nThis makes debugging significantly easier for operators.\n\nCloses-Bug: #2030326\nAssisted-By: Claude Code 4.5 Sonnet\nChange-Id: I093902f27a1221a063c7f3e7a2dc38525e91dcb1\nSigned-off-by: Omer \u003coschwart@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/2b826d85da7b8671e5bc6b4edcc53d9f1fd125ce"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/2b826d85da7b8671e5bc6b4edcc53d9f1fd125ce"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY"},{"label":"Workflow","status":"MAY"},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Review-Priority","description":"Review priority","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"-label:Review-Priority\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":[],"failing_atoms":["label:Review-Priority\u003dMIN"],"atom_explanations":{"label:Review-Priority\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}