)]}'
{"id":"openstack%2Fdesignate~972058","triplet_id":"openstack%2Fdesignate~master~Ibf81cc7b04b6d47f3085a91e929952c2c9ec6912","project":"openstack/designate","branch":"master","topic":"bug/2136984","attention_set":{"31664":{"account":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"last_update":"2026-01-06 16:15:12.000000000","reason":"\u003cGERRIT_ACCOUNT_22623\u003e replied on the change","reason_account":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}}},"removed_from_attention_set":{},"hashtags":[],"change_id":"Ibf81cc7b04b6d47f3085a91e929952c2c9ec6912","subject":"Fix total_count to include shared zones in zone listing","status":"NEW","created":"2026-01-02 20:45:02.000000000","updated":"2026-01-08 00:20:31.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":true,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"0ade7504080ec16fc19467a77017f9d6295ba7b3","_number":972058,"virtual_id_number":972058,"owner":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":36710,"name":"Jeong Jiho","display_name":"jiho","email":"jiho.jeong@samsung.com","username":"jihoJeong"},{"tag":"autogenerated:zuul:check","value":1,"date":"2026-01-02 22:02:24.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"recommended":{"_account_id":36710,"name":"Jeong Jiho","display_name":"jiho","email":"jiho.jeong@samsung.com","username":"jihoJeong"},"all":[{"value":1,"date":"2026-01-08 00:20:31.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":36710,"name":"Jeong Jiho","display_name":"jiho","email":"jiho.jeong@samsung.com","username":"jihoJeong"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2026-01-06 16:15:12.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":36710,"name":"Jeong Jiho","display_name":"jiho","email":"jiho.jeong@samsung.com","username":"jihoJeong"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"_account_id":36710,"name":"Jeong Jiho","display_name":"jiho","email":"jiho.jeong@samsung.com","username":"jihoJeong"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},{"_account_id":36710,"name":"Jeong Jiho","display_name":"jiho","email":"jiho.jeong@samsung.com","username":"jihoJeong"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-01-02 22:02:24.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-01-06 16:15:12.000000000","updated_by":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"reviewer":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"state":"REVIEWER"},{"updated":"2026-01-08 00:20:31.000000000","updated_by":{"_account_id":36710,"name":"Jeong Jiho","display_name":"jiho","email":"jiho.jeong@samsung.com","username":"jihoJeong"},"reviewer":{"_account_id":36710,"name":"Jeong Jiho","display_name":"jiho","email":"jiho.jeong@samsung.com","username":"jihoJeong"},"state":"REVIEWER"}],"messages":[{"id":"3369852f481ff87b5e5a4205ec3f879623506783","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"date":"2026-01-02 20:45:02.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4ec49a11e4a5f88706e754ae6b4fadcd318e1bce","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-01-02 22:02:24.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/cef7fbadf5c94f609e7a4e3d135feee3\n\n- designate-bind9-core https://zuul.opendev.org/t/openstack/build/47d0471d4c964a018e109e5901c53829 : SUCCESS in 48m 01s\n- designate-bind9-with-keystone-default-roles https://zuul.opendev.org/t/openstack/build/b183fcf6f13a404c8b40d55c7ee1ef4a : SUCCESS in 44m 56s\n- designate-pdns4-core https://zuul.opendev.org/t/openstack/build/ce9d13b3f64f49f8b7d3d0fa2ce65930 : SUCCESS in 38m 23s\n- designate-bind9-multipool https://zuul.opendev.org/t/openstack/build/d9879d809e90434bb82938a978552ff5 : SUCCESS in 32m 18s\n- designate-grenade-bind9 https://zuul.opendev.org/t/openstack/build/3023a75ee1b143618041c6b6402282a6 : SUCCESS in 1h 11m 03s\n- designate-grenade-pdns4 https://zuul.opendev.org/t/openstack/build/8323aaa954ce442cb4919f4c9bd87991 : SUCCESS in 1h 10m 00s\n- designate-grenade-bind9-skip-level https://zuul.opendev.org/t/openstack/build/d8199877d8254b1fb4ec447d499fa457 : SUCCESS in 1h 06m 58s\n- designate-grenade-pdns4-skip-level https://zuul.opendev.org/t/openstack/build/133a777693b641b6a2ba914d4a6f038b : SUCCESS in 56m 44s\n- designate-bind9-core-catalog-zones https://zuul.opendev.org/t/openstack/build/d0956131bedc457aba4c49745c748782 : SUCCESS in 44m 15s (non-voting)\n- designate-only-ipv6-pdns4 https://zuul.opendev.org/t/openstack/build/e834fdc3809b45e4b64006abd28bd2d5 : SUCCESS in 39m 56s\n- designate-only-ipv6-bind9 https://zuul.opendev.org/t/openstack/build/ae9f1f90bfb74d29b82790fb494e5366 : SUCCESS in 43m 39s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/a935acfc564e429cb5ea9a70dac27af6 : SUCCESS in 6m 06s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/0c98c8cfb92d4bf0be4bddc94c4faf11 : SUCCESS in 3m 05s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/6b7e0f01d195446db1d524a3035a7480 : SUCCESS in 4m 24s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/fadbfd2f03744ad88899cc7802d9e23e : SUCCESS in 7m 21s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/aa6c48204652411aa91398d25340bbc9 : SUCCESS in 4m 16s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/e707448ecb764e5ebd0c46d62c32c7df : SUCCESS in 5m 11s\n- neutron-tempest-plugin-designate-scenario https://zuul.opendev.org/t/openstack/build/392add32e8f64bf99541c93fe0c0111a : SUCCESS in 31m 25s\n- designate-tox-dnspython-latest https://zuul.opendev.org/t/openstack/build/efc8495a6355472f9493ff9587c98818 : SUCCESS in 4m 30s","accounts_in_message":[],"_revision_number":1},{"id":"517cd0f3dbd0d30d778dac287550d9f6e68c5691","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2026-01-06 16:15:12.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"0ade7504080ec16fc19467a77017f9d6295ba7b3","author":{"_account_id":36710,"name":"Jeong Jiho","display_name":"jiho","email":"jiho.jeong@samsung.com","username":"jihoJeong"},"date":"2026-01-08 00:20:31.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"693be69311b8b536e7d5d19cc9bf6f0aa7d735c1","revisions":{"693be69311b8b536e7d5d19cc9bf6f0aa7d735c1":{"kind":"REWORK","_number":1,"created":"2026-01-02 20:45:02.000000000","uploader":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"ref":"refs/changes/58/972058/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/designate","ref":"refs/changes/58/972058/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/designate refs/changes/58/972058/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/designate refs/changes/58/972058/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/designate refs/changes/58/972058/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/designate refs/changes/58/972058/1"}}},"commit":{"parents":[{"commit":"7c785e72c3936d89531a8866384f19172b1e1111","subject":"reno: Update master for unmaintained/2024.1","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/7c785e72c3936d89531a8866384f19172b1e1111"}]}],"author":{"name":"Omer","email":"oschwart@redhat.com","date":"2026-01-02 20:43:13.000000000","tz":-180},"committer":{"name":"Omer","email":"oschwart@redhat.com","date":"2026-01-02 20:43:13.000000000","tz":-180},"subject":"Fix total_count to include shared zones in zone listing","message":"Fix total_count to include shared zones in zone listing\n\nThe List Zones API\u0027s metadata.total_count field was excluding shared\nzones from the count, only counting zones owned by the requesting\nproject. This caused pagination logic to break and UI displays to\nshow incorrect counts (e.g., showing 5 of 4 zones) when zones were\nshared between projects.\n\nThe root cause was that count_zones() only queried the zones table\ndirectly, while find_zones() performs a LEFT JOIN with the\nshared_zones table to include zones shared with the project.\n\nThis patch extends count_zones() to accept an include_shared parameter\nthat, when True, performs the same LEFT JOIN logic as find_zones()\nand counts distinct zone IDs to avoid duplicates.\n\nAssisted-By: Claude Code 4.5 Sonnet\nCloses-Bug: #2136984\nChange-Id: Ibf81cc7b04b6d47f3085a91e929952c2c9ec6912\nSigned-off-by: Omer \u003coschwart@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/693be69311b8b536e7d5d19cc9bf6f0aa7d735c1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/693be69311b8b536e7d5d19cc9bf6f0aa7d735c1"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}},{"label":"Workflow","status":"MAY"},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Review-Priority","description":"Review priority","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"-label:Review-Priority\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":[],"failing_atoms":["label:Review-Priority\u003dMIN"],"atom_explanations":{"label:Review-Priority\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}