)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"521c28f1de211596514a9bfb7f8ce610cfbf078a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7ac44330_25e012d5","updated":"2026-02-12 00:19:04.000000000","message":"recheck failure is not related to the patch","commit_id":"4cad92316322b57ec1f1db156a11a325241435f8"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"ca10f7962c42cbe50c1cfbfa86e95c00dd882990","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"93f3948e_c7628b8c","updated":"2026-02-11 15:14:02.000000000","message":"recheck grenade jobs are not broken anymore","commit_id":"4cad92316322b57ec1f1db156a11a325241435f8"}],"designate/manage/pool.py":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"8a70761d63db1cf75f03fab479b0248b12a378c5","unresolved":true,"context_lines":[{"line_number":218,"context_line":"        # present in the YAML file before parsing"},{"line_number":219,"context_line":"        if self.replace:"},{"line_number":220,"context_line":"            # Map field names to their empty object types"},{"line_number":221,"context_line":"            empty_values \u003d {"},{"line_number":222,"context_line":"                \u0027also_notifies\u0027: objects.PoolAlsoNotifyList(),"},{"line_number":223,"context_line":"                \u0027attributes\u0027: objects.PoolAttributeList(),"},{"line_number":224,"context_line":"                \u0027catalog_zone\u0027: None,"}],"source_content_type":"text/x-python","patch_set":1,"id":"d7c13ad6_ade93613","line":221,"updated":"2026-02-10 17:11:20.000000000","message":"Feels like there should be a better pattern here. What happens if we change, add or remove any fields in the future.","commit_id":"4cad92316322b57ec1f1db156a11a325241435f8"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"4fd9dd274a83e28478636820d880feadb17f5a08","unresolved":true,"context_lines":[{"line_number":218,"context_line":"        # present in the YAML file before parsing"},{"line_number":219,"context_line":"        if self.replace:"},{"line_number":220,"context_line":"            # Map field names to their empty object types"},{"line_number":221,"context_line":"            empty_values \u003d {"},{"line_number":222,"context_line":"                \u0027also_notifies\u0027: objects.PoolAlsoNotifyList(),"},{"line_number":223,"context_line":"                \u0027attributes\u0027: objects.PoolAttributeList(),"},{"line_number":224,"context_line":"                \u0027catalog_zone\u0027: None,"}],"source_content_type":"text/x-python","patch_set":1,"id":"757f900e_4afd270b","line":221,"in_reply_to":"d7c13ad6_ade93613","updated":"2026-02-11 13:21:14.000000000","message":"I wonder if we should add something like this:\n\nOPTIONAL_CLEARABLE_FIELDS \u003d [\u0027also_notifies\u0027, \u0027attributes\u0027, \u0027catalog_zone\u0027]\n\nhere https://opendev.org/openstack/designate/src/branch/master/designate/objects/pool.py#L21\n\nand then use it in the _update_pool method, what do you think?","commit_id":"4cad92316322b57ec1f1db156a11a325241435f8"}]}
