)]}'
{"contrib/devstack/exercises/designate.sh":[{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"7ddfd5a668dbeeb7baa87cfc3a54f6601e77a5f1","unresolved":false,"context_lines":[{"line_number":150,"context_line":"designate record-list $DOMAIN_ID"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"# Fetch the record - should be gone"},{"line_number":153,"context_line":"designate record-get $DOMAIN_ID $CNAME_RECORD_ID || echo \"good - record was removed\""},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"# verify not in DNS anymore"},{"line_number":156,"context_line":"verify_name_type_dns $CNAME_RECORD_NAME CNAME $DOMAIN_NAME 1"}],"source_content_type":"text/x-sh","patch_set":21,"id":"baada198_f392b249","line":153,"updated":"2014-07-25 23:29:24.000000000","message":"Will merge this now - but this will not fail if the record still exists.\n\nWe should be testing the return code of the designate command, and then decide if it has passed or not.\n\nNeed to fix in a follow up patchset.","commit_id":"112d292a27e17115b7a2659c3afdd76adb0682d5"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"7ddfd5a668dbeeb7baa87cfc3a54f6601e77a5f1","unresolved":false,"context_lines":[{"line_number":162,"context_line":"designate domain-delete $DOMAIN_ID"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"# Fetch the domain - should be gone"},{"line_number":165,"context_line":"designate domain-get $DOMAIN_ID || echo \"good - domain was removed\""},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"# should not have SOA and NS records"},{"line_number":168,"context_line":"verify_name_type_dns $DOMAIN_NAME SOA $DESIGNATE_TEST_NSREC 1"}],"source_content_type":"text/x-sh","patch_set":21,"id":"baada198_33998a6d","line":165,"updated":"2014-07-25 23:29:24.000000000","message":"Same as above","commit_id":"112d292a27e17115b7a2659c3afdd76adb0682d5"}],"contrib/devstack/lib/designate":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"8b9129f07017c95a1054a1b7fd00a02fad420b83","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        return 0"},{"line_number":66,"context_line":"    fi"},{"line_number":67,"context_line":"    # give DNS changes time to show up"},{"line_number":68,"context_line":"    sleep 5"},{"line_number":69,"context_line":"    # for debugging"},{"line_number":70,"context_line":"    dig $DESIGNATE_DIG_FLAGS $DESIGNATE_DIG_HOST \"$1\" \"$2\""},{"line_number":71,"context_line":"    if [ -n \"$4\" ] ; then"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1ae5cdf2_0476b706","line":68,"updated":"2014-06-06 17:30:11.000000000","message":"Can we reduce this down to 1 sec or so? 5 seems awful large!","commit_id":"7009ab8546cf1b4e5bbfb807070e05b3b66411b3"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"8b9129f07017c95a1054a1b7fd00a02fad420b83","unresolved":false,"context_lines":[{"line_number":220,"context_line":"        # if there are problems, but we don\u0027t want the stdout being returned"},{"line_number":221,"context_line":"        # by this function"},{"line_number":222,"context_line":"        if [[ \"$1\" \u003d \"$DESIGNATE_TEST_DOMAIN_FIX\" ]]; then"},{"line_number":223,"context_line":"            designate domain-create --name $DESIGNATE_TEST_DOMAIN_FIX --email $DESIGNATE_TEST_EMAIL_FIX --ttl 86400 --description \"fixed ip domain\" 1\u003e\u00262"},{"line_number":224,"context_line":"        elif [[ \"$1\" \u003d \"$DESIGNATE_TEST_DOMAIN_FLT\" ]]; then"},{"line_number":225,"context_line":"            designate domain-create --name $DESIGNATE_TEST_DOMAIN_FLT --email $DESIGNATE_TEST_EMAIL_FLT --ttl 86400 --description \"floating ip domain\" 1\u003e\u00262"},{"line_number":226,"context_line":"        else"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"1ae5cdf2_64c05be1","line":223,"updated":"2014-06-06 17:30:11.000000000","message":"DESIGNATE_TEST_DOMAIN_FIX etc are not defined, and probably shouldn\u0027t get special treatment in this method when they return.","commit_id":"7009ab8546cf1b4e5bbfb807070e05b3b66411b3"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"e2ada81fbe6c1741298919e4071f3b7a0420500f","unresolved":false,"context_lines":[{"line_number":45,"context_line":"DESIGNATE_BIN_DIR\u003d$(get_python_exec_prefix)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# used with dig to look up in DNS"},{"line_number":48,"context_line":"DESIGNATE_DIG_HOST\u003d\"@localhost\""},{"line_number":49,"context_line":"DESIGNATE_DIG_FLAGS\u003d\"+short\""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# only if using IPA"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"1ae5cdf2_77e62746","line":48,"updated":"2014-06-09 11:01:04.000000000","message":"Also, can we use 127.0.0.1 ?\n\nDifferent distros have different IPs in /etc/hosts for localhost\n\nUsually either 127.0.0.1 or 127.0.1.1 - Since we need to bind tpo a specific IP (DevStack with Nova will start dnsmasq on an IP, if our DNS server is bound to 0.0.0.0:53, things will break.","commit_id":"40c84a7612c883c72b26785fc2826121fd63aeef"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"839efcf43666dbb40370c357845878a9279a8056","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        # the 1\u003e\u00262 will redirect stdout to stderr instead, which is useful"},{"line_number":220,"context_line":"        # if there are problems, but we don\u0027t want the stdout being returned"},{"line_number":221,"context_line":"        # by this function"},{"line_number":222,"context_line":"        if [[ \"$1\" \u003d \"$DESIGNATE_TEST_DOMAIN_FIX\" ]]; then"},{"line_number":223,"context_line":"            designate domain-create --name $DESIGNATE_TEST_DOMAIN_FIX --email $DESIGNATE_TEST_EMAIL_FIX --ttl 86400 --description \"fixed ip domain\" 1\u003e\u00262"},{"line_number":224,"context_line":"        elif [[ \"$1\" \u003d \"$DESIGNATE_TEST_DOMAIN_FLT\" ]]; then"},{"line_number":225,"context_line":"            designate domain-create --name $DESIGNATE_TEST_DOMAIN_FLT --email $DESIGNATE_TEST_EMAIL_FLT --ttl 86400 --description \"floating ip domain\" 1\u003e\u00262"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"1ae5cdf2_fcccf363","line":222,"updated":"2014-06-07 10:39:13.000000000","message":"DESIGNATE_TEST_DOMAIN_FIX etc are not defined, and probably shouldn\u0027t get special treatment in this method when they return.","commit_id":"40c84a7612c883c72b26785fc2826121fd63aeef"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"bac2b0c144897791db6a8809b9ad9e175c35415b","unresolved":false,"context_lines":[{"line_number":64,"context_line":"# only if using IPA"},{"line_number":65,"context_line":"IPA_HOST\u003d${IPA_HOST:-$(hostname)}"},{"line_number":66,"context_line":"IPA_CA_CERT\u003d${IPA_CA_CERT:-/etc/ipa/ca.crt}"},{"line_number":67,"context_line":"IPA_CLIENT_KEYTAB\u003d${IPA_CLIENT_KEYTAB:-$HOME/ipaadmin.keytab}"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"# Functions"},{"line_number":70,"context_line":"# ---------"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"1ae5cdf2_860c3044","line":67,"updated":"2014-06-10 14:47:04.000000000","message":"I think these get brought back in by accident - they now live in lib/designate_plugins/backend-ipa","commit_id":"10964096fdf656341e3d49bb754c8ab2f91ab0ca"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"bac2b0c144897791db6a8809b9ad9e175c35415b","unresolved":false,"context_lines":[{"line_number":230,"context_line":"        fi"},{"line_number":231,"context_line":"    fi"},{"line_number":232,"context_line":"}"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"# get the domain_name given the id"},{"line_number":235,"context_line":"function get_domain_name() {"},{"line_number":236,"context_line":"    designate domain-list | grep \"$1\" | get_field 2"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"1ae5cdf2_f12f6c86","line":233,"updated":"2014-06-10 14:47:04.000000000","message":"Only since there\u0027s going to be another patchset anyway due to the IPA vars - Can we move the two methods below to beside the `get_record_id` etc methods above?","commit_id":"10964096fdf656341e3d49bb754c8ab2f91ab0ca"}],"contrib/devstack/lib/designate_plugins/backend-bind9":[{"author":{"_account_id":9983,"name":"Richard Megginson","email":"rmeggins@redhat.com","username":"rmeggins"},"change_message_id":"d6ecf1249b1b731843870bcc0059030df5b00af0","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    allow-new-zones yes;"},{"line_number":97,"context_line":"    dnssec-validation auto;"},{"line_number":98,"context_line":"    auth-nxdomain no;    # conform to RFC1035"},{"line_number":99,"context_line":"    listen-on $DESIGNATE_SERVICE_HOST $DESIGNATE_SERVICE_PORT_DNS { any; };"},{"line_number":100,"context_line":"};"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"controls {"}],"source_content_type":"application/octet-stream","patch_set":14,"id":"baada198_1a1c2777","line":99,"updated":"2014-07-16 17:22:14.000000000","message":"According to the man page, the format of the listen-on directive is this:\n  listen-on [port INTEGER] { (ipv4_addr | ipv6_addr) [ port INTEGER ]; ...};","commit_id":"105e701f1084fbd3b467c5178bd1933e9c7b0054"}]}