)]}'
{"designate/sink/service.py":[{"author":{"_account_id":8094,"name":"Vinod Mangalpally","email":"mrvinod@outlook.com","username":"vinodmr"},"change_message_id":"61c129567136435808570da86f90119881a79285","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        # TODO(ekarlso): Change this is to endpoint objects rather then"},{"line_number":67,"context_line":"        # ourselves?"},{"line_number":68,"context_line":"        self._server \u003d rpc.get_listener(targets, [self])"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        if len(targets) \u003e 0:"},{"line_number":71,"context_line":"            self._server.start()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_d0110e05","line":68,"updated":"2014-06-05 18:17:11.000000000","message":"Should the assignment of self._server also be done only if len(targets) \u003e 0?","commit_id":"fa27103398214c7f9c1ad7963159c69b00a64ae3"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"7ba7cd44bc232d4daeecdda7e65f490fa7fe0236","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        # TODO(ekarlso): Change this is to endpoint objects rather then"},{"line_number":67,"context_line":"        # ourselves?"},{"line_number":68,"context_line":"        self._server \u003d rpc.get_listener(targets, [self])"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        if len(targets) \u003e 0:"},{"line_number":71,"context_line":"            self._server.start()"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ae5cdf2_90bce6bc","line":68,"in_reply_to":"1ae5cdf2_d0110e05","updated":"2014-06-05 18:22:46.000000000","message":"Possibly, but I wanted to keep the change small as I\u0027m aiming to get the DevStack gate running :)\n\nIf _server was not set, then the stop() method would need to know if there was \u003e0 targets as well.","commit_id":"fa27103398214c7f9c1ad7963159c69b00a64ae3"}]}