)]}'
{"id":"openstack%2Fdesignate~986336","triplet_id":"openstack%2Fdesignate~stable%2F2026.1~If9a4ef72be8d2fb5f18cfe3bf1231726f2a9bfe5","project":"openstack/designate","branch":"stable/2026.1","hashtags":[],"change_id":"If9a4ef72be8d2fb5f18cfe3bf1231726f2a9bfe5","subject":"Set allow_empty_secrets_for_tsig\u003dFalse in grenade job config","status":"MERGED","created":"2026-04-27 09:26:28.000000000","updated":"2026-05-11 14:48:49.000000000","submitted":"2026-05-11 14:45:04.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"986336","meta_rev_id":"e0613315eac56f1649a0591bc1fb3f422248857a","_number":986336,"virtual_id_number":986336,"owner":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2026-05-11 14:45:04.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"all":[{"value":2,"date":"2026-05-11 13:10:19.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"all":[{"value":1,"date":"2026-05-11 13:10:19.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-04-27 10:49:47.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"71ce476f0a62bfec270fca9659b35c415bbbd6b8","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"date":"2026-04-27 09:26:28.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d07a40cb338a07311dfbd941d56a9ea69c6f4362","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-04-27 10:49:47.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/844f123f95fd46dd8b4f2b39023e9e3c\n\n- designate-bind9-core https://zuul.opendev.org/t/openstack/build/e255741655f343b38210f492342d8b27 : SUCCESS in 50m 50s\n- designate-bind9-with-keystone-default-roles https://zuul.opendev.org/t/openstack/build/22890777dd5f4e9c9f1b236f6b3c9736 : SUCCESS in 51m 50s\n- designate-pdns4-core https://zuul.opendev.org/t/openstack/build/c70361e03835425ba128576bdffca87b : SUCCESS in 47m 08s\n- designate-bind9-multipool https://zuul.opendev.org/t/openstack/build/680433a27e3645a0ae79163e1ebc359c : SUCCESS in 32m 46s\n- designate-grenade-bind9 https://zuul.opendev.org/t/openstack/build/a5c7280fa3d7454e8176c38da71b19b2 : SUCCESS in 1h 12m 45s\n- designate-grenade-pdns4 https://zuul.opendev.org/t/openstack/build/16aaef97cb8f4011ae3d8587d6382711 : SUCCESS in 1h 10m 06s\n- designate-grenade-bind9-skip-level https://zuul.opendev.org/t/openstack/build/f99b73e8fa4a4908a8cf50de2cdeae08 : SUCCESS in 1h 13m 37s\n- designate-grenade-pdns4-skip-level https://zuul.opendev.org/t/openstack/build/791675de353c4f459238705ea068b6b1 : SUCCESS in 1h 03m 42s\n- designate-bind9-core-catalog-zones https://zuul.opendev.org/t/openstack/build/9bf4dfed8ff54cb6b42dd279de7af1f5 : SUCCESS in 44m 02s (non-voting)\n- designate-only-ipv6-pdns4 https://zuul.opendev.org/t/openstack/build/a857924603c6431ca253a29bb571b16a : SUCCESS in 49m 02s\n- designate-only-ipv6-bind9 https://zuul.opendev.org/t/openstack/build/fb202d76c1c049a4bcbf3b993b5be6c3 : SUCCESS in 43m 46s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/5c9555a0c3f44781a875396844533bf1 : SUCCESS in 5m 59s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/b5902be13d6041a690a0bdcd54a98f27 : SUCCESS in 3m 38s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/3dbaacc68f95490e886a6d9e47a87086 : SUCCESS in 4m 50s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/0ef3650557174de19c5635808b09299a : SUCCESS in 5m 12s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b771733c925b4344992966f3cce1f076 : SUCCESS in 5m 18s\n- neutron-tempest-plugin-designate-scenario https://zuul.opendev.org/t/openstack/build/599f43d112cc494394fbe269b251165a : SUCCESS in 32m 20s\n- designate-tox-dnspython-latest https://zuul.opendev.org/t/openstack/build/3995704911ca49c18912545d633ac7f5 : SUCCESS in 6m 23s","accounts_in_message":[],"_revision_number":1},{"id":"bba9ecef50baeea4749ec497d6b1aa5d13ce916f","author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"date":"2026-05-11 13:10:19.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"5d33eb8ceb8735fba8f3027c824b3dfeb1bcd87a","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-05-11 13:11:22.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"ab3bee89a3d655ce28987b1f816a56db88f598fb","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-05-11 14:45:04.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/a932017f620a488fa272e51f39a5e25b\n\n- designate-bind9-core https://zuul.opendev.org/t/openstack/build/80f510eb927a48209a5a220d3f6e557b : SUCCESS in 48m 32s\n- designate-bind9-with-keystone-default-roles https://zuul.opendev.org/t/openstack/build/830a41cc1b8c49f697a78fd87aae13f9 : SUCCESS in 48m 03s\n- designate-pdns4-core https://zuul.opendev.org/t/openstack/build/cbbaca0a3f0a4588b90221a4ea89edc9 : SUCCESS in 45m 12s\n- designate-bind9-multipool https://zuul.opendev.org/t/openstack/build/f313ef54665d440da707d399dfb027bf : SUCCESS in 34m 28s\n- designate-grenade-pdns4 https://zuul.opendev.org/t/openstack/build/34b3ee62e1cc412cbd061ad56a8d57d8 : SUCCESS in 1h 22m 02s\n- designate-grenade-bind9 https://zuul.opendev.org/t/openstack/build/25762e93a3a249ba91b85fa4f605ff37 : SUCCESS in 1h 12m 22s\n- designate-grenade-pdns4-skip-level https://zuul.opendev.org/t/openstack/build/616116e866c5471bbcd186d368a75d98 : SUCCESS in 56m 40s\n- designate-grenade-bind9-skip-level https://zuul.opendev.org/t/openstack/build/a17edbb5b82444ea88f576027d961328 : SUCCESS in 1h 22m 13s\n- designate-only-ipv6-pdns4 https://zuul.opendev.org/t/openstack/build/9d709722b33a4ab5bcc553b8f9d41ce3 : SUCCESS in 50m 42s\n- designate-only-ipv6-bind9 https://zuul.opendev.org/t/openstack/build/80f336cb10f54dafad3243bea9e846ee : SUCCESS in 57m 50s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/7598559daa1c4987b0a0a55dd88a2a4e : SUCCESS in 3m 15s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/3dc42074fc04479da668186009086aae : SUCCESS in 4m 59s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/865b09fdafdb408ebec7352140e4eed9 : SUCCESS in 5m 12s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/df1953a701a948108d20752a7dd3ca84 : SUCCESS in 7m 47s\n- neutron-tempest-plugin-designate-scenario https://zuul.opendev.org/t/openstack/build/c05c69ff35194b6aad03a4271284facf : SUCCESS in 32m 48s","accounts_in_message":[],"_revision_number":1},{"id":"09cd5ec4b12d9ff0afbf0043843997c0d56b4e01","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-05-11 14:45:04.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"e0613315eac56f1649a0591bc1fb3f422248857a","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-05-11 14:48:49.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/786c716d100c447c9f89e7f6715ee516\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1f6643839b554817b222bb669ff36c92 : SUCCESS in 1m 31s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"5b047dcabd6ea24f0653f4777d6f0d09ea47bb62","revisions":{"5b047dcabd6ea24f0653f4777d6f0d09ea47bb62":{"kind":"REWORK","_number":1,"created":"2026-04-27 09:26:28.000000000","uploader":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"ref":"refs/changes/36/986336/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/designate","ref":"refs/changes/36/986336/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/designate refs/changes/36/986336/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/designate refs/changes/36/986336/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/designate refs/changes/36/986336/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/designate refs/changes/36/986336/1"}}},"commit":{"parents":[{"commit":"8f4f747f5c32b5316ca029798376e9471bfc35cb","subject":"Update TOX_CONSTRAINTS_FILE for stable/2026.1","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/8f4f747f5c32b5316ca029798376e9471bfc35cb"}]}],"author":{"name":"Omer","email":"oschwart@redhat.com","date":"2026-03-18 15:54:26.000000000","tz":60},"committer":{"name":"Omer","email":"oschwart@redhat.com","date":"2026-04-27 09:22:34.000000000","tz":120},"subject":"Set allow_empty_secrets_for_tsig\u003dFalse in grenade job config","message":"Set allow_empty_secrets_for_tsig\u003dFalse in grenade job config\n\nRather than changing the default value of allow_empty_secrets_for_tsig\nfrom True to False (which would be an API breaking change), configure\nit explicitly in the grenade job\u0027s devstack_local_conf. This ensures\nthe tempest test_create_tsigkey_for_zone_empty_secret test runs with\nserver-side validation enforced, without breaking existing deployments\nthat rely on the current default.\n\nChange-Id: If9a4ef72be8d2fb5f18cfe3bf1231726f2a9bfe5\nSigned-off-by: Omer \u003coschwart@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/5b047dcabd6ea24f0653f4777d6f0d09ea47bb62"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/5b047dcabd6ea24f0653f4777d6f0d09ea47bb62"}]},"branch":"refs/heads/stable/2026.1"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"}},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Review-Priority","description":"Review priority","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"-label:Review-Priority\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":[],"failing_atoms":["label:Review-Priority\u003dMIN"],"atom_explanations":{"label:Review-Priority\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}