)]}'
{"id":"openstack%2Fdesignate~996761","triplet_id":"openstack%2Fdesignate~master~Ib925e72a7775b34d005d258e52e7167d05027597","project":"openstack/designate","branch":"master","hashtags":[],"change_id":"Ib925e72a7775b34d005d258e52e7167d05027597","subject":"Fix catalog zone TSIG key name to not include a trailing dot","status":"NEW","created":"2026-07-10 11:08:19.000000000","updated":"2026-07-10 12:33:02.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":true,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"88b0fc0d7f0621da6470c453a0d019248e2bf4f4","_number":996761,"virtual_id_number":996761,"owner":{"_account_id":20178,"name":"Tore Anderson","email":"tore@fud.no","username":"tore"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2026-07-10 12:33:02.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-07-10 12:33:02.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"8e5b4ff705f8320c9a82d9935e58ddbbc5653a10","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":20178,"name":"Tore Anderson","email":"tore@fud.no","username":"tore"},"date":"2026-07-10 11:08:19.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"88b0fc0d7f0621da6470c453a0d019248e2bf4f4","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-07-10 12:33:02.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/3f5d8014a30043c68141dea101a3081d\n\n- designate-bind9-core https://zuul.opendev.org/t/openstack/build/90e5470d98f448aba5be637a49f2094a : SUCCESS in 52m 54s\n- designate-bind9-with-keystone-default-roles https://zuul.opendev.org/t/openstack/build/6eab0a8625034fd9bf0c09a3e378ca22 : SUCCESS in 52m 17s\n- designate-pdns4-core https://zuul.opendev.org/t/openstack/build/92be5f6c46ed4cf9a9aac07a0c3c8df9 : SUCCESS in 53m 29s\n- designate-bind9-multipool https://zuul.opendev.org/t/openstack/build/17e48e1551f84ee69451609c5abfc7dc : SUCCESS in 38m 25s\n- designate-grenade-bind9 https://zuul.opendev.org/t/openstack/build/8ac5c7fe7aaa44d599c32deca90e4980 : SUCCESS in 1h 17m 20s\n- designate-grenade-pdns4 https://zuul.opendev.org/t/openstack/build/0b1b46a90413470cb71d7e3b2248710c : SUCCESS in 1h 14m 48s\n- designate-grenade-bind9-skip-level https://zuul.opendev.org/t/openstack/build/d0a3ff63dd654af09d01c0b9d9cdf8a8 : SUCCESS in 57m 01s\n- designate-grenade-pdns4-skip-level https://zuul.opendev.org/t/openstack/build/4c920ed53dd54f77b4fe6f581112e98f : SUCCESS in 1h 12m 55s\n- designate-bind9-core-catalog-zones https://zuul.opendev.org/t/openstack/build/d33e907a876545c388a391ac5dd5de1e : SUCCESS in 49m 41s (non-voting)\n- designate-only-ipv6-pdns4 https://zuul.opendev.org/t/openstack/build/87757357ae9d4d6ab8076cde21bd89e6 : SUCCESS in 56m 19s\n- designate-only-ipv6-bind9 https://zuul.opendev.org/t/openstack/build/ebd2dec4b7ae42debf0a432389639f78 : SUCCESS in 52m 19s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/e018a77603184cc1a04bb92e43b81c4c : SUCCESS in 5m 59s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/896a5af9da9c4d9981c175bc15276089 : SUCCESS in 3m 46s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/2196b9e148c840a58fa46449484d79d1 : SUCCESS in 4m 44s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/1d32267e7af44b18a6ef5faba674d021 : SUCCESS in 4m 46s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/2257750afd1b41a69145dd2cd8f30e4a : SUCCESS in 9m 05s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/68100a4118784ed5a8f561ee8f45d6c5 : SUCCESS in 6m 20s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/b8f28b7227a44467b3ffa8403580bde7 : SUCCESS in 6m 15s\n- neutron-tempest-plugin-designate-scenario https://zuul.opendev.org/t/openstack/build/e75eeb90549a40ba858ce375889addee : SUCCESS in 37m 10s\n- designate-tox-dnspython-latest https://zuul.opendev.org/t/openstack/build/335df75421d34e3db0d3749a51e261ff : SUCCESS in 6m 33s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"35c1f9ad004af46f4fa44491b6ed7e56205edc10","revisions":{"35c1f9ad004af46f4fa44491b6ed7e56205edc10":{"kind":"REWORK","_number":1,"created":"2026-07-10 11:08:19.000000000","uploader":{"_account_id":20178,"name":"Tore Anderson","email":"tore@fud.no","username":"tore"},"ref":"refs/changes/61/996761/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/designate","ref":"refs/changes/61/996761/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/designate refs/changes/61/996761/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/designate refs/changes/61/996761/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/designate refs/changes/61/996761/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/designate refs/changes/61/996761/1"}}},"commit":{"parents":[{"commit":"121839fc97fd3773bba4cd3b59f5e918e131bcdb","subject":"Merge \"Fix multipool-bind9 devstack plugin for Ubuntu 26.04+\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/121839fc97fd3773bba4cd3b59f5e918e131bcdb"}]}],"author":{"name":"Tore Anderson","email":"tore@redpill-linpro.com","date":"2026-07-10 11:00:41.000000000","tz":120},"committer":{"name":"Tore Anderson","email":"tore@redpill-linpro.com","date":"2026-07-10 11:07:44.000000000","tz":120},"subject":"Fix catalog zone TSIG key name to not include a trailing dot","message":"Fix catalog zone TSIG key name to not include a trailing dot\n\nThe catalog zone\u0027s TSIG key name was set directly from the catalog\nzone\u0027s FQDN attribute, which always carries a trailing dot (it\u0027s a\nDomainField, enforced by fields.DomainField.coerce). But\ndesignate-mdns resolves an incoming TSIG-signed request\u0027s key by\ndns.name.Name.to_text(omit_final_dot\u003dTrue), which always strips the\ntrailing dot, in both dnsutils.TsigKeyring.get (used during signature\nverification) and dnsmiddleware.TsigInfoMiddleware (used to scope the\nkey afterward). Storage does an exact string match on name, so the\ndotted stored value never matched the dot-less lookup key, and\nTSIG-authenticated AXFR of the catalog zone would fail with an unknown\nTSIG key regardless of what name the client configured.\n\nStrip the trailing dot when creating or updating the catalog zone\u0027s\nTSIG key so its stored name matches what designate-mdns actually\nqueries for.\n\nPartial-Bug: #2121861\n\nCo-Authored-By: Claude Sonnet 5 \u003cnoreply@anthropic.com\u003e\nChange-Id: Ib925e72a7775b34d005d258e52e7167d05027597\nSigned-off-by: Tore Anderson \u003ctore@redpill-linpro.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/35c1f9ad004af46f4fa44491b6ed7e56205edc10"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/35c1f9ad004af46f4fa44491b6ed7e56205edc10"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY"},{"label":"Workflow","status":"MAY"},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Review-Priority","description":"Review priority","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"-label:Review-Priority\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":[],"failing_atoms":["label:Review-Priority\u003dMIN"],"atom_explanations":{"label:Review-Priority\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}