)]}'
{"id":"openstack%2Fdesignate~998006","triplet_id":"openstack%2Fdesignate~stable%2F2026.1~I5a2a18903e2bdc6a7b2202203ef3d41a0c6a7849","project":"openstack/designate","branch":"stable/2026.1","attention_set":{},"removed_from_attention_set":{"31664":{"account":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"last_update":"2026-07-22 11:26:43.000000000","reason":"\u003cGERRIT_ACCOUNT_31664\u003e replied on the change","reason_account":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"}}},"hashtags":[],"change_id":"I5a2a18903e2bdc6a7b2202203ef3d41a0c6a7849","subject":"Require TSIG keys for zones in non-default pools","status":"MERGED","created":"2026-07-20 15:16:51.000000000","updated":"2026-07-22 13:10:06.000000000","submitted":"2026-07-22 13:07:43.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"998006","meta_rev_id":"9adb3e1016797202e83148051befcd7d0b7c7834","_number":998006,"virtual_id_number":998006,"owner":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2026-07-22 13:07:43.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"all":[{"value":2,"date":"2026-07-22 11:26:43.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2026-07-22 10:39:57.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"all":[{"value":1,"date":"2026-07-22 11:26:43.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"recommended":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"all":[{"value":1,"date":"2026-07-22 11:26:43.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","value":1,"default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-07-20 16:48:34.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-07-22 10:39:57.000000000","updated_by":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"reviewer":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"state":"REVIEWER"}],"messages":[{"id":"9fbfb053710657622952ed3f3b325d4e49bb6aa2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"date":"2026-07-20 15:16:51.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"cdeda58d980931936aceb0fdc18fc38b9c685144","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-07-20 16:48:34.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/46f0139019704f3797241f16c821e62f\n\n- designate-bind9-core https://zuul.opendev.org/t/openstack/build/5f2219d7a5d140349661d7e522a6f19d : SUCCESS in 41m 14s\n- designate-bind9-with-keystone-default-roles https://zuul.opendev.org/t/openstack/build/fc21749e4f6943e28c99611c920d5fdc : SUCCESS in 40m 12s\n- designate-pdns4-core https://zuul.opendev.org/t/openstack/build/b13289e72d1c488d8317ca61fd908d9a : SUCCESS in 46m 51s\n- designate-bind9-multipool https://zuul.opendev.org/t/openstack/build/87d364e5a76949b58401f3d36c66f60b : SUCCESS in 37m 49s\n- designate-grenade-bind9 https://zuul.opendev.org/t/openstack/build/ad3610d61ce344c9877a8471600517ff : SUCCESS in 1h 15m 29s\n- designate-grenade-pdns4 https://zuul.opendev.org/t/openstack/build/e49a9aa2903c44e0a9e741376c1767f5 : SUCCESS in 1h 23m 59s\n- designate-grenade-bind9-skip-level https://zuul.opendev.org/t/openstack/build/bcccf764567c441f8f1e8184d22d25bd : SUCCESS in 1h 11m 56s\n- designate-grenade-pdns4-skip-level https://zuul.opendev.org/t/openstack/build/c046a53d75ec42eb97151b6a68ce7da3 : SUCCESS in 1h 18m 30s\n- designate-bind9-core-catalog-zones https://zuul.opendev.org/t/openstack/build/8e96c94953dc4c91b5b375850135d6b0 : SUCCESS in 49m 12s (non-voting)\n- designate-only-ipv6-pdns4 https://zuul.opendev.org/t/openstack/build/05700a47aef74173b020314d28e1c711 : SUCCESS in 48m 23s\n- designate-only-ipv6-bind9 https://zuul.opendev.org/t/openstack/build/7c486bbff86b4a4b9da1dd49f99aa8b3 : SUCCESS in 52m 52s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/0a16e9cc23914560a6034afb280030df : SUCCESS in 7m 47s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/19a501a031d547409a741bb207e10aae : SUCCESS in 3m 25s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/52302a602b1d438e8cd04e1f2c62960a : SUCCESS in 5m 00s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/09a206134fd3445a94f69225f798259e : SUCCESS in 4m 51s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/e8700839a1b44f46b384930cf761b98d : SUCCESS in 7m 38s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9da3912ba7e845d6a28f03690efb41da : SUCCESS in 9m 20s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/d0ab8ddd0ad04ff6aec561f7dabcc4d7 : SUCCESS in 7m 19s\n- neutron-tempest-plugin-designate-scenario https://zuul.opendev.org/t/openstack/build/23b988d17f6b4484849b814fc4452c09 : SUCCESS in 30m 07s\n- designate-tox-dnspython-latest https://zuul.opendev.org/t/openstack/build/ac63258059114c76a8fcc3a14ee1a62d : SUCCESS in 7m 35s","accounts_in_message":[],"_revision_number":1},{"id":"b29aa8bf357b7caf598d7de6d366a4a2381e903c","author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"date":"2026-07-21 14:06:21.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"01f9cd9583857281e5d860f871f9dd1f094fa915","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2026-07-22 10:39:57.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"6d7997b90b4d85793c81542892662da753244103","author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"date":"2026-07-22 11:26:43.000000000","message":"Patch Set 1: Code-Review+2 Review-Priority+1 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"3551d8170cc53c32ce5dd122584a2d604e176a7c","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-07-22 11:27:17.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"f912e30b0813efa7a4fd673a48901b9dc9bf7ff5","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-07-22 13:07:43.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/1995735420db410d88437ba77f9e2150\n\n- designate-bind9-core https://zuul.opendev.org/t/openstack/build/84521a85c3d14a3380019eec5373246f : SUCCESS in 58m 19s\n- designate-bind9-with-keystone-default-roles https://zuul.opendev.org/t/openstack/build/adf66c3889bd42b08f15c7eb54d315ef : SUCCESS in 49m 49s\n- designate-pdns4-core https://zuul.opendev.org/t/openstack/build/d13ab8dafec34aef85a43ef2ddf0b2a0 : SUCCESS in 47m 19s\n- designate-bind9-multipool https://zuul.opendev.org/t/openstack/build/3c29a3525a574bf4a32ae9ab282fbb1d : SUCCESS in 16m 59s\n- designate-grenade-pdns4 https://zuul.opendev.org/t/openstack/build/85b52e4aed3c4be89d22d752f21827ca : SUCCESS in 1h 14m 13s\n- designate-grenade-bind9 https://zuul.opendev.org/t/openstack/build/6d465e6f204c48129eb643dcc33a9b6b : SUCCESS in 1h 14m 37s\n- designate-grenade-pdns4-skip-level https://zuul.opendev.org/t/openstack/build/56cdeebfe1dd4b01aaa2ac1c3f8dfc3e : SUCCESS in 54m 20s\n- designate-grenade-bind9-skip-level https://zuul.opendev.org/t/openstack/build/edb36f9ef6934f96a20e40baa1b654a8 : SUCCESS in 54m 16s\n- designate-only-ipv6-pdns4 https://zuul.opendev.org/t/openstack/build/03fd1b04ec794d0aa714dfb2a60232bc : SUCCESS in 47m 11s\n- designate-only-ipv6-bind9 https://zuul.opendev.org/t/openstack/build/d88b9e7907c74d079e1db0acdf829983 : SUCCESS in 43m 06s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/3df979aad9a7476ca9df77d016c790ce : SUCCESS in 3m 09s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/aeb0ef5737e540f195885c850cfff46a : SUCCESS in 4m 37s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/128914ed7956466199a99261299b35cd : SUCCESS in 4m 49s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ce748d9524c64cb78686c56fc250b655 : SUCCESS in 4m 42s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/75dbc8fcd9d145478142c7082d65abf0 : SUCCESS in 6m 20s\n- neutron-tempest-plugin-designate-scenario https://zuul.opendev.org/t/openstack/build/0479a7f921a64bf6bc6ee3fb477e7509 : SUCCESS in 44m 09s","accounts_in_message":[],"_revision_number":1},{"id":"7235e49e72769e596cdb47f23e2e3f2274417664","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-07-22 13:07:43.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"9adb3e1016797202e83148051befcd7d0b7c7834","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-07-22 13:10:06.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/96bcfcaef6d94cb79162b277d3fbc4d8\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/eceff8789b67481a8ae647c3287b701a : SUCCESS in 54s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/3b3ac9fc20834c999276107a2a1df96e : SUCCESS in 48s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"094ce8d73023452f66f45b0d92d46e073f7f36bc","revisions":{"094ce8d73023452f66f45b0d92d46e073f7f36bc":{"kind":"REWORK","_number":1,"created":"2026-07-20 15:16:51.000000000","uploader":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"ref":"refs/changes/06/998006/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/designate","ref":"refs/changes/06/998006/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/designate refs/changes/06/998006/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/designate refs/changes/06/998006/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/designate refs/changes/06/998006/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/designate refs/changes/06/998006/1"}}},"commit":{"parents":[{"commit":"912c03039c843fb3b5846eef318fd2d29ad98c5c","subject":"Fix mDNS record query pool scoping for split-horizon DNS","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/912c03039c843fb3b5846eef318fd2d29ad98c5c"}]}],"author":{"name":"Omer","email":"oschwart@redhat.com","date":"2025-12-19 21:42:32.000000000","tz":-180},"committer":{"name":"Omer","email":"oschwart@redhat.com","date":"2026-07-20 15:16:15.000000000","tz":120},"subject":"Require TSIG keys for zones in non-default pools","message":"Require TSIG keys for zones in non-default pools\n\nAdd validation during zone creation and pool moves to ensure that\nnon-default pools have TSIG keys configured. Without TSIG, MDNS\ndefaults to searching only in the default pool, causing zones in\nother pools to fail with \u0027ZoneNotFound\u0027 errors during AXFR,\nleaving them stuck in ERROR status.\n\nThis provides fail-fast behavior with a clear error message,\nrather than allowing zones to silently fail during synchronization.\n\nNote: this does not change existing API behavior for the user as\nthe zone would get into ERROR eventually without a TSIG key.\n\nDocumentation has been added to explain the TSIG requirement for\nmulti-pool deployments.\n\nCloses-Bug: #2008693\nAssisted-By: Claude Code 4.5 Sonnet\nChange-Id: I5a2a18903e2bdc6a7b2202203ef3d41a0c6a7849\nSigned-off-by: Omer \u003coschwart@redhat.com\u003e\n(cherry picked from commit 7dfcfb74f0375e016da3ae99bc39651bccefa189)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/094ce8d73023452f66f45b0d92d46e073f7f36bc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/094ce8d73023452f66f45b0d92d46e073f7f36bc"}]},"branch":"refs/heads/stable/2026.1"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"}},{"label":"Review-Priority","status":"MAY","applied_by":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Review-Priority","description":"Review priority","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"-label:Review-Priority\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":[],"failing_atoms":["label:Review-Priority\u003dMIN"],"atom_explanations":{"label:Review-Priority\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}