)]}'
{"id":"openstack%2Fdesignate~998009","triplet_id":"openstack%2Fdesignate~stable%2F2025.2~I5a2a18903e2bdc6a7b2202203ef3d41a0c6a7849","project":"openstack/designate","branch":"stable/2025.2","attention_set":{},"removed_from_attention_set":{"31664":{"account":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"last_update":"2026-07-22 11:27:07.000000000","reason":"\u003cGERRIT_ACCOUNT_31664\u003e replied on the change","reason_account":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"}}},"hashtags":[],"change_id":"I5a2a18903e2bdc6a7b2202203ef3d41a0c6a7849","subject":"Require TSIG keys for zones in non-default pools","status":"MERGED","created":"2026-07-20 15:19:39.000000000","updated":"2026-07-22 13:10:07.000000000","submitted":"2026-07-22 13:07:48.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"998009","meta_rev_id":"5c539ca4cd0ec63eef08b180722ce6f8324de707","_number":998009,"virtual_id_number":998009,"owner":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2026-07-22 13:07:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"all":[{"value":2,"date":"2026-07-22 11:27:07.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2026-07-22 10:40:01.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"all":[{"value":1,"date":"2026-07-22 11:27:07.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"recommended":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"all":[{"value":1,"date":"2026-07-22 11:27:07.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","value":1,"default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-07-20 16:46:39.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-07-22 10:40:01.000000000","updated_by":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"reviewer":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"state":"REVIEWER"}],"messages":[{"id":"6f5a052a9aa0f1d59423ee819cdada1a02d18325","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"date":"2026-07-20 15:19:39.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6ea7600b6aa3b01b9cd9b0dc48e8641a015c8787","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-07-20 16:46:39.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/c80b302fda914eefbc5d1d8b3aa6bdf8\n\n- designate-grenade-bind9 https://zuul.opendev.org/t/openstack/build/0072faada81548d8a03f1d407bcbf1b7 : SUCCESS in 1h 09m 06s\n- designate-grenade-pdns4 https://zuul.opendev.org/t/openstack/build/5352a20e339b4051acf11b4651ad1b6d : SUCCESS in 1h 20m 50s\n- designate-grenade-bind9-skip-level https://zuul.opendev.org/t/openstack/build/9215cf0cd62e4482ae114c965f5c2c5d : FAILURE in 36m 04s (non-voting)\n- designate-grenade-pdns4-skip-level https://zuul.opendev.org/t/openstack/build/6cac3b2a76234a23a550f28bb190dfb6 : FAILURE in 25m 00s (non-voting)\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/b0e38fe9edc84ec8951b3944dcb3283b : SUCCESS in 8m 08s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2d3a84b0382f4fde9d5c8034719f83f1 : SUCCESS in 3m 25s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/a761262054934989b6faf4fdbe0e227e : SUCCESS in 4m 59s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/b70e5a4f4ade4a1b94fab0eb7e453de4 : SUCCESS in 5m 18s\n- openstack-tox-py313 https://zuul.opendev.org/t/openstack/build/fe43dbdd3f83463f8319ffe70a314abb : SUCCESS in 8m 01s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c2aae9e5caca41f2b3385eb18ebe5a9d : SUCCESS in 8m 41s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/60dd7b27351e482ab39fd862d7a75acc : SUCCESS in 6m 08s\n- neutron-tempest-plugin-designate-scenario https://zuul.opendev.org/t/openstack/build/e720def7fd53405b8d7bb3232717a506 : SUCCESS in 34m 36s\n- designate-tox-dnspython-latest https://zuul.opendev.org/t/openstack/build/5768c37bd1ac48d1baec077aa4b24901 : SUCCESS in 7m 03s","accounts_in_message":[],"_revision_number":1},{"id":"c5c66ec9a33b8899f2d694f6e433e22699280435","author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"date":"2026-07-21 14:06:28.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"d609112f635ba35d63c4c4f03d33e0142596d953","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2026-07-22 10:40:01.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"1e1179d5359a68cbf1a312adf4a3d38ccc8ea80b","author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"date":"2026-07-22 11:27:07.000000000","message":"Patch Set 1: Code-Review+2 Review-Priority+1 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"09d6e2d7454e76af03906493d236edb99ddea947","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-07-22 11:27:48.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"835ce6691f2fdc5d4b0efbf5754e25d67145abf3","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-07-22 13:07:48.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/9be13ec28d3248c9b5a8974adb9fe552\n\n- designate-grenade-pdns4 https://zuul.opendev.org/t/openstack/build/9386ccbc8e6e43e8a35099918e52121c : SUCCESS in 1h 07m 30s\n- designate-grenade-bind9 https://zuul.opendev.org/t/openstack/build/b27c01f996144b8592df85fb723b7dcd : SUCCESS in 1h 14m 11s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/3f0266fe4b4248bbbe323a06e6effa93 : SUCCESS in 3m 29s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/c3512d6558f340589e85f8b76f371dae : SUCCESS in 4m 51s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/0228e88303414deaa71ee50b3f5513a2 : SUCCESS in 5m 12s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6c367b2601494d72919e21ac5f0bb021 : SUCCESS in 9m 56s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/2622db7161314d72840fd7f6b694f945 : SUCCESS in 6m 10s\n- neutron-tempest-plugin-designate-scenario https://zuul.opendev.org/t/openstack/build/dc7ae4396f1b47e98d25ed862d8ddc9e : SUCCESS in 33m 58s","accounts_in_message":[],"_revision_number":1},{"id":"00e83ec3f746e6383fd40db264c41051ef5b1dbb","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-07-22 13:07:48.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"5c539ca4cd0ec63eef08b180722ce6f8324de707","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-07-22 13:10:07.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/9643f9a7dd80482b8721b9de0f28a249\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9fa2f703f22d4e75932d32cabf05525f : SUCCESS in 54s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/fbd4f0edb6464f7bb04bce1f053bd9be : SUCCESS in 47s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"ef31c9598371471d0e91986c968a1dd85c64746c","revisions":{"ef31c9598371471d0e91986c968a1dd85c64746c":{"kind":"REWORK","_number":1,"created":"2026-07-20 15:19:39.000000000","uploader":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"ref":"refs/changes/09/998009/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/designate","ref":"refs/changes/09/998009/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/designate refs/changes/09/998009/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/designate refs/changes/09/998009/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/designate refs/changes/09/998009/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/designate refs/changes/09/998009/1"}}},"commit":{"parents":[{"commit":"c40f9ff7f2e963fa0459e0cb022e6db82fe27942","subject":"Fix mDNS record query pool scoping for split-horizon DNS","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/c40f9ff7f2e963fa0459e0cb022e6db82fe27942"}]}],"author":{"name":"Omer","email":"oschwart@redhat.com","date":"2025-12-19 21:42:32.000000000","tz":-180},"committer":{"name":"Omer","email":"oschwart@redhat.com","date":"2026-07-20 15:18:29.000000000","tz":120},"subject":"Require TSIG keys for zones in non-default pools","message":"Require TSIG keys for zones in non-default pools\n\nAdd validation during zone creation and pool moves to ensure that\nnon-default pools have TSIG keys configured. Without TSIG, MDNS\ndefaults to searching only in the default pool, causing zones in\nother pools to fail with \u0027ZoneNotFound\u0027 errors during AXFR,\nleaving them stuck in ERROR status.\n\nThis provides fail-fast behavior with a clear error message,\nrather than allowing zones to silently fail during synchronization.\n\nNote: this does not change existing API behavior for the user as\nthe zone would get into ERROR eventually without a TSIG key.\n\nDocumentation has been added to explain the TSIG requirement for\nmulti-pool deployments.\n\nCloses-Bug: #2008693\nAssisted-By: Claude Code 4.5 Sonnet\nChange-Id: I5a2a18903e2bdc6a7b2202203ef3d41a0c6a7849\nSigned-off-by: Omer \u003coschwart@redhat.com\u003e\n(cherry picked from commit 7dfcfb74f0375e016da3ae99bc39651bccefa189)\n(cherry picked from commit 094ce8d73023452f66f45b0d92d46e073f7f36bc)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/ef31c9598371471d0e91986c968a1dd85c64746c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/ef31c9598371471d0e91986c968a1dd85c64746c"}]},"branch":"refs/heads/stable/2025.2"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"}},{"label":"Review-Priority","status":"MAY","applied_by":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Review-Priority","description":"Review priority","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"-label:Review-Priority\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":[],"failing_atoms":["label:Review-Priority\u003dMIN"],"atom_explanations":{"label:Review-Priority\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}