)]}'
{"id":"openstack%2Fdesignate~998030","triplet_id":"openstack%2Fdesignate~stable%2F2025.1~I5a2a18903e2bdc6a7b2202203ef3d41a0c6a7849","project":"openstack/designate","branch":"stable/2025.1","attention_set":{},"removed_from_attention_set":{"31664":{"account":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"last_update":"2026-07-22 11:27:30.000000000","reason":"\u003cGERRIT_ACCOUNT_31664\u003e replied on the change","reason_account":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"}}},"hashtags":[],"change_id":"I5a2a18903e2bdc6a7b2202203ef3d41a0c6a7849","subject":"Require TSIG keys for zones in non-default pools","status":"MERGED","created":"2026-07-20 17:06:01.000000000","updated":"2026-07-22 13:10:15.000000000","submitted":"2026-07-22 13:07:54.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"998030","meta_rev_id":"3e5865044a459a510ed53701fd8c7d26b5466a65","_number":998030,"virtual_id_number":998030,"owner":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2026-07-22 13:07:53.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"all":[{"value":2,"date":"2026-07-22 11:27:30.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2026-07-22 10:40:12.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"all":[{"value":1,"date":"2026-07-22 11:27:30.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"recommended":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"all":[{"value":1,"date":"2026-07-22 11:27:30.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","value":1,"default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-07-20 18:03:49.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2026-07-22 10:40:12.000000000","updated_by":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"reviewer":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"state":"REVIEWER"}],"messages":[{"id":"42b7fc3a5c60a5246c5269e1b8baf1c430cf7d6a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"date":"2026-07-20 17:06:01.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"56ae1a5aa62973eec488b4f2ead8b0439588cb49","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-07-20 18:03:49.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/a855870856394ecd9af6d01fbd039184\n\n- designate-bind9 https://zuul.opendev.org/t/openstack/build/8574ef6b3a1f4fee84bad7b57c658cee : SUCCESS in 43m 20s\n- designate-bind9-centos9stream-fips https://zuul.opendev.org/t/openstack/build/cdea41dc24f4425fa7f3a60aa6351d3c : FAILURE in 15m 09s (non-voting)\n- designate-bind9-centos-9-stream https://zuul.opendev.org/t/openstack/build/53de15e033a74764be86e56e3fcb6229 : FAILURE in 28m 33s (non-voting)\n- designate-bind9-keystone-old-default-roles https://zuul.opendev.org/t/openstack/build/5db2ed236baf4942b773f306a88c9f3c : SUCCESS in 44m 53s\n- designate-pdns4 https://zuul.opendev.org/t/openstack/build/11382762f8ae48b4a2769ecab5a2e4a3 : SUCCESS in 45m 31s\n- designate-grenade-bind9 https://zuul.opendev.org/t/openstack/build/1b41390bd389499c988088b014ece748 : FAILURE in 21m 26s (non-voting)\n- designate-grenade-pdns4 https://zuul.opendev.org/t/openstack/build/bade9588f7e34ff99ba0246c41d5be9d : FAILURE in 10m 56s (non-voting)\n- designate-grenade-bind9-skip-level https://zuul.opendev.org/t/openstack/build/ab6334f9b3fd4e26a942b18bcdf28c4c : FAILURE in 12m 55s (non-voting)\n- designate-grenade-pdns4-skip-level https://zuul.opendev.org/t/openstack/build/3818bf3959fe489a8f676af37c629ed5 : FAILURE in 11m 43s (non-voting)\n- designate-ipv6-only-pdns4 https://zuul.opendev.org/t/openstack/build/d4c57606d710489790a4e73049631ae0 : SUCCESS in 46m 02s\n- designate-ipv6-only-bind9 https://zuul.opendev.org/t/openstack/build/366c92ca11d548de92aa5d06253fd471 : SUCCESS in 44m 42s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/9e90e6b6c7cf4946a0aaa483593a374c : SUCCESS in 6m 32s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/24dc12aaac7e472e836ee96d047836bc : SUCCESS in 5m 10s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/b4dee1c51f14422e8b5e091573d3ae0e : SUCCESS in 3m 17s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/b60fd646d32b4665afd5109683f88e63 : SUCCESS in 4m 55s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/80f0ecda92544adebc7b5fc1241913e8 : SUCCESS in 10m 13s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/2fac9293dce14bba9b9c89cc20d56a38 : SUCCESS in 5m 46s\n- neutron-tempest-plugin-designate-scenario-2025-1 https://zuul.opendev.org/t/openstack/build/c4a4c96ee4be4d3b944410520a4aa5cb : SUCCESS in 30m 51s\n- designate-tox-dnspython-latest https://zuul.opendev.org/t/openstack/build/8f24a915529243809018e8e16ec3b9e3 : SUCCESS in 5m 14s (non-voting)\n- designate-bind9-catalog-zones https://zuul.opendev.org/t/openstack/build/6c2c5cb3139444f186250ab7c96debcd : FAILURE in 51m 52s (non-voting)\n\nWarning:\n  File .ssh/known_hosts.old found in build home directory during playbook opendev.org/opendev/base-jobs/playbooks/base/cleanup.yaml for job designate-bind9-centos9stream-fips.  Add to preserve-home-paths if safe, or otherwise remove.\n  File .ssh/known_hosts.old found in build home directory during playbook opendev.org/opendev/base-jobs/playbooks/base/post-logs.yaml for job designate-bind9-centos9stream-fips.  Add to preserve-home-paths if safe, or otherwise remove.","accounts_in_message":[],"_revision_number":1},{"id":"954a6c24041797cb951c24ab99d4acbec14b8b97","author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"date":"2026-07-21 14:06:42.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"9ac96492392704eb82604ab98865ca120c251407","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2026-07-22 10:40:12.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"b6accfaee19b1e2ee3d98667100dbe001574aef9","author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"date":"2026-07-22 11:27:30.000000000","message":"Patch Set 1: Code-Review+2 Review-Priority+1 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"43cdadd013ee7c6ecc2ed2dee94af18e055f566e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-07-22 11:28:19.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"5950f21677046f1b985a15607defe3ae59882958","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-07-22 13:07:53.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/a8bd423f203d4f28b6b6a59f4dab2f1e\n\n- designate-bind9 https://zuul.opendev.org/t/openstack/build/82ea95458a9d4252905b3b0b98cd2f46 : SUCCESS in 43m 46s\n- designate-bind9-keystone-old-default-roles https://zuul.opendev.org/t/openstack/build/a391203347ab432aa97c39597b7beea1 : SUCCESS in 49m 22s\n- designate-pdns4 https://zuul.opendev.org/t/openstack/build/aa924f55e7474f788d55260f78e2a67a : SUCCESS in 38m 31s\n- designate-grenade-pdns4 https://zuul.opendev.org/t/openstack/build/49dd638df1614c5e89004c6246148f36 : FAILURE in 23m 00s (non-voting)\n- designate-grenade-pdns4-skip-level https://zuul.opendev.org/t/openstack/build/acf10a81008745d5909f5b76afc9916a : FAILURE in 10m 00s (non-voting)\n- designate-ipv6-only-pdns4 https://zuul.opendev.org/t/openstack/build/7f03722ac3e94859be151044115ccf84 : SUCCESS in 45m 58s\n- designate-ipv6-only-bind9 https://zuul.opendev.org/t/openstack/build/fb8ef5cf315a4107ad1c331f97607c68 : SUCCESS in 49m 05s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/cadad17b425541a7b99cc623a936be53 : SUCCESS in 4m 00s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/4b25f167ed3b4207a39d79a67d726683 : SUCCESS in 4m 47s\n- openstack-tox-py312 https://zuul.opendev.org/t/openstack/build/2c6052ef35c449bab590f2fb609044b6 : SUCCESS in 5m 11s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0268672f89a348a5a9710a76710e69ae : SUCCESS in 8m 42s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/e4a9b09b7c2d4b6789cdfb4ec3400a05 : SUCCESS in 6m 10s\n- neutron-tempest-plugin-designate-scenario-2025-1 https://zuul.opendev.org/t/openstack/build/90dd9e601ae44295b0e2d3143196af02 : SUCCESS in 34m 31s","accounts_in_message":[],"_revision_number":1},{"id":"9f2761b6ee40a609cac553db935e5e2284f54624","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-07-22 13:07:54.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"3e5865044a459a510ed53701fd8c7d26b5466a65","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-07-22 13:10:15.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/f821600d3021474e9f2f4a3d0ecce958\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/668737a07cf348a59d5c5714a144ce4b : SUCCESS in 57s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/ed64090823404490bd322920d58a3620 : SUCCESS in 49s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"15f5db678cec792cb5421659e25cfeb35d64817a","revisions":{"15f5db678cec792cb5421659e25cfeb35d64817a":{"kind":"REWORK","_number":1,"created":"2026-07-20 17:06:01.000000000","uploader":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"ref":"refs/changes/30/998030/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/designate","ref":"refs/changes/30/998030/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/designate refs/changes/30/998030/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/designate refs/changes/30/998030/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/designate refs/changes/30/998030/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/designate refs/changes/30/998030/1"}}},"commit":{"parents":[{"commit":"9cf243268fe224abb38fff8d65b8c3c8d33fed2f","subject":"Fix mDNS record query pool scoping for split-horizon DNS","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/9cf243268fe224abb38fff8d65b8c3c8d33fed2f"}]}],"author":{"name":"Omer","email":"oschwart@redhat.com","date":"2025-12-19 21:42:32.000000000","tz":-180},"committer":{"name":"Omer","email":"oschwart@redhat.com","date":"2026-07-20 17:05:09.000000000","tz":120},"subject":"Require TSIG keys for zones in non-default pools","message":"Require TSIG keys for zones in non-default pools\n\nAdd validation during zone creation and pool moves to ensure that\nnon-default pools have TSIG keys configured. Without TSIG, MDNS\ndefaults to searching only in the default pool, causing zones in\nother pools to fail with \u0027ZoneNotFound\u0027 errors during AXFR,\nleaving them stuck in ERROR status.\n\nThis provides fail-fast behavior with a clear error message,\nrather than allowing zones to silently fail during synchronization.\n\nNote: this does not change existing API behavior for the user as\nthe zone would get into ERROR eventually without a TSIG key.\n\nDocumentation has been added to explain the TSIG requirement for\nmulti-pool deployments.\n\nCloses-Bug: #2008693\nAssisted-By: Claude Code 4.5 Sonnet\nChange-Id: I5a2a18903e2bdc6a7b2202203ef3d41a0c6a7849\nSigned-off-by: Omer \u003coschwart@redhat.com\u003e\n(cherry picked from commit 7dfcfb74f0375e016da3ae99bc39651bccefa189)\n(cherry picked from commit 094ce8d73023452f66f45b0d92d46e073f7f36bc)\n(cherry picked from commit ef31c9598371471d0e91986c968a1dd85c64746c)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/15f5db678cec792cb5421659e25cfeb35d64817a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/designate/commit/15f5db678cec792cb5421659e25cfeb35d64817a"}]},"branch":"refs/heads/stable/2025.1"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"}},{"label":"Review-Priority","status":"MAY","applied_by":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"}}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dMAX"],"failing_atoms":["label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Review-Priority","description":"Review priority","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"-label:Review-Priority\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":[],"failing_atoms":["label:Review-Priority\u003dMIN"],"atom_explanations":{"label:Review-Priority\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}