)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"af0043065ffc0a6c7a3c345bbb183e0183225fdb","unresolved":true,"context_lines":[{"line_number":25,"context_line":"ns_records\u0027 existing order, preserving the old behavior for that"},{"line_number":26,"context_line":"case."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Co-Authored-By: Claude Sonnet 5 \u003cnoreply@anthropic.com\u003e"},{"line_number":29,"context_line":"Change-Id: I0cfbda0a6e460e8bb6fae2fa3e55cfe3e2054fb7"},{"line_number":30,"context_line":"Signed-off-by: Tore Anderson \u003ctore@redpill-linpro.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"4f7e92c3_57997827","line":28,"range":{"start_line":28,"start_character":0,"end_line":28,"end_character":55},"updated":"2026-09-04 12:05:46.000000000","message":"Could we replace this label with either Generated-By or Assisted-By label as defined here? https://openinfra.org/legal/ai-policy","commit_id":"2e53662804696926a965984eff5dda3ba0ecd1d1"},{"author":{"_account_id":20178,"name":"Tore Anderson","email":"tore@fud.no","username":"tore"},"change_message_id":"9d1fc834b89ce7227a3cad84ace75f1fc82b8715","unresolved":false,"context_lines":[{"line_number":25,"context_line":"ns_records\u0027 existing order, preserving the old behavior for that"},{"line_number":26,"context_line":"case."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Assisted-By: Claude Sonnet 5 \u003cnoreply@anthropic.com\u003e"},{"line_number":29,"context_line":"Change-Id: I0cfbda0a6e460e8bb6fae2fa3e55cfe3e2054fb7"},{"line_number":30,"context_line":"Signed-off-by: Tore Anderson \u003ctore@redpill-linpro.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"d23d4557_807360c1","line":28,"in_reply_to":"4f7e92c3_57997827","updated":"2026-09-04 12:33:46.000000000","message":"Done.","commit_id":"24db7bb163f80803f4240fc68e2bcc820be47b68"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"af0043065ffc0a6c7a3c345bbb183e0183225fdb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"58b384e3_7016dcd8","updated":"2026-09-04 12:05:46.000000000","message":"a few small comments, thanks for working on it","commit_id":"2e53662804696926a965984eff5dda3ba0ecd1d1"},{"author":{"_account_id":20178,"name":"Tore Anderson","email":"tore@fud.no","username":"tore"},"change_message_id":"d0d11f64738d03bc705ed065b571f93f24f98556","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7c117c13_9006fad8","updated":"2026-07-22 08:01:47.000000000","message":"recheck","commit_id":"2e53662804696926a965984eff5dda3ba0ecd1d1"},{"author":{"_account_id":20178,"name":"Tore Anderson","email":"tore@fud.no","username":"tore"},"change_message_id":"87458fc96d50aa8d52b566860fd2aa938ea9b9dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"eb58f6d3_8ee4c86d","updated":"2026-07-28 10:45:08.000000000","message":"recheck cause I think this the failures are caused by CI flakiness","commit_id":"2e53662804696926a965984eff5dda3ba0ecd1d1"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"d0a5f5d6fe4942bf8d002deb93caedc51ee3614b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1a899cc9_7ece66de","updated":"2026-07-30 11:49:33.000000000","message":"recheck https://review.opendev.org/c/openstack/requirements/+/999181 got merged","commit_id":"2e53662804696926a965984eff5dda3ba0ecd1d1"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"e1562ae279bb72be51bdd92cc24e543e6d10420c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"840e4189_cce36cc2","updated":"2026-09-08 09:55:55.000000000","message":"Ideally could we have bugs for all of these?","commit_id":"24db7bb163f80803f4240fc68e2bcc820be47b68"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"c1f5e7168081b65faab1192f2d03a97ef88e7f46","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f1c824ba_84fe4939","updated":"2026-09-04 15:10:33.000000000","message":"It looks like an OpenDev infra mirror (mirror.ca-ymq-1.vexxhost.opendev.org) is unreachable from the vexxhost test nodes. I will monitor to see when it is resolved","commit_id":"24db7bb163f80803f4240fc68e2bcc820be47b68"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"a71dd3c9a28488479f9975db5f4b9b575c599b0a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b42312ff_721d9a5f","updated":"2026-09-07 09:49:23.000000000","message":"LGTM","commit_id":"24db7bb163f80803f4240fc68e2bcc820be47b68"},{"author":{"_account_id":20178,"name":"Tore Anderson","email":"tore@fud.no","username":"tore"},"change_message_id":"5cf346867b4b76590d1e20241379456872ecd320","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6d637dcb_0358cdaf","in_reply_to":"840e4189_cce36cc2","updated":"2026-09-08 10:36:18.000000000","message":"Done: https://bugs.launchpad.net/designate/+bug/2166758","commit_id":"7fffc389ac2426e65103d491ec49cafd6ec882d0"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"0fe89ce90373db9e6525eaabfec9ae3abd3fa943","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"32dae2f7_2d4ae0f9","updated":"2026-09-08 13:03:11.000000000","message":"recheck designate_tempest_plugin.tests.api.v2.test_pool.PoolAdminTest","commit_id":"a349be0540a6cd2325c155742c86d7819d6e2630"}],"designate/storage/sqlalchemy/__init__.py":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"af0043065ffc0a6c7a3c345bbb183e0183225fdb","unresolved":true,"context_lines":[{"line_number":2576,"context_line":"        \"\"\""},{"line_number":2577,"context_line":"        # The lowest priority ns_record is used as the SOA MNAME. Ties are"},{"line_number":2578,"context_line":"        # broken by pool.ns_records\u0027 existing order."},{"line_number":2579,"context_line":"        mname \u003d min(pool.ns_records, key\u003dlambda ns_record: ns_record.priority)"},{"line_number":2580,"context_line":""},{"line_number":2581,"context_line":"        soa_record \u003d objects.RecordList()"},{"line_number":2582,"context_line":"        soa_record.append("}],"source_content_type":"text/x-python","patch_set":1,"id":"d86d18af_73f9a93e","line":2579,"range":{"start_line":2579,"start_character":8,"end_line":2579,"end_character":78},"updated":"2026-09-04 12:05:46.000000000","message":"pool.ns_records isn\u0027t guaranteed non-empty here. Unlike the zone create/update paths (central/service.py create_zone/update_zone_pool), which explicitly check len(pool_ns_records) \u003d\u003d 0 and raise NoServersConfigured before building an SOA, create_pool/update_pool have no such guard — they call straight into _ensure_catalog_zone_config -\u003e this method whenever pool.catalog_zone is set. A pool defined with catalog_zone set but an empty/missing ns_records (e.g. a pools.yaml typo or mid-setup config) will hit min() on an empty sequence and raise an unhandled ValueError instead of a clear error.\n\nCould we add a check here (or in _ensure_catalog_zone_config) that raises exceptions.NoServersConfigured() if pool.ns_records is empty, matching the behavior operators already get from the zone-creation path?","commit_id":"2e53662804696926a965984eff5dda3ba0ecd1d1"},{"author":{"_account_id":20178,"name":"Tore Anderson","email":"tore@fud.no","username":"tore"},"change_message_id":"9d1fc834b89ce7227a3cad84ace75f1fc82b8715","unresolved":false,"context_lines":[{"line_number":2576,"context_line":"        \"\"\""},{"line_number":2577,"context_line":"        if not pool.ns_records:"},{"line_number":2578,"context_line":"            LOG.critical(\u0027No nameservers configured. Please create at \u0027"},{"line_number":2579,"context_line":"                         \u0027least one nameserver\u0027)"},{"line_number":2580,"context_line":"            raise exceptions.NoServersConfigured()"},{"line_number":2581,"context_line":""},{"line_number":2582,"context_line":"        # The lowest priority ns_record is used as the SOA MNAME. Ties are"}],"source_content_type":"text/x-python","patch_set":2,"id":"14306082_8771d4a4","line":2579,"in_reply_to":"d86d18af_73f9a93e","updated":"2026-09-04 12:33:46.000000000","message":"Done, plus added a regression test.","commit_id":"24db7bb163f80803f4240fc68e2bcc820be47b68"}]}