)]}'
{"devstack-vm-gate.sh":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"8eefb3a2ad6598a8894dcefae5da150010446dd7","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    if [ \"$DEVSTACK_CINDER_DRIVER\" \u003d\u003d \"ceph\" ]; then"},{"line_number":101,"context_line":"        echo \"CINDER_DRIVER\u003dceph\" \u003e\u003e localrc"},{"line_number":102,"context_line":"        MY_ENABLED_SERVICES+\u003d,ceph"},{"line_number":103,"context_line":"    fi"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    if [ \"$DEVSTACK_GATE_TEMPEST_HEAT_SLOW\" -eq \"1\" ]; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1ae5cdf2_99eb86a3","line":102,"updated":"2014-06-18 16:52:03.000000000","message":"The features.yaml file fed into test-matrix.py should control enabled services. This condition should only deal with writing to localrc. See the ironic virt driver case below. ironic is a service too but this only deals with localrc changes.\n\nAlso this change should use bash [[]] instead of test/[] as there is another change by sdague to do that everywhere in devstack gate.","commit_id":"0044c71bee4dacae2448ec80c3fc4e29f42e09a7"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"26ffd890cf19e627094a15a345384ba72347b0d9","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    if [ \"$DEVSTACK_CINDER_DRIVER\" \u003d\u003d \"ceph\" ]; then"},{"line_number":101,"context_line":"        echo \"CINDER_DRIVER\u003dceph\" \u003e\u003e localrc"},{"line_number":102,"context_line":"        MY_ENABLED_SERVICES+\u003d,ceph"},{"line_number":103,"context_line":"    fi"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    if [ \"$DEVSTACK_GATE_TEMPEST_HEAT_SLOW\" -eq \"1\" ]; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1ae5cdf2_bdebcda2","line":102,"in_reply_to":"1ae5cdf2_99eb86a3","updated":"2014-06-18 17:16:48.000000000","message":"Thanks! Done","commit_id":"0044c71bee4dacae2448ec80c3fc4e29f42e09a7"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"e3fc1b96626b926c186ca2f43dd8ff31c9c2aa54","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    if [[ \"$DEVSTACK_CINDER_DRIVER\" \u003d\u003d \"ceph\" ]]; then"},{"line_number":106,"context_line":"        echo \"CINDER_DRIVER\u003dceph\" \u003e\u003e localrc"},{"line_number":107,"context_line":"        MY_ENABLED_SERVICES+\u003d,ceph"},{"line_number":108,"context_line":"    fi"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    if [ \"$DEVSTACK_GATE_TEMPEST_HEAT_SLOW\" -eq \"1\" ]; then"}],"source_content_type":"text/x-sh","patch_set":4,"id":"baada198_96521d10","line":107,"updated":"2014-08-04 18:35:44.000000000","message":"This also turns on ceph for nova and glance.\n\nAlso, for Cinder, another change is needed.  See this for an example: https://review.openstack.org/#/c/107472/7/stack.sh","commit_id":"603071daed6f1554523d4f3e8da206302d4cb90d"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"73aef229195733650ebec8a797f55a7ca2fa53d0","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    if [[ \"$DEVSTACK_CINDER_DRIVER\" \u003d\u003d \"ceph\" ]]; then"},{"line_number":106,"context_line":"        echo \"CINDER_DRIVER\u003dceph\" \u003e\u003e localrc"},{"line_number":107,"context_line":"        MY_ENABLED_SERVICES+\u003d,ceph"},{"line_number":108,"context_line":"    fi"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    if [ \"$DEVSTACK_GATE_TEMPEST_HEAT_SLOW\" -eq \"1\" ]; then"}],"source_content_type":"text/x-sh","patch_set":4,"id":"baada198_e9fb7e45","line":107,"in_reply_to":"baada198_363f9123","updated":"2014-08-04 19:32:07.000000000","message":"Agree that for d-g, a global flag makes sense.  The devstack support covers nova/glance/cinder and I think we want to enable it all here.","commit_id":"603071daed6f1554523d4f3e8da206302d4cb90d"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"8cb23a18a2dfb0f02f3608286386e6c98dc41c40","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    if [[ \"$DEVSTACK_CINDER_DRIVER\" \u003d\u003d \"ceph\" ]]; then"},{"line_number":106,"context_line":"        echo \"CINDER_DRIVER\u003dceph\" \u003e\u003e localrc"},{"line_number":107,"context_line":"        MY_ENABLED_SERVICES+\u003d,ceph"},{"line_number":108,"context_line":"    fi"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    if [ \"$DEVSTACK_GATE_TEMPEST_HEAT_SLOW\" -eq \"1\" ]; then"}],"source_content_type":"text/x-sh","patch_set":4,"id":"baada198_363f9123","line":107,"in_reply_to":"baada198_3686b15f","updated":"2014-08-04 18:51:47.000000000","message":"Correct the enabled services change is redundant with features.yaml and should be removed.\n\nFor the first thing, I think we should just have a DEVSTACK_CEPH binary flag and either turn it on for everything or turn it off. Seems like folks using ceph in production are using it so they can use it across the services and not just for eg cinder. Is it possible to do that with devstack today?","commit_id":"603071daed6f1554523d4f3e8da206302d4cb90d"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"3198630893b7641710b7af484f89159bd094cf8f","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    if [[ \"$DEVSTACK_CINDER_DRIVER\" \u003d\u003d \"ceph\" ]]; then"},{"line_number":106,"context_line":"        echo \"CINDER_DRIVER\u003dceph\" \u003e\u003e localrc"},{"line_number":107,"context_line":"        MY_ENABLED_SERVICES+\u003d,ceph"},{"line_number":108,"context_line":"    fi"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    if [ \"$DEVSTACK_GATE_TEMPEST_HEAT_SLOW\" -eq \"1\" ]; then"}],"source_content_type":"text/x-sh","patch_set":4,"id":"baada198_3686b15f","line":107,"in_reply_to":"baada198_96521d10","updated":"2014-08-04 18:37:33.000000000","message":"Also. isn\u0027t this line not necessary given the additions to features.yaml?","commit_id":"603071daed6f1554523d4f3e8da206302d4cb90d"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"312f891b71586774af92784b18a6fbd9b5c8fc95","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    fi"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    if [[ \"$DEVSTACK_GATE_CEPH\" \u003d\u003d \"1\" ]]; then"},{"line_number":44,"context_line":"        MY_ENABLED_SERVICES+\u003d,ceph"},{"line_number":45,"context_line":"        echo \"CINDER_ENABLED_BACKENDS\u003dceph:ceph\" \u003e\u003elocalrc"},{"line_number":46,"context_line":"    fi"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"baada198_87d2e958","line":44,"updated":"2014-08-04 20:18:26.000000000","message":"This line can be removed as features.yaml should do it for us.","commit_id":"30476827e3ce33515b853b69f8dc478e14ad9d21"}],"features.yaml":[{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"e3fc1b96626b926c186ca2f43dd8ff31c9c2aa54","unresolved":false,"context_lines":[{"line_number":138,"context_line":"  ceph:"},{"line_number":139,"context_line":"    base:"},{"line_number":140,"context_line":"      services: [ceph]"},{"line_number":141,"context_line":"      rm-services: [s-proxy, s-account, s-container, s-object]"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"baada198_36415136","line":141,"updated":"2014-08-04 18:35:44.000000000","message":"I don\u0027t think there\u0027s any reason to turn off swift here.","commit_id":"603071daed6f1554523d4f3e8da206302d4cb90d"}]}