)]}'
{"devstack-vm-gate-wrap.sh":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"a8652e5e42f10acb24b4915eaddbc464dd02596f","unresolved":false,"context_lines":[{"line_number":223,"context_line":"# DGGS\u003d1 means don\u0027t upgrade from one release to another. Instead \"upgrade\""},{"line_number":224,"context_line":"# services to replace old service with new service. EG nova baremetal to"},{"line_number":225,"context_line":"# ironic."},{"line_number":226,"context_line":"export DEVSTACK_GATE_GRENADE_SIDEWAYS\u003d${DEVSTACK_GATE_GRENADE_SIDEWAYS:-0}"},{"line_number":227,"context_line":"# DGGPN\u003d1 means upgrade everything but n-cpu."},{"line_number":228,"context_line":"export DEVSTACK_GATE_GRENADE_PARTIAL_NCPU\u003d${DEVSTACK_GATE_GRENADE_PARTIAL_NCPU:-0}"},{"line_number":229,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"baada198_0e10f8a9","line":226,"updated":"2014-08-01 19:07:22.000000000","message":"This is all fine... I wonder though if we should stop doing this with ints, and just create a DEVSTACK_GRENADE_MODE\u003d\n\none of \u0027pullup\u0027, \u0027forward\u0027, \u0027sideways\u0027, \u0027partial\u0027 (pullup is a crazy word, but something else like that) to do a be less nested.","commit_id":"d40babbdc22736545117d0970629d90b21897ddb"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"d9bec29d931f55622915ea05c400760058338a7c","unresolved":false,"context_lines":[{"line_number":234,"context_line":""},{"line_number":235,"context_line":"# TODO(clarkb) clean up condition once job defs are updated."},{"line_number":236,"context_line":"if [[ \"$DEVSTACK_GATE_GRENADE\" \u003d\u003d \"pullup\" ]] || [[ \"$DEVSTACK_GATE_GRENADE\" -eq \"1\" ]]; then"},{"line_number":237,"context_line":"    export DEVSTACK_GATE_TEMPEST\u003d1"},{"line_number":238,"context_line":"    if [[ \"$GRENADE_BASE_BRANCH\" \u003d\u003d \"stable/icehouse\" ]]; then"},{"line_number":239,"context_line":"        export GRENADE_OLD_BRANCH\u003d\"stable/havana\""},{"line_number":240,"context_line":"        export GRENADE_NEW_BRANCH\u003d\"stable/icehouse\""}],"source_content_type":"text/x-sh","patch_set":4,"id":"7ac7a964_223d3c90","line":237,"updated":"2014-08-14 21:53:08.000000000","message":"Why is DO_NOT_UPGRADE_SERVICES\u003d not set here, but is elsewhere?","commit_id":"49cfb334eca4986a6897725755cfe0a806aaf3a4"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"6ce4d561f4172e72c1d0894234af7427eab7e04e","unresolved":false,"context_lines":[{"line_number":234,"context_line":""},{"line_number":235,"context_line":"# TODO(clarkb) clean up condition once job defs are updated."},{"line_number":236,"context_line":"if [[ \"$DEVSTACK_GATE_GRENADE\" \u003d\u003d \"pullup\" ]] || [[ \"$DEVSTACK_GATE_GRENADE\" -eq \"1\" ]]; then"},{"line_number":237,"context_line":"    export DEVSTACK_GATE_TEMPEST\u003d1"},{"line_number":238,"context_line":"    if [[ \"$GRENADE_BASE_BRANCH\" \u003d\u003d \"stable/icehouse\" ]]; then"},{"line_number":239,"context_line":"        export GRENADE_OLD_BRANCH\u003d\"stable/havana\""},{"line_number":240,"context_line":"        export GRENADE_NEW_BRANCH\u003d\"stable/icehouse\""}],"source_content_type":"text/x-sh","patch_set":4,"id":"7ac7a964_42279864","line":237,"in_reply_to":"7ac7a964_223d3c90","updated":"2014-08-14 21:56:38.000000000","message":"That is a miss. Do you think I should just remove the set to empty string? It might be clearer that way.","commit_id":"49cfb334eca4986a6897725755cfe0a806aaf3a4"}],"devstack-vm-gate.sh":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"a8652e5e42f10acb24b4915eaddbc464dd02596f","unresolved":false,"context_lines":[{"line_number":255,"context_line":"        # Possibly enable ironic when generating the \"new\" localrc."},{"line_number":256,"context_line":"        DEVSTACK_GATE_IRONIC\u003d$tmp_DEVSTACK_GATE_IRONIC"},{"line_number":257,"context_line":"        DEVSTACK_GATE_VIRT_DRIVER\u003d$tmp_DEVSTACK_GATE_VIRT_DRIVER"},{"line_number":258,"context_line":"    fi"},{"line_number":259,"context_line":"    cd $BASE/new/devstack"},{"line_number":260,"context_line":"    setup_localrc \"new\" \"$GRENADE_OLD_BRANCH\""},{"line_number":261,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"baada198_2eca1c1a","line":258,"updated":"2014-08-01 19:07:22.000000000","message":"I feel like what was actually want in sideways is a config snippet for old and one for new that gets injected at the end of localrc. Which is trickier, but would be more generic.","commit_id":"d40babbdc22736545117d0970629d90b21897ddb"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"7991f71ef2aa14c8c6f208b1956106c939b5b0d5","unresolved":false,"context_lines":[{"line_number":256,"context_line":"    cd $BASE/old/devstack"},{"line_number":257,"context_line":"    setup_localrc \"old\" \"$GRENADE_OLD_BRANCH\""},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    if [[ \"$DEVSTACK_GATE_GRENADE\" \u003d\u003d \"sideways-ironic\" ]]; then"},{"line_number":260,"context_line":"        # Possibly enable ironic when generating the \"new\" localrc."},{"line_number":261,"context_line":"        export DEVSTACK_GATE_IRONIC\u003d$tmp_DEVSTACK_GATE_IRONIC"},{"line_number":262,"context_line":"        export DEVSTACK_GATE_VIRT_DRIVER\u003d$tmp_DEVSTACK_GATE_VIRT_DRIVER"}],"source_content_type":"text/x-sh","patch_set":4,"id":"baada198_26e391d9","line":259,"updated":"2014-08-06 15:27:07.000000000","message":"I think that the sideways bits have to be inside localrc to set the services right there for the new side.","commit_id":"49cfb334eca4986a6897725755cfe0a806aaf3a4"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"e4cbe65131f8d948eaab4372b0b6219a075e0a6a","unresolved":false,"context_lines":[{"line_number":256,"context_line":"    cd $BASE/old/devstack"},{"line_number":257,"context_line":"    setup_localrc \"old\" \"$GRENADE_OLD_BRANCH\""},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    if [[ \"$DEVSTACK_GATE_GRENADE\" \u003d\u003d \"sideways-ironic\" ]]; then"},{"line_number":260,"context_line":"        # Possibly enable ironic when generating the \"new\" localrc."},{"line_number":261,"context_line":"        export DEVSTACK_GATE_IRONIC\u003d$tmp_DEVSTACK_GATE_IRONIC"},{"line_number":262,"context_line":"        export DEVSTACK_GATE_VIRT_DRIVER\u003d$tmp_DEVSTACK_GATE_VIRT_DRIVER"}],"source_content_type":"text/x-sh","patch_set":4,"id":"baada198_94171c53","line":259,"in_reply_to":"baada198_26e391d9","updated":"2014-08-06 19:30:18.000000000","message":"Never mind, I just got lost in the inline logic","commit_id":"49cfb334eca4986a6897725755cfe0a806aaf3a4"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"d9bec29d931f55622915ea05c400760058338a7c","unresolved":false,"context_lines":[{"line_number":257,"context_line":"    setup_localrc \"old\" \"$GRENADE_OLD_BRANCH\""},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    if [[ \"$DEVSTACK_GATE_GRENADE\" \u003d\u003d \"sideways-ironic\" ]]; then"},{"line_number":260,"context_line":"        # Possibly enable ironic when generating the \"new\" localrc."},{"line_number":261,"context_line":"        export DEVSTACK_GATE_IRONIC\u003d$tmp_DEVSTACK_GATE_IRONIC"},{"line_number":262,"context_line":"        export DEVSTACK_GATE_VIRT_DRIVER\u003d$tmp_DEVSTACK_GATE_VIRT_DRIVER"},{"line_number":263,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":4,"id":"7ac7a964_42423811","line":260,"updated":"2014-08-14 21:53:08.000000000","message":"Why is this possibly as opposed to definitely?","commit_id":"49cfb334eca4986a6897725755cfe0a806aaf3a4"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"6ce4d561f4172e72c1d0894234af7427eab7e04e","unresolved":false,"context_lines":[{"line_number":257,"context_line":"    setup_localrc \"old\" \"$GRENADE_OLD_BRANCH\""},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    if [[ \"$DEVSTACK_GATE_GRENADE\" \u003d\u003d \"sideways-ironic\" ]]; then"},{"line_number":260,"context_line":"        # Possibly enable ironic when generating the \"new\" localrc."},{"line_number":261,"context_line":"        export DEVSTACK_GATE_IRONIC\u003d$tmp_DEVSTACK_GATE_IRONIC"},{"line_number":262,"context_line":"        export DEVSTACK_GATE_VIRT_DRIVER\u003d$tmp_DEVSTACK_GATE_VIRT_DRIVER"},{"line_number":263,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":4,"id":"7ac7a964_82ce1082","line":260,"in_reply_to":"7ac7a964_42423811","updated":"2014-08-14 21:56:38.000000000","message":"Because and this is silly, but the current ironic tests don\u0027t use ironic as a virt driver. They use libvirt. I don\u0027t fully understand it, but ya. So tmp_DEVSTACK_GATE_VIRT_DRIVER may be libvirt or ironic depending on how they have their tests set up.","commit_id":"49cfb334eca4986a6897725755cfe0a806aaf3a4"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"d9bec29d931f55622915ea05c400760058338a7c","unresolved":false,"context_lines":[{"line_number":262,"context_line":"        export DEVSTACK_GATE_VIRT_DRIVER\u003d$tmp_DEVSTACK_GATE_VIRT_DRIVER"},{"line_number":263,"context_line":"    fi"},{"line_number":264,"context_line":"    if [[ \"$DEVSTACK_GATE_GRENADE\" \u003d\u003d \"sideways-neutron\" ]]; then"},{"line_number":265,"context_line":"        # Possibly enable neutron when generating the \"new\" localrc."},{"line_number":266,"context_line":"        export DEVSTACK_GATE_NEUTRON\u003d$tmp_DEVSTACK_GATE_NEUTRON"},{"line_number":267,"context_line":"    fi"},{"line_number":268,"context_line":"    cd $BASE/new/devstack"}],"source_content_type":"text/x-sh","patch_set":4,"id":"7ac7a964_62473420","line":265,"updated":"2014-08-14 21:53:08.000000000","message":"Ditto?","commit_id":"49cfb334eca4986a6897725755cfe0a806aaf3a4"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"6ce4d561f4172e72c1d0894234af7427eab7e04e","unresolved":false,"context_lines":[{"line_number":262,"context_line":"        export DEVSTACK_GATE_VIRT_DRIVER\u003d$tmp_DEVSTACK_GATE_VIRT_DRIVER"},{"line_number":263,"context_line":"    fi"},{"line_number":264,"context_line":"    if [[ \"$DEVSTACK_GATE_GRENADE\" \u003d\u003d \"sideways-neutron\" ]]; then"},{"line_number":265,"context_line":"        # Possibly enable neutron when generating the \"new\" localrc."},{"line_number":266,"context_line":"        export DEVSTACK_GATE_NEUTRON\u003d$tmp_DEVSTACK_GATE_NEUTRON"},{"line_number":267,"context_line":"    fi"},{"line_number":268,"context_line":"    cd $BASE/new/devstack"}],"source_content_type":"text/x-sh","patch_set":4,"id":"7ac7a964_42831804","line":265,"in_reply_to":"7ac7a964_62473420","updated":"2014-08-14 21:56:38.000000000","message":"For neutron I think it may actually always be neutron and this comment is a bad copy paste with insufficient text substitution.","commit_id":"49cfb334eca4986a6897725755cfe0a806aaf3a4"}],"test-matrix.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"53c34201b93a67aefbb27e8129e04dfd8df45994","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    configs \u003d []"},{"line_number":67,"context_line":"    for k, v in os.environ.iteritems():"},{"line_number":68,"context_line":"        if k.startswith(\u0027DEVSTACK_GATE_\u0027):"},{"line_number":69,"context_line":"            if v not in [\u0027\u0027, \u00270\u0027, \u0027false\u0027, \u0027False\u0027, \u0027FALSE\u0027]:"},{"line_number":70,"context_line":"                f \u003d k.split(\u0027DEVSTACK_GATE_\u0027)[1]"},{"line_number":71,"context_line":"                configs.append(f.lower())"},{"line_number":72,"context_line":"    return configs"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_2cbe64ce","line":69,"updated":"2014-08-04 19:52:32.000000000","message":"nit: would be nice if this was a \u0027is_false\u0027 function just for clarity","commit_id":"01eab06bda58666b7e3da4b9587a4e7937d21c40"}]}