)]}'
{"test-matrix.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"8046f637b90920724d9ac9ce9a48832a31714536","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    LOG.debug(\"Branch: %s\" % branch)"},{"line_number":97,"context_line":"    LOG.debug(\"Configs: %s\" % configs)"},{"line_number":98,"context_line":"    if os.environ.get(\u0027DEVSTACK_GATE_NO_SERVICES\u0027) not in FALSE_VALUES:"},{"line_number":99,"context_line":"        features \u003d set(GRID[\u0027config\u0027][\u0027default\u0027][\u0027no_services\u0027])"},{"line_number":100,"context_line":"    else:"},{"line_number":101,"context_line":"        features \u003d set(GRID[\u0027config\u0027][\u0027default\u0027][branch])"},{"line_number":102,"context_line":"    # do all the adds first"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_f8b9207a","line":99,"updated":"2014-08-26 16:49:53.000000000","message":"This mixes together branch listing and this special meta var thing in the features.yaml file. This means we can\u0027t have a branch called no_services. We prefix our branches as stable/*, proposed/*, feature/* etc so I think this is fine. But something we may want to think about if we ever redo this config.\n\nOne way of doing that may be to have the default: section be only meta var things, then have a branches: section that contains the current branch listings?\n\nWith only on of these special vars today it is hard to justify redoing the config.","commit_id":"2ac355640a2fdd05beb3242fcd210ffeadcfa6a7"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"6ac96eff9446d8428e3a232aec7affa2c6d6ef04","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    LOG.debug(\"Branch: %s\" % branch)"},{"line_number":97,"context_line":"    LOG.debug(\"Configs: %s\" % configs)"},{"line_number":98,"context_line":"    if os.environ.get(\u0027DEVSTACK_GATE_NO_SERVICES\u0027) not in FALSE_VALUES:"},{"line_number":99,"context_line":"        features \u003d set(GRID[\u0027config\u0027][\u0027default\u0027][\u0027no_services\u0027])"},{"line_number":100,"context_line":"    else:"},{"line_number":101,"context_line":"        features \u003d set(GRID[\u0027config\u0027][\u0027default\u0027][branch])"},{"line_number":102,"context_line":"    # do all the adds first"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_1d5ce0ec","line":99,"in_reply_to":"1abeadc6_f8b9207a","updated":"2014-08-27 14:29:52.000000000","message":"Agreed. As we accumulate more, something like a dgmeta/ prefix would be a good way to reduce future collision risks. For now I\u0027m okay with it.","commit_id":"2ac355640a2fdd05beb3242fcd210ffeadcfa6a7"}]}