)]}'
{"id":"openstack%2Fdevstack-gate~122896","triplet_id":"openstack%2Fdevstack-gate~master~Iade4870dbdec97b6bb9c407d1e200505dfc427ed","project":"openstack/devstack-gate","branch":"master","topic":"pre_cleanup_hook","hashtags":[],"change_id":"Iade4870dbdec97b6bb9c407d1e200505dfc427ed","subject":"Add a pre-clean and post-clean hooks.","status":"ABANDONED","created":"2014-09-20 00:11:14.000000000","updated":"2014-10-28 16:58:46.000000000","total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"880eec0980f89af678f4bad88f8054aa08dc7935","_number":122896,"virtual_id_number":122896,"owner":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"date":"2014-10-27 18:47:21.000000000","_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":1,"date":"2014-09-24 02:08:14.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2014-09-24 11:10:00.000000000","_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},{"_account_id":5660,"name":"Kurt Taylor","email":"kurt.r.taylor@gmail.com","username":"krtaylor"},{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},{"_account_id":11966,"name":"daya kamath","email":"daya_k@yahoo.com","username":"daya-k"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"recommended":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},{"value":1,"date":"2014-09-24 03:10:35.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},{"value":1,"date":"2014-09-23 21:28:52.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},{"value":1,"date":"2014-09-29 13:03:27.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":5660,"name":"Kurt Taylor","email":"kurt.r.taylor@gmail.com","username":"krtaylor"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},{"value":2,"date":"2014-09-24 02:54:42.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},{"value":1,"date":"2014-09-24 08:21:25.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":11966,"name":"daya kamath","email":"daya_k@yahoo.com","username":"daya-k"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},{"_account_id":5660,"name":"Kurt Taylor","email":"kurt.r.taylor@gmail.com","username":"krtaylor"},{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},{"_account_id":11966,"name":"daya kamath","email":"daya_k@yahoo.com","username":"daya-k"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},{"_account_id":5660,"name":"Kurt Taylor","email":"kurt.r.taylor@gmail.com","username":"krtaylor"},{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},{"_account_id":11966,"name":"daya kamath","email":"daya_k@yahoo.com","username":"daya-k"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-09-22 18:25:47.000000000","updated_by":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"reviewer":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"state":"REVIEWER"},{"updated":"2014-09-23 21:28:52.000000000","updated_by":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"reviewer":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"state":"REVIEWER"},{"updated":"2014-09-24 02:08:14.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2014-09-24 02:54:42.000000000","updated_by":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"reviewer":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"state":"REVIEWER"},{"updated":"2014-09-24 03:10:35.000000000","updated_by":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"reviewer":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"state":"REVIEWER"},{"updated":"2014-09-24 08:21:25.000000000","updated_by":{"_account_id":11966,"name":"daya kamath","email":"daya_k@yahoo.com","username":"daya-k"},"reviewer":{"_account_id":11966,"name":"daya kamath","email":"daya_k@yahoo.com","username":"daya-k"},"state":"REVIEWER"},{"updated":"2014-09-29 13:03:27.000000000","updated_by":{"_account_id":5660,"name":"Kurt Taylor","email":"kurt.r.taylor@gmail.com","username":"krtaylor"},"reviewer":{"_account_id":5660,"name":"Kurt Taylor","email":"kurt.r.taylor@gmail.com","username":"krtaylor"},"state":"REVIEWER"},{"updated":"2014-10-27 18:47:21.000000000","updated_by":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"reviewer":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"state":"REVIEWER"}],"messages":[{"id":"142d98ce5d7e62ef8b0f5e8c5ea1b368827513fb","author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"date":"2014-09-20 00:11:14.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"70a3d85e6fd34851a3be75f6b41d8ab4067fc16b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-09-20 04:40:02.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded.\n\n- check-tempest-dsvm-full http://logs.openstack.org/96/122896/1/check/check-tempest-dsvm-full/af8a05e : SUCCESS in 49m 07s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/96/122896/1/check/check-tempest-dsvm-postgres-full/eebf135 : SUCCESS in 51m 53s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/96/122896/1/check/check-tempest-dsvm-neutron-full/1913afd : SUCCESS in 58m 29s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/96/122896/1/check/check-tempest-dsvm-neutron-heat-slow/4740959 : SUCCESS in 19m 14s\n- check-grenade-dsvm http://logs.openstack.org/96/122896/1/check/check-grenade-dsvm/8e7245f : SUCCESS in 43m 53s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/96/122896/1/check/gate-tempest-dsvm-large-ops/7ae296a : SUCCESS in 19m 08s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/96/122896/1/check/gate-tempest-dsvm-neutron-large-ops/b323370 : SUCCESS in 24m 24s\n- gate-devstack-gate-unittests http://logs.openstack.org/96/122896/1/check/gate-devstack-gate-unittests/644e3b6 : SUCCESS in 10s\n- check-devstack-dsvm-cells http://logs.openstack.org/96/122896/1/check/check-devstack-dsvm-cells/877ee76 : SUCCESS in 19m 29s\n- check-dg-tempest-dsvm-full http://logs.openstack.org/96/122896/1/check/check-dg-tempest-dsvm-full/dc46289 : SUCCESS in 53m 34s\n- check-dg-tempest-dsvm-full-reexec http://logs.openstack.org/96/122896/1/check/check-dg-tempest-dsvm-full-reexec/e67ef28 : SUCCESS in 57m 15s\n- check-dg-hooks-dsvm http://logs.openstack.org/96/122896/1/check/check-dg-hooks-dsvm/dd1ca9c : SUCCESS in 4m 28s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/96/122896/1/check/check-grenade-dsvm-partial-ncpu/9cca5b7 : SUCCESS in 45m 53s\n- check-swift-dsvm-functional http://logs.openstack.org/96/122896/1/check/check-swift-dsvm-functional/01f416c : SUCCESS in 17m 20s\n- check-tempest-dsvm-full-icehouse http://logs.openstack.org/96/122896/1/check/check-tempest-dsvm-full-icehouse/a3c470c : SUCCESS in 47m 46s\n- check-tempest-dsvm-neutron-icehouse http://logs.openstack.org/96/122896/1/check/check-tempest-dsvm-neutron-icehouse/f6b16f6 : SUCCESS in 55m 05s\n- check-tempest-dsvm-postgres-full-icehouse http://logs.openstack.org/96/122896/1/check/check-tempest-dsvm-postgres-full-icehouse/ed15059 : SUCCESS in 47m 46s\n- check-devstack-dsvm-cells-icehouse http://logs.openstack.org/96/122896/1/check/check-devstack-dsvm-cells-icehouse/0c8cdcc : SUCCESS in 15m 22s\n- check-tempest-dsvm-full-havana http://logs.openstack.org/96/122896/1/check/check-tempest-dsvm-full-havana/01f119f : SUCCESS in 36m 07s (non-voting)\n- check-tempest-dsvm-neutron-havana http://logs.openstack.org/96/122896/1/check/check-tempest-dsvm-neutron-havana/d5499ae : SUCCESS in 35m 15s (non-voting)\n- check-tempest-dsvm-postgres-full-havana http://logs.openstack.org/96/122896/1/check/check-tempest-dsvm-postgres-full-havana/8d9639b : SUCCESS in 36m 29s (non-voting)\n- check-devstack-dsvm-cells-havana http://logs.openstack.org/96/122896/1/check/check-devstack-dsvm-cells-havana/fb548de : SUCCESS in 13m 25s (non-voting)\n- check-tempest-dsvm-ironic-pxe_ssh-nv http://logs.openstack.org/96/122896/1/check/check-tempest-dsvm-ironic-pxe_ssh-nv/e78dccd : SUCCESS in 29m 29s (non-voting)\n- check-tempest-dsvm-ironic-pxe_ssh-postgres-nv http://logs.openstack.org/96/122896/1/check/check-tempest-dsvm-ironic-pxe_ssh-postgres-nv/7253a96 : SUCCESS in 29m 56s (non-voting)\n- check-tempest-dsvm-f20 http://logs.openstack.org/96/122896/1/check/check-tempest-dsvm-f20/6d1bbce : SUCCESS in 47m 22s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"2d1b8be9e2eac71efb511786b73278eb0a7cded0","author":{"_account_id":6316,"name":"Anita Kuno","email":"anteaya@anteaya.info","username":"anteaya"},"date":"2014-09-22 18:25:47.000000000","message":"Patch Set 1: Code-Review+1\n\nI think it would be good to add some hooks if they help third party ci clean up after themselves. My +1 is for the general direction, I don\u0027t know enough about devstack-gate code to offer an opinion as to whether this is the best implementation.","accounts_in_message":[],"_revision_number":1},{"id":"41fd8750ffb3cb1c2b7673b77f6963211f9c3ec0","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2014-09-22 23:14:19.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"57a865f56785c8239687b0c2911a059cf70e021b","author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"date":"2014-09-23 14:18:55.000000000","message":"Patch Set 1: Code-Review-1\n\nThank you, this would be nice to have for 3rd party CI indeed.\n\n-1 is to indicate a concern about code duplication, there are now 4 nearly identical hook calls.","accounts_in_message":[],"_revision_number":1},{"id":"91184b520203de97b2fe5327d9a562ff362fc596","author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"date":"2014-09-23 14:33:46.000000000","message":"Patch Set 1:\n\nHi Mikhail,\n\nThanks for your review. I don\u0027t know how to refactor these hooks to share common code. Could you help me out with this? You can ping me on irc @asselin.\n\nThanks!\nRamy","accounts_in_message":[],"_revision_number":1},{"id":"855167e68f423aef5c5036e3973e2b69ba2c256d","author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"date":"2014-09-23 15:17:55.000000000","message":"Patch Set 1: -Code-Review\n\nRamy, I would wait for more reviews first. If there is an agreement it would be good to restructure first, you can look how other functions are implemented, for example https://github.com/openstack-infra/devstack-gate/blob/068c3ed3c06f519b57ec53d9d8d5526abaa9e0ea/functions.sh#L118-L128\nSo then the hook calls would be replaced with something similar to\n  call_hook_if_defined post_clean_hook\n  RETVAL\u003d$?","accounts_in_message":[],"_revision_number":1},{"id":"25483b6e88d11cb162347c821db032c5f770a472","author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"date":"2014-09-23 17:19:23.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"2c364683bd0aa20cc9a15645c1a16a2032def9c2","author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"date":"2014-09-23 18:31:33.000000000","message":"Patch Set 2: Code-Review-1\n\n(2 comments)\n\nThank you for the new patch. I think it is good. But it would be better to split it, and make first patch for refactoring, and the second for actually adding post and pre cleanup hooks. It is a good practice and recommended by OpenStack guidelines.","accounts_in_message":[],"_revision_number":2},{"id":"e9dd7b9180898782c90d3581bc2349983846843d","author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"date":"2014-09-23 20:33:35.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"1910eb7ab310531908a1caf6da1a0309bf318d5e","author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"date":"2014-09-23 20:42:58.000000000","message":"Patch Set 3: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"c00b27bfc04c622fbc1a7cd668e888a1d36fb173","author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"date":"2014-09-23 21:24:21.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"0d3aba4b6993faf9baf6c36bc444f738f26c5ef6","author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"date":"2014-09-23 21:28:52.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"7480258f490eba0b04c79ea2166c3493e996b140","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-09-24 02:08:14.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded.\n\n- check-tempest-dsvm-full http://logs.openstack.org/96/122896/4/check/check-tempest-dsvm-full/762788b : SUCCESS in 56m 49s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/96/122896/4/check/check-tempest-dsvm-postgres-full/f0ecbbe : SUCCESS in 48m 49s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/96/122896/4/check/check-tempest-dsvm-neutron-full/8d571e4 : SUCCESS in 1h 09m 10s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/96/122896/4/check/check-tempest-dsvm-neutron-heat-slow/cf91f1a : SUCCESS in 24m 51s\n- check-grenade-dsvm http://logs.openstack.org/96/122896/4/check/check-grenade-dsvm/dfff4bf : SUCCESS in 50m 07s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/96/122896/4/check/gate-tempest-dsvm-large-ops/7c1efe1 : SUCCESS in 20m 49s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/96/122896/4/check/gate-tempest-dsvm-neutron-large-ops/e8bbb4d : SUCCESS in 25m 03s\n- gate-devstack-gate-unittests http://logs.openstack.org/96/122896/4/check/gate-devstack-gate-unittests/05de7ad : SUCCESS in 4s\n- check-devstack-dsvm-cells http://logs.openstack.org/96/122896/4/check/check-devstack-dsvm-cells/f8e8a63 : SUCCESS in 17m 41s\n- check-dg-tempest-dsvm-full http://logs.openstack.org/96/122896/4/check/check-dg-tempest-dsvm-full/372202f : SUCCESS in 1h 00m 36s\n- check-dg-tempest-dsvm-full-reexec http://logs.openstack.org/96/122896/4/check/check-dg-tempest-dsvm-full-reexec/d88746f : SUCCESS in 45m 43s\n- check-dg-hooks-dsvm http://logs.openstack.org/96/122896/4/check/check-dg-hooks-dsvm/4967338 : SUCCESS in 6m 04s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/96/122896/4/check/check-grenade-dsvm-partial-ncpu/04eb119 : SUCCESS in 41m 07s\n- check-swift-dsvm-functional http://logs.openstack.org/96/122896/4/check/check-swift-dsvm-functional/424e72d : SUCCESS in 20m 56s\n- check-tempest-dsvm-full-icehouse http://logs.openstack.org/96/122896/4/check/check-tempest-dsvm-full-icehouse/4034489 : SUCCESS in 49m 38s\n- check-tempest-dsvm-neutron-icehouse http://logs.openstack.org/96/122896/4/check/check-tempest-dsvm-neutron-icehouse/5ffa96c : SUCCESS in 54m 26s\n- check-tempest-dsvm-postgres-full-icehouse http://logs.openstack.org/96/122896/4/check/check-tempest-dsvm-postgres-full-icehouse/3743a11 : SUCCESS in 46m 12s\n- check-devstack-dsvm-cells-icehouse http://logs.openstack.org/96/122896/4/check/check-devstack-dsvm-cells-icehouse/adf5510 : SUCCESS in 14m 34s\n- check-tempest-dsvm-full-havana http://logs.openstack.org/96/122896/4/check/check-tempest-dsvm-full-havana/dc48ff9 : SUCCESS in 36m 03s (non-voting)\n- check-tempest-dsvm-neutron-havana http://logs.openstack.org/96/122896/4/check/check-tempest-dsvm-neutron-havana/b304225 : SUCCESS in 35m 21s (non-voting)\n- check-tempest-dsvm-postgres-full-havana http://logs.openstack.org/96/122896/4/check/check-tempest-dsvm-postgres-full-havana/34bd49b : SUCCESS in 36m 39s (non-voting)\n- check-devstack-dsvm-cells-havana http://logs.openstack.org/96/122896/4/check/check-devstack-dsvm-cells-havana/8834cb2 : SUCCESS in 13m 33s (non-voting)\n- check-tempest-dsvm-ironic-pxe_ssh-nv http://logs.openstack.org/96/122896/4/check/check-tempest-dsvm-ironic-pxe_ssh-nv/a26f1d6 : SUCCESS in 33m 21s (non-voting)\n- check-tempest-dsvm-ironic-pxe_ssh-postgres-nv http://logs.openstack.org/96/122896/4/check/check-tempest-dsvm-ironic-pxe_ssh-postgres-nv/2cc4344 : SUCCESS in 30m 46s (non-voting)\n- check-tempest-dsvm-f20 http://logs.openstack.org/96/122896/4/check/check-tempest-dsvm-f20/cec3078 : SUCCESS in 47m 35s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"03c2b11ae2eac5930c5ef70e01896d9431f30927","author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"date":"2014-09-24 02:54:42.000000000","message":"Patch Set 4: Code-Review+2","accounts_in_message":[],"_revision_number":4},{"id":"00023ec4867c456e745e891501fb826b2b1e3393","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2014-09-24 03:10:35.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"8fdef881335431f2e76f7eada3d1c73c51f6de4c","author":{"_account_id":11966,"name":"daya kamath","email":"daya_k@yahoo.com","username":"daya-k"},"date":"2014-09-24 08:21:25.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"2fbfe1a47048e4ed4b37920642789115fcd58f9f","author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"date":"2014-09-24 11:10:00.000000000","message":"Patch Set 4:\n\nThanks for your review. Please also review this depends-on change:\nhttps://review.openstack.org/#/c/123578/1","accounts_in_message":[],"_revision_number":4},{"id":"30dea0d2b03a4001be036f096bc0b500063c42d0","author":{"_account_id":5660,"name":"Kurt Taylor","email":"kurt.r.taylor@gmail.com","username":"krtaylor"},"date":"2014-09-29 13:03:27.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"01cb8d067e13878872f853786fe1992635900e6d","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"date":"2014-10-27 18:47:21.000000000","message":"Patch Set 4:\n\nThis change is not necessary. You can run cleanup stuff prior to and after running d-g. Just add it to your jenkins jobs (which you would have to do to take advantage of this change anyways).\n\nThe reason we have the other hooks is you actually do want to run the test stuff in the context of d-g but site specific cleanup should be fine without that context.\n\nAdding this functionality to d-g is also problematic because it will not be tested/consumed upstream which can lead to it breaking in unexpected ways.","accounts_in_message":[],"_revision_number":4},{"id":"6a27269b2e11b28ef6f29ed1a82d2a74b0389347","author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"date":"2014-10-28 16:58:34.000000000","message":"Patch Set 4:\n\nI was able to do what I needed without using the patch using Clark\u0027s suggestion.\n\nPre-clean, however, is not quite pre-clean, since it runs after devstack cleans. In my case, I was sanitizing log files, so in post-clean, I unzip them, update, and rezip them. Performance penalty to unzip and rezip is about 2 seconds, which is acceptible. \n\ne.g.\n\n          cp devstack-gate/devstack-vm-gate-wrap.sh ./safe-devstack-vm-gate-wrap.sh\n          set +e\n          ./safe-devstack-vm-gate-wrap.sh\n          job_result\u003d$?\n\n          export BASE\u003d/opt/stack\n          pre_clean_hook\n          post_clean_hook\n\n          exit $job_result\n\nSo I will abandon.","accounts_in_message":[],"_revision_number":4},{"id":"4da9275cfd69f67d112bdb1de286d53620da942b","author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"date":"2014-10-28 16:58:46.000000000","message":"Abandoned\n\nI was able to do what I needed without using the patch using Clark\u0027s suggestion.\n\nPre-clean, however, is not quite pre-clean, since it runs after devstack cleans. In my case, I was sanitizing log files, so in post-clean, I unzip them, update, and rezip them. Performance penalty to unzip and rezip is about 2 seconds, which is acceptible. \n\ne.g.\n\n          cp devstack-gate/devstack-vm-gate-wrap.sh ./safe-devstack-vm-gate-wrap.sh\n          set +e\n          ./safe-devstack-vm-gate-wrap.sh\n          job_result\u003d$?\n\n          export BASE\u003d/opt/stack\n          pre_clean_hook\n          post_clean_hook\n\n          exit $job_result\n\nSo I will abandon.","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"3b97f8b610241a30646194c9e29a163458924680","revisions":{"9839f8734d9317d4c0d1c8c9f570aca4ff05a40e":{"kind":"REWORK","_number":1,"created":"2014-09-20 00:11:14.000000000","uploader":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"ref":"refs/changes/96/122896/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack-gate","ref":"refs/changes/96/122896/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/96/122896/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/96/122896/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/96/122896/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack-gate refs/changes/96/122896/1"}}},"commit":{"parents":[{"commit":"804bf2e5632e779368fcf785060575c6c08c75ae","subject":"Merge \"Add tempest-lib to the projects list\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/804bf2e5632e779368fcf785060575c6c08c75ae"}]}],"author":{"name":"Ramy Asselin","email":"ramy.asselin@hp.com","date":"2014-09-20 00:04:31.000000000","tz":-420},"committer":{"name":"Ramy Asselin","email":"ramy.asselin@hp.com","date":"2014-09-20 00:11:13.000000000","tz":-420},"subject":"Add a pre-clean hook.","message":"Add a pre-clean hook.\n\n3rd party ci needs to do some cleanup.\npost_test_hook is not sufficient because it only runs when successful.\nExisting cleanup host function doesn\u0027t have any hooks.\nLet this be the hook.\nWhile we\u0027re at it, let\u0027s add a post-clean hook for completeness.\n\nChange-Id: Iade4870dbdec97b6bb9c407d1e200505dfc427ed\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/9839f8734d9317d4c0d1c8c9f570aca4ff05a40e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/9839f8734d9317d4c0d1c8c9f570aca4ff05a40e"}]},"branch":"refs/heads/master"},"d8fb65f47a2aa0c5d9e5c3e00b98176532e48419":{"kind":"REWORK","_number":2,"created":"2014-09-23 17:19:23.000000000","uploader":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"ref":"refs/changes/96/122896/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack-gate","ref":"refs/changes/96/122896/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/96/122896/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/96/122896/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/96/122896/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack-gate refs/changes/96/122896/2"}}},"commit":{"parents":[{"commit":"068c3ed3c06f519b57ec53d9d8d5526abaa9e0ea","subject":"Merge \"Switch to static content for glance upload test\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/068c3ed3c06f519b57ec53d9d8d5526abaa9e0ea"}]}],"author":{"name":"Ramy Asselin","email":"ramy.asselin@hp.com","date":"2014-09-20 00:04:31.000000000","tz":-420},"committer":{"name":"Ramy Asselin","email":"ramy.asselin@hp.com","date":"2014-09-23 17:19:21.000000000","tz":-420},"subject":"Add a pre-clean hook.","message":"Add a pre-clean hook.\n\n3rd party ci needs to do some cleanup.\npost_test_hook is not sufficient because it only runs when successful.\nExisting cleanup host function doesn\u0027t have any hooks.\nLet this be the hook.\nWhile we\u0027re at it, let\u0027s add a post-clean hook for completeness.\nRefactor hook logic into a function for reuse.\n\nChange-Id: Iade4870dbdec97b6bb9c407d1e200505dfc427ed\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/d8fb65f47a2aa0c5d9e5c3e00b98176532e48419"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/d8fb65f47a2aa0c5d9e5c3e00b98176532e48419"}]},"branch":"refs/heads/master"},"0cc1254d37bafb0c5b0bfecb875cf47d2cd788dd":{"kind":"REWORK","_number":3,"created":"2014-09-23 20:33:35.000000000","uploader":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"ref":"refs/changes/96/122896/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack-gate","ref":"refs/changes/96/122896/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/96/122896/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/96/122896/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/96/122896/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack-gate refs/changes/96/122896/3"}}},"commit":{"parents":[{"commit":"c9052a4ad1bdff71f26c731e8fe4be5306ad3172","subject":"Refactor the hook logic into a reusable function","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/c9052a4ad1bdff71f26c731e8fe4be5306ad3172"}]}],"author":{"name":"Ramy Asselin","email":"ramy.asselin@hp.com","date":"2014-09-23 20:29:52.000000000","tz":-420},"committer":{"name":"Ramy Asselin","email":"ramy.asselin@hp.com","date":"2014-09-23 20:29:52.000000000","tz":-420},"subject":"Add a pre-clean and post-clean hooks.","message":"Add a pre-clean and post-clean hooks.\n\n3rd party ci needs to do some cleanup.\npost_test_hook is not sufficient because it only runs when successful.\nExisting cleanup host function doesn\u0027t have any hooks.\nLet this be the hook.\nWhile we\u0027re at it, let\u0027s add a post-clean hook for completeness.\n\nChange-Id: Iade4870dbdec97b6bb9c407d1e200505dfc427ed\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/0cc1254d37bafb0c5b0bfecb875cf47d2cd788dd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/0cc1254d37bafb0c5b0bfecb875cf47d2cd788dd"}]},"branch":"refs/heads/master"},"3b97f8b610241a30646194c9e29a163458924680":{"kind":"REWORK","_number":4,"created":"2014-09-23 21:24:21.000000000","uploader":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"ref":"refs/changes/96/122896/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack-gate","ref":"refs/changes/96/122896/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/96/122896/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/96/122896/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/96/122896/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack-gate refs/changes/96/122896/4"}}},"commit":{"parents":[{"commit":"c9052a4ad1bdff71f26c731e8fe4be5306ad3172","subject":"Refactor the hook logic into a reusable function","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/c9052a4ad1bdff71f26c731e8fe4be5306ad3172"}]}],"author":{"name":"Ramy Asselin","email":"ramy.asselin@hp.com","date":"2014-09-23 20:29:52.000000000","tz":-420},"committer":{"name":"Ramy Asselin","email":"ramy.asselin@hp.com","date":"2014-09-23 21:21:38.000000000","tz":-420},"subject":"Add a pre-clean and post-clean hooks.","message":"Add a pre-clean and post-clean hooks.\n\n3rd party ci needs to do some cleanup.\npost_test_hook is not sufficient because it only runs when successful.\nExisting cleanup host function doesn\u0027t have any hooks.\nLet this be the hook.\nWhile we\u0027re at it, let\u0027s add a post-clean hook for completeness.\n\nChange-Id: Iade4870dbdec97b6bb9c407d1e200505dfc427ed\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/3b97f8b610241a30646194c9e29a163458924680"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/3b97f8b610241a30646194c9e29a163458924680"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}