)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6609,"name":"Elizabeth K. Joseph","email":"lyz@princessleia.com","username":"lyz"},"change_message_id":"f1926403576e332e3d5170e079de93364a00aa8f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Flavio Percoco \u003cfpercoco@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-10-29 10:50:53 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Set ZAQAR_BACKEND in localrc if present"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In order to add more gates on different backends for Zaqar, we need to"},{"line_number":10,"context_line":"set the ZAQAR_BACKEND env var in devstack. Setting it in the job is not"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a8c0949_ebab3bd4","line":7,"updated":"2014-10-30 15:18:34.000000000","message":"Since the localrc seems to no longer be a part of this, can you adjust the commit message?","commit_id":"c9d69d8b21159fd2e83c0b9e6c0fc3242f3f8be2"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"39847d543b5e6da5481d67ccd0970e894b27a1a5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Flavio Percoco \u003cfpercoco@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-10-29 10:50:53 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Set ZAQAR_BACKEND in localrc if present"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In order to add more gates on different backends for Zaqar, we need to"},{"line_number":10,"context_line":"set the ZAQAR_BACKEND env var in devstack. Setting it in the job is not"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a8c0949_cb24bfc8","line":7,"in_reply_to":"7a8c0949_ebab3bd4","updated":"2014-10-30 15:41:05.000000000","message":"mmh, but we are still setting it in the localrc here in devstack-vm-gate.sh\n\nAm I missing something?","commit_id":"c9d69d8b21159fd2e83c0b9e6c0fc3242f3f8be2"}],"devstack-vm-gate.sh":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"084fec771fa0fc7c697d43c2d98edea09fd61341","unresolved":false,"context_lines":[{"line_number":280,"context_line":"        echo \"INSTALL_TESTONLY_PACKAGES\u003dTrue\" \u003e\u003e localrc"},{"line_number":281,"context_line":"    fi"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"    if [[ -z \"$ZAQAR_BACKEND\" ]]; then"},{"line_number":284,"context_line":"\techo \"ZAQAR_BACKEND\u003d$ZAQAR_BACKEND\" \u003e\u003e localrc"},{"line_number":285,"context_line":"    fi"},{"line_number":286,"context_line":"}"}],"source_content_type":"text/x-sh","patch_set":1,"id":"baa201ad_ff98041d","line":283,"updated":"2014-10-14 09:50:58.000000000","message":"Let\u0027s add a comment here on what this does - like elsewhere...","commit_id":"a4b8ca0e9cda9364575775279107dc29dc1c142b"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"084fec771fa0fc7c697d43c2d98edea09fd61341","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    fi"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"    if [[ -z \"$ZAQAR_BACKEND\" ]]; then"},{"line_number":284,"context_line":"\techo \"ZAQAR_BACKEND\u003d$ZAQAR_BACKEND\" \u003e\u003e localrc"},{"line_number":285,"context_line":"    fi"},{"line_number":286,"context_line":"}"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"baa201ad_3fec4c8f","line":284,"updated":"2014-10-14 09:50:58.000000000","message":"no tabs here.","commit_id":"a4b8ca0e9cda9364575775279107dc29dc1c142b"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"4550b5f46d5f48641880875d3b173720cabd57a4","unresolved":false,"context_lines":[{"line_number":280,"context_line":"        echo \"INSTALL_TESTONLY_PACKAGES\u003dTrue\" \u003e\u003e localrc"},{"line_number":281,"context_line":"    fi"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"    if [[ -z \"$ZAQAR_BACKEND\" ]]; then"},{"line_number":284,"context_line":"        # allow enabling other backends for zaqar"},{"line_number":285,"context_line":"        echo \"ZAQAR_BACKEND\u003d$ZAQAR_BACKEND\" \u003e\u003e localrc"},{"line_number":286,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"baa201ad_5449dc2f","line":283,"updated":"2014-10-14 21:35:51.000000000","message":"Also conventions is to prefix this vars with DEVSTACK_GATE_ then set the devstack specific value via localrc. That said the \"bare\" ZAQAR_BACKEND doesn\u0027t bother me too much. However, we do set defaults for all values in devstack-vm-gate-wrap.sh and this variable should come with a default.","commit_id":"3d425e1b8ecea9808e56223d6c6af6b441d42a81"},{"author":{"_account_id":6609,"name":"Elizabeth K. Joseph","email":"lyz@princessleia.com","username":"lyz"},"change_message_id":"6bd385071fda637d5f60374af8ee1282efe5f6ee","unresolved":false,"context_lines":[{"line_number":280,"context_line":"        echo \"INSTALL_TESTONLY_PACKAGES\u003dTrue\" \u003e\u003e localrc"},{"line_number":281,"context_line":"    fi"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"    if [[ -z \"$ZAQAR_BACKEND\" ]]; then"},{"line_number":284,"context_line":"        # allow enabling other backends for zaqar"},{"line_number":285,"context_line":"        echo \"ZAQAR_BACKEND\u003d$ZAQAR_BACKEND\" \u003e\u003e localrc"},{"line_number":286,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"baa201ad_3691c79a","line":283,"updated":"2014-10-14 16:44:50.000000000","message":"Maybe I\u0027m confused about your intention here, but -z evaluate to true if $ZAQAR_BACKEND is *not* set.","commit_id":"3d425e1b8ecea9808e56223d6c6af6b441d42a81"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"982baf71bd0a4155f67dc94499a617d82ccaa128","unresolved":false,"context_lines":[{"line_number":280,"context_line":"        echo \"INSTALL_TESTONLY_PACKAGES\u003dTrue\" \u003e\u003e localrc"},{"line_number":281,"context_line":"    fi"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"    if [[ -z \"$ZAQAR_BACKEND\" ]]; then"},{"line_number":284,"context_line":"        # allow enabling other backends for zaqar"},{"line_number":285,"context_line":"        echo \"ZAQAR_BACKEND\u003d$ZAQAR_BACKEND\" \u003e\u003e localrc"},{"line_number":286,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"baa201ad_9188bd23","line":283,"in_reply_to":"baa201ad_3691c79a","updated":"2014-10-14 17:32:27.000000000","message":"Indeed, this should be \"-n\".","commit_id":"3d425e1b8ecea9808e56223d6c6af6b441d42a81"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"cb2bca9c3f1b1b04fb6b87f32a1b24692a74cb8d","unresolved":false,"context_lines":[{"line_number":280,"context_line":"        echo \"INSTALL_TESTONLY_PACKAGES\u003dTrue\" \u003e\u003e localrc"},{"line_number":281,"context_line":"    fi"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"    if [[ -z \"$ZAQAR_BACKEND\" ]]; then"},{"line_number":284,"context_line":"        # allow enabling other backends for zaqar"},{"line_number":285,"context_line":"        echo \"ZAQAR_BACKEND\u003d$ZAQAR_BACKEND\" \u003e\u003e localrc"},{"line_number":286,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"baa201ad_4cb06c43","line":283,"in_reply_to":"baa201ad_5449dc2f","updated":"2014-10-15 08:34:18.000000000","message":"I went with `ZAQAR_BACKEND` because I found other variables that weren\u0027t prepended with `DEVSTACK_GATE`. That said, I\u0027ll change it since I have to push another PS anyway.\n\nI\u0027ll update `project-config`\u0027s patch as well.","commit_id":"3d425e1b8ecea9808e56223d6c6af6b441d42a81"}]}