)]}'
{"devstack-vm-gate-wrap.sh":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"9f77ba4e8034a908635a5333ed755a4458c9df11","unresolved":false,"context_lines":[{"line_number":143,"context_line":"# The feature matrix to select devstack-gate components"},{"line_number":144,"context_line":"export DEVSTACK_GATE_FEATURE_MATRIX\u003d${DEVSTACK_GATE_FEATURE_MATRIX:-features.yaml}"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"# Set to 1 to run the Tempest test suite"},{"line_number":147,"context_line":"export DEVSTACK_GATE_TEMPEST\u003d${DEVSTACK_GATE_TEMPEST:-0}"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"# Set to 1 to run the devstack exercises"}],"source_content_type":"text/x-sh","patch_set":2,"id":"fa81d914_79ffbeaa","line":146,"updated":"2015-01-29 20:58:27.000000000","message":"The comment here is almost identical to the comment for the new variable. We should colocate these two variables (for readability) and update the comments associated with them to specifically call out what each of them does.\n\nSomething like:\n\n  # Set to 1 to install, configure, and run Tempest test suite\n export DEVSTACK_GATE_TEMPEST\u003d${DEVSTACK_GATE_TEMPEST:-0}\n\n  # Set to 1 to short circuit Tempest test suite execution post Tempest configuration\n  export DEVSTACK_GATE_TEMPEST_NO_EXECUTE\u003d${DEVSTACK_GATE_TEMPEST_NO_EXECUTE:-0}\n\nNote completely sold on that variable name but _NONE doesn\u0027t really convey much info itself.","commit_id":"098d96abec1c4a3e921c54d1820bbe068d4627f3"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"9dc2fe9319568540645939bed00ec6d47f01cce6","unresolved":false,"context_lines":[{"line_number":143,"context_line":"# The feature matrix to select devstack-gate components"},{"line_number":144,"context_line":"export DEVSTACK_GATE_FEATURE_MATRIX\u003d${DEVSTACK_GATE_FEATURE_MATRIX:-features.yaml}"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"# Set to 1 to run the Tempest test suite"},{"line_number":147,"context_line":"export DEVSTACK_GATE_TEMPEST\u003d${DEVSTACK_GATE_TEMPEST:-0}"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"# Set to 1 to run the devstack exercises"}],"source_content_type":"text/x-sh","patch_set":2,"id":"fa81d914_9cc8e023","line":146,"in_reply_to":"fa81d914_39f46686","updated":"2015-01-29 21:33:22.000000000","message":"I was having a hard time myself...I was torn between:\n\nDEVSTACK_GATE_TEMPEST_NONE\nDEVSTACK_GATE_TEMPEST_INSTALL_ONLY\nDEVSTACK_GATE_TEMPEST_CONFIG_ONLY\nDEVSTACK_GATE_TEMPEST_SKIP_TESTS\n\nIt seems that DEVSTACK_GATE_TEMPEST_NOTESTS would be the clearest?","commit_id":"098d96abec1c4a3e921c54d1820bbe068d4627f3"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"9075af9c0bccd3e8dd0aca6bf5f9c7979f4a434a","unresolved":false,"context_lines":[{"line_number":143,"context_line":"# The feature matrix to select devstack-gate components"},{"line_number":144,"context_line":"export DEVSTACK_GATE_FEATURE_MATRIX\u003d${DEVSTACK_GATE_FEATURE_MATRIX:-features.yaml}"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"# Set to 1 to run the Tempest test suite"},{"line_number":147,"context_line":"export DEVSTACK_GATE_TEMPEST\u003d${DEVSTACK_GATE_TEMPEST:-0}"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"# Set to 1 to run the devstack exercises"}],"source_content_type":"text/x-sh","patch_set":2,"id":"fa81d914_39f46686","line":146,"in_reply_to":"fa81d914_79ffbeaa","updated":"2015-01-29 21:02:44.000000000","message":"Gah previous comment should end with \"Not completely sold on that variable name\". Sorry for any confusion this comment may have caused.","commit_id":"098d96abec1c4a3e921c54d1820bbe068d4627f3"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"8744c72b8e96b9b862085558f2681ca96c403603","unresolved":false,"context_lines":[{"line_number":143,"context_line":"# The feature matrix to select devstack-gate components"},{"line_number":144,"context_line":"export DEVSTACK_GATE_FEATURE_MATRIX\u003d${DEVSTACK_GATE_FEATURE_MATRIX:-features.yaml}"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"# Set to 1 to run the Tempest test suite"},{"line_number":147,"context_line":"export DEVSTACK_GATE_TEMPEST\u003d${DEVSTACK_GATE_TEMPEST:-0}"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"# Set to 1 to run the devstack exercises"}],"source_content_type":"text/x-sh","patch_set":2,"id":"fa81d914_1a978d49","line":146,"in_reply_to":"fa81d914_9cc8e023","updated":"2015-01-29 23:23:11.000000000","message":"I like NOTESTS, why don\u0027t we go with that.","commit_id":"098d96abec1c4a3e921c54d1820bbe068d4627f3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"02000b61f402828a84fc2fd61d11d523ed68d837","unresolved":false,"context_lines":[{"line_number":302,"context_line":"export DEVSTACK_GATE_TEMPEST_ALL\u003d${DEVSTACK_GATE_TEMPEST_ALL:-0}"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"# Set to 1 to run none of the tempest tests"},{"line_number":305,"context_line":"export DEVSTACK_GATE_TEMPEST_NONE\u003d${DEVSTACK_GATE_TEMPEST_NONE:-0}"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"# Set to a regex to run tempest with a custom regex filter"},{"line_number":308,"context_line":"export DEVSTACK_GATE_TEMPEST_REGEX\u003d${DEVSTACK_GATE_TEMPEST_REGEX:-\"\"}"}],"source_content_type":"text/x-sh","patch_set":2,"id":"1a930d6b_0c922e9f","line":305,"updated":"2015-01-22 14:28:37.000000000","message":"We could mimic tox --notest option with DEVSTACK_GATE_TEMPEST_NOTEST, but it\u0027s just nice to have.","commit_id":"098d96abec1c4a3e921c54d1820bbe068d4627f3"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"91677e3a6a8f646f86d5b1b195c652be556a5c8b","unresolved":false,"context_lines":[{"line_number":143,"context_line":"# The feature matrix to select devstack-gate components"},{"line_number":144,"context_line":"export DEVSTACK_GATE_FEATURE_MATRIX\u003d${DEVSTACK_GATE_FEATURE_MATRIX:-features.yaml}"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"# Set to 1 to run the Tempest test suite"},{"line_number":147,"context_line":"export DEVSTACK_GATE_TEMPEST\u003d${DEVSTACK_GATE_TEMPEST:-0}"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"# Set to 1 to short circuit Tempest test suite execution post Tempest configuration"}],"source_content_type":"text/x-sh","patch_set":3,"id":"fa81d914_1dddc7e0","line":146,"updated":"2015-01-30 00:05:45.000000000","message":"Was hoping this comment would be updated too so that each of the two comments (this one and the one below) better reflect the effect they have on tempest.","commit_id":"6eaaf6a521eed2d6f0f9347c56af2444988e694f"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"635eb1a474ed1d0db4e836256b1aec983e4ad2d4","unresolved":false,"context_lines":[{"line_number":143,"context_line":"# The feature matrix to select devstack-gate components"},{"line_number":144,"context_line":"export DEVSTACK_GATE_FEATURE_MATRIX\u003d${DEVSTACK_GATE_FEATURE_MATRIX:-features.yaml}"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"# Set to 1 to run the Tempest test suite"},{"line_number":147,"context_line":"export DEVSTACK_GATE_TEMPEST\u003d${DEVSTACK_GATE_TEMPEST:-0}"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"# Set to 1 to short circuit Tempest test suite execution post Tempest configuration"}],"source_content_type":"text/x-sh","patch_set":3,"id":"fa81d914_7d016305","line":146,"in_reply_to":"fa81d914_1dddc7e0","updated":"2015-01-30 00:07:20.000000000","message":"This looks pretty self-explanatory to me. What else is there to add? Let me see if I can come up with a better explanation.","commit_id":"6eaaf6a521eed2d6f0f9347c56af2444988e694f"}],"devstack-vm-gate.sh":[{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"bb74ac32d26ff8644c722d9e0ebcec5b57d46934","unresolved":false,"context_lines":[{"line_number":519,"context_line":"    fi"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"    # We don\u0027t need to run Tempest, if this is switched on"},{"line_number":522,"context_line":"    if [[ \"$DEVSTACK_GATE_TEMPEST_INSTALL_ONLY\" -eq \"1\" ]]; then"},{"line_number":523,"context_line":"        exit 0"},{"line_number":524,"context_line":"    fi"},{"line_number":525,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"3a961159_dc70e70a","line":522,"updated":"2015-01-20 16:57:38.000000000","message":"You\u0027ll need to define and document this environment variable in devstack-vm-gate-wrap.sh.","commit_id":"0e6f683a0c6e10ae151691e6ccb1e81399e54659"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"7759730ad3e85658def4df9ea3f450faa29f5b3d","unresolved":false,"context_lines":[{"line_number":519,"context_line":"    fi"},{"line_number":520,"context_line":""},{"line_number":521,"context_line":"    # We don\u0027t need to run Tempest, if this is switched on"},{"line_number":522,"context_line":"    if [[ \"$DEVSTACK_GATE_TEMPEST_INSTALL_ONLY\" -eq \"1\" ]]; then"},{"line_number":523,"context_line":"        exit 0"},{"line_number":524,"context_line":"    fi"},{"line_number":525,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"3a961159_dc8c67da","line":522,"in_reply_to":"3a961159_dc70e70a","updated":"2015-01-20 16:59:58.000000000","message":"Thanks, I knew I missed something :)","commit_id":"0e6f683a0c6e10ae151691e6ccb1e81399e54659"}]}