)]}'
{"id":"openstack%2Fdevstack-gate~164874","triplet_id":"openstack%2Fdevstack-gate~master~I43139d2885d0284d1ea05eba9dabc75687a6fa5f","project":"openstack/devstack-gate","branch":"master","topic":"easier-services-tweaking","hashtags":[],"change_id":"I43139d2885d0284d1ea05eba9dabc75687a6fa5f","subject":"Mechanism to allow easier fine-tuning of devstack-gate services","status":"ABANDONED","created":"2015-03-16 21:27:44.000000000","updated":"2015-04-07 22:42:26.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"78e492caec9ec1b24f9f2244d19ebc29f8476513","_number":164874,"virtual_id_number":164874,"owner":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":1,"date":"2015-03-16 23:49:15.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2015-03-23 20:45:48.000000000","_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"all":[{"value":-1,"date":"2015-03-23 20:41:38.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},{"value":1,"date":"2015-03-23 16:40:57.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-03-16 23:49:15.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-03-23 16:40:57.000000000","updated_by":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"reviewer":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"state":"REVIEWER"},{"updated":"2015-03-23 20:41:38.000000000","updated_by":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"reviewer":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"state":"REVIEWER"}],"messages":[{"id":"58fb1fdb367da4edb1ee529aa7c0ddde4a1e2f2c","author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"date":"2015-03-16 21:27:44.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0ff78ad19a311fb429b510a801c91b553a500777","author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"date":"2015-03-16 21:29:15.000000000","message":"Patch Set 1:\n\nYes, yes and more yes! Awesome work Doug, even if you did it while you were supposed to be paying attention to the Neutron meeting.\n\n:)","accounts_in_message":[],"_revision_number":1},{"id":"97bc1356795c98bdb2175b065d0e74eff6a88cf4","author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"date":"2015-03-16 21:29:26.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"efc842e68469bd62fb42d6d7cc65b401fe84a376","author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"date":"2015-03-16 22:29:26.000000000","message":"Patch Set 1: Workflow-1\n\nUnit test failure in the single token corner case (tox -r fails locally, so I\u0027m abusing Jenkins.)","accounts_in_message":[],"_revision_number":1},{"id":"be3ff331deb2cc50cb5d60e047311c7f5f7418b2","author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"date":"2015-03-16 22:34:49.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"b8e57facbaed18dc591d58f8e5d6a4188d736a9f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-16 23:49:15.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- check-tempest-dsvm-full http://logs.openstack.org/74/164874/2/check/check-tempest-dsvm-full/9f4a4e9/ : SUCCESS in 36m 23s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/74/164874/2/check/check-tempest-dsvm-postgres-full/f988a34/ : SUCCESS in 37m 58s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/74/164874/2/check/check-tempest-dsvm-neutron-full/33c2cd8/ : SUCCESS in 51m 24s\n- check-grenade-dsvm http://logs.openstack.org/74/164874/2/check/check-grenade-dsvm/ee471ea/ : SUCCESS in 41m 42s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/74/164874/2/check/gate-tempest-dsvm-large-ops/980bd19/ : SUCCESS in 25m 43s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/74/164874/2/check/gate-tempest-dsvm-neutron-large-ops/17af055/ : SUCCESS in 24m 20s\n- gate-devstack-gate-unittests http://logs.openstack.org/74/164874/2/check/gate-devstack-gate-unittests/16e7111/ : SUCCESS in 11s\n- check-devstack-dsvm-cells http://logs.openstack.org/74/164874/2/check/check-devstack-dsvm-cells/28b6342/ : SUCCESS in 20m 43s\n- check-dg-tempest-dsvm-full http://logs.openstack.org/74/164874/2/check/check-dg-tempest-dsvm-full/8542176/ : SUCCESS in 43m 25s\n- check-dg-tempest-dsvm-full-reexec http://logs.openstack.org/74/164874/2/check/check-dg-tempest-dsvm-full-reexec/8fd5b36/ : SUCCESS in 45m 10s\n- check-dg-hooks-dsvm http://logs.openstack.org/74/164874/2/check/check-dg-hooks-dsvm/56e6db3/ : SUCCESS in 7m 02s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/74/164874/2/check/check-grenade-dsvm-partial-ncpu/a047ce1/ : SUCCESS in 43m 55s\n- check-neutron-dsvm-functional-nv http://logs.openstack.org/74/164874/2/check/check-neutron-dsvm-functional-nv/ac0aa5e/ : SUCCESS in 8m 07s (non-voting)\n- check-swift-dsvm-functional http://logs.openstack.org/74/164874/2/check/check-swift-dsvm-functional/68d5b91/ : SUCCESS in 24m 00s\n- check-tempest-dsvm-full-icehouse-nv http://logs.openstack.org/74/164874/2/check/check-tempest-dsvm-full-icehouse-nv/358fb57/ : SUCCESS in 35m 38s (non-voting)\n- check-tempest-dsvm-neutron-icehouse-nv http://logs.openstack.org/74/164874/2/check/check-tempest-dsvm-neutron-icehouse-nv/07584d5/ : SUCCESS in 40m 28s (non-voting)\n- check-tempest-dsvm-postgres-full-icehouse-nv http://logs.openstack.org/74/164874/2/check/check-tempest-dsvm-postgres-full-icehouse-nv/562368e/ : SUCCESS in 31m 35s (non-voting)\n- check-devstack-dsvm-cells-icehouse-nv http://logs.openstack.org/74/164874/2/check/check-devstack-dsvm-cells-icehouse-nv/50634fc/ : SUCCESS in 13m 24s (non-voting)\n- check-tempest-dsvm-full-juno-nv http://logs.openstack.org/74/164874/2/check/check-tempest-dsvm-full-juno-nv/de66bc5/ : SUCCESS in 34m 15s (non-voting)\n- check-tempest-dsvm-neutron-full-juno-nv http://logs.openstack.org/74/164874/2/check/check-tempest-dsvm-neutron-full-juno-nv/07bb5c8/ : SUCCESS in 45m 38s (non-voting)\n- check-tempest-dsvm-postgres-full-juno-nv http://logs.openstack.org/74/164874/2/check/check-tempest-dsvm-postgres-full-juno-nv/154e5a7/ : SUCCESS in 33m 04s (non-voting)\n- check-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/74/164874/2/check/check-tempest-dsvm-ironic-pxe_ssh/6fa1a05/ : SUCCESS in 39m 18s\n- check-tempest-dsvm-f21 http://logs.openstack.org/74/164874/2/check/check-tempest-dsvm-f21/3050336/ : FAILURE in 41m 08s (non-voting)\n- check-tempest-dsvm-centos7 http://logs.openstack.org/74/164874/2/check/check-tempest-dsvm-centos7/93a5359/ : SUCCESS in 52m 56s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"95e9dcf37deffa0efcf9f3bfb70644fa3ac29e61","author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"date":"2015-03-23 16:40:57.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"1adb93f9e344c2379220b3436f5d36f207720af7","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"date":"2015-03-23 20:41:38.000000000","message":"Patch Set 2: Code-Review-1\n\nThis seems like something that test-matrix.py should be doing not devstack-vm-gate.sh.","accounts_in_message":[],"_revision_number":2},{"id":"8ae838ba0383df49728bbba49e8c4312c50b92fb","author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"date":"2015-03-23 20:45:48.000000000","message":"Patch Set 2:\n\nI started looking there, but it didn\u0027t seem to fit well, nor does it catch all the methods of setting services.  Can you hum a few more bars?\n\nThis file is what I\u0027m trying to cleanup: https://github.com/openstack/neutron-lbaas/blob/master/neutron_lbaas/tests/contrib/gate_hook.sh\n\nAnd I did something even more horrible for my third-party CI, that I\u0027d also like to cleanup.","accounts_in_message":[],"_revision_number":2},{"id":"4e0ca022e4f52e78276b778446fc80fd044efdab","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"date":"2015-04-06 23:00:36.000000000","message":"Patch Set 2:\n\nMy suggestion would be to simply specify the services you need in a different features.yaml file. One reason we describe the services in a file that can be overridden like that is so that you can easily override the defaults shipped by d-g.","accounts_in_message":[],"_revision_number":2},{"id":"9af1581213d0d53224b71aa663ae1642af6cb776","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"date":"2015-04-06 23:03:12.000000000","message":"Patch Set 2:\n\nAnother alternative is to update the service list using the existing ENABLE_SERVICES appending and hvae devstack sort it out.","accounts_in_message":[],"_revision_number":2},{"id":"c9ec0db989fea264c3e8268b163df349b0205b92","author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"date":"2015-04-07 00:52:58.000000000","message":"Patch Set 2:\n\nThanks. I think ENABLED_SERVICES\u003d gets stomped by d-g, and you have to either use features.yml or OVERRIDE_ENABLE_SERVICES.\n\nMy issue with either of those mechanisms is that you have to specify a complete list.  There is no way to say, \"give me the default list, but with these changes\", nor is there a hook to edit the generated list before devstack runs.\n\nI was hoping to use the *default* features.yaml services, and just tweak it, because there is value in the default services list being maintained by infra.","accounts_in_message":[],"_revision_number":2},{"id":"977d91744d468af64df9f1f9342ce53f4add78b0","author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"date":"2015-04-07 15:32:43.000000000","message":"Patch Set 2:\n\nAs noted on irc, ENABLED_SERVICES should not be stomped by d-g and devstack should support -Service1,Service2 to disable Service1 and enable Service2. So a string like this can be placed in ENABLED_SERVICES to modify the results of processing features.yaml.\n\nIf that all works as expected (and if it doesn\u0027t its probably a bug that should be fixed), this change should be abandoned.","accounts_in_message":[],"_revision_number":2},{"id":"8c96a78d2af76503ca0904858ddad7436c6f2b5a","author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"date":"2015-04-07 17:24:42.000000000","message":"Patch Set 2:\n\nI agree.  I already have a test up here: https://review.openstack.org/#/c/171049/\n\nBut the gate breakage last night got in the way of me finishing the test.  Expect a confirm/abandon today.  Thanks.","accounts_in_message":[],"_revision_number":2},{"id":"164d7559fac5df918bf918e9a0ebdcb136687174","author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"date":"2015-04-07 22:42:26.000000000","message":"Abandoned\n\nAs pointed out, you can pass negations to devstack via ENABLED_SERVICES.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"6d288cc57848897087b2836a6d0d78ca4d6104d2","revisions":{"c9da49e5f642f5033b1ef7f90f800a648ca00b8f":{"kind":"REWORK","_number":1,"created":"2015-03-16 21:27:44.000000000","uploader":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"ref":"refs/changes/74/164874/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack-gate","ref":"refs/changes/74/164874/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/74/164874/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/74/164874/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/74/164874/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack-gate refs/changes/74/164874/1"}}},"commit":{"parents":[{"commit":"22dd205d6113c4b63a77bf7f80227718cae1cda0","subject":"Merge \"add oslo.versionedobjects\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/22dd205d6113c4b63a77bf7f80227718cae1cda0"}]}],"author":{"name":"Doug Wiegley","email":"dougw@a10networks.com","date":"2015-03-16 21:27:14.000000000","tz":-360},"committer":{"name":"Doug Wiegley","email":"dougw@a10networks.com","date":"2015-03-16 21:27:14.000000000","tz":-360},"subject":"Mechanism to allow easier fine-tuning of devstack-gate services","message":"Mechanism to allow easier fine-tuning of devstack-gate services\n\nChange-Id: I43139d2885d0284d1ea05eba9dabc75687a6fa5f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/c9da49e5f642f5033b1ef7f90f800a648ca00b8f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/c9da49e5f642f5033b1ef7f90f800a648ca00b8f"}]},"branch":"refs/heads/master"},"6d288cc57848897087b2836a6d0d78ca4d6104d2":{"kind":"REWORK","_number":2,"created":"2015-03-16 22:34:49.000000000","uploader":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"ref":"refs/changes/74/164874/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack-gate","ref":"refs/changes/74/164874/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/74/164874/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/74/164874/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/74/164874/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack-gate refs/changes/74/164874/2"}}},"commit":{"parents":[{"commit":"22dd205d6113c4b63a77bf7f80227718cae1cda0","subject":"Merge \"add oslo.versionedobjects\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/22dd205d6113c4b63a77bf7f80227718cae1cda0"}]}],"author":{"name":"Doug Wiegley","email":"dougw@a10networks.com","date":"2015-03-16 21:27:14.000000000","tz":-360},"committer":{"name":"Doug Wiegley","email":"dougw@a10networks.com","date":"2015-03-16 22:34:41.000000000","tz":-360},"subject":"Mechanism to allow easier fine-tuning of devstack-gate services","message":"Mechanism to allow easier fine-tuning of devstack-gate services\n\nChange-Id: I43139d2885d0284d1ea05eba9dabc75687a6fa5f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/6d288cc57848897087b2836a6d0d78ca4d6104d2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/6d288cc57848897087b2836a6d0d78ca4d6104d2"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}