)]}'
{"id":"openstack%2Fdevstack-gate~164895","triplet_id":"openstack%2Fdevstack-gate~master~I5a1d0932f369b1e0d8c0039e09eaea2ee43b86de","project":"openstack/devstack-gate","branch":"master","hashtags":[],"change_id":"I5a1d0932f369b1e0d8c0039e09eaea2ee43b86de","subject":"Translate semi-colon into newline when parsing $DEVSTACK_LOCAL_CONFIG","status":"ABANDONED","created":"2015-03-16 22:54:29.000000000","updated":"2015-03-17 01:05:11.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"9dfbefc81cf7ecc9b7006fd8f73eb9522fd440db","_number":164895,"virtual_id_number":164895,"owner":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},{"value":1,"date":"2015-03-17 00:10:03.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":-1,"date":"2015-03-17 01:04:13.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2015-03-16 23:11:59.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},{"value":-1,"date":"2015-03-16 23:08:34.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"all":[{"value":-1,"date":"2015-03-17 01:04:13.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2015-03-16 22:55:13.000000000","_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-03-16 22:55:13.000000000","updated_by":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"reviewer":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"state":"REVIEWER"},{"updated":"2015-03-16 23:08:34.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2015-03-17 00:10:03.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"96f6b7580711b5a4f9415ddfff25249f0f5d4d20","author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"date":"2015-03-16 22:54:29.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e14ad10d5018575919cef0cba65883ab01fea358","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2015-03-16 23:08:34.000000000","message":"Patch Set 1: Code-Review-1\n\ni don\u0027t believe this is generically safe; you\u0027ve got stuff like [1] and others that use \";\" as a deliminator in their config-values and this will split them too\n\n[1] http://git.openstack.org/cgit/openstack/neutron/tree/neutron/plugins/sriovnicagent/common/config.py#n44","accounts_in_message":[],"_revision_number":1},{"id":"61adf6adc152637c93edccce3d6545041c195de6","author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"date":"2015-03-16 23:11:59.000000000","message":"Patch Set 1: Code-Review-1\n\nFlavio, why do we need this? devstack handles multiple config options per line separated by a colon ok, right?","accounts_in_message":[],"_revision_number":1},{"id":"dfedf9491beba2fedfc3d347c277824e3ac63a67","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-17 00:10:03.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- check-tempest-dsvm-full http://logs.openstack.org/95/164895/1/check/check-tempest-dsvm-full/e149866/ : SUCCESS in 40m 56s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/95/164895/1/check/check-tempest-dsvm-postgres-full/3975099/ : SUCCESS in 41m 19s\n- check-tempest-dsvm-neutron-full http://logs.openstack.org/95/164895/1/check/check-tempest-dsvm-neutron-full/e21ed25/ : SUCCESS in 45m 57s\n- check-grenade-dsvm http://logs.openstack.org/95/164895/1/check/check-grenade-dsvm/2d69492/ : SUCCESS in 47m 44s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/95/164895/1/check/gate-tempest-dsvm-large-ops/bafa8d2/ : SUCCESS in 27m 10s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/95/164895/1/check/gate-tempest-dsvm-neutron-large-ops/62efe00/ : SUCCESS in 27m 43s\n- gate-devstack-gate-unittests http://logs.openstack.org/95/164895/1/check/gate-devstack-gate-unittests/74c73a3/ : SUCCESS in 15s\n- check-devstack-dsvm-cells http://logs.openstack.org/95/164895/1/check/check-devstack-dsvm-cells/cb8b43c/ : SUCCESS in 19m 14s\n- check-dg-tempest-dsvm-full http://logs.openstack.org/95/164895/1/check/check-dg-tempest-dsvm-full/d25733a/ : SUCCESS in 40m 11s\n- check-dg-tempest-dsvm-full-reexec http://logs.openstack.org/95/164895/1/check/check-dg-tempest-dsvm-full-reexec/850f9ae/ : SUCCESS in 44m 10s\n- check-dg-hooks-dsvm http://logs.openstack.org/95/164895/1/check/check-dg-hooks-dsvm/1efd927/ : SUCCESS in 6m 33s\n- check-grenade-dsvm-partial-ncpu http://logs.openstack.org/95/164895/1/check/check-grenade-dsvm-partial-ncpu/c93001f/ : SUCCESS in 46m 48s\n- check-neutron-dsvm-functional-nv http://logs.openstack.org/95/164895/1/check/check-neutron-dsvm-functional-nv/9c8f6a3/ : SUCCESS in 6m 03s (non-voting)\n- check-swift-dsvm-functional http://logs.openstack.org/95/164895/1/check/check-swift-dsvm-functional/3f6255f/ : SUCCESS in 24m 48s\n- check-tempest-dsvm-full-icehouse-nv http://logs.openstack.org/95/164895/1/check/check-tempest-dsvm-full-icehouse-nv/deb1786/ : SUCCESS in 33m 30s (non-voting)\n- check-tempest-dsvm-neutron-icehouse-nv http://logs.openstack.org/95/164895/1/check/check-tempest-dsvm-neutron-icehouse-nv/1271474/ : SUCCESS in 41m 38s (non-voting)\n- check-tempest-dsvm-postgres-full-icehouse-nv http://logs.openstack.org/95/164895/1/check/check-tempest-dsvm-postgres-full-icehouse-nv/422e5b1/ : SUCCESS in 33m 06s (non-voting)\n- check-devstack-dsvm-cells-icehouse-nv http://logs.openstack.org/95/164895/1/check/check-devstack-dsvm-cells-icehouse-nv/caef6eb/ : SUCCESS in 11m 54s (non-voting)\n- check-tempest-dsvm-full-juno-nv http://logs.openstack.org/95/164895/1/check/check-tempest-dsvm-full-juno-nv/d99bd1a/ : SUCCESS in 31m 57s (non-voting)\n- check-tempest-dsvm-neutron-full-juno-nv http://logs.openstack.org/95/164895/1/check/check-tempest-dsvm-neutron-full-juno-nv/f97e217/ : SUCCESS in 41m 36s (non-voting)\n- check-tempest-dsvm-postgres-full-juno-nv http://logs.openstack.org/95/164895/1/check/check-tempest-dsvm-postgres-full-juno-nv/27606a7/ : SUCCESS in 29m 29s (non-voting)\n- check-tempest-dsvm-ironic-pxe_ssh http://logs.openstack.org/95/164895/1/check/check-tempest-dsvm-ironic-pxe_ssh/3ef8e20/ : SUCCESS in 34m 45s\n- check-tempest-dsvm-f21 http://logs.openstack.org/95/164895/1/check/check-tempest-dsvm-f21/01d1ac9/ : FAILURE in 47m 01s (non-voting)\n- check-tempest-dsvm-centos7 http://logs.openstack.org/95/164895/1/check/check-tempest-dsvm-centos7/693e32e/ : SUCCESS in 58m 16s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"1909058fd28bbbf972682569075bc9853b84cbe3","author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"date":"2015-03-17 01:04:13.000000000","message":"Patch Set 1: Code-Review-1 Workflow-1\n\nhmmm; those are good points Ian and Kyle.\n\nI was thinking of a way of encoding multiple lines in\nthe variable; thinking that local.conf would not work\nproperly without it. Well, it clearly works fine, so\nthere is no real advantage in doing the char translation.\n\nLet me can that idea. ;)","accounts_in_message":[],"_revision_number":1},{"id":"9dfbefc81cf7ecc9b7006fd8f73eb9522fd440db","author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"date":"2015-03-17 01:05:11.000000000","message":"Abandoned\n\nthis is not a needed change; it may actually cause more harm than good, so let\u0027s forget about it.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"04554e04524b1399645eb928b9ae741c26c5646b","revisions":{"04554e04524b1399645eb928b9ae741c26c5646b":{"kind":"REWORK","_number":1,"created":"2015-03-16 22:54:29.000000000","uploader":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"ref":"refs/changes/95/164895/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/devstack-gate","ref":"refs/changes/95/164895/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/95/164895/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/95/164895/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/devstack-gate refs/changes/95/164895/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/devstack-gate refs/changes/95/164895/1"}}},"commit":{"parents":[{"commit":"22dd205d6113c4b63a77bf7f80227718cae1cda0","subject":"Merge \"add oslo.versionedobjects\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/22dd205d6113c4b63a77bf7f80227718cae1cda0"}]}],"author":{"name":"Flavio Fernandes","email":"ffernand@redhat.com","date":"2015-03-16 22:47:07.000000000","tz":-240},"committer":{"name":"Flavio Fernandes","email":"ffernand@redhat.com","date":"2015-03-16 22:54:21.000000000","tz":-240},"subject":"Translate semi-colon into newline when parsing $DEVSTACK_LOCAL_CONFIG","message":"Translate semi-colon into newline when parsing $DEVSTACK_LOCAL_CONFIG\n\nIn cases when $DEVSTACK_LOCAL_CONFIG contains multiple values separated\nby \u0027;\u0027 split them up into multiple lines. This makes for a much\nmore readable local.rc file.\n\nChange-Id: I5a1d0932f369b1e0d8c0039e09eaea2ee43b86de\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/04554e04524b1399645eb928b9ae741c26c5646b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/devstack-gate/commit/04554e04524b1399645eb928b9ae741c26c5646b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}