)]}'
{"devstack-vm-gate-wrap.sh":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"a663cc2de03a2b60557e1aab37fc7bbf406634c8","unresolved":false,"context_lines":[{"line_number":304,"context_line":"        # here to fall trhough to the next conditionals"},{"line_number":305,"context_line":"        partial-ncpu)"},{"line_number":306,"context_line":"            export DO_NOT_UPGRADE_SERVICES\u003d[n-cpu]"},{"line_number":307,"context_line":"            ;\u0026"},{"line_number":308,"context_line":"        partial-ironic)"},{"line_number":309,"context_line":"            export DO_NOT_UPGRADE_SERVICES\u003d[ir-api,ir-cond]"},{"line_number":310,"context_line":"            ;\u0026"}],"source_content_type":"text/x-sh","patch_set":2,"id":"dac4157f_fe20744b","line":307,"updated":"2015-04-20 16:52:54.000000000","message":"This fall through means that whenever we partial upgrade n-cpu we also partial upgrade ironic. In that case why don\u0027t we just reduce this to a single case called \"partial\"?","commit_id":"05e4636d6cf9d42d9516cc84bf10814585a353b7"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"8afbcf323c77e1b41166f286f8e3f56268e97252","unresolved":false,"context_lines":[{"line_number":304,"context_line":"        # here to fall trhough to the next conditionals"},{"line_number":305,"context_line":"        partial-ncpu)"},{"line_number":306,"context_line":"            export DO_NOT_UPGRADE_SERVICES\u003d[n-cpu]"},{"line_number":307,"context_line":"            ;\u0026"},{"line_number":308,"context_line":"        partial-ironic)"},{"line_number":309,"context_line":"            export DO_NOT_UPGRADE_SERVICES\u003d[ir-api,ir-cond]"},{"line_number":310,"context_line":"            ;\u0026"}],"source_content_type":"text/x-sh","patch_set":2,"id":"dac4157f_de237004","line":307,"in_reply_to":"dac4157f_fe20744b","updated":"2015-04-20 16:57:24.000000000","message":"Actually sdague points out this is worse than I initially thought because DO_NOT_UPGRADE_SERVICES is overridden below making the partial ncpu case never run.","commit_id":"05e4636d6cf9d42d9516cc84bf10814585a353b7"},{"author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"change_message_id":"6469b9497dec820d1a583a60cd26da82606f7254","unresolved":false,"context_lines":[{"line_number":282,"context_line":"        # sideways upgrades try to move between configurations in the"},{"line_number":283,"context_line":"        # same release, typically used for migrating between services"},{"line_number":284,"context_line":"        # or configurations."},{"line_number":285,"context_line":"        sideways)"},{"line_number":286,"context_line":"            export GRENADE_OLD_BRANCH\u003d\"$GRENADE_BASE_BRANCH\""},{"line_number":287,"context_line":"            export GRENADE_NEW_BRANCH\u003d\"$GRENADE_BASE_BRANCH\""},{"line_number":288,"context_line":"            ;;"}],"source_content_type":"text/x-sh","patch_set":3,"id":"dac4157f_c19391f9","line":285,"updated":"2015-04-20 17:21:48.000000000","message":"We regex match this currently, but this is a literal match.  There are sideways variants (sideways-ironic, sideways-neutron), so we probably need to change this.  (Thanks Clark!)","commit_id":"f3ed9aa879509322a296463b43bfbe6463cc4094"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"e34da0f03ff9b097312b4caedd34416ce4aa5063","unresolved":false,"context_lines":[{"line_number":282,"context_line":"        # sideways upgrades try to move between configurations in the"},{"line_number":283,"context_line":"        # same release, typically used for migrating between services"},{"line_number":284,"context_line":"        # or configurations."},{"line_number":285,"context_line":"        sideways)"},{"line_number":286,"context_line":"            export GRENADE_OLD_BRANCH\u003d\"$GRENADE_BASE_BRANCH\""},{"line_number":287,"context_line":"            export GRENADE_NEW_BRANCH\u003d\"$GRENADE_BASE_BRANCH\""},{"line_number":288,"context_line":"            ;;"}],"source_content_type":"text/x-sh","patch_set":3,"id":"dac4157f_d410f150","line":285,"in_reply_to":"dac4157f_c19391f9","updated":"2015-04-20 17:25:21.000000000","message":"Done","commit_id":"f3ed9aa879509322a296463b43bfbe6463cc4094"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"6fbd26fece703db7373c92bfdf433740831a9b03","unresolved":false,"context_lines":[{"line_number":282,"context_line":"        # sideways upgrades try to move between configurations in the"},{"line_number":283,"context_line":"        # same release, typically used for migrating between services"},{"line_number":284,"context_line":"        # or configurations."},{"line_number":285,"context_line":"        sideways-*)"},{"line_number":286,"context_line":"            export GRENADE_OLD_BRANCH\u003d\"$GRENADE_BASE_BRANCH\""},{"line_number":287,"context_line":"            export GRENADE_NEW_BRANCH\u003d\"$GRENADE_BASE_BRANCH\""},{"line_number":288,"context_line":"            ;;"}],"source_content_type":"text/x-sh","patch_set":4,"id":"dac4157f_540aa1d3","line":285,"updated":"2015-04-20 17:30:02.000000000","message":"The old pattern match did not require a hyphen (-) in the string.","commit_id":"d09cb948f9ece1e1f57d29d541a6df611617e9db"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"1838fd13242c0146cb31a561c3edeb751a64b53e","unresolved":false,"context_lines":[{"line_number":282,"context_line":"        # sideways upgrades try to move between configurations in the"},{"line_number":283,"context_line":"        # same release, typically used for migrating between services"},{"line_number":284,"context_line":"        # or configurations."},{"line_number":285,"context_line":"        sideways-*)"},{"line_number":286,"context_line":"            export GRENADE_OLD_BRANCH\u003d\"$GRENADE_BASE_BRANCH\""},{"line_number":287,"context_line":"            export GRENADE_NEW_BRANCH\u003d\"$GRENADE_BASE_BRANCH\""},{"line_number":288,"context_line":"            ;;"}],"source_content_type":"text/x-sh","patch_set":4,"id":"dac4157f_b420ddf8","line":285,"in_reply_to":"dac4157f_540aa1d3","updated":"2015-04-20 17:35:36.000000000","message":"Looks like we can safely assume there will always be a specific subtype for sideways-something.","commit_id":"d09cb948f9ece1e1f57d29d541a6df611617e9db"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"1838fd13242c0146cb31a561c3edeb751a64b53e","unresolved":false,"context_lines":[{"line_number":301,"context_line":""},{"line_number":302,"context_line":"        # partial upgrades are like normal upgrades except they leave"},{"line_number":303,"context_line":"        # certain services behind. We use the base 4 operator \u0027;\u0026\u0027"},{"line_number":304,"context_line":"        # here to fall trhough to the next conditionals"},{"line_number":305,"context_line":"        partial-*)"},{"line_number":306,"context_line":"            if [[ \"$DEVSTACK_GATE_GRENADE\" \u003d\u003d \"partial-ncpu\" ]]; then"},{"line_number":307,"context_line":"                export DO_NOT_UPGRADE_SERVICES\u003d[n-cpu]"}],"source_content_type":"text/x-sh","patch_set":4,"id":"dac4157f_145f8973","line":304,"updated":"2015-04-20 17:35:36.000000000","message":"Typo, but not going to -1 on a typo in a code comment.","commit_id":"d09cb948f9ece1e1f57d29d541a6df611617e9db"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"6fbd26fece703db7373c92bfdf433740831a9b03","unresolved":false,"context_lines":[{"line_number":302,"context_line":"        # partial upgrades are like normal upgrades except they leave"},{"line_number":303,"context_line":"        # certain services behind. We use the base 4 operator \u0027;\u0026\u0027"},{"line_number":304,"context_line":"        # here to fall trhough to the next conditionals"},{"line_number":305,"context_line":"        partial-*)"},{"line_number":306,"context_line":"            if [[ \"$DEVSTACK_GATE_GRENADE\" \u003d\u003d \"partial-ncpu\" ]]; then"},{"line_number":307,"context_line":"                export DO_NOT_UPGRADE_SERVICES\u003d[n-cpu]"},{"line_number":308,"context_line":"            elif [[ \"$DEVSTACK_GATE_GRENADE\" \u003d\u003d \"partial-ironic\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":4,"id":"dac4157f_f4f9b5c9","line":305,"updated":"2015-04-20 17:30:02.000000000","message":"Same for this one as well.","commit_id":"d09cb948f9ece1e1f57d29d541a6df611617e9db"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"1838fd13242c0146cb31a561c3edeb751a64b53e","unresolved":false,"context_lines":[{"line_number":302,"context_line":"        # partial upgrades are like normal upgrades except they leave"},{"line_number":303,"context_line":"        # certain services behind. We use the base 4 operator \u0027;\u0026\u0027"},{"line_number":304,"context_line":"        # here to fall trhough to the next conditionals"},{"line_number":305,"context_line":"        partial-*)"},{"line_number":306,"context_line":"            if [[ \"$DEVSTACK_GATE_GRENADE\" \u003d\u003d \"partial-ncpu\" ]]; then"},{"line_number":307,"context_line":"                export DO_NOT_UPGRADE_SERVICES\u003d[n-cpu]"},{"line_number":308,"context_line":"            elif [[ \"$DEVSTACK_GATE_GRENADE\" \u003d\u003d \"partial-ironic\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":4,"id":"dac4157f_747925fc","line":305,"in_reply_to":"dac4157f_f4f9b5c9","updated":"2015-04-20 17:35:36.000000000","message":"And also for partial-something.","commit_id":"d09cb948f9ece1e1f57d29d541a6df611617e9db"}]}